- 28 Aug, 2020 40 commits
-
-
nohe@chromium.org authored
This adds a ChromeOS feature flag disabled-by-default. This will allow users the capability to copy images to the clipboard as an experiemental features from the ChromeOS Files App. This will be enforced in the javascript chrome.fileManagerPrivate API. Bug: 827333 Change-Id: Ic04ebd75ac2d38e527f2682fbe1ab4a87c644853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375702 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#802631}
-
Hans Wennborg authored
TBR=thakis Bug: 1122969 Change-Id: Iee48f90cb68ea8088101bfdf37b432f99729af95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380655Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#802630}
-
Yunke Zhou authored
Bug: 1122717 Change-Id: I960a3bdffda9f0a2f19cca30dfc6c15acdb33dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379842 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802629}
-
Ulan Degenbaev authored
Subsequent CLs will add support for workers. Since each worker has its own V8 instance and its own heap, a new PerIsolateV8MemoryUsage level is added to the result. Changes: - V8IsolatedWorldMemoryUsage is removed. - PerFrameV8MemoryUsageData is renamed to PerContextV8MemoryUsage. - PerIsolateV8MemoryUsage is added and contains data which used to be directly in PerProcessV8MemoryUsage. - PerProcessV8MemoryUsage now contains an array of PerIsolateV8MemoryUsage, which right now always has 1 entry but in the future we will instrument more isolates. The support for extension contexts (isolated worlds) is removed until they get their own V8ContextTokens. Bug: 1085129 Change-Id: I273f06ec839e509f73cff6a1692d06d9ed36d752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359069 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#802628}
-
Roman Aleksandrov authored
Bug: 1119399 Change-Id: Id94e7d2fe95ae94bd26f027ecffb170c4b701251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368555Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1597611060-adf0ab6d7715dfdb592c8864718732c417ac4f3f.profdata to chrome-win32-master-1598601518-e5c4427f7e0d3b1c20c8bd75b29ccde9f832fa2b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id4f9b54037e807d8c6975fc88cc1aca238c1df36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381433Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802626}
-
Adithya Srinivasan authored
In preparation for restricting cross-origin portal post messaging, this CL changes portal-host-exposure.sub.html to use Stash to communicate from a cross-origin portal to its embedder, instead of using postMessage. Bug: 1108793 Change-Id: Ib3dbb7cc56277cf28ac7a12ccf369a7ea9ce9f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377323 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#802625}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598594188-9fa81c93dd83e8129d07cc38e4d22506253a8a4e.profdata to chrome-mac-master-1598613564-5098a3febf11f8ec7b96c750766d9c7bc759629e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I4e4a14ff583875435d2f25aef6378fd9154bf775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381441Reviewed-by:
-
Edward Jung authored
Part of Chrome efforts to remove oppressive language in the codebase. Change-Id: I21dacf6759dbf840692127e1a30eb08a724549ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380273Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#802623}
-
Swapnil authored
Some protos are not meeting the guidelines and raise a warning on the server side as the firt entry should have some predefined keywords in it. The keywords that are allowed according to the guidelines are: https://source.corp.google.com/piper///depot/google3/devtools/staticanalysis/pipeline/analyzers/proto_best_practices/analyzer/service/enum_utils.cc;l=15 Change-Id: I8c152bf9892c62e09dda49e1b3115c845687db8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368552Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#802622}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/89760badbdb0..7ab9c51e8047 2020-08-28 sakal@webrtc.org Update gradle wrapper & gradle plugin. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4eb99eced16169ac18edf7d61476a6014e29ba7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381437Reviewed-by:
-
Noel Gordon authored
Videos are container formats that contain a video stream and its audio stream. The streams may be in any order. So if the audio is the first, mime type sniffing detects audio/* mime content. Not quite right given the main content is "video/*". After CL:2379424, the metadata system can reliably detect "video/*" if we include media metadata types in a metadata request [1]. Change the quick view metadata request for local video to do that, and change the expected mime type to "video/ogg" in the integration test. [1] See apitest of the expected behavior added in CL:2345936 testGetContentMetadataVideoResetsAudioMime Test: browser_tests --gtest_filter="QuickView/FilesApp*" Bug: 1114622 Fixes: 1114622 Change-Id: If9b62f9be1f51c760253c85e396ea2cf4cf741eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381333 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#802620}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6b329fd516bd..d4a7e12496b5 2020-08-28 tvanderlippe@chromium.org Typecheck persistence/AutoMapping.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5c3c853cb9b05601cb0da711d1793148b30b2565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381435Reviewed-by:
-
David Roger authored
This function can be called from within the ProfileManager destructor. The profile manager is destroyed by the g_browser_process doing profile_manager_.reset(). When this happens, the profile_manager_ member is first set to nullptr, and then the ProfileManager object is destroyed. As a result calling g_browser_process->profile_manager() within the profile manager destruction is a null pointer dereference. Fixed: 1122243 Change-Id: I3ac7a41e8d36212ddc78403eb4c830ceb1059b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379758 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#802618}
-
Andrew Shulaev authored
Bug: 156903151 Change-Id: I45898f934ba8b8487532cd452bbb59eca7b644ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366723 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#802617}
-
Alex Ilin authored
This reverts commit a1ee3eea. Reason for revert: SwitchToTabTest#testSwitchToTabSuggestionWhenIncognitoTabOnTop is failing fails on O and P bots Original change's description: > TabModel type should same as Tab type when switching tab > > We were use getCurrentModel() to switch tab, and this will be a problem > in multi window mode. We should choose the model(incognito or not) same > as the tab which we will switch to. > > Bug: 1121102 > Change-Id: Ie9742fb4a1b38f921c01d7f8ffd47a813b1b5a14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379093 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802295} TBR=tedchoc@chromium.org,gangwu@chromium.org Change-Id: Ic897ac3efff8f859fb1c2eb6b94997185145820e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121102, 1122985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379899Reviewed-by:
-
Yunke Zhou authored
Bug: 1121252 Change-Id: I808c1b4ec6519997751710990fead37d2ca7f5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374786Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e855d43. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I5002ac5a689e29597fd503af3ce23296f0bbb1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380552Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802614}
-
Jan Krcal authored
This CL fixes a regression in the user menu that the title and the subtitle stopped appearing. This was likely caused by some change in general UI code how views without layout manager are handled. This CL defines a proper layout manager for the container making the title and the subtitle appear correctly again. Bug: 1119719 Change-Id: I97cc2f7dbfff7a75d69c438e4dc31d87dd09191c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379725 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802613}
-
Alex Chau authored
chrome/services/sharing/* - Introduced ConnectionsOptions for RequestConnection - ConnectionsOptions includes bluetooth MAC address and medium selector chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of the above APIs Medium availability is determined by DataUsage setting and network status Bug: 1076008 Change-Id: I20a3f6ab3258d657984356aa3576d9a407350721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379893 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802612}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I845ef2c5bf23f4206f30993697bc1ff750772eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381430Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802611}
-
Himanshu Jaju authored
- Integrates PayloadTracker in NearbySharingService. - Registers PayloadPaths for incoming connections. - Handles transfer completion and cleanup for incoming connections. Bug: 1085068 Change-Id: Ic8df7bab0077c3fd3c95042831dcff7b07faf29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367677 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#802610}
-
Jana Grill authored
Currently when ADB sideloading is disabled by the admin and the powerwash is triggered by clicking on the notification, the device is restarted and then the user is presented with the reset screen which only has one action, namely powerwash. If they restart their device again, they are again presented with the same screen. As it does not make sense to show the reset screen with only a single action, this screen should be skipped and the powerwash should be triggered immediatelly. Ideally the powerwash would be triggered as soon as the user clicks "Reset to powerwash" on the notification, however this does not work since there cannot be logged in users when a powerwash is triggered. Also we have to account for the case when the user ignores the notification, in which case their device is powerwashed on next restart. Therefore as soon as the device is restarted the powerwash is triggered. There is no need for any UI to be displayed. Bug: 1121246 Change-Id: I501a170d4661da4988c2c03806032ae8a3a08a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374649Reviewed-by:
-
Himanshu Jaju authored
Adds a setter for testing to avoid real disk space checks since they can introduce flakiness in tests. Bug: 1122497 Change-Id: I5319dc7149913585014ed64b266bea5eb16af9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379841 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL adds |extension_version| as optional output argument to the two force-install methods of the ExtensionForceInstallMixin. Bug: none Change-Id: I2824659d033f65b56f2a1e4fa7df34392db42ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374213 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802607}
-
Rouslan Solomakhin authored
Before this patch, PaymentCredential in WebAuthn and secure payment confirmation method in PaymentRequest API always required a user verifying platform authenticator device, which made testing difficult on Linux with UbiKey, for example. This patch adds a chrome://flags/#enable-debug-for-secure-payment-confirmation flag to remove the user verifying platform authenticator restriction. After this patch, web developers can test secure payment confirmation in such use cases as on Linux with UbiKey. Bug: 1122715 Change-Id: I270dcd07ba7cbf2b8f6cedb8f4fad2bf0e5968e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379955Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802606}
-
Wez authored
View attachment to the Scenic view tree is used as a proxy for visibility of the View. Attachment events were previously used to mark a Frame's WebContents as visible or occluded. This resulted in the content being treated as "visible" as soon as the View was created, before it was actually attached and displayed. FrameImpl::CreateView() no longer Show()s the FrameWindowTreeHost during initial View creation, instead deferring to the View attachment event to Show() it. This results in the WindowTreeHost's compositor, Aura windows etc, all remaining non-visible until attachment. Detachment is treated similarly, by Hide()ing the FrameWindowTreeHost. EnableHeadlessRendering() is the equivalent of View attachment for HEADLESS contexts, so is modified to Show() the FrameWindowTreeHost. Add a browser test to verify that document.visibilityState is "hidden" immediately after having called CreateView(), but without the View actually attached to the Scenic view tree. Bug: 1109270 Change-Id: Ic375a30d51549134509abdaeb71c5c180cfdb1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353263Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802605}
-
Saurabh Nijhara authored
This CL cleans up ExtensionFetch struct to use ExtensionId for the extension_id and base::Version for the extension_version. It also cleans up ExtensionDownloader to use ExtensionIdSet instead of std::set<std::string>. Bug: 1122664 Change-Id: I5bf3ec21339edda1dd4ea1d8ef1c01894f1e88cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379865 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802604}
-
Boris Sazonov authored
Adds API to sign-in without enabling sync and modifies AccountPickerDelegate to use it. Bug: 1095128 Change-Id: I968428d887f759bf26586c5bd80fe82d1b736060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379770 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#802603}
-
ssid authored
BUG=1122186 Change-Id: If281fb573369d257cc547e8d9b354092d3fd4fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379253 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802602}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1597599037-37d4838cd87f22a0e9d22daa07afdb6346a7ed70.profdata to chrome-win64-master-1598572748-c240e19e9b06ea3510ae397a3f34ad9e6bf7d036.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0edd6ea2daf6b5565e374448672f615dccb0a658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381192Reviewed-by:
-
Christy Chen authored
Sending browser backend locale in a query parameter to the frontend. We will determine the DevTools locale based on this. See 'Loading a locale' section in Loc design doc for more details: https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit?ts=5d945064#heading=h.bd504lfafn49 Bug: 941561 Change-Id: I68c7b00eac21ea17b6bebd79cfc8ab46ab1eb24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278846 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#802600}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d3eba1db0a14..fde4d2f7457e 2020-08-28 syoussefi@chromium.org Revert "Vulkan:Clean up best practices exceptions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I4201a9015a9b16fdcd81ec850408ef342aa9bd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381393Reviewed-by:
-
Alex Chau authored
- All code changes are caused by API changes in NearbyConnections library - Added TODOs for unimplemented APIs Bug: 1076008 Change-Id: I7a1cfa0d435386222f2ba00bfc503fcd706aa526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379713 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#802598}
-
Oleh Lamzin authored
Change-Id: I5ab90a41991f5cec2665a2e4c825fc7db23bfe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377981Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#802597}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49ddc6ec3f80..6b329fd516bd 2020-08-28 patrick.brosset@microsoft.com Grid: Move the list of grids below settings in the Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122493 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c86d4cd3026d21f7b5271760e73ab11fde44151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381396Reviewed-by:
-
Alexander Hendrich authored
No behavior changes, pure clean up: * replace std::string with ExtensionId where applicable * replace NULL -> nullptr Bug: none Change-Id: I8cccd87bfa11f51a8213910f53798130e358c201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366726 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Noel Gordon authored
Use chrome.fileManagerPrivate.getContentMimeType to extract the sniffed content mime type a file entry. If that mime is an audio or video type, call chrome.fileManagerPrivate.getContentMetadata to fetch the metadata tags and optionally images from the file entry. No change in behavior, no new tests. Bug: 1114622 Change-Id: Ia006eccc1785a7a960d8ba0f4e6401a9e2d3c1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379424 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#802594}
-
Wez authored
These tests often timeout, leading to CQ & waterfall retries or false failures. TBR=sergeyu Bug: 1104563, 1104562 Change-Id: Icf4c0f87c3261be182db384d2354e3ef2cd20b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380275Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802593}
-
Zakhar Voit authored
wl_output_send_scale takes an integer |scale| argument, while display scale can possibly be fractional. Right now we send scale=0 when display scale is less than 100%. This CL sends 1 instead to fix compositor's (Ozone/Wayland) crashes. The proper solution for this is to implement xdg_output extension which supports fractional scaling. This will be done in future CLs. Bug: 1115671 Change-Id: Ic115aefad96cc8a5f454ff2faa2fe1fd0c4b285d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352733Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#802592}
-
