GitLab

BUG=327256

Review URL: https://codereview.chromium.org/223163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261435 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261434 0039d316-1c4b-4281-b951-d872f2087c98

Original patch is https://codereview.chromium.org/196503005/.
But it was reverted because of memory leaks.
https://codereview.chromium.org/223583002/

This is the fixed version.

BUG=327256

Review URL: https://codereview.chromium.org/223123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261432 0039d316-1c4b-4281-b951-d872f2087c98

Allow notifications of unhandled taps via the GestureStateListener.  This change
makes GestureTap events blocking, but there are several use-cases for which this
will be necessary, e.g., WebView and contextual search.

NOTRY=true

Review URL: https://codereview.chromium.org/218633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261431 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261430 0039d316-1c4b-4281-b951-d872f2087c98

Previously, synthetic gesture completion callbacks were triggered as soon as
the last generated event was *sent*.  A truer indicator of completion, however,
is when the last generated event was *ack'ed*.  For now, this is accomplished
by blocking the completion notification until all events have been flushed
through the pipeline.

In the future, a better solution will be inserting event
fences with an appropriate callback to indicate completion.  Note that this
approach fails to properly wait until all timeout events have been flushed
(e.g., GestureTap events on desktop sites on Android).

BUG=357505

Review URL: https://codereview.chromium.org/217163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261429 0039d316-1c4b-4281-b951-d872f2087c98

261337: primiano : Add support for arm64
251272: mallinath : Adding rdbx_get_packet_index to export list

BUG=354405
NOTRY=true

Review URL: https://codereview.chromium.org/223693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261428 0039d316-1c4b-4281-b951-d872f2087c98

After crbug.com/332146 is fixed, in Android WebView, GLES2Decoder can be
used on two threads. Make sure a ShaderTranslatorCache instance is only
used on a single thread by refcounting an instance between all decoders.

Also protect ShInitialize by using the thread safety guarantees of
LazyInstance.

For tests, a new instance of ShaderTranslatorCache is passed for each
ContextGroup.

BUG=

Review URL: https://codereview.chromium.org/217813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359510

Review URL: https://codereview.chromium.org/213623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261426 0039d316-1c4b-4281-b951-d872f2087c98

The implementation is based on the results from 'dumpsys batterystats'.

R=tonyg@chromium.org,jeremy@chromium.org
BUG=314481

Review URL: https://codereview.chromium.org/222413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
NOTRY=true

Review URL: https://codereview.chromium.org/217183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358952

Review URL: https://codereview.chromium.org/217423021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261423 0039d316-1c4b-4281-b951-d872f2087c98

This CL does the following:

- Componentize SigninOAuthHelper
- Replaces AccountReconcilor's calls to Profile with calls to SigninClient
- Passes AccountReconcilor's dependencies in directly rather than having
  AccountReconcilor obtain them from factories via the Profile
- Componentizes AccountReconcilor

BUG=334196,333999

Review URL: https://codereview.chromium.org/219933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261422 0039d316-1c4b-4281-b951-d872f2087c98

Add a result for 'gpu_average_frequency_hz' to the power metric. This represents a weighted average of the P-States over the time the GPU was active.

Also correctly convert hz -> mhz in powermetrics output.

BUG=357106

Review URL: https://codereview.chromium.org/220963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353954
TBR=darin

Review URL: https://codereview.chromium.org/203623010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261420 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261419 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170760:170771&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/223403009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355073

Review URL: https://codereview.chromium.org/216883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261415 0039d316-1c4b-4281-b951-d872f2087c98

Loading empty_feed.json is meaningless now.
LoadAccountMetadataForWapi() is deprecated and has no effect essentially.

BUG=334544
TEST=browser_tests

Review URL: https://codereview.chromium.org/221853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261414 0039d316-1c4b-4281-b951-d872f2087c98

GetResourceEntryReqeust is used by DriveAPIService

BUG=357038
TEST=build

Review URL: https://codereview.chromium.org/221883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261413 0039d316-1c4b-4281-b951-d872f2087c98

    
If a network delegates sets a redirect URL (in BeforeRequest or HeadersReceived), then it should get full
control over the target URL.
In particular, data:-URIs should remain unchanged because Chrome does not interpret # as a delimiter for reference fragments.
    
BUG=354653
TEST=net_unittests:
URLRequestTestHTTP.RedirectWithReferenceFragment:URLRequestTestHTTP.RedirectJobWithReferenceFragment (tests new behavior)
URLRequestTestHTTP.RedirectWithReferenceFragmentAndUnrelatedUnsafeUrl:URLRequestTestHTTP.Redirect302PreserveReferenceFragment (regression test)

Review URL: https://codereview.chromium.org/212543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261412 0039d316-1c4b-4281-b951-d872f2087c98

This changes the presubmit rule for adding pepper interface hashes to UMA to a
notification instead of a warning. This is because the presubmit is a bit too
broad, and was blocking some changes from being submitted through the CQ.

Using a notification message should be fine, since the impact of missing a
histogram is relatively low (we'll just see a number for a while), and the hash
can always be added later.

BUG=351389
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/221973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358265
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/222683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261410 0039d316-1c4b-4281-b951-d872f2087c98

1) JSON loader does not set error code to 0 on success.
2) Store signature on user import
3) Do not filter out need password change/incomplete flags.

R=nkostylev@chromium.org
TBR=bauerb@chromium.org

BUG=244472

Review URL: https://codereview.chromium.org/221813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261409 0039d316-1c4b-4281-b951-d872f2087c98

This removes the confusing code in content/renderer/accessibility that
serializes updates from Blink's accessibility tree, and replaces it with
calls to the new cleaner and fully-unit-tested AXTreeSerializer class.

BUG=316726

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261099

Review URL: https://codereview.chromium.org/125763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261408 0039d316-1c4b-4281-b951-d872f2087c98

Normalizing source file names before calculating hash by extracting the last component of the file path.
This hash is sent as TrackedObject.source_file_name_hash field.

This solves the problem described in the bug to a degree that we can build a functioning prototype for the server-side analysis tool. The tool will use (filename:line) pair to identify a piece of code that posts a task, and extract parameters to PostTask (and similar) functions to conveniently identify the task.

This solution is not final because the short filenames are not unique, and we’ll have about 6 conflicting pairs. This is OK for the proof-of-concept tool; further development might go in 1 of 2 different directions:
1. We like the results of the (file, line) method mentioned above, and we improve this solution, for example, by renaming files to make them unique.
2. We don’t like it, probably because of inconsistency of names on the server-side tool and the chrome://profiler page, and because it doesn’t show task entrypoints when the closure is created outside of the PostTask parameters list. In this case, we may want to explore adding an identifying parameter to the closure constructor. I’m not going to dive too deep into this, but we have a design for this. Anyways, in this case, we won’t use filename to identify tasks, and the fact that they are not unique will be OK.

For the record, there were other alternatives to extracting the last component, mainly:
1. Post-preprocessing (sic!) or compile-time or post-compile step that normalizes file names.
The issue was the high price (may be weeks of work), which is not OK for a proof-of-concept tool. For example, if we choose later to pass ID in the closure, this work would be wasted.

2. Identify the task by PC (program counter) instead of (file, line). This would require extending the UMA with a map of addresses of loaded modules, per process, and add 2 fields to TrackedObject: PC and module ID. This may be too much for a prototype. There also are some concerns regarding the server-side part of this approach.

BUG=357787

Review URL: https://codereview.chromium.org/217483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349058

Review URL: https://codereview.chromium.org/221353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261406 0039d316-1c4b-4281-b951-d872f2087c98

This patch contains images used by r261396.

BUG=343127
TEST=ran browser_test on Release/Debug.
manually verified that each filetype icons appears correctly.
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/224073002

Patch from Naoki Fukino <fukino@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261405 0039d316-1c4b-4281-b951-d872f2087c98

This code is dependent on aura but not on ash. It'd be
useful in app_shell, which doesn't use ash.

BUG=354711

Review URL: https://codereview.chromium.org/222383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261404 0039d316-1c4b-4281-b951-d872f2087c98

R=miguelg@chromium.org,iancottrell@chromium.org

Review URL: https://codereview.chromium.org/221173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261403 0039d316-1c4b-4281-b951-d872f2087c98

AW Shell shows a white screen when we play a video. It only plays sound.
This patch implements onShowCustomView() and onHideCustomView() of AwContentsClient to fix it up.

Review URL: https://codereview.chromium.org/223253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261402 0039d316-1c4b-4281-b951-d872f2087c98

And also I am forced to do some clean up on the existing code to avoid adding the source provider inside the WebRtcLocalAudioTrack.

NOTRY=true

BUG=358960
TEST=content_unittests

Review URL: https://codereview.chromium.org/221863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261401 0039d316-1c4b-4281-b951-d872f2087c98

The repeat feature did not work if there was only a single file in the list. This patch fixes the issue.

BUG=chrome-os-partner:27258
TEST=audio_player tests pass
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/221623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261398 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danakj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/216633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261397 0039d316-1c4b-4281-b951-d872f2087c98

Make Files.app and Chrome refer same icon sets and remove duplicate files.
Now those icon files are not under file_manager folder, changed their id from IDR_FILE_MANAGER_IMG_FILETYPE_* to IDR_FILETYPE_*

BUG=343127
TEST=ran browser_test on Release/Debug.
manually verified that each filetype icons appears correctly.

R=jochen@chromium.org, oshima@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/209433005

Patch from Naoki Fukino <fukino@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261396 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327641

Review URL: https://codereview.chromium.org/220263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/222543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107602

Review URL: https://codereview.chromium.org/222143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261391 0039d316-1c4b-4281-b951-d872f2087c98