- 24 Oct, 2019 40 commits
-
-
Ethan Jimenez authored
1. Updating functionality of `ITextRangeProvider::MoveEndpointByUnit` to reflect UIA-specific behavior expected by ATs when moving by line and crossing the start of an inline block boundary, which should be effectively treated as a line break. This is mostly implemented in `AXPlatformNodeTextRangeProviderWin`, but a new method `AtStartOfInlineBlock` is introduced in `AXPosition` to expose inline block boundaries similar to how paragraph boundaries are computed by using an `AbortMovePredicate`. 2. Adding browser tests to cover new expectations mentioned above. Bug: 928948 Change-Id: Ie243a96885edaf3037c75f375ae4fce20fa29e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858518 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709093}
-
chrome://webrtc-internalsChristopher Grant authored
Follow the lead of other DevUI pages, and move WebRTC internals resources (those used in chrome://webrtc-internals) into the DFM. This removes ~25 KB from the main .pak file on Android. Bug: 927131 Change-Id: Ia243ec46e728a711cc7c3bb8df10cb661300d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869014Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709092}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc78aaceea0a..a9229043e357 git log fc78aaceea0a..a9229043e357 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 sprang@webrtc.org Calls OnPacketsAcknowledged on RtpRtcp instead of RTPSender directly. 2019-10-24 ssilkin@webrtc.org Revert "Reset end-of-frame flag in non-VCL packet." Created with: gclient setdep -r src/third_party/webrtc@a9229043e357 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:999807 Change-Id: I4eec0cdb586117711fcdbaf9ec08581e9619d783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709091}
-
Alan Cutter authored
This CL updates WebAppControllerBrowserTest test names to look like WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/HostedAppController WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/UnifiedControllerWithBookmarkApp WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/UnifiedControllerWithWebApp instead of WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/0 WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/1 WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/2 Bug: 876576 Change-Id: I0a5cb9f4b51f977304312f07848e34c079e571ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877504 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#709090}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/177c5c4fe392..b8943e033650 git log 177c5c4fe392..b8943e033650 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 hidehiko@chromium.org chromite: Enable TastVMTests on betty-pi-arc-paladin. Created with: gclient setdep -r src/third_party/chromite@b8943e033650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf0440f8ca4bdb0ded1ada4b1c210c311295beb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879027Reviewed-by:
-
Boris Sazonov authored
Disables TabPersistentStoreTest#testUndoCloseAllTabsWritesTabListFile on API levels greater than 25 (Android N), as it is flaky there. TBR=twellington@chromium.org Bug: 1017732 Change-Id: Iebbb912d8401eba4497edc7d9e6a1ac70d73ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878750Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709088}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38c2b4512e74..d4a217b1f81e git log 38c2b4512e74..d4a217b1f81e --date=short --no-merges --format='%ad %ae %s' 2019-10-24 eseckler@google.com Merge "processor: Support arg/metadata/label filters in ExportJson()" 2019-10-24 fmayer@google.com Merge "Print usage to stderr." 2019-10-24 fmayer@google.com Merge "Fix invalid exit code for `trace_to_text symbolize.`" 2019-10-24 lalitm@google.com trace_processor: add range mode to RowMap Created with: gclient setdep -r src/third_party/perfetto@d4a217b1f81e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: Ia41bf055a14ea35aa64ca7d8d10f1929c187c0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878871Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/396ace2f..24fd62c5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia49f602b6b3bf24d148c6082318075cbcdb5b6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878947Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709086}
-
Bence Béky authored
Chrome is already enforcing a limit of 256 kB on incoming header list size via the BufferedSpdyFramer::max_header_list_size_ member. It used to notify the server about this limit by sending the HTTP/2 setting SETTINGS_MAX_HEADER_LIST_SIZE, but that was turned off at https://crrev.com/c/677304 because of a bug in middleboxes. Now that that issue seems to be solved, sending the setting can be resumed. Bug: 751642 Change-Id: I7e2a193d9bb56c63a6c26c5ea65fd5deb9a96def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877531 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#709085}
-
manuk authored
Prior to this CL, only the search provider debounced requests. This CL introduces AutocompleteProviderDebouncer which can be reused by other providers. Debouncing doc provider is behind a feature "OmniboxDebounceDocumentProvider" and configured by the params "DebounceDocumentProviderFromLastRun" and "DebounceDocumentProviderDelayMs". Bug: 1015820, 864302 Change-Id: I397a29848e8d1abde3c8ecdaec91cef2e416e37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869393Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709084}
-
Dominique Fauteux-Chapleau authored
Added IsAuthorized to BinaryUploadService. Makes UploadForDeepScanning private and instead exposes MaybeUploadForDeepScanning, which calls IsAuthorized before UploadForDeepScanning. Bug: 1014926, 1014927 Change-Id: I2ae991569a171eeeef447ff8a47f41f9ed99460f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865412 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709083}
-
Liquan(Max) Gu authored
As part of the Scroll-to-expand payment handler project, this patch will embed the web-content of the payment handler web-app into the payment-handler bottom-sheet. This patch also adds the CustomTabToolbar view (without the coordinator yet) as the payment-handler's toolbar. Bug: 999196 Change-Id: I403de9c01c3598bb120f0fb51dc7872adda8c8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872167 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709082}
-
Adenilson Cavalcanti authored
Missing functionality to be able to reuse portable helpers. Change-Id: If38e5f2b44cff9fb5f1744a59961ee6902f847f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876760Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709081}
-
Yi Su authored
This reverts commit 4c3e1c10. Reason for revert: This CL introduces massive crashes in M78. Original change's description: > Remove legacy check on null NavigationItem in CRWWKNavigationHandler > > Now that pending NavigationItem are stored in NavigationContext, it > will never be null. Remove the legacy code that checks if pending > NavigationItem exists in CRWWKNavigationHandler. > > Bug: 925304 > Change-Id: I5eb541f068b4a6db1f5322fed2e7318d686a845a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730424 > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683507} TBR=eugenebut@chromium.org,mrsuyi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925304 Change-Id: I091ae74a41d23454ac1af0ba6c752af9a6d7f41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878749Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709080}
-
Stephen McGruer authored
TBR=roagarwal@chromium.org Bug: 1017731 Change-Id: I7ababc844fa3193efde48ae29162ddf7986105a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878987Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709079}
-
Jamie Madill authored
'o' should have been '#' in one section. Bug: None Change-Id: I458e1f7300e8ea9a2607d23ee1d80e039acc9879 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879308Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#709078}
-
Xianzhu Wang authored
Virtual test suites under the same prefix with different args are confusing and error-prone. As we'll combine virtual test suite entries with the same prefix/arg into one suite in crrev.com/c/1873504, this CL prepares for that. See that CL for the future format of VirtualTestSuites. Bug: 1014162 Change-Id: I707c67f7a5be925fde7fb252b5f7ceec50edb6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876740 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709077}
-
Mike Wittman authored
pthread_attr_getstack returns the lowest address in the stack allocation, so the size must be added to get the base address. Also adds logic to cache the main thread base address to avoid performance overhead on Android. This is modeled after similar logic in GetStackEnd() in base/debug/stack_trace.cc. Bug: 988579 Change-Id: Ia31b85afafc98b61dc60eb2c0d0ab64ba70877c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869831 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709076}
-
Peter Kasting authored
Bug: 82078 Change-Id: I0b56a851bafdd9894bf8ccd44bf9a765f7170498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869828 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#709075}
-
Antonio Gomes authored
... so that it can be used on more testing files. Note that, given that one of the methods reimplemented need access blink::WebLocalFrame, the newly added files can not reside in renderer/platform/testing, where other similar files are. BUG=787254 R=guidou@chromium.org Change-Id: I1dd6154407d744daab6cdbad0003bf2ddafe7485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873986 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Emily Stark authored
Named namespaces are discouraged in chrome/ (as discussed on chromium-dev and recently codified in https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#named-namespaces). This removes the safety_tips namespace, renames a couple functions as needed, and does a little more miscellaneous cleanup (e.g., removing unnecessary aliases). TBR=csharrison@chromium.org,ellyjones@chromium.org Change-Id: I28dbd6ba2a90784fe148e91ccd75bc607d6192b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876474Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#709073}
-
Henrique Nakashima authored
Initially, it contains: - ChromeColors (was part of ColorUtils) - @color - toolbar_background_primary - toolbar_background_primary_dark - standard_mode_tint - tint_on_dark_bg Shared resources that correspond to Chrome style should be moved here. Bug: 995916 Change-Id: I455c63e444655e4bac6f8b68cb7d2b9650f06f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872181Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709072}
-
Stephen White authored
Change-Id: I5c5b27bdf1923aa3d0b3a6fb2fb36d3ce1fcb733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864361 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709071}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad557c41da7c..3671a6a21726 git log ad557c41da7c..3671a6a21726 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 jmadill@chromium.org Revert "git-cl: Add diff lines of context setting." Created with: gclient setdep -r src/third_party/depot_tools@3671a6a21726 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ie5a2589a464303c34e6ca1f7c01a7ead5023ad25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878870Reviewed-by:
-
Dave Tapuska authored
Move FrameMsg_ResetContentSecurityPolicy to a RemoteFrame mojo interface. BUG=1008432 Change-Id: I8b96015cefc57e297594ac6d2ebc4024ffd698e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873400 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709069}
-
David Dorwin authored
Bug: 1013709 Test: There are separate tests for the render and browser process. Renderer process (adapted from https://crrev.com/2349963002): 1. Load the file from http://crbug.com/288697#c12. 2. Change the OS time zone. 3. Click "recheck" and verify that the new time zone is displayed. Don't reload the page as this could result in a new renderer process. 4. Change the OS time zone back to the original time zone. 5. Repeat step 3. Browser process (adapted from https://crrev.com/697203006): 1. Open History (chrome://history/) 2. Change the OS time zone. 3. Reload the History page and verify that times displayed are in the new time zone. Change-Id: Ifefbb67efebda8a23200a3ba163ce961a7260807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845623Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709068}
-
Friedrich Horschig authored
This CL ensures that the touch to fill backend properly dismisses all remains of touch to fill before showing the password preferences. Because the dismissal was incomplete, users wouldn't be able to trigger a keyboard or any touch to fill sheet. Bug: 1017724 Change-Id: If26f00332897064c10fb12a17edaf2503a96d1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878828Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#709067}
-
Nicolás Peña Moreno authored
Currently, |enabled_| is a boolean used as a performance optimization to avoid doing work when nothing is subscribing to violations that are reported by the PerformanceMonitor. This is often the case, so the optimization works well, although it is only slightly faster than just checking whether the corresponding |thresholds_| entry is_zero(). However, we plan to start buffering longtasks soon, which requires observing for them from the beginning regardless of the presence of a PerformanceObserver. With this change, |enabled_| would not work well as an optimization because it would be set to true most of the time. This CL changes its meaning so that it excludes longtasks, thus being false most of the time even after we start observing longtasks by default. Bug: 1016815 Change-Id: I06d8e8631c83663ead48f344ca08759472edf61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874048 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709066}
-
Andreas Haas authored
In the context of an ongoing refactoring of WTF::ArrayBuffers we move the implementation out of libwtf. The idea is to merge it into DOMArrayBuffer eventually and get rid of WTF::ArrayBuffer completely. StaticBitmapImage included WTF::ArrayBufferContents but cannot include anything in third_party/blink/renderer/core/typed_arrays/*. With this CL I remove the direct creation of ArrayBufferContents in StaticBitmapImage. The idea behind the CL is that instead of creating an ArrayBufferContents in ConvertToArrayBufferContents, we just pass a pointer to the backing store of the ArrayBufferContents, and let StaticBitmapImage just fill that backing store with data. I renamed the function therefore to CopyToByteArray. To be able to allocate an ArrayBufferContents of the right size, StaticBitmapImage now also provides a SizeInBytes function, and MayHaveStrayArea to indicate if the backing store needs to be zero-initialized. Alternative implementations would be to just fill a WTF::Vector, and then copy the result into an ArrayBufferContents, or to provide a producer function to StaticBitmapImage so that it can allocate an ArrayBufferContents in an opaque way. I did not like both, the former requires extra copying, the latter is too complicated. R=jbroman@chromium.org Bug: chromium:1008840 Change-Id: I0b283dd9605f31905f3cb0d65615fc85d84e8f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871674Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709065}
-
Clark DuVall authored
Change-Id: I8e0c93abdbaf040347448a51c0280cbfe524abc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877307 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#709064}
-
Jared Saul authored
Removes outdated owners (csashi, dlkumar, jiahuiguo) and extends three histograms for a year that we still find useful. Fixed: 1016405, 1016413, 1016432 Change-Id: Ie4b2f2075ba8862a892bb270c5d2d48b3a4849b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877811Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#709063}
-
Jérôme Lebel authored
Removing Unified consent flag description. Related to: crrev.com/c/1866513 Bug: 951313, 1015805 Change-Id: I5f42081038b0176e3d55d1935f0592688dd05cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813507 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#709062}
-
Mike Wittman authored
The stack sampling implementations for Linux and Android platforms require the pthread_t type to obtain the stack base address, in addition to the PlatformThreadId. This change introduces a minimal ThreadToken abstraction that encapsulates the necessary thread state across platforms. TBR=gab@chromium.org Bug: 988579 Change-Id: Ie5d70709ddae362ca414dc5a635e456c8bd9f8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860151Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The boolean looks like it was needed because there was a bug in iOS 4 that didn't allow for this custom copy behavior. Now, the underlying OnCopy method never returns false, and iOS 4 is no longer supported, so this doesn't need t return a boolean. The copy will always happen. Bug: 866446 Change-Id: I11f3b90b191d10442ab513d377756cacbfb898e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869005 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709060}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateAssistantAudioDecoder in AssistantAudioDecoderFactory interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. Bug: 955171 Change-Id: I2de4cb0561c69201335817ec6a873258a30d9a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871503 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709059}
-
Himanshu Jaju authored
Consistently use hardware_info while renaming devices in SharingService. This allows us to locally modify manufacturer names at a single place. Bug: 1016332 Change-Id: I309ddc4abb93242ba496666996badefbf10c24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878650Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709058}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I5771e2c7294c29241ccda5a55f9ebb5f95117871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876976 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Emily Stark authored
Namespaces are discouraged in chrome/, as previously discussed on chromium-dev and recently codified at https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#named-namespaces. This CL removes the lookalikes:: namespace. Change-Id: I91cd483630881c4cb29fb5cf3f44ca91b5a767c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877127 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709056}
-
Javier Ernesto Flores Robles authored
This reverts commit 770741aa. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[iOS][MF][EG2] Migrate credit card tests" > > This reverts commit b27f6c3c. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[iOS][MF][EG2] Migrate credit card tests" > > > > This reverts commit 919aab84. > > > > Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 > > > > Original change's description: > > > [iOS][MF][EG2] Migrate credit card tests > > > > > > Consolidate Manual Fallback matchers in one place. > > > Consolidate credit card Autofill helpers in the respective app > > > interface. > > > > > > TBR= eugenebut@chromium.org > > > > > > Bug: 1017685, 1016367 > > > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#709020} > > > > TBR=stkhapugin@chromium.org,javierrobles@chromium.org > > > > Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1017685, 1016367 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709028} > > TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org > > Change-Id: If9bf98648abb8c0211764c378490c34f84039f27 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017685, 1016367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878490 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709048} TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org Change-Id: I3adaebe3761571c6bbd5721edd49639a5c0e49a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878829Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#709055}
-
Livvie Lin authored
Rename INSECURE to INFO and DANGEROUS to NOT_SECURE_WARNING. The eventual goal is to use the info icon to convey site information and a grey triangle icon to indicate non-secure connections (crbug.com/1008219). Thus, this cl renames the info icon to be more descriptive and the danger icon to be more general. Bug: 1008219 Change-Id: Id012ec42d4c6ec75e4f7aee4247029b89b4d704a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876129Reviewed-by:
-
