Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 26 Jul, 2016 33 commits
  3. 25 Jul, 2016 7 commits
    • qiangchen's avatar
      Bug Fix: Tab Capture Mouse Pointer Off On Mac · f5a740f3
      qiangchen authored 
      The cursor renderer on Mac, takes the chrome window based coordinate
as web contents based coordinate.

This CL fixes that bug.

BUG=625237

Review-Url: https://codereview.chromium.org/2166953002
Cr-Commit-Position: refs/heads/master@{#407637}
      f5a740f3
    • apacible's avatar
      [Md Feedback] Add the rest of existing strings. · 56407438
      apacible authored 
      This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow.

The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign.

No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog.

BUG=615535
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163753003
Cr-Commit-Position: refs/heads/master@{#407636}
      56407438
    • sergeyu's avatar
      Ensure that connection can be closed in response to a data message. · aed3bb65
      sergeyu authored 
      Added a unittest that verifies that it's safe to tear down connection
synchronously in response to a message. Also fixed issues that were
causing crashes in that scenario. Particularly added
PeerConnectionWrapper that wraps PeerConnection for WebrtcTransport
and allows closing it asynchronously.

Review-Url: https://codereview.chromium.org/2172153005
Cr-Commit-Position: refs/heads/master@{#407635}
      aed3bb65
    • qyearsley's avatar
      Rename MockTool -> MockWebKitPatch. · a2414e18
      qyearsley authored 
      Now that webkit_patch and multi_command_tool are merged,
(http://crbug.com/621181) it may be confusing that the mock version
of WebKitPatch is called MockTool.

This renaming also resolves a FIXME comment.

BUG=621181

Review-Url: https://codereview.chromium.org/2127343003
Cr-Commit-Position: refs/heads/master@{#407634}
      a2414e18
    • eae's avatar
      Add null-check to ShapeResult::fallbackFonts · 63402c5b
      eae authored 
      Add a null check for m_runs[i]->m_fontData in ShapeResult::fallbackFonts
to ensure that isTextOrientationFallbackOf is only called when it's set.

TBR=pdr@chromium.org
BUG=629005

Review-Url: https://codereview.chromium.org/2177163003
Cr-Commit-Position: refs/heads/master@{#407633}
      63402c5b
    • enne's avatar
      Set BrowserCompositorOutputSurface's vsync parameters on mac · bd7d5c4d
      enne authored 
      Mac routes vsync parameters differently than other platforms.  Other
platforms go directly through BrowserCompositorOutputSurface, which then
routes it to the vsync manager (without begin frame scheduling) or just
to the root BeginFrameSource for that BrowserCompositorOutputsurface
(with begin frame scheduling).

Mac is different in that the RenderWidgetHostViewMac gets the vsync info
from the DisplayLink, which forwards it to the BrowserCompositorMac.
This would then forward that to the ui::Compositor's vsync manager which
would then be used to tick the browser and then indirectly would forward
to the begin frame source for the BrowserCompositorOutputSurface to tick
the display.

--enable-begin-frame-scheduling turns off the vsync manager, which
previously left the browser and then display compositors to tick at
default intervals and timebases on Mac, leading to power regressions.
OOPS.

This patch adds an additional route where the BrowserCompositorMac
forwards vsync info to the BrowserCompositorOutputSurface's
BeginFrameSource via ui::Compositor's ui::ContextFactory (aka
GpuProcessTransportFactory).  As the BrowserCompositorOutputSurface's
begin frame source is the source of all frames when using
--enable-begin-frame-scheduling, this fixes the regression.

Once --enable-begin-frame-scheduling becomes the default, all of the
vsync info and vsync manager plumbing can be removed.

With this patch, power usage on one test laptop for h264 video when
using --enable-begin-frame-scheduling goes from 2.00W -> 2.05W instead
of from 2.0W -> 2.3W.

R=ccameron@chromium.org

Review-Url: https://codereview.chromium.org/2170053002
Cr-Commit-Position: refs/heads/master@{#407632}
      bd7d5c4d
    • pkotwicz's avatar
      Makes WebAPK handle NOTIFICATION_PREFERENCES intents · 349039d0
      pkotwicz authored 
      This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is
forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent
when the user long presses on a notification on L+ and taps on the "gear icon".

BUG=610156

Review-Url: https://codereview.chromium.org/2169743002
Cr-Commit-Position: refs/heads/master@{#407631}
      349039d0