- 29 Oct, 2020 40 commits
-
-
Stephen Nusko authored
This reverts commit b83b94de. Reason for revert: crbug/1143787 broke android perf bot build ERROR at //clank/features/chime/BUILD.gn:6:1: Unable to load "/b/s/w/ir/cache/builder/src/chrome/android/modules/chime/chime_module.gni". import("//chrome/android/modules/chime/chime_module.gni") ^------------------------------------------------------- See //build/config/android/internal_rules.gni:2432:20: which caused the file to be included. _deps += [ "${_target_label}__assetres" ] ^--------------------------- Original change's description: > Migrate chime dfm definition downstream > > chime is a downstream only DFMs, it should be defined downstream only > and not reference clank from the chromium repo. > > Followup downstream cl crrev.com/i/3358245 > > Change-Id: I54b4cc29cbb23c61f654fe86831f0e5c2f512d95 > Bug: 1142775 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495608 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822269} TBR=agrieve@chromium.org,xingliu@chromium.org,mheikal@chromium.org Change-Id: I299777b981d11776298848e9a0d5a02dd82d068f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142775,1143787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508290 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822284}
-
Tanmoy Mollik authored
When SyncDisabled policy is set, show a toast saying that "Sync is disabled by your administrator" when user taps on the sync row in main settings page. Screenshot: https://crbug.com/1136780#c3 Bug: 1136780 Change-Id: I9ba71843ecc191e1e4faaa24377bcaadbb6c07bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505749 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822283}
-
Joe Mason authored
This clarifies the ownership of the callback: it is owned by the request object but will be destroyed after it is called or once no response can be received (such as if the ProcessNode is destroyed). This lets the caller store objects as callback parameters without leaking, or make a V8DetailedMemoryRequestOneShot self-owning by storing it in its own callback. Also changes the ownership of V8DetailedMemoryRequestOneShotAnySeq's callback: it is now owned by the wrapped V8DetailedMemoryRequestOneShot, so that it gets deleted with the same logic, instead of being owned by the V8DetailedMemoryRequestOneShotAnySeq. This splits the OneShot unit tests up as the extra test cases make them unwieldy, and factors out repeated test setup code into the test fixture. R=chrisha Bug: 1080672 Change-Id: I2e4c83b24965816ad6a886ea1c32a5d872c158e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487842Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#822282}
-
Michael Lippautz authored
- /impl: Blink implementation of Oilpan - /v8_wrapper: V8 implementation of Oilpan and wrapper code Mostly mechanical CL that creates trampolines for all headers that are also included from some other directoy that platform/heap/. Investigating the public API is future work. Tests are not covered by this CL. Change-Id: Id066f9b251be7ea833ffd41dbcdd6c1ed77eccb6 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505651 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822281}
-
Jeffrey Young authored
Handle case of device without battery. Handle case of battery not full, not charging, but connected to power. BUG=b:171979755 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I0dda61d03e361bcc1a21d5ad9ef33a954debf7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500324 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822280}
-
Toby Huang authored
Under step #5 for manual testing. The developer doesn't have to test these edge cases every time, but this bullet is a useful reminder to think about what unexpected situations could break your code. Bug: 1142952 Change-Id: Ie5cf5878bc555582e7ea0f8bdf425872b01e834f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506066Reviewed-by:
Zork <zork@chromium.org> Commit-Queue: Zork <zork@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822279}
-
Tim Volodine authored
Move visual_utils code and tests from components/safe_browsing/ content/password_protection to compontents/safe_browsing/core/ common/. The code for visual_utils currently lives in components/safe_browsing/content/password_protection/, but is now used by both password_protection and phishing_classifier code, therefore this CL moves the files and tests to the common/ directory. This solves the assert_no_deps issue and allows to remove the "nogncheck" in scorer.h when depending on the "c/s_b/c/password_protection" target from the phishing_classifier (which is in deps for chrome/renderer/BUILD.gn), see crbug.com/1138547 for details. BUG=1138547,1136950 Change-Id: Ic3796eec31c32ff6aee9e9267fbbebb0be090ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495066Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#822278}
-
Liviu Tinta authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. Bug: 1047176, 1113863 Change-Id: I839d0856887188000ef57963083f013d8c6f9cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498862Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#822277}
-
Jaeyong Bae authored
This patch adds padding between the security icon and the origin on the URL bar. It means changing according to UX feedback. The screen shot would be attached on the issue link. Bug: 1052493 Change-Id: Ifd24f97e7085bb0aa0e652276b76d2eca24517bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500973Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#822276}
-
Alex Turner authored
Change-Id: Ib0c8e6bc7b8e2aa3fc4a1e5787911905c5b476a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495601Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#822275}
-
Guido Urdaneta authored
Replace callsites with StopSource(), inherited from MediaStreamVideoSource. Also add a running() accessor, for better state tracking. Bug: 1142955 Change-Id: Ib197b9b696d8b8b0a75d504a5c92135fd4185280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504236 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#822274}
-
Aga Wronska authored
This change addresses two problems with parent access code on login screen. 1. When doing reauth we should validate parent code against all configurations that are available on device. We enforce parent code when the device is owned by child, event if it is different user going through reauth. It will fix https://crbug.com/1140310. 2. IsDeviceOwnedByChild is causing a crash when the device owner cannot be found on user list. While I cannot reproduce such situation, it seems that either stored device owner id is incorrect or we fail at reading users list from Local State. Relaxing the owner check and defaulting to false will prevent crash while we investigate the problem further. It is a speculative fix for https://crbug.com/1140357. Bug: 1140310, 1140357 Change-Id: I3d4afab92741d90cae768f58b0da831f0c6c163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490855Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#822273}
-
Rune Lillesveen authored
Test sometimes fail on MacOS 10.15 builder. See e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5298 TBR=romanarora@chromium.org Bug: 1143663 Change-Id: I72a41ca282d02302f33d626544ba7980d6c356d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505988Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#822272}
-
Peter Wen authored
From v2.1 to v3.0, this is required to use new custom lint checks in aars' lint.jar files. Updated baseline accordingly. Bug: 1142927 Change-Id: Id078b9a7a56c37ed6e40483adbffdeaed63b718a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490990Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#822271}
-
Tanmoy Mollik authored
Add loadEmptyPartnerBookmarkShimForTesting method call in the setUp class as this method is also called in other Bookmark tests. This should fix the flakiness. Bug: 1133426 Change-Id: I4542bda0744d28c26f3748cd2634fa3b5dbc4c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498688Reviewed-by:
-
Mohamed Heikal authored
chime is a downstream only DFMs, it should be defined downstream only and not reference clank from the chromium repo. Followup downstream cl crrev.com/i/3358245 Change-Id: I54b4cc29cbb23c61f654fe86831f0e5c2f512d95 Bug: 1142775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495608Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: Ifd5e8f80c212747550dd6447d3296af96f477970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507730 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#822268}
-
Fabrice de Gans-Riberi authored
The timeout for no data in the Cast Streaming Receiver was incorrectly set to 10s. It should have been 15s. Bug: 1143508 Change-Id: Ibbc56176ed848f99162c61310c8ff70c65fe0b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506465 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#822267}
-
Parastoo Geranmayeh authored
TBR=bbudge Bug: 1143728 Change-Id: Ieb9bca3f2e356a2bcb4647d0d9634270da829da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507870Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#822266}
-
Fredrik Söderqvist authored
The |object_bounding_box_| and |stroke_bounding_box_| members of LayoutSVGRoot and LayoutSVGContainer directly relate to the bounds of the child (descendant) content. Move management of them to SVGContentContainer. Change-Id: If3b6803e46b789de40566fbc7c473467c232a627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505872Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#822265}
-
Alex Moshchuk authored
It looks like the test was flaky because it navigated a hidden iframe to an OOPIF, but the OOPIF's CrossProcessFrameConnector starts out as visible by default, and we didn't properly wait for the frame's hidden visibility to propagate to CrossProcessFrameConnector before checking visibility or metrics in the browser process. Fix this by waiting for layout to complete via an extra EvalJsAndWaitForLifecycleUpdate. The suspected problem and the fix is similar to https://chromium-review.googlesource.com/c/chromium/src/+/2503316 Bug: 1135595 Change-Id: If897d3fc41c5b00bfe9028db1af3bf515d6a8865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503839Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822264}
-
Stephen Nusko authored
This is currently 12.5% flaky and is already disabled on nexus5x webview. This is due to story occasionally generating to much data for the trace buffer. Bug: 1143740 Change-Id: I74bc5fdaad999bce76d8a469b8470175c307b26d No-Try: True TBR: johnchen@chromium.org CC: mythria@chromium.org,tmrts@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507830Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6d93e6c4293..06d17cd5d92e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC parastoog@google.com,futhark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: parastoog@google.com,futhark@google.com Change-Id: I60d9ceddbc4cad381931cf8f458c876e601152b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507538Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822262}
-
Darin Fisher authored
Change-Id: I60f4def267077064cbd55bdb43661f544905eeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507889 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822261}
-
Mark Cogan authored
In some circumstances, |connectedScenes| can contain a scene with no associated SceneController while cleaning up after the last OTR tab. This CL ensures that when this happens, the nil controller isn't added to the controller array. (Root cause for this state is unclear; some comments are added here as well to guide future investigations). Bug: 1142782 Change-Id: I33617e6e2252a2124870430c2eefc2cb4158a28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506440 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#822260}
-
Shahbaz Youssefi authored
Bug: 478572 Bug: 871352 Bug: 1136367 Bug: 1136369 Bug: 1143392 Bug: 1143408 Bug: 1143424 Bug: angleproject:2930 Bug: angleproject:3111 Bug: angleproject:3481 Bug: angleproject:5259 Change-Id: I66f1b04fade96015e9ea3727a4185753dd528135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505734 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822259}
-
Anton Bikineev authored
This also removes default arguments for PartitionOptions. Bug: 11297512 Change-Id: I0a694f8b300a04a08fb21fd1191066556f21d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507432Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#822258}
-
Vidhan Jain authored
This reverts commit bd6beb55. Reason for revert: Open comments on CL Original change's description: > [Autofill][States] Implemented StateNameMapUpdater > > StateNameMapUpdater is a helper class for StateNameMapUpdater > that reads the data from the state data files and loads them to the > map. > > Bug: 1111960 > Change-Id: I8add7215a1ec450e0a31ef999b2adfa6dade138b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471337 > Reviewed-by: Matthias Körber <koerber@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Vidhan Jain <vidhanj@google.com> > Cr-Commit-Position: refs/heads/master@{#822187} TBR=battre@chromium.org,koerber@google.com,schwering@google.com,vidhanj@google.com Change-Id: I5a47671505371abfccfd5ba5ebbe43002e2db4f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507751Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#822257}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/. Bug: 1143194 Change-Id: I575b56264674cc6faa903118d8305d6db20f6572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506108 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822256}
-
yilkal authored
This CL records the error state of access token fetch in the new EduCoexistence flow. The histogram already exists and doesn't need to be defined. Bug: 1140250 Change-Id: I2da00d0d01f273127aeb081737e00397fd19b735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490732Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822255}
-
Elly Fong-Jones authored
This flag has been default-enabled for a long time and has been expired for 11 milestones now. Bug: 1110583 Change-Id: I72ae22ab084d6f8e096582301b3ac59824b95304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505600 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#822254}
-
Trent Begin authored
The network diagnostics mojo is now a separate html file instead of being included directly. This allows the polymer 3 modulizes to correctly convert the include into a module. Bug: chromium:11406598 Change-Id: Idc4dc7c1a23b0a9897742289c311c07e0507fc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490349 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#822253}
-
Daniel Hosseinian authored
crrev.com/820094 recently disabled the test on macOS and Linux due to flakes. The tests are now flaking on Windows due to crashes, not timeouts. TBR=jam@chromium.org Bug: 1141263 Change-Id: Ie2913d30a138b8073811e3ee04774c473d893aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507950Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#822252}
-
Sven Zheng authored
Currently if a developer want to run a pixel test locally, they need to append "--no-luci-auth" flag. With this change, developer will not need to the flag when running test locally. This makes the test easier to use as adding the flag is not obvious. Change-Id: I4cba13fba41a38099e714d0ab5e9e3ddc648d250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506139Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822251}
-
Rune Lillesveen authored
TBR=josiahk@google.com Bug: 1139939 Change-Id: I4b173529cfebfaea9f5efd5f1c2ce621bc0cacac AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505806Reviewed-by:
-
Etienne Bergeron authored
This CL is adding the code to dump memory usage for inner-structures used by URLIndexPrivateData. The purpose of this CL is to estimate the size/count of the pathological cases and to see which inner strucutures required limits. NOTE: This CL need to be reverted before the M88 branch point on Nov 12. Bug: 1068883 Change-Id: I5c4709d7ce7b634aa2ccf5b40bc19d6bff2e77eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504278 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#822249}
-
Chris Harrelson authored
Metrics are very positive. Bug: 1115577 Change-Id: Ib68e5fcf6248f02e5ebc665247116b410ab50c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488753Reviewed-by:
-
Mehran Mahmoudi authored
This attempts to fix the failing StartupPaintPreviewTest#testRemoveOnActionbarClick test. Bug: 1143219 Change-Id: Icc93483d13d96c9331f1b26d5ff9f0ef748c0750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506886Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822247}
-
David Bienvenu authored
This CL makes the native window occlusion tracking code register a global event hook for EVENT_OBJECT_SHOW/HIDE events. When we get one of those events, check if the window class is either "MultitaskingViewFrame" (alt tab) or "TaskListThumbnailWnd" (taskbar preview). If either of these is shown, mark all non minimized root windows as visible, so that their thumbnail will appear, and things like YouTube videos will play in the thumbnail. When either of these is hidden, recalculate occlusion. The downside of this approach is that we will mark all Chrome root windows as unoccluded when any app's thumbnail is shown from the taskbar. I think it's worth doing this to fix the thumbnail regressions. There can also be a bit of a delay before rendering resumes in the thumbnails. Bug: 1137110, 993776 Change-Id: I5528d612822517071dc06904f9093ee5ee9f9f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503815Reviewed-by:
-
Eric Roman authored
NOTRY=true Change-Id: I4027f3889e876cb5450829d89dd8310459cb271b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508209 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#822245}
-
