- 22 Sep, 2020 40 commits
-
-
Andrew Xu authored
This CL handles the clipboard data with the restricted access from the multipaste menu. It implements the following things: (1) Disable the menu item whose clipboard history data should not be accessed through the multipaste menu. (2) The disabled menu item should have different UI appearance. Bug: 1106847 Change-Id: I4c58cc898a3f529a928787d6ef378eaa49f5871a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409736Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809185}
-
Xianzhu Wang authored
We should not add ContentsVisualOverflowRect() to VisualOverflowRect() if a LayoutBox should clip overflow. This should include contain:paint. This also makes the bounds of the composited layer just contain the visible part, not all descendants. Change-Id: Ibca5839ba4db59f3478131e0d00245070d99dc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422150 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809184}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d41c2a6b8aeb..edd7f9e94d43 2020-09-21 tommi@webrtc.org Check if logging for a severity is enabled at the call site. 2020-09-21 glahiru@webrtc.org Rename CancerStickCastle to RoboCaller. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8eaf8d373cea70b2af417a406f3086270accfeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809183}
-
Mustafa Emre Acer authored
Bug: 1130092 Change-Id: I50224da935beb436f2828ef8047435882a044452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419389Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809182}
-
Regan Hsu authored
This CL removes the NewOsSettingsSearch flag from the cc and enums files and defaults the JS/HTML codepaths it affects to true. Bug: 1080777 Change-Id: I0198f8a3141c3653072c8124a311dbf9beea5dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422266Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809181}
-
Vladimir Levin authored
This patch changes the content-visibility check in the inspector code to make sure that we consider ancestor frames as locked as well. R=chrishtr@chromium.org Bug: 1128790 Change-Id: Ie8a4dfebb694bbe50e8c5179ccd9e8cdcc57c35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422244Reviewed-by:
-
rbpotter authored
Bug: 1048812 Change-Id: I1b93c04ca890423f2361d5f3c8211e8a926fed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416839Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809179}
-
Nicholas Verne authored
Fixed: 1094742 Change-Id: I86e65b45d34da352049f7c43d82d0e7a4ec1f615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422020 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#809178}
-
Frédéric Wang authored
This is a follow-up of [1] which didn't handle the case of pseudo elements with a math display value. A reftest is added to verify the expected behavior with pseudo elements, but will fail until the parsing of math display values is adjusted to match what the CSSWG agreed. However, this test checks the fix for an assertion failure (http://crbug.com/1130127). Bug: 6606, 1127222, 1130127 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2404789 Change-Id: I4f7c13db003f776045a934eae9be5839b3c0343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418658Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#809177}
-
David Maunder authored
In EditUrlSuggestionProcessor and EditUrlSuggestionUnitTest there is an assumption that the URL can be acquired off an uninitialized Tab. This is currently not allowed using the UserData pattern. I recommend if the Tab is not initialized we pull the url off the web contents and not store on the UserData object CriticalPersistedTabData. Bug: 1117396 Change-Id: I0223d481b7a25722f4e6bf85e78cad45060fcbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410346 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#809176}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/3f5086309f48..e8573af9803f $ git log 3f5086309..e8573af98 --date=short --no-merges --format='%ad %ae %s' 2020-09-13 chanheepark Add a safeguard in case matching an element take longer than the interaction timeout time. 2020-09-10 tirodkar Multi-window support for visibility check 2020-09-10 tirodkar Add optional verbose logging for AppStateTracker info. 2020-09-10 mobile-devx-github-bot Disable auto capitalization for text fields and text views to reduce flakiness. 2020-09-09 chanheepark Disable auto capitalization for text fields and text views to reduce flakiness. 2020-09-08 chanheepark Fix test failure when tested locally on iPhone 11. 2020-09-06 chanheepark Do not log element information before performing action. 2020-09-03 chanheepark UI element's respondsToSelector needs to be called on the main thread. 2020-09-01 chanheepark Modify the executeJavascript action so that it works on main thread. 2020-08-31 albertbow Rename EDOBlacklistedType to EDOBlockedType per go/respectful-code. 2020-08-28 tirodkar s/URLBlacklistRege/KeyBlockedURLRegex 2020-08-28 chanheepark Rename 'explicitRunLoopDrain' to 'explicitDrainInMainRunLoop' to be more clear. 2020-08-26 tirodkar Fix Xcode project with new assertions / keyboard work. 2020-08-25 chanheepark Deleted unused methods. 2020-08-24 tirodkar Update breaking Assertion Define Macro strings. 2020-08-24 albertbow Resolve process-ownership mismatch of isKindOfClass in EG tests. 2020-08-19 tirodkar Fix issue with typing in a UITextField of the emailAddress keyboardType. 2020-08-18 tirodkar GREYAssertions logging fix 2020-08-17 chanheepark Warn user when the application uses grey_tap() to enable UISwitch. 2020-08-14 chanheepark Adds some comment for readability. 2020-08-12 mobile-devx-github-bot Add the new EarlGrey assertions macros for Objective-C. 2020-08-12 tirodkar Add support for internal runloop push / pop methods. 2020-08-11 chanheepark Print element description on GREYLogVerbose before performing action or assertion. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1126944 Change-Id: Icb5737162412efc5fb0675c30f75d6e843cddc25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416745Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#809175}
-
Sergey Ulanov authored
Some codecs require extra_data to be passed from the demuxer to decoder. FuchsiaAudioDecoder wasn't passing that information to AudioConsumer, so it wasn't passed to the decoder. Bug: 1130881 Change-Id: I095c5cdd8fa99a7316af976d9a5cb748ec9027eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423304 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809174}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I42e3f16d4237ce6fd4cfbb7df8c78c5ef08f40a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422582Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809173}
-
Andrew Grieve authored
Useful for downloading .sizediff from trybots and inspecting locally. Includes minor refactoring of file_format.py Bug: None Change-Id: I7cf9f8a5829e0eaab6210b632713508ce279ba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422318 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809172}
-
Maggie Cai authored
There are couple of cases where when selecting "Stay In Chrome" and "Remember my choice" actually stores an entry with empty app_id. However this happens randomly and cannot be reproduced easily. Add the DumpWithoutCrashing to get a trace to help debugging. The main purpose is to identify where the empty string get generated, because logically it doesn't seem to be possible. In addition to this, some early return are also added to avoid storing the entries. BUG=853604 Change-Id: I320f29418b606288e056d38088f266c817f812e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418279Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Min Qin authored
This CL use NTP clicks to help order the tiles. BUG=1096224 Change-Id: I9d3ec7c9f2d8526a7ef6cd5e5f106a48b31d767a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418902 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809170}
-
Nnamdi Theodore Johnson-Kanu authored
screenshot: https://imgur.com/cbjTH0K Bug: 1093185 Change-Id: I21eb0cdc5ad12749b7fddadd2b126dc7a1e6d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414650Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Jimmy Gong authored
MessageReceiver is responsbile for receiving serialized proto messages, deserializing the messages, and notifying clients of the updated messages. Bug: 1106937 Test: unit_tests Change-Id: I6d1c75d3f63c27213e3b85b561f6e0c3b4e47161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419757 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Mike Wittman authored
ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android, and is unrelated to any debugging functionality, so move it to a buildflag header under base/profiler. Also add the required includes to the files that use it. Bug: 1129939 Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Chris Lu authored
Bug: 1130064 Change-Id: Iedd92a96e41306e88af0d9531825adc96f27aa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419532 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#809166}
-
Peter Kasting authored
Bug: none Change-Id: I65e77af4986544bf5ec6a9e7d8784adb228884aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422984 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809165}
-
Ahmed Mehfooz authored
This CL allows the holding space bubble to dynamically add / remove items and resize as required when that happens. Bug: 1129321 Change-Id: I8b072de15628ca0fc56f23d6286026b0f6aeda69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412639 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
Peter Kasting authored
Remove DISALLOW_COPY, use constexpr more, move constants as close to first use as possible, etc. This was originally motivated by wanting to change the Combobox::set_callback() call to set_closure(); that's present here, but I couldn't help cleaning up at least some of the rest of this too. Switching to layout managers (from explicit positioning) also fixes some graphical bugs that resulted from comboboxes' preferred sizes changing after creation. Bug: none Change-Id: Iad0d483327a07ad865b252f5ab58e90037512125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421029 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This test seems to fail consistently when it actually runs (most bots skip this test suite entirely because they don't have the required GMSCore version). This disables the full test class. Tbr: nsatragno@chromium.org Bug: 1130845 Test: out/Default/bin/run_chrome_public_test_apk -f Fido2CredentialRequestTest.* Change-Id: I4655c905dd36d376f6d3842b85c8698a2ba84b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423143 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809162}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ica25552e416e0e7790865f0fb152cca9fcb9b83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422830Reviewed-by:
-
chinsenj authored
Original CL dc64daa2 was reverted by a326c157 due to a container-overflow. This CL fixes the container-flow. Original commit message: While the flag for limiting windows to the current active desk is enabled, if a user swaps desks while the window cycle list is open, the contents will not update to the new active desk. This CL makes the window cycle list reset if it is open and a desk swap occurs while the aforementioned flag is enabled. Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows Bug: 1067327 Change-Id: I9dddd0e780db33f5b727770583e0517f12eecece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417213Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809160}
-
Peter Kasting authored
Remove DISALLOW_COPY, use constexpr more, move constants as close to first use as possible, etc. This was originally motivated by wanting to change the Combobox::set_callback() call to set_closure(); that's present here, but I couldn't help cleaning up at least some of the rest of this too. Bug: none Change-Id: I5539b0b9d11a534d059107f57dd91d0f65b7a0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420778 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#809159}
-
Meredith Lane authored
TBR=elklm@google.com https://crrev.com/c/2421731 marked external/wpt/xhr/xhr-timeout-longtask.any.html as flaky on Mac10.14, but the same flakiness is present on Mac10.13: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20098 Bug: 1130533 Change-Id: I801951c158677be84804764f41bbf9b8fe6de6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422924 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#809158}
-
David Bienvenu authored
LaunchModeRecorder logs the launch mode on destruction, if set. Launch methods now take an optional LaunchModeRecorder instance for those callers that originate from an external launch. This fixes two bugs: launching multiple profiles logs multiple launch modes, and opening a profile from the user manager records a launch mode. Bug: 1032501 Change-Id: I6924ea27a8d1cf79e5a05a957c93536c55fc2830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384332Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809157}
-
Nikita Podguzov authored
Bug: 1112397 Change-Id: I2bbdc3fb7594cbc519bbb01cf2b3a5d7d251c63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414177Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#809156}
-
Gavin Williams authored
Remove the flag for enabling printer server ui as the feature has been successfully released. Bug: 1128533 Change-Id: I4c6c856a3692ae16784e81cdcdc1fd099101e648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411733Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#809155}
-
Brian Sheedy authored
Updates the flag used by the GPU Telemetry-based tests to disable device discovery notifications. Previously, this was achieved via --disable-device-disicovery-notifications, but is now achieved via --disable-features=MediaRouter. TBR=kbr@chromium.org Change-Id: Ib83b88e0d77dce2745a3d57b31449b2dad1016ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421884Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809154}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a7b87067b2c..b653fdea2f19 2020-09-21 treehugger-gerrit@google.com Merge "Two small fixes for pages with a 16KB system page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9dc113df30e9f30b048458bc00063e70d12a60e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421438Reviewed-by:
-
Kent Tamura authored
NGFieldsetLayoutAlgorithm::CreateConstraintSpaceFor*() should set TextDirection. Bug: 1130174 Change-Id: I2f763c5b24b22f1ebe836f6a7a548a63577184e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422059 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809152}
-
Tom Anderson authored
Fixes the build after [1] broke it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2392140 R=mcasas CC=tmathmeyer Bug: 1066670, 1127532 Change-Id: I340f91a1d4ba7214ea47fa4b1bb4a368fe5597f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406168Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#809151}
-
Josh Nohle authored
(1) Stop use of the soon-to-be removed (cl/332518395) GetDeviceState RPC, which checks for changes to the contact list since the last upload to the Nearby Share server. It is being removed due to the large QPS load from People API pub/sub. (2) Locally detect if the contact list or allowlist has changed since the last upload by persisting a hash of the last successfully uploaded contact data. The downside of this is that the contact list must always be downloaded to perform this check; compare this with the cheap GetDeviceState RPC call. This change detection is necessary to determine if certificates need to be revoked. (3) Remove and recreate *all* private certificates *after* new contact data is uploaded to the Nearby Share server. Note: This resolves the contacts/certificates upload race condition outlined in b/168698917. (4) Because of the added burden to fully download the contact list to check for changes, increase the check-in period from 1 hour to 12 hours. This happens in the background. However, contacts will be downloaded as soon as the user starts actively using Nearby Share (b/168834197). (5) While we're at it, remove support for the CheckContactsReachability RPC, which is unused and irrelevant. The ListContactPeople RPC only returns reachable contacts. Bug: b/154863722, b/154861518 Fixed: b/168832874, b/168698917, 1126134 Change-Id: Icef8833a46802e7953141e0a7cd1533278395a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419915Reviewed-by:James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#809150}
-
Thanh Nguyen authored
1. Adds an icon as the badge icon for the FAR recommendations 2. Make the icon consistent with arc playstore search result. 3. Move EncircledImageSource to ImageSkiaOperations so that it can be reused (no logic changed) Bug: 1028373 Change-Id: Ieabf6f39e63472f6d1b0eee70b6bc9841dbbd13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402472 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809149}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If93f0d4e4e82a93b6405c97f93d8c5993279792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422829Reviewed-by:
-
Tommy Li authored
We previously added a top inset to section headers to pad it from the results with no headers. We didn't consider that the section header could be in the top position. This leads to some extra margin for no reason, and also leads to being able to click through the popup onto the bookmark bar on MacOS. This CL fixes that. We should merge this to M86 as it's a trivial fix. Bug: 1130812 Change-Id: Ife0e81c343465e6c8624eeecbea7672e9028be93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422887 Auto-Submit: Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809147}
-
Lepton Wu authored
This reverts commit d8b85fc3. Reason for revert: The original bug has been fixed. Original change's description: > Disable webgl-compressed-texture-etc.html webgl-conformance test on CrOS > > The test is failing on CrOS and blocking LKGM updates. This disables it > while we figure out what regressed to allow for LKGM updates. > > Bug: 1127052 > Change-Id: Ie44baff4b78e495c1af42b4f01e4b6bb6b16071d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404749 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806261} TBR=oshima@chromium.org,ynovikov@chromium.org,kbr@chromium.org,bsheedy@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127052 Change-Id: I346f6a9d5f2149c444d955997975a94bc2abe80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421436Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Lepton Wu <lepton@chromium.org> Cr-Commit-Position: refs/heads/master@{#809146}
-
