GitLab

Bug: 830892
Change-Id: I665849d42d4af63171a972eaa10d9670b23f8899
Reviewed-on: https://chromium-review.googlesource.com/1134220
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574914}

There is a bug that Password Manager might silently update credentials
on successful submit of PSL matched form which doesn't have username.
That's bad, because pretty often that's not right thing. The submitted
form can be SMS verification for example.

This CL simplifies PasswordManager::ShouldPromptUserToSavePassword and
makes it returns true in case of password update as result the update
bubble is always shown when on password update.

Bug: 856543
Change-Id: I7579610e084c456ce22ca568c4f8a63284e63a5a
Reviewed-on: https://chromium-review.googlesource.com/1122134
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574913}

https://skia.googlesource.com/skia.git/+log/ebd37e2af478..4a17501f5bbd


git log ebd37e2af478..4a17501f5bbd --date=short --no-merges --format='%ad %ae %s'
2018-07-13 robertphillips@google.com Revert "update SkColor4f::FromColor() to preserve transfer function"
2018-07-13 robertphillips@google.com Revert "update SkToSRGBColorFilter color management"


Created with:
  gclient setdep -r src/third_party/skia@4a17501f5bbd

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I66ae41fdc6978ad11d50932f0a256ddbc2ba88f2
Reviewed-on: https://chromium-review.googlesource.com/1136392Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574912}

Disabling test ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement
for Android. Test is currently failing for Chrome Beta and Stable.

Bug: chromedriver:2376
Change-Id: Ia5677522deffb7cfa37efe3fdde71634cb686d4f
Reviewed-on: https://chromium-review.googlesource.com/1136219
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574911}

Freeze the iOS kernel version in the user-agent string to be "15E148"
for iOS 11.3 and later for consistency with Safari and to reduce the
fingerprinting surface.

Likewise, reduce OS version granularity from three numbers to two
numbers for iOS 11.3 and later.

BUG=860229

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0165ba4ae9dfd51308e26ebecba1a5dfba3df398
Reviewed-on: https://chromium-review.googlesource.com/1126105
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574910}

The destructor was calling RemoveControllee which calls into observers
which can do arbitrary work. This CL instead calls the observers
asynchronously after the provider host destructor finishes.

This isn't strictly to fix the linked bug but it may help, and will
allow a future patch which destroys object hosts explicitly without
worry that the observer functions were depending on them.

This required several other changes because observers destroying
the caller is a common pattern throughout the code.

Bug: 854993
Change-Id: I051f82a2ae01b36256cd8b6457347135d2863b6b
Reviewed-on: https://chromium-review.googlesource.com/1136163
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574909}

I'm removing the two renavigation metrics for ad frames both because they're not
needed anymore, and because the ad-to-ad metric was buggy, and would always
report that the navigation was to an ad for SubresourceFilter frames such as
those created via ad scripts initially.

Change-Id: I6114b239ed4251cb136e93ff55d724971d46705c
Reviewed-on: https://chromium-review.googlesource.com/1135294
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574908}

Previous versions of functions made private and named
assignFromString and replaceFromString,respectively.
assign wraps assignFromString.
replace wraps replaceFromString.

Bug: 739170
Change-Id: I3fd39a44fed1482f7e07524815297b9eec322b60
Reviewed-on: https://chromium-review.googlesource.com/1134987
Commit-Queue: Maja Kabus <kabusm@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574907}

This animation was added as a way of making the movement that happens
when omnibox suggestions are shown less jarring/annoying. It actually
had the opposite effect. ¯\_(ツ)_/¯

This change is in preparation for a follow-on CL which will remove the
movement entirely.

Bug: 853355
Change-Id: I7ae000f67fd09f3dde7a1583568696c700d19622
Reviewed-on: https://chromium-review.googlesource.com/1135774Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574906}

Using wpt-import in Chromium 2e4de532.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21196

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I5545a034c395afb0b64023acddf7354b1aafc7e4
Reviewed-on: https://chromium-review.googlesource.com/1136372
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574905}

... instead of our own copy. Post-mortem clean up.

BUG=844973

Change-Id: I0e4a69b94c0fd4d3a4fd55ecf43b80435a2e0dc5
Reviewed-on: https://chromium-review.googlesource.com/1136511Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#574904}

We can just directly use the base::Optional value here.

Bug: 791086
Change-Id: I3be79503ea2af4e68cbd751c1391ba651739fa34
Reviewed-on: https://chromium-review.googlesource.com/1135118Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574903}

IdentityManager is the recommended API to access the
Google account used by the user and SigninManager is
deprecated.

Bug: 797929
Change-Id: Ia182b65b4bd764821bd7cb46524b6400b5c35828
Reviewed-on: https://chromium-review.googlesource.com/1128809
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574902}

This reverts commit 356993f4.

Reason for revert: Test timeouts should be fixed by crrev/c/1136033.

Original change's description:
> Revert "Increase the UI paint timeout to 5 seconds."
> 
> This reverts commit 51181f47.
> 
> Reason for revert:
> Speculatively revert for resolving the bot failure on the CI: 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041
> 
> Original change's description:
> > Increase the UI paint timeout to 5 seconds.
> > 
> > This fixes the first browser window appearing blank for a moment. In
> > general, it's better to block than to show the UI in an inconsistent
> > state. Web content should *not* wait this long.
> > 
> > Bug: 849762
> > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73
> > Reviewed-on: https://chromium-review.googlesource.com/1135119
> > Commit-Queue: Sidney San Martín <sdy@chromium.org>
> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> > Reviewed-by: ccameron <ccameron@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574731}
> 
> TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org
> 
> Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 849762
> Reviewed-on: https://chromium-review.googlesource.com/1136131
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574823}

TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org,tzik@chromium.org

Change-Id: Ibfd8e40c1795e0d0f04e7373c66a6b85c9b0c8fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849762
Reviewed-on: https://chromium-review.googlesource.com/1136551Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574901}

Tests that use the fake or in-process context factory won't actually
produce the CALayerParams structure that un-blocks the
CATransactionCoordinator.

When the CATransactionCoordinator's timeout was increased to 5 seconds,
this started causing test timeouts. Disabling it for these tests should
improve the test running time substantially.

Bug: 849762
Change-Id: I05bb2fa07611d6a5b3e65cc2417a6af2111f2dd4
Reviewed-on: https://chromium-review.googlesource.com/1136033
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574900}

This CL changes the position of the FindBar to follow the design of
UI Refresh.

Bug: 805508
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5938fa23fac401f65d1324f06f73087388f66a80
Reviewed-on: https://chromium-review.googlesource.com/1134767Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574899}

This CL changes the layout of the tabCountLabel in the TabGrid button
to position it with autolayout, to prevent the app from freezing when
rotating.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I104b6c17c336e27301e2c991f0524f2fbf9062c9
Reviewed-on: https://chromium-review.googlesource.com/1136446Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574898}

Currently in its own target, and simply dumps the output to a file without
checking

Bug: 863174
Test: out/Default/ntp_render_browsertests
Change-Id: I61ca7714005c3b1d40f354d9f2ca519750843108
Reviewed-on: https://chromium-review.googlesource.com/1135756Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574897}

Change DirectoryTree.updateTreeByEntry_ to call updateItemByEntry on
its sub-items, to fix folder updates within EntryListItem/My Files.

Add MY_FILES_ROOT_LABEL to static translation strings.js for UI tests.

Also change getBreadcrumbsPath result to accept the expectedPath with
or without My Files prefix so tests can pass with/without My Files.

Bug: 857335
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I76b85c75374190403ed1301f4021b5ec725d9d00
Reviewed-on: https://chromium-review.googlesource.com/1136340
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574896}

- The UnifiedConsentService waits until the sync engine is intialized to
make changes to the sync-everything state.
- When the engine is initialized, UnifiedConsentService tries to make
sync-everything match the unfied-consent-given pref.

This change makes sure that the user is in the correct state after
going through the consent bump. (The consent bump is shown before
the sync engine is initialized.)

Before this CL, the sync-everything pref was set to false at startup as
part of the migration. When the user didn't opt into unified-consent
after going through the consent bump, all sync data type toggles would
be off because the sync-everything pref was set to false before the engine
was initialized.

Bug: 819909
Change-Id: I13f56e69197d3469fab1a3259eb6c5cbeb7ffbdf
Reviewed-on: https://chromium-review.googlesource.com/1136442
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574895}

Rename PdfiumPage::ScopedLoadCounter to more appropriate
name PdfiumPage::ScopedUnloadPreventer.

Change-Id: Idd8b7d2b57dbbeac0826ade010b29420956c9062
Reviewed-on: https://chromium-review.googlesource.com/1100834
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574894}

This is in preparation of adding a new echo cancellation type constraint value.

It also clarifies the existing situation.

Bug: TBD
Change-Id: Iae3db2451aea302dd758cc0880649193274afedc
Reviewed-on: https://chromium-review.googlesource.com/1133259Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574893}

Adding chevron with animation to collapse and expand the 2 sections
in the Sync and Google services settings.
To support collapsable section, SettingsCollapsibleItem and
SettingsCollapsibleCell classes are added.

Screenshot:
https://drive.google.com/open?id=1Q82j3xiB7ZYihyyCiS_xalh2AFcCzKTs

Mocks:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3ae6bac383_31_43

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9f75fa1105faaf5e81133a1250a800aa5bfa2136
Reviewed-on: https://chromium-review.googlesource.com/1128758
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574892}

This CL makes sure that the email is filled on the Chrome sign-in page
for all Chrome sign-in flows started from extensions.

Bug: 856513
Change-Id: If90c80971bd2c95c5e44707fe166ea9228f12fed
Reviewed-on: https://chromium-review.googlesource.com/1124696Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574891}

The next step will be to figure out how to get back to the initiating
WebContents, dump the redirect chain into a LoadURLParams struct,
and continue the download as navigation.

BUG=831073
R=qinmin@chromium.org,dtrainor@chromium.org

Change-Id: I28c55fdc9982433b684184b234f8f503c46facc5
Reviewed-on: https://chromium-review.googlesource.com/1135307Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574890}

Inactive tab hit-testing overlap regions is now calculated to be 1 dip
above the top of the tab separator.

Bug: 859204
Change-Id: Idbd92f9209ff2bbcd5516f26d1acfbd0b83ae563
Reviewed-on: https://chromium-review.googlesource.com/1135726Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574889}

This is done by adding a new |enable_language_splits| variable to
the android_app_bundle GN template. Note that splitting by
screen_density or ABI currently doesn't make sense for Chromium,
but could be added in the future.

Only the chrome_public_bundle target uses language-based
splits in this CL.

BUG=846633,820459
R=agrieve@chromium.org, yfriedman@chromium.org
TBR=twellington@chromium.org,tedchoc@chromium.org

Change-Id: Ic89f9dd4b8c78e8b2127bb19208db18bc8027eab
Reviewed-on: https://chromium-review.googlesource.com/1125934
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574888}

exception_messages.* triggers the pattern match for the IPC owner
presubmit, but it isn't actually an IPC-related file.

Bug: 863161
Change-Id: Ia5655c49c991bcab308dca36bd41c4afc574f941
Reviewed-on: https://chromium-review.googlesource.com/1136063
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574887}

Bug: 771597
Change-Id: I432d1f2d39745f311c4aba259bce8d1a080e48ba
Reviewed-on: https://chromium-review.googlesource.com/1136431Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#574886}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6234bd45..47b0a995

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iac4af3529c4772ca388c44c6410cd12f7cd7b071
Reviewed-on: https://chromium-review.googlesource.com/1136229Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574885}

Some devices like VM or chromeboxes do not have built-in camera at all,
we should not treat it as an error.

BUG=b:77833131,b:64996728,chromium:832816,chromium:852302
TEST=external camera works on teemo (a chromebox)

Change-Id: I2a19afa72ab9e0828f4c65a7761cd2b54d1ecfdd
Reviewed-on: https://chromium-review.googlesource.com/1136451Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574884}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/27998f763495..74aa8cb5bd4e


git log 27998f763495..74aa8cb5bd4e --date=short --no-merges --format='%ad %ae %s'
2018-07-13 dats@google.com drivefs: Add chronos to fuse-drivefs group


Created with:
  gclient setdep -r src/third_party/chromite@74aa8cb5bd4e

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I6fb262d242f1435ee66abb20fee5c96cf2f0fa9a
Reviewed-on: https://chromium-review.googlesource.com/1135357Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574883}

When the WebSocketHandshakeReuseConnection feature was enabled,
"Keep-Alive" would be included in the Connection header. This behaviour
was copied from Firefox, however it is non-standard.

Microsoft Edge does not include "Keep-Alive" in the Connection header,
and Windows authentication works with WebSockets in Microsoft Edge. So
it is unlikely any server depeneds on the presence of "Keep-Alive".

Stop including "Keep-Alive" in the Connection header when
WebSocketHandshakeReuseConnection is enabled.

BUG=423609

Change-Id: Icaf232872c25b13951c7b22ac8d7f375eeadc9ff
Reviewed-on: https://chromium-review.googlesource.com/1131354Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574882}

Fields set in the streamline configuration should not be modifable by
user.

BUG=chromium:857452
TEST=manual, I'm going to add tests checking this into CL:1131497

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2835df9dd6b0bd68660302c634747fa216a53b8b
Reviewed-on: https://chromium-review.googlesource.com/1134782
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574881}

This CL adds an animation for the TabGrid button in the toolbar.
The button has an animation when the tab count is changing.
It also rotates if a tab is added in background, to match the new
animation.

Bug: 843576
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia26e5a89db0ac0baeba0fc5d6ec57b58ff6fe30f
Reviewed-on: https://chromium-review.googlesource.com/1131455
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574880}

The masked password is displayed for non-PSL and non-Android credentials now.
Later when the drop-down supports a bottom label, it'll be shown for all.

Bug: 851021
Change-Id: I491e7c24a58311c1250e8e89cddb9ccae95a9296
Reviewed-on: https://chromium-review.googlesource.com/1135325Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574879}

This CL adds the animation triggered when opening a new tab in
background.

Bug: 843576
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I243e375139f6e5c58e164ef43785db277604a4a4
Reviewed-on: https://chromium-review.googlesource.com/1131191
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574878}

We'd like to make DOMNodeRemoved and DOMNodeRemovedFromDocument events
asynchronous. This CL adds some UseCounters to investigate its impact.

* kDOMNodeRemoved*EventDelayed:
  We already dispatch the events asynchronously in some cases.
  This counts them.

* kDOMNodeRemoved*EventHandlerAccessDetachingNode:
  Count cases where
 - Accessing parentNode of to-be-removed Node
 - getElementById() for to-be-removed Node or its descendants
 - NodeList/HTMLCollection/querySelector*() for to-be-removed Node
  or its descendants in DONNodeRemoved* event handler.
  If we change the timing, we'll have incompatibility in such cases.

  This doesn't have a perfect coverage. For example, sibling access
  from a sibling of to-be-removed node is not counted.

* kDOMNodeRemoved*EventListenedAtNonTarget:
  Count if the events are listened at non-target nodes.
  If we change the timing, bubbling/capturing won't work well.

This CL has no behavior changes except UseCounters.
If benchmarks regress a little, we won't revert this CL soon, and
will revert after a branch point. If benchmarks regress very much,
we'll revert this CL.

Test infrastructure:
* Add internals.clearUseCounter() so that we can test a UseCounter
  multiple times in a single test.

Bug: 859391
Change-Id: Iefaa324217a3e914c7f095165aba513b847b328f
Reviewed-on: https://chromium-review.googlesource.com/1134640
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574877}

Using wpt-import in Chromium 115ba705.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21195

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mlamouri@chromium.org:
  external/wpt/remote-playback
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=robertma

No-Export: true
Change-Id: I4a6c5ebbff768dda66cf112598def030eee37936
Reviewed-on: https://chromium-review.googlesource.com/1136223
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574876}

NVDA is announcing live region text changes multiple times. Only fire
one type of live region event at a time.
- Name from attribute change (e.g. from alt, aria-label, aria-labelledby,
etc.): fire only a name change event.
- Text contents change: fire only text removed/inserted events.

Bug: 778478
Change-Id: I7dd17217826fe2ba18bd2c921839bcf19f7d63cf
Reviewed-on: https://chromium-review.googlesource.com/1134021
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574875}