- 07 Jun, 2014 23 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275583 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/316383003/dcheng@chromium.org authored
Reason for revert: Breaks rendering on Android Chrome. Original issue's description: > Blink roll r175622:175677 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175677&mode=html > > TBR=peter@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275538 TBR=peter@chromium.org BUG=381982 NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/319183009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275582 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
We were previously linking in this .obj file which patched the broken ftol that was causing floating point stack overflows. This is fixed in VS2013 Update2 and so is no longer required. https://connect.microsoft.com/VisualStudio/feedback/details/808199 R=cpu@chromium.org BUG=348525 Review URL: https://codereview.chromium.org/318153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275581 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Telemetry is designed for performance, not functional testing and it is currently bearing more of the weight of these failures than the infra can handle. NOTRY=True BUG= Review URL: https://codereview.chromium.org/322593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275580 0039d316-1c4b-4281-b951-d872f2087c98
-
reed@google.com authored
BUG= Review URL: https://codereview.chromium.org/321563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275579 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=none TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/322623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275578 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Add an extension override bubble and warning box for proxy extensions. (2nd attempt, this time with two one-liner test fixes) Also use the browser action highlighting for extensions that have a browser action icon. NOTE: This CL was already green-lighted here: https://codereview.chromium.org/288923004/ BUG=381291 TBR=sky, devlin, dbeam Review URL: https://codereview.chromium.org/320633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275577 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275576 0039d316-1c4b-4281-b951-d872f2087c98
-
justincohen@chromium.org authored
This pulls in the following CLs: - r1332 Fix minor typo in a comment in r1331. - r1333 Fix a memory leak in DwarfCUToModule::FuncHandler::Finish(). - r1334 Linux: Fix a memory leak in ExceptionHandler. - r1335 Print more x86-64 registers in minidump_stackwalk - r1336 Add missing MD_MISCINFO_FLAGS1_BUILDSTRING. - r1337 Add virtual dtor to LibcurlWrapper. - r1338 Use PAGE_MAX_SIZE. PAGE_SIZE is now a variable size. BUG=none TEST=None Review URL: https://codereview.chromium.org/314303010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275575 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
It is failing the smoke tests. TBR=dtu@chromium.org NOTRY=True NOTREECHECKS=True BUG= Review URL: https://codereview.chromium.org/326453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275574 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
Instead of waiting for build based on timeout, now we try to check the build status by parsing the buildbot JSON. This will remove unnecessary wait when build fails. Otherwise build is treated as Pending, and bisect script waits till max timeout. BUG=368939 NOTRY=true Review URL: https://codereview.chromium.org/295133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275573 0039d316-1c4b-4281-b951-d872f2087c98
-
ajuma@chromium.org authored
This creates an expanded GPU rasterization device whitelist for a field trial. BUG=380694 Review URL: https://codereview.chromium.org/313703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275572 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
src/extensions/browser/api/ Make it compiled and fix typo. BUG=381706 Review URL: https://codereview.chromium.org/319543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275571 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
In addition to making sessions unavailable, also abort inactive streams and close idle sessions. BUG=324653 Review URL: https://codereview.chromium.org/321513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275570 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=381550 Review URL: https://codereview.chromium.org/320053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275569 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
CanExecuteScriptOnPage is currently being used for both content script permissions and generic access (tabs api, etc). Instead, since these have two purposes, there should be two functions. BUG=379356 Review URL: https://codereview.chromium.org/321533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275568 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Once upon a time, in an era of great suffering, Chromium Mac was not using CoreAnimation, with it being necessary to override -drawRect: to paint the tab contents area background fill. That time has, unfortunately, not yet passed. This change simply updates a few comments to wrap up the resolution of bug 354598, which ccameron@ has mainly fixed in an earlier change; and also defaults the bgColor to white when the themed color is not available. BUG=354598 Review URL: https://codereview.chromium.org/319703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275567 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
Revert of Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (https://codereview.chromium.org/302553007/) Reason for revert: Caused every LayoutTest to ASSERT in every configuration. Original issue's description: > Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked. > > Existing implementation calls SetScreenOrientationForTesting and sends screen > orientation events even when the test screen orientation is locked. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275535 TBR=jochen@chromium.org,ch.dumez@samsung.com,mlamouri@chromium.org,sl.ostapenko@samsung.com NOTREECHECKS=true NOTRY=true BUG=162827 Review URL: https://codereview.chromium.org/323663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275566 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/307423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275563 0039d316-1c4b-4281-b951-d872f2087c98
-
stanisc@chromium.org authored
This was achieved by changing ProfileSyncService::GetTypeStatusMap() to have a special case for proxy types. A passive proxy type gets assigned status "ok" instead of "warning" which makes it appear green on the about:sync page. BUG=380442 Review URL: https://codereview.chromium.org/312333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275561 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
remove test windows. i don't think we need them any more. BUG=381477 R=mukai@chromium.org TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/314303004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275560 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
My r275303 mistakenly removed a function override. (it was a reasonable change for an earlier patch set) Restore ConstrainedWebDialogDelegateViewViews code. (uses dialog frame views via CreateNonClientFrameView) BUG=381524 TEST=Print preview dialog frame is back to normal. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/317243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275559 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Removed unnecessary static PrivetV3Session::Create method. BUG=372843 Review URL: https://codereview.chromium.org/314303009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275558 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Jun, 2014 17 commits
-
-
pavely@chromium.org authored
Tree doesn't compile, returning to original state. > Revert 275154 "ChromeOS login webui refactoring : Move GAIA-rela..." > > This change preventing me from reverting r275046 which seems to be causing > failures in KioskTest > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > > > ChromeOS login webui refactoring : Move GAIA-related code to gaia_screen_handler > > > > BUG=373314 > > R=nkostylev@chromium.org > > > > Review URL: https://codereview.chromium.org/304303005 > > TBR=antrim@chromium.org > > Review URL: https://codereview.chromium.org/310313006 TBR=pavely@chromium.org Review URL: https://codereview.chromium.org/321633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275556 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
Tree doesn't compile, returning to original state. > Revert 275046 "ChromeOS login webui refactoring: split user sele..." > > Revert change as it likely causes KioskTest failure > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > > > ChromeOS login webui refactoring: split user selection/gaia login screens. > > Phase two : move user list processing to UserSelectionScreen > > > > BUG=373314 > > R=nkostylev@chromium.org > > > > Review URL: https://codereview.chromium.org/296823009 > > TBR=antrim@chromium.org > > Review URL: https://codereview.chromium.org/317243006 TBR=pavely@chromium.org Review URL: https://codereview.chromium.org/319273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275555 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Removes the second dialog implementation, which was a slightly modified version of the first one. BUG=NONE Review URL: https://codereview.chromium.org/318733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275554 0039d316-1c4b-4281-b951-d872f2087c98
-
rosca@adobe.com authored
SkGpuDevice constructors are deprecated and the factory should be used instead when filters and blending require offscreen targets. Extra NULL check added: for many reasons, something can go wrong within GrGpuGL::onCreateTexture() and fail to create the backing store's texture. Instead of crashing, we can handle this gracefully and simply render the page without the blending applied. BUG=359947 Review URL: https://codereview.chromium.org/315913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275553 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
set up a timer to cancel any requests, if the handshake takes too long. The requests will be retried and will use either QUIC or TCP, whichever connects first. Review URL: https://codereview.chromium.org/318993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275552 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This is in preparation of merging NetworkState and FavoriteState, crbug.com/375955. The merge will involve a number of changes to ShillPropertyHandler and in the process of making those changes some additional logging and test cleanup was necessary that isn't directly related to the merge itself. BUG=none For trivial changes to chrome/browser/ui/webui/options/ TBR=dbeam@chromium.org Review URL: https://codereview.chromium.org/299403012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275551 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
Revert change as it likely causes KioskTest failure http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring: split user selection/gaia login screens. > Phase two : move user list processing to UserSelectionScreen > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/296823009 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/317243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275550 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Move GAIA-related code to gaia_screen_handler > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/304303005 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/310313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275549 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Simplify login methods. > > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/324463003 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/319633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275548 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Android keyboard generates key press and key release events for latin keyboard. The client was sending them as KeyEvent, as result the host was not injecting correct characters when remote keyboard layout is not Qwerty. Now client sends TextEvent for events that come from software keyboard. BUG=364276 Review URL: https://codereview.chromium.org/303443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275547 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
InputManager provides ToplevelEventTarget and AcceleratorManager. Added test short cut (ctrl-l) to show the home card. BUG=375534 TEST=covered by unit tests R=sadrul@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/305873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275545 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
The size of the frame data from a delegated source will not in general match up exactly with the delegated layer's bounds. Frame sizes and layer bounds are both expressed as integers, but frame sizes are in physical pixels and layer bounds are in device-independent pixels. If the device scale is not an integer, there may not be an exact mapping between the two spaces. For instance, if the layer size is 105 x 211 and the device scale is 1.5, the delegated content is responsible for filling 157.5 x 316.5 physical pixels in the final output. This isn't really possible so what actually happens is the delegated renderer produces a frame with a physical size of 158 x 317 pixels and sends that up to the DRLI. To map this frame into physical space, the DRLI should apply the inverse of the device scale factor to reflect that the frame covers 105.333 x 211.3333 logical pixels. Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317) resulting in the frame being scaled down non-uniformly to try to make 158 x 317 pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up mapping pixels partially outside of the layer's logical bounds into the layer's logical bounds. BUG=370074 Review URL: https://codereview.chromium.org/311253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275544 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Review URL: https://codereview.chromium.org/320513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275542 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
TBR=nduca@chromium.org BUG= Review URL: https://codereview.chromium.org/322553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275541 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Make FixupUserInput() just return the fixed-up input text, since almost every caller wanted that (and the one that didn't, the HUP, will change in the future) * Make some functions which took an AutocompleteInput object and then only cared about the text() just take a string16 * Eliminated HistoryURLProvider::RunAutocompletePasses(), since it had only one caller, and just inline the code into Start(). Also got rid of the |fixup_input_and_run_pass_1| variable that was never false. BUG=none TEST=none Review URL: https://codereview.chromium.org/312423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275540 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275539 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175677&mode=html TBR=peter@chromium.org Review URL: https://codereview.chromium.org/316383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275538 0039d316-1c4b-4281-b951-d872f2087c98
-