- 22 Dec, 2019 25 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b02ce1317e55..73e676d96293 Created with: gclient setdep -r src-internal@73e676d96293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5bcfe0d7b3df4acac66f498298843ff2f00981f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979861Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727094}
-
Ben Pastene authored
This will cause it to be false in ARC-bits of chrome-branded linux-chromeos builds. This should reduce the maintenance burden of Chrome's clang since there's a non-zero cost of ensuring the official linux-chromeos build config builds with thin lto. Disabling it should be safe since linux-chromeos is a developer-only build, and actual builds of Chrome OS explicitly set it: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c6956bccc6e77a38395f35919d43c502f6c5cdf/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild#271 Bug: 1033839 Change-Id: I8d44482a6cea956afba808480aeed69c64e5c6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967602 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727093}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c069396d1b7b..b02ce1317e55 Created with: gclient setdep -r src-internal@b02ce1317e55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibb2d0e3a9706f060a9bf486c0a8cb49e2890c902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979859Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: Ia96367ac73d710a3da9fe504c02a4d192ca6e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727091}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/presentation. Bug: 1001114 Change-Id: I87f701a9e52a90911e82b0c6a68bff524e3af203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961688 Commit-Queue: Julie Kim(OoO til Jan 01) <jkim@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#727090}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cca9e2e29e2a..3ace0d74bcbe git log cca9e2e29e2a..3ace0d74bcbe --date=short --first-parent --format='%ad %ae %s' 2019-12-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3ace0d74bcbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I072fe310cd93c62732bc99a8b589bd0f2b371c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979857Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb1300fea863..c069396d1b7b Created with: gclient setdep -r src-internal@c069396d1b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idab921f1f93ea0f3418576aa22caed9190b538ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979856Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I20b6a14b7109dd3d994bbd20719f8d82b33fa7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979066Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727087}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/259752745b7a..cb1300fea863 Created with: gclient setdep -r src-internal@cb1300fea863 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4ab78bf6cb4ad2c0cd0acff1b7b07bbab99f7276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979855Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc4b93407789..259752745b7a Created with: gclient setdep -r src-internal@259752745b7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie0328d6bb972473551101ee4f40d50fc37afe3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979852Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47314dc0. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1631d7d425c71e2c6ec328706d5000cd81cc7680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979971Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727084}
-
Xianzhu Wang authored
This reverts commit 35ecc051. Reason for revert: Add SetPropertyTreesNeedRebuild() which was mistakenly removed in the previous patch. This avoids b/14358579 and crbug.com/1034788. Original change's description: > Revert "Reland "Move fields in cc::Layer::Inputs for layer tree mode only into LayerTreeInputs"" > > This reverts commit ba176792. > > Reason for revert: b/146358579 > > Original change's description: > > Reland "Move fields in cc::Layer::Inputs for layer tree mode only into LayerTreeInputs" > > > > This reverts commit 074fbb7f. > > > > Reason for revert: Fixed break by not printing position in > > cc::Layer::ToString(). > > > > Original change's description: > > > Revert "Move fields in cc::Layer::Inputs for layer tree mode only into LayerTreeInputs" > > > > > > This reverts commit d46e17a7. > > > > > > Reason for revert: breaks cc::Layer::ToString() > > > > > > Original change's description: > > > > Move fields in cc::Layer::Inputs for layer tree mode only into LayerTreeInputs > > > > > > > > This makes clear what fields are for layer tree mode only, and avoid > > > > unnecessary memory usage of the unused fields in layer tree mode. > > > > > > > > (TBR for passive one line change in ui/compositor/layer.h) > > > > TBR=flackr@chromium.org > > > > > > > > Change-Id: I711db13c08885038728af71776c02e5d40ab5d86 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965743 > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#725002} > > > > > > TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org > > > > > > Change-Id: Ie742d5a9baac487564635f5ce214f878c37f104f > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969330 > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#725058} > > > > TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org > > > > Change-Id: Ibe5bc5f35ec7d8efb492cd0fe028c016fcebfb9f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969331 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#725068} > > TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: I2c80f9ee78ddaee2625b59f691356c52fa4720a6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970304 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725336} TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib600623a1c6cb671d812cc6737df361f180a9e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978467 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ec826085b2a..ac29f1342fd2 git log 6ec826085b2a..ac29f1342fd2 --date=short --first-parent --format='%ad %ae %s' 2019-12-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@ac29f1342fd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ib3fd3dbae51ba9958d11197d0095fef7447ec82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979853Reviewed-by:
-
Will Cassella authored
Passing a `mojo::StructPtr` by const-ref is basically just passing a `std::unique_ptr` by const-ref, which is disallowed by the style guide. https://google.github.io/styleguide/cppguide.html#Ownership_and_Smart_Pointers It's also inefficient because it requires a double-indirection to access any members of the pointee. Change-Id: Ic579a5ae19dbc5ff871bd07e7ef5c92f410a83b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977396Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#727081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ed0ad69e2b1..dc4b93407789 Created with: gclient setdep -r src-internal@dc4b93407789 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I806a8944e9721fc653a2bfee3bdc63fd9c2dea50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979954Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b21c79dc. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If315189193683cfb8e3b7553d3a63b0e83cbb23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979969Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/814d64d058ed..3ed0ad69e2b1 Created with: gclient setdep -r src-internal@3ed0ad69e2b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If35d382ba34da615d534f4061479b9f4872000ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979642Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add a helper function GenerateSequence() to make it easier to write tests that need to issue a series of commands for a sequence of frames. With this function, it should be possible to write tests for any sequences that hit any of the DCHECK()s in this code. Add a couple of simple tests with this new function. BUG=1034103 Change-Id: I61f2e22ca69f9d2cfb1e09b1e42a18d4c44e429d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979767 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#727077}
-
Kent Tamura authored
The following operations and functions had issues applying wrong context nodes to non-first arguments. This CL fixes them. - Operators: or and = != < > <= >= + - * div mod - Functions: concat() starts-with() contains() substring-before() substring-after() substring() translate() Bug: 1036075 Change-Id: I87b393557dc55897d01f6ea627ae83a34cf45331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977884Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#727076}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0af8b596129b..07d3bcf1c443 git log 0af8b596129b..07d3bcf1c443 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 gary.sweet@broadcom.com Correct calculation of GL_MAX_VARYING_COMPONENTS Created with: gclient setdep -r src/third_party/angle@07d3bcf1c443 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I3012831da39e76c85123d84a77eb669882878454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979309Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add more information for the various stages to help better understand (and reproduce) the DCHECK() hits. BUG=1034103, 1035382 Change-Id: I85c98bc70c1270baa231768f35555a38657e4ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979849 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Andrew Xu authored
In ShelfView with the Hotseat flag enabled, ShelfView's |last_visible_index_| updates in ScrollableShelfView::ViewHierarchy- Changed which may be triggered when the child view is destructed. However, for the removed child view, it may be destructed at the end of fading out animation that runs in asynchronous way. As a result, the old value of |last_visible_index_| may still be accessed , such as in tests. This CL fixes the issue by updating |last_visible_index_| before starting the fading out animation when hotseat is enabled. Bug: 1032702 Change-Id: I53c890427f23241763fb001b173459bcce230a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576007Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727073}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34b3c0b066e5..cca9e2e29e2a git log 34b3c0b066e5..cca9e2e29e2a --date=short --first-parent --format='%ad %ae %s' 2019-12-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cca9e2e29e2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9259f6aa5784793a39d475a9416c2d01ca84b62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979953Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8dd630b30d06ca7eea351a388f4f58a5abab4d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979061Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727071}
-
Sadrul Chowdhury authored
This reverts commit b21c79dc. Reason for revert: Broke build on chromeos: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/15413 Original change's description: > Roll clang n332890-c2443155-1 : n333938-3a6da112-1. > > Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. > > Bug: 1030664 > Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 > Auto-Submit: Reid Kleckner <rnk@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727069} TBR=thakis@chromium.org,ukai@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: I2736079e5922fb9b182e952d233d5020ec15eef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979042Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#727070}
-
- 21 Dec, 2019 15 commits
-
-
Reid Kleckner authored
Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`. Bug: 1030664 Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387 Auto-Submit: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Dana Fried authored
In a few caes, fading out a view would not actually cause it to become invisible. These can be listed as: - In some cases, FadeInOutMode::kHide would not hide the view - If the layout were reset during a fade-out of a view hidden by calling SetVisible() or FadeOut() the view might fail to hide This change ensures that a view that is supposed to fade out always does - and adds appropriate unit tests. Change-Id: I9713f9806e0aa13ad8b35982ac47c2112c91d348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979635Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#727068}
-
Etienne Bergeron authored
Follow up this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1976702 R=oysteine@chromium.org CC=vasilii@chromium.org Bug: 1027929 Change-Id: Id88483e68b41604f541d3bdf71e35d8bca381a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978937 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#727067}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/exo/ Fixed: 1007687 Change-Id: I9a4f7be49e8ff96b9a35e796bc64e54caf9b27a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979014 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#727066}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.83-1576492580-benchmark-81.0.4000.0-r1 to 81-3945.83-1576492580-benchmark-81.0.4001.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I53c787c14e02774d11919b40bc6cc4278ad02f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979307Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bcfc4f47594..814d64d058ed Created with: gclient setdep -r src-internal@814d64d058ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I35bb1ca4ddc5076022d1bb063ca54e6b3f42e71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979889Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b40bf3083746..4bcfc4f47594 Created with: gclient setdep -r src-internal@4bcfc4f47594 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4580059670d9d16b2cfea14b3372f171827aa372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979462Reviewed-by:
-
Samuel Huang authored
This reverts commit 162137c6. Reason for revert: crbug.com/1036648: This CL triggers heap-use-after-free in ASAN (although the root cause lies elsewhere, maybe inactive code). Reverting to denoise system. Original change's description: > Enable AppService InstanceRegistry feature. > > BUG=1011235 > > Change-Id: Icb262a58b4464d7963acb0b22a9d30ce7b070060 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972738 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726576} TBR=dominickn@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1036648, 1011235 Change-Id: Ib942d2a4f72e24871adea66626dc95b78a8f06c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979850 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727062}
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: If6c37c46b3736a936c84cae393fdbc71655a5033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973815 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727061}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2e2f25aec20..b40bf3083746 Created with: gclient setdep -r src-internal@b40bf3083746 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idc1c9adccf439d3885ecd99fa8ac8ccdd679d9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979461Reviewed-by:
-
Etienne Bergeron authored
Move the functions without dependencies to RunList into RenderText. R=pkasting@chromium.org Bug: 1025561 Change-Id: I257fdca2543d9a56823cdbcc7fed1e94467ebaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978097Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727059}
-
Etienne Bergeron authored
Trival dead code. R=pkasting@chromium.org Bug: 1025561 Change-Id: I1297bed599a55fd11fedcb810379173b8c17c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979368Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ebf5fd11de10..6ec826085b2a git log ebf5fd11de10..6ec826085b2a --date=short --first-parent --format='%ad %ae %s' 2019-12-21 reed@google.com Reland "make clipIsWideOpen virtual, so device's don't have to rely on regions" Created with: gclient setdep -r src/third_party/skia@6ec826085b2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I573ef092af17aff6e5f1598f9f5421d111f01733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979459Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: Ic7a12e3e08215eb588b4cb6b4cbb7feda1aaff4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979457Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc33b15dc48f..a2e2f25aec20 Created with: gclient setdep -r src-internal@a2e2f25aec20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifcc0672d17333e58073bef455ee6e6720ff0db66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979456Reviewed-by:
-
