GitLab

Same as previous fix, but for mouse buttons.

The SYN_DROPPED part is N/A because that is handled by libevdev.

BUG=463002
TEST=Tested unplug by unplugging mouse with left button held.
  Left mouse button gets properly released rather than being stuck.
  (NB: Could not reproduce without adding a delay to expose the race).

Review URL: https://codereview.chromium.org/983213003

Cr-Commit-Position: refs/heads/master@{#319699}

Adds the ability to extract which applications can handle a particular
intent.

BUG=464934

Review URL: https://codereview.chromium.org/988963004

Cr-Commit-Position: refs/heads/master@{#319698}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/13e51f9..86e31a1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/994643002

Cr-Commit-Position: refs/heads/master@{#319697}

Revert of Re-enable the new SQLitePersistentCookieStore load strategy. (patchset #1 id:1 of https://codereview.chromium.org/953993002/)

Reason for revert:
This CL causes hangs during shutdown.

https://code.google.com/p/chromium/issues/detail?id=465271

Original issue's description:
> Re-enable the new SQLitePersistentCookieStore load strategy.
>
> When I first turned on the new load strategy, it caused deadlocks during
> shutdown. I found and fixed the bug in SequencedWorkerPool.
>
> BUG=448910
>
> Committed: https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b
> Cr-Commit-Position: refs/heads/master@{#318305}

TBR=erikwright@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448910

Review URL: https://codereview.chromium.org/992723002

Cr-Commit-Position: refs/heads/master@{#319696}

Chrome Apps (e.g. hangouts etc.) can set a custom shape for the windows. Make
sure the shape is translated correctly in hidpi environment.

BUG=461120
R=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/985993002

Cr-Commit-Position: refs/heads/master@{#319695}

BUG=463892

Review URL: https://codereview.chromium.org/988003002

Cr-Commit-Position: refs/heads/master@{#319694}

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/983223004

Cr-Commit-Position: refs/heads/master@{#319693}

autosize is no longer used in <extensionoptions> and it adds a lot of complexity.

I eventually want <extensionview> and <extensionoptions> to merge to reduce maintenance
overhead, especially on the <webview>/GuestView team. This dead code makes it harder to reach that objective.

BUG=442033

Review URL: https://codereview.chromium.org/990223002

Cr-Commit-Position: refs/heads/master@{#319692}

BUG=462246
TEST=Start Chrome with --enable-new-avatar-menu and a single, local profile.
Sign in. The avatar button should correctly update and display the synced name.

Review URL: https://codereview.chromium.org/974373002

Cr-Commit-Position: refs/heads/master@{#319691}

We were putting the wrong FrameTreeNode ID on the OpenURLParams
when a navigation was destined for a different WebContents.

BUG=464944
TEST=Shift click a link to https://chrome.google.com/webstore
     in --site-per-process mode.

Review URL: https://codereview.chromium.org/988953003

Cr-Commit-Position: refs/heads/master@{#319690}

The objective of the patch is that the poster attribute for plugins can support high-dpi images via the img srcset syntax, i.e.

<param name="poster" value="poster1x.png 1x, poster2x.png 2x" />

BUG=457333

Review URL: https://codereview.chromium.org/981623003

Cr-Commit-Position: refs/heads/master@{#319689}

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/983793003

Cr-Commit-Position: refs/heads/master@{#319688}

Also fix position of bubble for requestAutocomplete dialog.

BUG=464640

Review URL: https://codereview.chromium.org/981293003

Cr-Commit-Position: refs/heads/master@{#319687}

The last committed URL check isn't sufficient in certain scenarios.
This CL ensures that login interstitials always replace any existing
interstitial.

BUG=458972

Review URL: https://codereview.chromium.org/938713003

Cr-Commit-Position: refs/heads/master@{#319686}

Revert "Revert of Output closure-compiled JavaScript files (patchset #10 id:180001 of https://codereview.chromium.org/958383003/)"

This reverts commit 30fc31d1.

Missed a renaming a reference to run_js_check

Original issue's description:
> Output closure-compiled JavaScript files
>
> If generate_output is set, chcker.py adds compiler flags to actually
> output the compiled JS. It will also output a source map if the build
> is Debug.
>

BUG=393874

Review URL: https://codereview.chromium.org/990983002

Cr-Commit-Position: refs/heads/master@{#319685}

Fix off-by-one in SpdyFramer::GetNumberRequiredContinuationFrames().

BUG=464748

Review URL: https://codereview.chromium.org/989283002

Cr-Commit-Position: refs/heads/master@{#319684}

This makes it easier to run verification within bpf_dsl_unittests too,
though it also exposes that FakeTrapRegistry was being sloppy by not
reusing trap IDs when a trap handler is assigned a second time.

BUG=449357

Review URL: https://codereview.chromium.org/935743003

Cr-Commit-Position: refs/heads/master@{#319683}

Add a dbus implementation for the wifi ap manager. ap_manager is a
ChromeOS service that manages the hostapd instance; this is a dbus
binding that the ChromeOS service.

BUG=463194

Review URL: https://codereview.chromium.org/980973003

Cr-Commit-Position: refs/heads/master@{#319682}

When user saves an image, add headers requesting a pass through
from the data reduction proxy. Without this, images will be
saved in webp format which is not supported by most image viewers.
BUG=464436

Review URL: https://codereview.chromium.org/988453002

Cr-Commit-Position: refs/heads/master@{#319681}

Introduce struct AlternativeService and use it in
BrokenAlternateProtol{List,Map} instead of BrokenAlternateProtocolEntry.  This
is the first step towards making an alternative service broken not with respect
to an origin, but by itself.

BUG=392576

Review URL: https://codereview.chromium.org/987813002

Cr-Commit-Position: refs/heads/master@{#319680}

The typedefs in native_web_contents_modal_dialog.h are no longer needed
after http://crrev.com/866263008.
This change removes them, as discussed in that CL.

Review URL: https://codereview.chromium.org/985133002

Cr-Commit-Position: refs/heads/master@{#319679}

Right now, there's a chance that the NSMenu can outlive the underlying menu
model (which is owned by the view controller). Make sure we reset the context
menu before destruction and before creating a new menu to correct this.

BUG=462175

Review URL: https://codereview.chromium.org/967883006

Cr-Commit-Position: refs/heads/master@{#319678}

Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". (patchset #4 id:60001 of https://codereview.chromium.org/988863002/)

Reason for revert:
This seems to be causing FallbackIconUrlParserTest unit_tests to fail, see, for example,
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/7625
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/7297
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/39924
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10797

Original issue's description:
> [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#".
>
> Design: go/chrome-fallback-icons
>
> Fallback icon "explicit flow" URL used to have '#' in hex colors, e.g.:
>
> chrome://fallback-icon/,#01f,#123456,,/http://www.google.com
>
> Problem: "#" denotes fragment in URLs, so we get rid of it. This causes no ambiguity
> with named color (e.g., "red") because no named color consists of letters a-f only.
> Also adding "ARGB" hex color since this is supported in Skia color parsing.
>
> BUG=455063
>
> Committed: https://crrev.com/8fa91aabefbe9784eca0c169bc2ad2dd92f5d887
> Cr-Commit-Position: refs/heads/master@{#319630}

TBR=jhawkins@chromium.org,huangs@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455063

Review URL: https://codereview.chromium.org/989133003

Cr-Commit-Position: refs/heads/master@{#319677}

There's no need for AutofillPopUpButton here. None of its functionality
is used.

BUG=448572

Review URL: https://codereview.chromium.org/987503002

Cr-Commit-Position: refs/heads/master@{#319676}

Rename initWithWebContents -> initWithBridge and remove |webContents_|
because it is never used.

BUG=448572

Review URL: https://codereview.chromium.org/983833004

Cr-Commit-Position: refs/heads/master@{#319675}

Pass a pointer instead, as per the style guide. Also makes the
constructor explicit (all callsites already are explicit).

BUG=464816
TBR=blundell@chromium.org,agl,dmichael,garykac

Review URL: https://codereview.chromium.org/982413002

Cr-Commit-Position: refs/heads/master@{#319674}

Same as previous unplug fix, but for the libevdev/gestures path. This
applies to hybrid keyboards with attached mouse/touchpad.

The SYN_DROPPED part is N/A because that is handled by libevdev.

BUG=463002
TEST=Tested unplug by unplugging devices with shift held.
  Shift gets properly released rather than being stuck.
  (NB: Could not reproduce without adding a delay to expose the race).

Review URL: https://codereview.chromium.org/990483002

Cr-Commit-Position: refs/heads/master@{#319673}

Update logic for disabling keyboards on X11 when Maximize Mode is activated.

TEST=Manual testing on device
BUG=chrome-os-partner:37106

Review URL: https://codereview.chromium.org/991933002

Cr-Commit-Position: refs/heads/master@{#319672}

The name help_outline is what the icon library calls it.

BUG=464640
TBR=dfalcantara@chromium.org

Review URL: https://codereview.chromium.org/994683002

Cr-Commit-Position: refs/heads/master@{#319671}

Checking whether credit card scanning is possible can be an expensive
operation. The result of this call is unlikely to change during the
lifetime of a browser process. This patch will query credit card
scanning feature once when the user types in a credit card input field
for the first time. Restarting the browser process is necessary to clear
the cache.

BUG=461944

Review URL: https://codereview.chromium.org/990463002

Cr-Commit-Position: refs/heads/master@{#319670}

Policy extensions weren't installed by the user, and frequently cannot be
uninstalled. Similar to component extensions, we shouldn't synthesize actions
for these extensions.

BUG=463939

Review URL: https://codereview.chromium.org/977943002

Cr-Commit-Position: refs/heads/master@{#319669}

BUG=https://code.google.com/p/chromedriver/issues/detail?id=984

Review URL: https://codereview.chromium.org/883083002

Cr-Commit-Position: refs/heads/master@{#319668}

Before this patch in order to run single test one needs to create
xml file with credentials for every site which can be tested.
This patch fixes this issue.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/994573002

Cr-Commit-Position: refs/heads/master@{#319667}

I think, when explicitly declaring a dependency on a target
(like gn_all does on build_utf8_validator_tables), if the target
is unconditionally only built in the host toolset, the dependency
needs to also say that; my initial version of the dependency did
not do that, leading gyp_chromium to fail in obscure ways.

R=thakis@chromium.org
BUG=465198

Review URL: https://codereview.chromium.org/990093002

Cr-Commit-Position: refs/heads/master@{#319666}

Initial attempt found here: https://codereview.chromium.org/983933002/

This is going to be used by https://codereview.chromium.org/975943002/

TEST=LayerOwnerTest.RecreateRootLayerWithNullCompositor
TEST=LayerOwnerTestWithCompositor.RecreateRootLayerWithCompositor

BUG=337596

Review URL: https://codereview.chromium.org/987043004

Cr-Commit-Position: refs/heads/master@{#319665}

This patch should not change any behaviour. It introduces a new version
of onReceviedError that will be called for all resources and provides
more information about the failed request.

BUG=456782

Review URL: https://codereview.chromium.org/992593003

Cr-Commit-Position: refs/heads/master@{#319664}

The operator& is dangerous and makes it unclear what you are doing.
Replace it with a get_pointer() method.

R=Nico
TBR=garykac@chromium.org
BUG=464816

Committed: https://crrev.com/845755856c54aabac7022ee373618468b92f2e61
Cr-Commit-Position: refs/heads/master@{#319565}

Review URL: https://codereview.chromium.org/986563003

Cr-Commit-Position: refs/heads/master@{#319663}

BUG=260022,350202

Review URL: https://codereview.chromium.org/914363003

Cr-Commit-Position: refs/heads/master@{#319662}

Make the chrome://extensions page use chrome.developerPrivate API for
extension error-related functionality.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

Additionally, fix a bug in extensions.js where calling "showOverlay" on an
already-visible hid the overlay (temporarily).

BUG=461039

Review URL: https://codereview.chromium.org/973303002

Cr-Commit-Position: refs/heads/master@{#319661}

Most problems are because of wrong collation or not reading the style guide, so
pointing people to those.

BUG=

Review URL: https://codereview.chromium.org/989533002

Cr-Commit-Position: refs/heads/master@{#319660}