- 27 Feb, 2019 40 commits
-
-
Ella Ge authored
TBR: jorgelo@chromium.org Bug: 936576 Change-Id: I83cada3c08e3cf1ba46d915d090071670f7de4bb Reviewed-on: https://chromium-review.googlesource.com/c/1492427Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636173}
-
sczs authored
Some of the trailingButton related code wasn't being used. This CL removes that and updates the comments to be more specific to the trailing button. Bug: N/A Change-Id: I1d07dd57647f6020d76a134afb8a753174cb2eef Reviewed-on: https://chromium-review.googlesource.com/c/1489425 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636172}
-
Brian White authored
Bug: 932525 Change-Id: Idd0a434ec165ec9de5f4b4f4b4578fea6d1f797c Reviewed-on: https://chromium-review.googlesource.com/c/1482565 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#636171}
-
Matt Wolenetz authored
Overflowing size_t buffer indexer could allow OOB unless overflow is caught. BUG=933743 Change-Id: I0c83be7571b3ad386c165189d48fb0b80745f687 Reviewed-on: https://chromium-review.googlesource.com/c/1490832Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636170}
-
Meilin Wang authored
Implement Assistant Key remapping like other neighbors and add a feature flag to guard this new feature. Bug: 784857 Test: local compile and manually test. Change-Id: I595b836084d5af558edd5077350faff96c61db59 Reviewed-on: https://chromium-review.googlesource.com/c/1471299 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636169}
-
Tien Mai authored
Bug: 936459 Change-Id: I5e0b944240b059b151ec26a8fb29aa47f920471d Reviewed-on: https://chromium-review.googlesource.com/c/1492355Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636168}
-
Paul Jensen authored
This requires two small changes: 1. Specify the BUILDTYPE to adb_install_apk.py, rather than try and point it at the APK file in the out directory. 2. Install the test instrumentation APK. CronetTest.apk no longer exists. Change-Id: Ib29e4fd3e242873ebf9a21b8f7eb12bff9e79a51 Reviewed-on: https://chromium-review.googlesource.com/c/1492358 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#636167}
-
Paul Jensen authored
Android's system HTTP stack exception messages changed slightly in Android P, so update our tests that run against the system HTTP stack to match. Bug: 931800 Bug: 931803 Change-Id: I21a3a5b9024be26fbe804cdd278533b1315fb54d Reviewed-on: https://chromium-review.googlesource.com/c/1492366 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
How to test: out/Release/chrome --trace-config-file=perfetto_test_config.cfg --perfetto-output-file=perfetto_dump.log With a perfetto_test_config.cfg like this: { "trace_config": {"included_categories": ["blink.console", "blink"], "record_mode": "record-as-much-as-possible"}, "startup_duration": 30 } TBR=oysteine@google.com (TBR'd to avoid +1 from both @chromium.org and @google.com) BUG=925142 Change-Id: I2fbe57ddc75cb98bae5ca17c5e907fe249e1a216 Reviewed-on: https://chromium-review.googlesource.com/c/1161541Reviewed-by:oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#636165}
-
Nicholas Hollingum authored
New icons include: - Shutting down the vm from the terminal's context menu - Switching to {low,high}-density mode for a crostini apps The icons were created by sgabriel@ and converted to .icon format using a skiafy tool (http://evanstade.github.io/skiafy/). Bug: 930858 Change-Id: I9b4b952c810685f5e067a63c9749ad853cc849f3 Reviewed-on: https://chromium-review.googlesource.com/c/1490358Reviewed-by:Evan Stade <estade@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#636164}
-
Brad Hall authored
This pulls down the current dsymutil package and places it in src/tools/clang Bug: 930147 Change-Id: If75bd86e02f724de95bdc2f658ea2b1df1c0d76c Reviewed-on: https://chromium-review.googlesource.com/c/1492298 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636163}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 354873`. Requires a small workaround for https://crbug.com/936418 in crashpad. Change-Id: I546f0b71c479cae5418eb16b0fb2548d6f315c7f Bug: 929680 Reviewed-on: https://chromium-review.googlesource.com/c/1490840Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636162}
-
Tanmoy Mollik authored
Bug: 929799 Change-Id: Ie3e0c49798ead8863a5bf6f9334ede58484890b8 Reviewed-on: https://chromium-review.googlesource.com/c/1484295 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#636161}
-
Marc Treib authored
It was used for the ClearServerData flow which has been removed. Bug: 490836 Change-Id: I7c2dc3b175db6f54a726ca13997678ec46bcc87a Reviewed-on: https://chromium-review.googlesource.com/c/1481321 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636160}
-
Marc Treib authored
It was identical to GetForProfile; all call sites are migrated to that. While we're here, also rename HasProfileSyncService to HasSyncService. Bug: 924508 Change-Id: I71a83b3f921cd5cb7a1ae656dd3d710f9569f08c Reviewed-on: https://chromium-review.googlesource.com/c/1483078 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
These follow the pattern of the other functions in gtest_mac; I will need them shortly for testing the new accessibility API bindings. This change also cleans up the GTestMac suite, removing needless use of autorelease pools and merging cases into ones with more descriptive names. NOPRESUBMIT=true Bug: 386671 Change-Id: Ic0471148e0095f536906210a14f1927e6435a89d Reviewed-on: https://chromium-review.googlesource.com/c/1488714 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636158}
-
Andrew Luo authored
The filters specified on the command line are now merged with the expected failures in the expected_failure_on_bot.json and exclusion filters in webview_cts_gcs_path.json. The merging logic uses test_filter.InitializeFilterFromArgs. Bug: 925321 Test: run_cts.py --test-launcher-filter-file=<filter file> --skip-expected-failures Change-Id: I2d58709990aec94f651e860fa1c54a26ac59f8f1 Reviewed-on: https://chromium-review.googlesource.com/c/1486681 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636157}
-
Wei-Yin Chen (陳威尹) authored
When using two-stage thumbnail fetching with THUMBNAIL_PROVIDER and THUMBNAIL_KEY, we populate the Java side cache with thumbnails from all the tabs, and then consume them when scrolling the recycler view. This causes a few issues. 1) Instead of reading what's visible first, it reads all the tabs, causing more delay and wasting power. 2) If the number of tabs exceeds the cache capacity, some of them would be evicted, and missing from the UI. This CL replaces THUMBNAIL_PROVIDER and THUMBNAIL_KEY with THUMBNAIL_FETCHER, and removes the Java side cache. THUMBNAIL_FETCHER fetches the thumbnail on demand when it is about to be visible. Bug: 930929 Change-Id: I5ef2e3c87db99240bed76419fb8149ec4212cf6a Reviewed-on: https://chromium-review.googlesource.com/c/1490440 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636156}
-
Andrey Kosyakov authored
We have a race between requestIntercepted arriving from browser and other resource events arriving from renderer. We don't really care about the order these events arrive, so just sort everything before dumping. Bug: 933880 Change-Id: If1bcae28d8c6d4bbe5cf38a89ae389397230a77f Reviewed-on: https://chromium-review.googlesource.com/c/1492487 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#636155}
-
James Lissiak authored
Accessibility testing of the Performance Monitor tool revealed several issues which are addressed in this patch: - Keyboard A11y: The graph toggling UI could not be navigated or manipulated via the keyboard. This restricts keyboard-only users from interacting correctly with the tool. - The fix was to allow users to navigate through the list of MetricIndicators in the left panel using the Tab key. Also adding a keypress event listener to allow toggling each of the MetricIndicators with either the 'Enter' or 'Space' keys. - Color A11y: The UI relied solely on color differences to identify each graph. This prevents users with reduced color perception from easily using the tool. - The fix was to add a text label to each graph and improve the contrast ratio of the fill color. - Screen Reader A11y: There was no screen reader accessible information in the perf monitor tool. This prevents visually impared users from using the tool. - The fix was to add announceable text to the buttons and a description to the graph (A future improvement would be to also announce the graph values in realtime as the data comes in) Screenshot of changes for comparison: https://imgur.com/a/nUNInsl Change-Id: Iaf8d2b5bf54f91b776372ae9d4c5e182d1bd6721 Reviewed-on: https://chromium-review.googlesource.com/c/1488051 Commit-Queue: James Lissiak <jalissia@microsoft.com> Reviewed-by:Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#636154}
-
Ayman Almadhoun authored
This change introduces a new UI component (toolbar) that will be displayed in the BottomTabGridSheet. Bug: 934910 Change-Id: I64294b14dff6366a80025b69d5daccb55732ff8e Reviewed-on: https://chromium-review.googlesource.com/c/1490057Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48e7065ac6a3..2c7964832eac git log 48e7065ac6a3..2c7964832eac --date=short --no-merges --format='%ad %ae %s' 2019-02-27 srte@webrtc.org Remove rtc::TimeMillis() call from ALR detector. 2019-02-27 mbonadei@webrtc.org Rolling third_party/winsdk_samples_v71. 2019-02-27 kuddai@google.com Propagate base minimum delay from video jitter buffer to webrtc/api. Created with: gclient setdep -r src/third_party/webrtc@2c7964832eac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I394f2cf6f1bf3893a0b94a3ccab6dfe9f4490326 Reviewed-on: https://chromium-review.googlesource.com/c/1492010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636152}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9e7e84f53554..2f1dad229d8b git log 9e7e84f53554..2f1dad229d8b --date=short --no-merges --format='%ad %ae %s' 2019-02-27 stimim@google.com Octopus: stop signing ToT factory install shim 2019-02-27 stimim@google.com Sarien: sign factory install shim 2019-02-27 nednguyen@google.com cros deploy: simplify _GetPackagesPaths implementation Created with: gclient setdep -r src/third_party/chromite@2f1dad229d8b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I1ac72be108cc9ef8eb36eea52fda432c2a194140 Reviewed-on: https://chromium-review.googlesource.com/c/1492551Reviewed-by:
-
Tien Mai authored
The flakiness was caused by the killing of the GLS process when a user deselects a running GCPW credential. The process in the background was still running and then process the kill by trying to report an error but at this point the provider and/or credential is no longer alive. Also fixes a crash in GCPW when the user is in the middle of a sign in using GLS but LogonUI goes to screen saver mode and kills the GLS. Bug: 936518 Change-Id: I7e2a06bf42ec0454b19460b2c5b150612c67be11 Reviewed-on: https://chromium-review.googlesource.com/c/1492356 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#636150}
-
manuk authored
This CL adds a chrome://flags flag for crrev.com/c/1475746. Bug: 931836 Change-Id: Idfadc33d618c0c57d2f22121b87bde1fa5126ec9 Reviewed-on: https://chromium-review.googlesource.com/c/1487695 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636149}
-
Chris Harrelson authored
This reverts commit 0d564c1d. It is a re-land of the original patch, with a fix to support the AA quad rendering path in GLRenderer. Bug: 936087 Change-Id: I1e7d19051d891a20f902704bebf78ca45145751f Reviewed-on: https://chromium-review.googlesource.com/c/1489899 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#636148}
-
Steven Bennetts authored
Conditionally initializing DBus is fragile. This moves the DBus initialization from ChromeFeatureListCreator (which has no clear relationship to DBus) to ChromeMainDelegate::PostEarlyInitialization. If this change appears to cause failures, please feel free to revert. Bug: 647367 Change-Id: I3d6fb0fee08d33f0a04836d1ca09dd25dbe8cfa2 Reviewed-on: https://chromium-review.googlesource.com/c/1489631Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636147}
-
Charlie Harrison authored
Bug: 934080 Change-Id: I1e7b49892b14b77185730ff4cf8d7bd7b2ac3020 Reviewed-on: https://chromium-review.googlesource.com/c/1480715 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Avery Musbach authored
I am implementing the "Divider snapping" animation specified here: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#project-resizing Notice that the window bounds update continuously with the snap animation. That is what makes it so much more complicated to implement than the "Divider selection" part and the "Divider deselection" part. Test: ash_unittests SplitViewOverviewSessionTest.SplitViewOverviewBothActiveTest Test: ash_unittests SplitViewOverviewSessionTest.DragDividerToExitTest Test: ash_unittests SplitViewOverviewSessionTest.SnappedWindowBoundsTest Test: ash_unittests SplitViewOverviewSessionTest.OverviewHasMinimumBoundsWhenDividerDragged Test: ash_unittests SplitViewControllerTest.SplitDividerWindowBounds Test: ash_unittests SplitViewControllerTest.InternalDisplayConfigurationChange* Test: ash_unittests SplitViewControllerTest.SwapWindows Test: ash_unittests SplitViewControllerTest.DoubleTapDivider Test: ash_unittests SplitViewControllerTest.DragAndDouble*Divider Test: ash_unittests SplitViewControllerTest.SnapWindowDuringDividerSnapAnimation Test: ash_unittests SplitViewControllerTest.StartDraggingDividerDuringSnapAnimation Test: ash_unittests SplitViewControllerTest.DividerPositionOnResizingSnappedWindowWithMinimumSizeTest Test: ash_unittests SplitViewControllerTest.EndSplitViewDuringDividerSnapAnimation Bug: 884930 Change-Id: I2494998606a340d75a87bf96fb5f83d38c751bb3 Reviewed-on: https://chromium-review.googlesource.com/c/1480869Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#636145}
-
manuk authored
This CL adds a chrome://flags flag for crrev.com/c/1478030. Bug: 931836 Change-Id: Id618d29f3c4a4720b6b540249f5d4f3a8bc85947 Reviewed-on: https://chromium-review.googlesource.com/c/1487183Reviewed-by:
-
Ryo Hashimoto authored
BUG=925769 TEST=Open google.com with a custom tab and see it's mobile version Change-Id: I748e9077efbd7323b6d7f54d2e1d7ea4ef058a7c Reviewed-on: https://chromium-review.googlesource.com/c/1491164 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636143}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eabd978a..348ff0ae Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbc7dd47b8fe1bee34fffee890f20bbd36d37f92 Reviewed-on: https://chromium-review.googlesource.com/c/1492432Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636142}
-
Ella Ge authored
TBR: dgozman@chromium.org No-Try: true Bug: 936479 Change-Id: I3dcef6ec81c43749b4010ff3b8a8750330dd1712 Reviewed-on: https://chromium-review.googlesource.com/c/1492833Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/34d13313235f..67d87128fd00 git log 34d13313235f..67d87128fd00 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5edafb5ac109..928dfeed1796 (2 commits) 2019-02-27 borenet@google.com [recipes] Plumb task ID through to DM results Created with: gclient setdep -r src/third_party/skia@67d87128fd00 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I08d406de5f246ab0efe48de1d20024026411483b Reviewed-on: https://chromium-review.googlesource.com/c/1492371Reviewed-by:
-
David Black authored
This was caused by handling |DidStopLoading| multiple times. We only want to handle it one time per |contents_| instance which equates to a single time per handled Web UI deep link. Bug: b:126381597 Change-Id: I7cdce45db3ee584959ccc4210431254a7007a698 Reviewed-on: https://chromium-review.googlesource.com/c/1492354Reviewed-by:
-
David Black authored
Per UX requirements, in-Assistant notifications should be animated in and out smoothly. Demo: https://drive.google.com/open?id=1KPaOCen6pmHFV8_SRV1w5hqYNDBN2xsJ Bug: b:118654460 Change-Id: Ie02827f8a0d864cd2f652b668b9880bcd51246df Reviewed-on: https://chromium-review.googlesource.com/c/1483708 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Jacques Newman authored
Added unit test. Bug: 844149 Change-Id: I8933d1e228057f9ad883ed5823f4de3b6cc64507 Reviewed-on: https://chromium-review.googlesource.com/c/1488572 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636137}
-
Céline O'Neil authored
This CL adds a seed corpus to the CompositorFrame fuzzer. It can be defined in protobuf text format (.asciipb) and is automatically encoded to binary for use with the binary proto fuzzer. Defining a seed corpus is useful if there are known good and interesting starting points for the fuzzer, and is recommended by Chromium's fuzzing guide: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/efficient_fuzzer.md#Seed-Corpus As the CompositorFrame fuzzer increases in complexity, it will take an increasingly long time for libfuzzer to stumble upon interesting inputs, which will at the very least slow down local testing of new additions to the fuzzer. Adding a GN target to automatically encode the seed corpus protobuf messages allows us to take advantage of the faster binary proto fuzzing (as opposed to text proto fuzzing), but keeps it easy for a human to define and understand test cases. It also keeps us from having to check in hard-to-decipher binary test files to the Chromium repository. The GN target and Python script for the conversion were based off of similar automation in //src/chrome/browser/resources/safe_browsing/. Bug: 923088 Change-Id: If07887d6711b06e0682dc6e9c4a56d72ecb89b2a Reviewed-on: https://chromium-review.googlesource.com/c/1480868 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636136}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating CameraState into @IntDef using rules similar to other @IntDef inside Chromium project: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface BUG=919666 Change-Id: Ia61774a94dabc6acf7f9615f6fe083f2e5dc1bdf Reviewed-on: https://chromium-review.googlesource.com/c/1487813 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636135}
-
Sigurdur Asgeirsson authored
Bug: 936456 Change-Id: I31c53d888666aa5cf0e7787c12e24486e61834da Reviewed-on: https://chromium-review.googlesource.com/c/1492033 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636134}
-
