- 28 Sep, 2020 40 commits
-
-
Michael Hansen authored
This is a follow-up from the Nearby Connections uprev to add the |enable_bluetooth_listening| advertising option which allows listening on incoming Bluetooth Classic connections. Bug: 1131986 Change-Id: I76c5ee5583264e0e65afdc6f48db4455922f5c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432197 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811405}
-
Alan Cutter authored
AccountManagerUIHandlerTest tests were disabled in https://bugs.chromium.org/p/chromium/issues/detail?id=1131834 due to flakiness with ExternalWebAppManager. This is due to https://chromium-review.googlesource.com/c/chromium/src/+/2423823 altering the behaviour of when chromeos::ProfileHelper::IsPrimaryProfile() gets called uncovering an incompatiblity between the profile created by these tests and IsPrimaryProfile(). This CL disables ExternalWebAppManager's start up flow to avoid triggering the IsPrimaryProfile() incompatibility so we can re-enable these tests. Bug: 1131834 Change-Id: Ia4d15785a64b45689f742d3604c10e1b8502cafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#811404}
-
Xiaohui Chen authored
Bug: b:169578241 Test: manually Change-Id: Ia9ae5b9a71838c160ca81c73842c59b71db16270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436583Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#811403}
-
Austin Eng authored
Adds Dawn's tests to Linux FYI Experimental Release (NVIDIA) Bug: chromium:1016948, dawn:200 Change-Id: I69f3c9d7c4eb4e54e7ae2c5d8738547b4784d17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424036 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811402}
-
Sebastien Marchand authored
There's 2 issues with histogram_paths.py on Windows: - Some path have different casing on Win vs Linux, see crbug.com/1132974 . This is not the right way to fix this but this allows running histogram_paths.py on Windows. - Normalizing the path separators after sorting them causes some sorting differences (this causes "tools/metrics/histograms/histograms_xml/renderer4/histograms.xml" to appear before "tools/metrics/histograms/histograms_xml/renderer/histograms.xml" on Windows. Bug: 1132974 Change-Id: Id6953f29f2073551df9a13cc2c72d2e6eef33cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436293Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811401}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/views/extensions This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I5300e111b30d94c6571f090128a32ad638f0f2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435980 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811400}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..09a013c1993f704e $ git log ba9d95e4328b..09a013c1993f704e --date=short --no-merges --format='%ad %ae %s' 2020-09-28 wub Change quic_toy_client.cc to include the correct header file for AF_INET/AF_INET6/AF_UNSPEC on windows. 2020-09-28 bnc Add code count for quic_fix_http3_goaway_stream_id. 2020-09-28 fayang Dropping initial keys at the end of writing to avoid potential missing write keys in the middle of writing. 2020-09-28 bnc Do not clip error codes larger than QUIC_LAST_ERROR. 2020-09-28 quiche-dev Fix //third_party/quic/core:quic_connection_test with randomized flags 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. 2020-09-25 quiche-dev Fix a latent query-of-death Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: I4e66876896183a09d1c33fc3d2f0768bbe71f619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435748 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Auto-Submit: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811399}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ac564dd6553..29d2aa6ec8cc 2020-09-28 vidorteg@microsoft.com Changing tone on a settings screen string. 2020-09-28 alexrudenko@chromium.org Refactor highlight and grid tools 2020-09-28 chrche@microsoft.com [Loc] Dont localize "top" and "iframe" when used as Javascript context 2020-09-28 wolfi@chromium.org Fix bug where FrameTreeNode is selected despite clicking elsewhere If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131801,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e38b38baf620297992dad1597d99d46c474952e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811398}
-
Brandon Walderman authored
The --no-service-autorun command line switch prevents service processes from registering for autorun. This change updates ChromeDriver to use this flag for desktop sessions. Service processes are tied to the same user data directory as the browser process that launched them. If a service process is created during a ChromeDriver session, it will use the temporary user data directory that ChromeDriver created. This directory is deleted at the end of the ChromeDriver session so it will be meaningless after a machine reboot. The --no-service-autorun switch ensures that we don't try to launch a service process with a previously deleted user data directory on startup. This issue was first found in Microsoft Edge. A notification service is created and added to autorun by default when Edge starts for the first time in a new profile. A downstream fixed has been checked in to disable this service when --enable-automation is passed on the command line. However, --no-service-autorun is still a good idea for ChromeDriver since any potential service processes that are created during a ChromeDriver session should not create OS artifacts such as autorun entries that persist beyond the ChromeDriver session. Bug: 1132969 Change-Id: I12c501b9e6c9ff8887f28fdd6f3144b113218e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436773Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811397}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/views This CL was uploaded by git cl split. R=pbos@chromium.org Change-Id: Ifd8b52796b8a642ac5fbcf8b4c069f0eac730437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435804 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811396}
-
Khushal authored
This reverts commit 2dc7fd65. Reason for revert: Merged to 86. Was temporary to support merge of a safer fix. Original change's description: > media: Ensure sync token synchronization for VideoFrame images. > > Instead of relying on the sync token returned by > AcceleratedStaticBitmapImage to ensure synchronization with the raster > stream used by skia, perform this when the mailbox is returned. This is > temporary to allow merging a safer change to 86 release branch. > > R=dalecurtis@chromium.org > > Bug: 1131123 > Change-Id: I639a0d864fae29ddb32182aeda5ba2e854b1f5ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433049 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810936} TBR=dalecurtis@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1131123 Change-Id: Ia49977cb40ab9caea536d7c3dfeab4a97181874a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435782Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811395}
-
Evan Stade authored
This reverts commit f56db26f. Reason for revert: breakage was already fixed in 1df2fd67 Original change's description: > Revert "Adjust aggregate_vector_icons GN template." > > This reverts commit 6197ec27. > > Reason for revert: Broke chromeos-betty-pi-arc-cfi-thin-lto-chrome > > BUG=1133015 > > Original change's description: > > Adjust aggregate_vector_icons GN template. > > > > Change the name of the icon list from `icons` to `sources`. This makes > > gn format alphabetize the list. > > > > Bug: 1132894 > > Change-Id: I8dfe07d74fa2ddfd32ef8bec8729923e999a640e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427135 > > Commit-Queue: Evan Stade <estade@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811364} > > TBR=sky@chromium.org,estade@chromium.org > > Change-Id: I69cd779577af70125c23f4b6085d62d97ec231fc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1132894 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436394 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811389} TBR=sky@chromium.org,estade@chromium.org,afakhry@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1133015 Bug: 1132894 Change-Id: I73199d77ecb5dd156ef89a40dcc26581841b12cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436892Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#811394}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: Ie60214eede9dc3d7f332d01918ffc9a618ec09b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431413 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811393}
-
Kevin McNee authored
The expression already has the specified type. Bug: None Change-Id: I49ac50699182978380f964959957ea1001046b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435920 Commit-Queue: ssid <ssid@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#811392}
-
Chong Gu authored
Bug: 1131989 Change-Id: I9b84112d9d3552a744010f4008a3d9b7d21b4fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429446Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#811391}
-
Peter Wen authored
Previously, android_library_factory assumed that parameters would have no bounded type parameters. This CL adds code to generate those bounded type parameters for public method arguments in *Factory.java files. Example: Previously method(Callback<Context> a) would become method(Callback a) in the generated *Factory.java file. Now the <Context> type parameter is preserved in the generated *Factory.java file. Add missing dep for //components/browser_ui/android/bottomsheet:factory_java and //chrome/browser/video_tutorials:factory_java since previously these imports were elided due to the type parameter being omitted. Bug: 1131954 Change-Id: Ic5303cfaae5e3e89eddc00f9bcfef919ebb3d7dc Fixed: 1131954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428734 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811390}
-
Ahmed Fakhry authored
This reverts commit 6197ec27. Reason for revert: Broke chromeos-betty-pi-arc-cfi-thin-lto-chrome BUG=1133015 Original change's description: > Adjust aggregate_vector_icons GN template. > > Change the name of the icon list from `icons` to `sources`. This makes > gn format alphabetize the list. > > Bug: 1132894 > Change-Id: I8dfe07d74fa2ddfd32ef8bec8729923e999a640e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427135 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811364} TBR=sky@chromium.org,estade@chromium.org Change-Id: I69cd779577af70125c23f4b6085d62d97ec231fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436394Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811389}
-
John Abd-El-Malek authored
This is a reland of 1b36f1a7. The fix is to not use a video that requires proprietary codecs. Original change's description: > Add autoplay parameter to navigations. > > Bug: 1131881 > Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810932} Bug: 1131881 Change-Id: I4d791880960a0b1ad3dbaf88ece39c4f1b6c8f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435838 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811388}
-
Joanmarie Diggs authored
If AXPosition::AsValidDOMPosition is called with kMoveLeft on an inline text box created from generated content, and that text box immediately follows an input with visibility:hidden, an infinite loop can occur: In the case of generated content, AsValidDOMPosition will attempt to create a previous position based on the previous object (i.e. the hidden input, which lacks accessible children). In order to not skip over intervening text in the case of native text controls, CreatePreviousPosition returns a position immediately after that control (i.e. the generated content). In order to prevent this infinite loop, check the resulting AXPosition before calling AsValidDOMPosition on it. If the position hasn't changed after we've tried to convert a generated-content position into a DOM position, return an empty AXPosition. AX-Relnotes: Prevents a page crash when accessibility is enabled. Bug: 1131019 Change-Id: I4d7899bb598ce03a679b553aafb509ef2028ac05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426490 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811387}
-
Hiroki Nakagawa authored
This is a follow-up CL for https://crrev.com/c/2413830. After the CL, mojom::PrerenderHandleClient was the client of mojom::PrerenderProcessor so that should have been renamed to mojom::PrerenderProcessorClient. Bug: 1132746 Change-Id: Ia55cbf2f0e248baf3f172caeccbd29be18f3f614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434071Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811386}
-
Taylor Brandstetter authored
Change-Id: I802ac8a08a2e97e4cfac121108fc98611cb3bd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430289Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#811385}
-
Miguel Casas authored
ChromeOS AMD devices seem to have troubles scanning out high-bit depth framebuffers; this CL disables creating such DisplayColorSpaces on said platforms while we fix that. (FTR there're no HDR-capable panels on AMD Chromebooks, but users can connect an external HDR screen, hitting this path.) Bug: b/169576243, b/165825264 Change-Id: I7e451d9817fee34d01c7d1ef943ef43fb1dce4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435925Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#811384}
-
Alexander Alekseev authored
This reverts commit c1744bc0. Reason for revert: Broke build: https://crbug.com/1132766 Original change's description: > exo: Move XkbTracker from WaylandKeyboardDelegate to Seat. > > This is preparation to share XkbTracker with wayland IME server. > > BUG=1123705 > TEST=Built locally. Run exo_unittests. > > Change-Id: I7859c2193578cc5a18fa39a96c3fe86d2f39f4dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428505 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810863} TBR=mukai@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123705,1132766 Change-Id: I92c8df6383ea569ca2b88780c6017c619e26d1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434097 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#811383}
-
Haiyang Pan authored
This reverts commit f6120650. Reason for revert: webview and weblayer test suites have a bad time today and causes the pending time spiking for Pie. Will reland this CL once the issue is resolved. Original change's description: > luci: Increase CQ experimental percentage to 80 from 60 for pie-arm64-rel > > After the test suites adjustment in crrev.com/c/2427028, the device > usage looks in a good shape and should be able to hold more traffc: > http://shortn/_E2uBVeObl6 > > Bug: 1111436 > Change-Id: I9bfb44a96feb2bc2d49ec8335afc73324711db5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429931 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811298} TBR=estaab@chromium.org,bpastene@chromium.org,hypan@google.com Change-Id: I16bc0c24eaab0e2067c3554a9b3476d8acbbe6cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437009Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811382}
-
David Bertoni authored
ExtensionManagementApiTest.Uninstall was disabled for flakiness many years ago. It is no longer flaky. Bug: 174411 Change-Id: I5f1bc2ff2d52edaf1f347856133446600c3336e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432405Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811381}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77397c4f2930..9a49d4b5de90 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I2b48099041c2e08aa8c72383d9acd09ed0fcfe6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811380}
-
Ben Kelly authored
Cache.addAll() must wait for the all requests to succeed before starting to store the results in CacheStorage. Previously this was done by waiting for all the Response objects to become available and only then would it begin loading the bodies into blobs. This does not work with throttling since throttling requires bodies to be loaded in order to make progress. The main change in this CL is to refactor things so we now immediately load the body to a blob when a Response becomes available. We then wait for all Responses and their bodies before proceeding to store the result. This should not use too much memory since loading a Response to a blob streams data to the BlobRegistry, which may then subsequently stream to disk if necessary. One notable change here is that code cache generation now requires loading the body into an ArrayBuffer from a blob. Previously we loaded the response to the ArrayBuffer and then converted that into a blob. This will be slightly slower for putting scripts in CacheStorage, but that should be fine since generally we do not optimize for write performance. Other changes in this CL: * Adds a cache.addAll() test for the throttled service worker case. * Adds `cache:no-store` to the existing throttled service worker test since that more easily triggers true throttling behavior. This in turn also required draining the response bodies in the test. * Refactored cache add(), addAll(), and put() to all go through the same set of objects where appropriate. * FetchHandler is used in add/addAll to wait for each individual fetch() to complete. * ResponseBodyLoader is used in add/addAll/put to take a Response and load its body as a blob. * BarrierCallbackForPutResponse waits for a list of Response and blob objects to become available before calling PutImpl(). * BarrierCallbackForPutComplete waits for any code cache generation and the final cache operation to complete. Bug: 1035448 Change-Id: I8c9b6b5831cfd21bd266e526a138de4cbf03171f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404267 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811379}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601294375-805284c073a4c807365387c8b737f70c270f4966.profdata to chrome-mac-master-1601315959-5577f3dbf01608bf6e215c63714e131a2bd389f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f5f34b19437a9c69086fb651f916fc77d1f5ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436231 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811378}
-
Xiyuan Xia authored
EndTest() only really exit tests when there are no pending main frames. This might be cause of flaky timeout failure. This CL changes to redraw only the needed frames so that EndTest() would not be blocked. Bug: 1127563 Change-Id: I28943ddf1bd247b1ec2cdebc98fb28d77b2f2543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426971 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#811377}
-
Geoff Lang authored
Bug: angleproject:2634 Change-Id: I1a9adc2cb13e3377dbdd2eaca9d5bd877358b063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435328Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811376}
-
Andres Calderon Jaramillo authored
This CL ensures that buffers that require a horizontal flip transform are not promoted to overlays. The reason why this is needed is that support for this transform is dependent on the buffer layout (e.g., on some devices, linear buffers with a horizontal flip transform cannot be scanned out). Unfortunately, page flip testing does not currently use real buffers, so we could end up promoting a buffer to an overlay plane incorrectly. Horizontally flipped linear buffers are used in the camera capture app. They can also be used by web pages that use getUserMedia() plus CSS. Bug: b:161758029, b:168899960 Test: launch the camera capture app on JSL Change-Id: I24df6c8e0820ce391e5699de3cb906f348df9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434911 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#811375}
-
Evan Stade authored
TBR: sky@chromium.org Bug: none Change-Id: Iea3da6ecd4ee4c982ec9ffd11e8433d2c8a706dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436910Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#811374}
-
Xiaocheng Hu authored
This patch ships the following @font-face descriptors with M87: - ascent-override - descent-override - line-gap-override Bug: 1098355 Change-Id: I5ecb8761ccdd4a6c35eef3b8326266bc756dadc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432949Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811373}
-
Maksim Moskvitin authored
Bug: 1130650 Change-Id: Icb7c11466a7b7fced2831584572c3433c50d7ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435108 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#811372}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07fb2be4. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." 6bdcd688 "[COOP] access reporting: split property.https.html test." f4c4d71a "Only reset trailing_collapsible_space_ structure if it has value" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Iff06af3aab658d5df2cfdd94b330e1285ef0bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435583Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811371}
-
Anastasia Helfinstein authored
Bug: 1126920 Change-Id: Ia8357864f15f29266432423c87351c1899725451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429518Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#811370}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I5ae49205600b870897481f8fadd99f8143c45bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430328 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811369}
-
Evan Stade authored
Also make ChromeTranslateClient return const& instead of &. Non-const refs are forbidden by the style guide. Bug: none Change-Id: I8e49bc7bb3dacb83b124ff0a12e302805c2387ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404360 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#811368}
-
chinsenj authored
Currently with the InteractiveWindowCycleList flag enabled, if a user taps on an item it will activate that window and exit the window cycle list. It's unclear to users that this selection is being made. To address this, this CL makes it so taps move the focus ring to the tapped item rather than activating the tapped item. Test: manual + modified existing test Bug: 1067327 Change-Id: Ic35972a931d2ddf5c2afa6bb02743a25e0e9ecf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432725Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#811367}
-
James Cook authored
OS settings are being migrated from Polymer 2 to Polymer 3, so load time performance metrics are still valuable. Extend both load time metrics to June 2021. Bug: 1121211 Change-Id: I9b7b59f52edd8bb580f662a33470475e605349bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436294 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811366}
-