- 06 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d85a5094684e..6eef2ff50b8c Created with: gclient setdep -r src-internal@6eef2ff50b8c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib19729a510ea57751984507dea02724fd66fe102 Reviewed-on: https://chromium-review.googlesource.com/c/1319951Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605788}
-
Jeremy Roman authored
Bug: 856641 Change-Id: Id1f5bdff7cbf8cf6fa62adeadc2d07e819755a5c Reviewed-on: https://chromium-review.googlesource.com/c/1318687Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605787}
-
Tibor Goldschwendt authored
This fixes a bug with certain Android emulators. Bug: 899732 Change-Id: Ia30d087ea6993a5fcc08ccb62b6a23e5260f5d2d Reviewed-on: https://chromium-review.googlesource.com/c/1320022Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605786}
-
Xiyuan Xia authored
Fixed with https://chromium-review.googlesource.com/c/1281167 and no longer fails for mash. Bug: 884360 Change-Id: If5fe9b326eb2f8b73b3af900631ef3b0fb8263f8 Reviewed-on: https://chromium-review.googlesource.com/c/1320196 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605785}
-
Miguel Casas authored
This CL simplifies the resource management in CRProvider: there's no need to keep |is_single_buffered_| since it's always the opposite of |resource_recycling_enabled_|, and there's no need to keep a |single_buffer_| since there's already a vector of |canvas_resources_|, that can be limited to having only one when IsSingleBuffered(). Most of the changes are in NewOrRecycledResource(), which has to accommodate this new simpler mode (note that there are unit tests covering it). Two more side things: - Renames: s/recycled_resources_/canvas_resources_/ - A few comments are updated/corrected. Change-Id: Ib12db2fd7c2ba7eeb2f9144c49b061114c395e97 Bug: 839970 Reviewed-on: https://chromium-review.googlesource.com/c/1308043Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#605784}
-
Seth Hampson authored
This adds the P2PQuicStream::Delegate::OnDataReceived and adds tests. It also adds the concept of marking data as consumed by the application and keeping track of the application's read buffered size and amount. This ensures that the P2PQuicStream does not give the application more data than it can buffer, and if its buffer is full it will apply backpressure to the send side. Bug: 874296 Change-Id: I85f677778631a04a5eb1ccd71457485c9444824e Reviewed-on: https://chromium-review.googlesource.com/c/1316836 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605783}
-
Bernie Thompson authored
BUG=b:117489304 TEST=None Change-Id: I551877e5b4ea970bf52a68e28c9418a812bc5f3a Reviewed-on: https://chromium-review.googlesource.com/c/1320011Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/heads/master@{#605782}
-
Mario Sanchez Prada authored
Use call to IdentityManager::HasPrimaryAccount() instead of the former SigninManagerBase::IsAuthenticated(), and remove unnecessary includes. Bug: 890816 Change-Id: I7d5d0f6a078c1065984cabcc071efd3fc02ed92d Reviewed-on: https://chromium-review.googlesource.com/c/1314472Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#605781}
-
Bo Liu authored
This is not in any gn file for awhile now. Change-Id: Iffd6189ada81ea3add408309259925116f60ad50 Reviewed-on: https://chromium-review.googlesource.com/c/1320026Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605780}
-
Toni Barzic authored
Stop observing paymentPortal iframe load in MobileSetupUI - MobileSetupUI sends portal load status messages to the mobile setup webui, but webui merely ignores them. The paymentPortal load status is observed directly in webui by using webview APIs, so messages from the MobileSetupUI are not needed anymore. Change-Id: Ic757e786d4b7efbc3242544f0f9db90226fc8ffa Reviewed-on: https://chromium-review.googlesource.com/c/1318850Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#605779}
-
Andrew Grieve authored
Change motivated by JNI refactorings, which are made simpler by not having to specify this blacklist in GN. TBR=agrieve # Trivial build refactor Bug: 898261 Change-Id: Ic81e99a460f54e5c02fedfd9f8467390045ee21c Reviewed-on: https://chromium-review.googlesource.com/c/1317341 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605778}
-
Roger McFarlane authored
This CL updates the AutofillMetricsTest.AutofillFormSubmittedState to explicitly configure all of the relevant feature flags for its test scenarios, instead of depending on the default state of some feature flags. Bug: 824834 Change-Id: I28c9506fce90fc796c6db0c889d7e3f860561971 Reviewed-on: https://chromium-review.googlesource.com/c/1320217Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605777}
-
Tarun Bansal authored
In data reduction proxy, do not call GetWiFiSSID() on non-Android platforms since it may call hung IO loop. See the associated bug. Bug: 896296 Change-Id: I85ca975465505696f627e77594c27a4ddbe1838e Reviewed-on: https://chromium-review.googlesource.com/c/1319329Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#605776}
-
Alexei Filippov authored
Change-Id: I231ac01a72c90d4d6feac86ae8278590f3e494cf Reviewed-on: https://chromium-review.googlesource.com/c/1315994Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#605775}
-
Fernando Serboncini authored
TBR=fserb@chromium.org Change-Id: I0a01e263121ceea3c4ccec41fdb3efe6fceb2b32 Reviewed-on: https://chromium-review.googlesource.com/c/1320218 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605774}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ba6af1e543b..7b391c51f694 git log 6ba6af1e543b..7b391c51f694 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 nednguyen@google.com Remove legacy timeline based metrics (TBMv1) & all related code Created with: gclient setdep -r src/third_party/catapult@7b391c51f694 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I45df0db594c8195de4c7684da9386661002d6218 Reviewed-on: https://chromium-review.googlesource.com/c/1319950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605773}
-
Hans Wennborg authored
NDK r16 "helpfully" installs libc++ as libstdc++ to make the NDK's Clang use that by default. However, we use a more recent Clang, and after r346167 that starts looking for libc++, which then can't be found due to the renaming. This hacks around the problem by renaming it back. Well, it makes a copy actually, to support Clangs both before and after. We should remove all this in the future when we've moved to a newer NDK. Bug: 902270 Change-Id: Ib69be5faeb0e0b0c8b5b2588fdb66610e30de687 Reviewed-on: https://chromium-review.googlesource.com/c/1319712 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605772}
-
Leszek Swirski authored
The existing XR test workaround (crrev.com/c/1306173) checks for the existence of isInitializationComplete by attempting to access it. However, accessing an undeclared variable throws a ReferenceError -- the correct way of checking for its existence is using typeof. Bug: 894796 Change-Id: I86a5ac2ba45fea5e51c7e0f9fddc4167b8772443 Reviewed-on: https://chromium-review.googlesource.com/c/1319715Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#605771}
-
Mike Wasserman authored
Attempt to init the display device scale factor in WindowTreeHost's ctor. WindowTreeHost subclasses/users may use the cached scale before InitHost. See http://crbug.com/899084 and https://crrev.com/c/1311080 (PS7) This may incorrectly use the primary display's scale for new windows on extended displays. Still, a best effort attempt to initialize the cached value here may be worthwhile. It's unclear if this solves any practical defects similar to crbug.com/899084. Bug: None Test: Automated Change-Id: Ia776d870d8a51c5ac381b2a023c7a2a579dca97a Reviewed-on: https://chromium-review.googlesource.com/c/1318693Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605770}
-
Mitsuru Oshima authored
Bug: 901433 Test: manual. See bug for repro step Change-Id: Idd25bc0b0b0519141660b11cb7db5e67bc04122c Reviewed-on: https://chromium-review.googlesource.com/c/1319855Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605769}
-
Clark DuVall authored
Some services that run in a utility process such as the Data Decoder Service will shut themselves down cleanly if they do not have requests for a period of time. These were being treated as OOM kills previously. This uses the approach Bo outlined in http://crbug.com/872343. Bug: 872343 Change-Id: Iaf371520893076981d44429a7ec1c444b637c93d Reviewed-on: https://chromium-review.googlesource.com/c/1298024Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#605768}
-
Christian Biesinger authored
I should've removed this line in crrev.com/c/1247184 R=dgrogan@chromium.org Bug: 784059 Change-Id: Iad283f72794abce0dd46835afed1a90c77e0fc91 Reviewed-on: https://chromium-review.googlesource.com/c/1320213 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605767}
-
Seth Hampson authored
This adds the P2PQuicStream::WriteData function and adds tests. It also adds the concept of a write buffered amount, enforcing this at the P2PQuicStreamImpl. Bug: 874296 Change-Id: Id02c8aa8d5368a87bb24a2e50dab5ef94bcae131 Reviewed-on: https://chromium-review.googlesource.com/c/1315534 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605766}
-
Ahmed Fakhry authored
This CL changes the default behavior from always placing the shelf on the top-left display in the unified matrix, to placing it according to its aligment: - "left" alignment -> top-left display in the matrix. - "right" alignment -> top-right display in the matrix. - "bottom" alignment -> bottom-left display in the matrix. This CL also fixes the shelf positioning when changing the unified display zoom (the unified scale factor was not taken into consideration). BUG=897771 TEST=Modified tests. Change-Id: Idf7a364ce40340e69a1dbb8785318725ea1aa890 Reviewed-on: https://chromium-review.googlesource.com/c/1315711Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605765}
-
Becca Hughes authored
Move the MediaSessionAction enum from blink to //services. BUG=875004 Change-Id: I29a13b696b0d27facbb1fbf98a162f827d9a476e Reviewed-on: https://chromium-review.googlesource.com/c/1302694 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#605764}
-
Chris Lu authored
Replaces individual Collection's ImageDataSource. Replaces the ImageDataSource for History and Recent Tabs. Bug: 851665 Change-Id: I01329b6f0926361d85e48d310dd37c919de47d7f Reviewed-on: https://chromium-review.googlesource.com/c/1318830 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605763}
-
Nate Fischer authored
Default code path is unchanged, this only changes behavior when the network service is enabled. This changes AwURLRequestContextGetter's HTTP cache to be in-memory when the network service is enabled, to avoid creating a second HTTP cache (in addition to the NetworkContext's cache). R=jam@chromium.org Bug: 887538 Test: N/A Change-Id: I13073e68a46d6eedaca6d77cf2f96b3ea84fdecb Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1319334Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605762}
-
Juan Antonio Navarro Perez authored
Story is flaky when running as smoke test. NOTRY=true TBR=nednguyen@google.com Bug: 899887 Change-Id: I7e7a924329121c5fd5645dd8e0a92e61d7afe6a5 Reviewed-on: https://chromium-review.googlesource.com/c/1320173Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#605761}
-
Andrew Grieve authored
Ran into a bot failure where the tool didn't exist for vr tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930637010680307008/+/steps/chrome_public_test_vr_apk_on_Android_device_Nexus_5X__retry_with_patch_/0/stdout Change-Id: I815a5d591b7ef123449e545cd643948d5fa87fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1319854 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605760}
-
Luna Lu authored
Change-Id: Ib8e1aba6d56ee257664aef39aed635490f25f2e1 Reviewed-on: https://chromium-review.googlesource.com/c/1320019Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#605759}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a305a2ef715..5d3deb7301b1 git log 7a305a2ef715..5d3deb7301b1 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 fmalita@chromium.org [skottie] Preserve image aspect ratio 2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3d86e89bce7a..77b2436e28f4 (1 commits) 2018-11-06 mtklein@google.com Revert "make enum santizer fatal" 2018-11-06 reed@google.com change MakeRecAndEffects to take SkFont Created with: gclient setdep -r src/third_party/skia@5d3deb7301b1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I7fbdbbd49fc71bc437e93c2339aa01386aae0c8b Reviewed-on: https://chromium-review.googlesource.com/c/1320151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605758}
-
Alexandre Frechette authored
Fixing logic bug in IPH triggering logic. Adding a variation for "force trigger on english" experiment as a flag to automatically trigger it. Bug: 883456 Change-Id: Ice024580601fdfe5debb862bb7cfeff956b04dbc Reviewed-on: https://chromium-review.googlesource.com/c/1318631Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#605757}
-
Mario Sanchez Prada authored
Rely on the IdentityManager's API instead of SigninManager's one, and implement identity::IdentityManager::Observer to monitor for signed-in and signed-out events. Bug: 890824, 887463 Change-Id: Ic8a7d46ba91c0824d8949475c04fa75131c5cf70 Reviewed-on: https://chromium-review.googlesource.com/c/1315213 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605756}
-
Evan Stade authored
It's flaky everywhere, not just mash. TBR=caseq@chromium.org Bug: 889878 Change-Id: Iae5bdc6625102ad5dc59707a68f1f67db2a53dcd Reviewed-on: https://chromium-review.googlesource.com/c/1318801Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605755}
-
Takuto Ikuta authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/155f802a6be3..4169b31090db $ git log 155f802a6..4169b3109 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 tikuta Fix for unused-lambda-capture warning 2018-11-05 gordana.cmiljanovic [MIPS] Add support for 64b MIPS architecture 2018-11-03 tikuta Revert "Fix for unused-lambda-capture warning" 2018-10-23 tikuta Fix for unused-lambda-capture warning Created with: roll-dep src/third_party/swiftshader Bug: 681136 Change-Id: I74a53ae11edbd50fb69c95764a7c77dc54b473c1 Reviewed-on: https://chromium-review.googlesource.com/c/1318511Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605754}
-
Seth Hampson authored
As part of the effort to add read/write to the P2PQuicTransportStream, some of the stream level tests need to be moved into their own more isolated testing environment. This includes using a MockQuicSession. This change moves the stream unit tests to this new environment, and also updates the p2p_quic_transport_test.cc to use Mock objects instead of the fake objects for the delegates. Bug: 874296 Change-Id: Ifdfd30f753a2b6090c8f73330978c5feed2b9cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1312971Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#605753}
-
Dan Sanders authored
Experiments have been uneventful for many weeks. Enable by default for M72. TimeToFirstFrame is negatively impacted by this change, as the startup IPC now hops throught the browser where before it went directly over the GPU channel. The cost is typically less than 30ms. Reconfigurations are faster because PictureBuffer allocation no longer requires any IPC. Bug: 522298 Change-Id: I40ea00150f7dadfe2319e2cdb27e3be5f29a702c Reviewed-on: https://chromium-review.googlesource.com/c/1315940 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605752}
-
Xi Cheng authored
Change-Id: I5059c4f7e1351ea62749fd381fd6fea3a812f749 Reviewed-on: https://chromium-review.googlesource.com/c/1319345Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#605751}
-
Sebastien Marchand authored
The fact that the LIVE_STATE_USING_WEB_SOCKETS reason exists might confuse some devs who could assume that using a WebSocket will protect their page, this add a comment to specify that this heuristic isn't currently used. Change-Id: Ibc6034a53c87291993dfa66094b69a2fa55aa0cf Reviewed-on: https://chromium-review.googlesource.com/c/1319771Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#605750}
-
Peng Huang authored
WebGL may use GL_RGB texture, and choose viz::RGBA_8888 as resource format. So to make WebGL work, we should not consider it an invalid combination. Bug: 901822 Change-Id: I4b6678492b2fb847d66de3fe8ec7b0049ca8eaff Reviewed-on: https://chromium-review.googlesource.com/c/1318076Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605749}
-