- 05 Oct, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b2f9583. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25868 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If543bcc74b17c59182501eb945d642aacb71cd8e Reviewed-on: https://chromium-review.googlesource.com/c/1263891 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597074}
-
Alexander Timin authored
Replacing MessageLoop with ScopedTaskEnvironment will allow us to get more accurate information about its lifetime and get rid of lazy bindings. R=jochen@chromium.org CC=gab@chromium.org,alexclarke@chromium.org BUG=892139,891670 Change-Id: I9ffc7fec4c34a87c205c4d65d6e0fb8c5e21b05e Reviewed-on: https://chromium-review.googlesource.com/c/1261816Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597073}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0a74e09b39c1..78cdde3df652 git log 0a74e09b39c1..78cdde3df652 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 kron@webrtc.org Add support for sending RTP two-byte header extensions. 2018-10-05 mbonadei@webrtc.org Don't include <memory.h> in aligned_malloc.cc. Created with: gclient setdep -r src/third_party/webrtc@78cdde3df652 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I432e0de72785e0570e96b15624b6c46f2d31f220 Reviewed-on: https://chromium-review.googlesource.com/c/1263873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597072}
-
Fredrik Söderquist authored
Rather than resolving the URL again during Task::Create, pass the KURL resolved by ImageLoader::UpdateFromElement through. Also move the resolution before the |loading_image_document_| special- case. Bug: 889183 Change-Id: I52ea65d1af96a5919e128f0623fa6bd9026850f7 Reviewed-on: https://chromium-review.googlesource.com/c/1254266Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#597071}
-
vitaliii authored
1) Add the following comment // If you change or add any fields in this file, update proto_visitors.h // and potentially proto_enum_conversions.{h, cc}. to all *_specifics.proto, which are actually mentioned in proto_visitors.h. Previously some of them were missing the comment at all and others were telling about proto_value_conversions, which actually does not need to be updated. 2) Add // If you change or add any enums in this file, update // proto_enum_conversions.{h, cc}. to sync_enums.proto, since it containts enums only. Change-Id: Ic68f5694a4a227bc20aeb84f21593b41581ae0af Reviewed-on: https://chromium-review.googlesource.com/c/1055627 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597070}
-
Eric Seckler authored
.. to make them conform to the styleguide. Also includes some minor comment edits. TBR=mbarbella@chromium.org Change-Id: I8dc5616979e9a97c8837a98ed6565cbf4b266c82 Reviewed-on: https://chromium-review.googlesource.com/c/1264204Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#597069}
-
Sergio Villar Senin authored
Early implementations of IdentityManager used to cache its internal state and update it (notifying its observers) via custom callbacks. That's no longer the case as IdentityManager acts now as a passthrough to the backing classes. There is no guarantee that the IdentityManager is going to receive the "events" before any other observer. The tests are still valid though, as they can be used to verify that we get consistent values from IdentityManager from within SigninManagerBase::Observer and OAuth2TokenService::Observer while we transition all of these observers (and the flows that start from them) incrementally to IdentityManager. Bug: 892077 Change-Id: I4bfea3f5114c5ad21444af43e6bfd119ffce65ba Reviewed-on: https://chromium-review.googlesource.com/c/1264199 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be4324e9..25a2b998 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I91e06d633087ba00fb3a9f805f78894d935f0825 Reviewed-on: https://chromium-review.googlesource.com/c/1263889Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30f82e022cc4..530c5963e910 Created with: gclient setdep -r src-internal@530c5963e910 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I04cc33a13cbfd8393b604cdeb761f7a246d76252 Reviewed-on: https://chromium-review.googlesource.com/c/1263870Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597066}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/14246813a110..0ca09753392d git log 14246813a110..0ca09753392d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oetuaho@nvidia.com Add GLES3 support for EXT_blend_func_extended Created with: gclient setdep -r src/third_party/angle@0ca09753392d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib42c47a895b8882d9035cef2b8669dc5367fd6c8 Reviewed-on: https://chromium-review.googlesource.com/c/1263872Reviewed-by:
-
Colin Blundell authored
"Signing out" always happens via SigninManager and causes the account to be removed from SigninManager as well as AccountTrackerService. However, the primary account can be removed from AccountTrackerService in circumstances *other than* the user signing out of the primary account; e.g., if the refresh token for the account is revoked from ProfileOAuth2TokenService. In these circumstances, there would still be a primary account (i.e., SigninManagerBase::GetAuthenticatedAccountId() returns a valid account ID), but there would be no AccountInfo for the account (i.e., SigninManagerBase::GetAuthenticatedAccountInfo() returns an empty AccountInfo). IdentityManager::HasPrimaryAccount() currently internally uses SigninManagerBase::GetAuthenticatedAccountInfo(). This will result in it giving an incorrect result in these edge cases. This CL changes it to use SigninManagerBase::IsAuthenticated() and adds a test that fails before the change. Bug: 892553 Change-Id: I227ad6767089b259c0d54e33f5f88f6789f2de9a Reviewed-on: https://chromium-review.googlesource.com/c/1264203Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597064}
-
Matt Falkenhagen authored
This treats the network service crashing like the worker's process crashing, and prevents clients getting stuck with a broken worker. Originally landed at: https://chromium-review.googlesource.com/c/1260903 It was reverted because the test flaked because the host was sometimes not yet created. The diff in the reland is to wait for the host to be created. Bug: 848256 Change-Id: Ic656f0bf5a320526cf6f7715399f8f71db05619b Reviewed-on: https://chromium-review.googlesource.com/c/1264139Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597063}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/extensions/api. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 890902 Change-Id: Ie70b063af990199a2c23956114a026264d8a7e67 Reviewed-on: https://chromium-review.googlesource.com/c/1257905 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15082f69653d..39be1c969580 git log 15082f69653d..39be1c969580 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@39be1c969580 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I539f6d9f35c76faf2e9b0519c0f3fcc817fa8c34 Reviewed-on: https://chromium-review.googlesource.com/c/1263871Reviewed-by:
-
Martin Šrámek authored
...due to flakiness. Bug: 892484 Change-Id: Ic947c7c7f9a7868249ec200e760ef3cdcf52ca1b TBR: hnakashima@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1264381Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597060}
-
henrika authored
Bug: NONE Change-Id: I596b793a81a4e4d29e05d7459b273028a96c4a99 Reviewed-on: https://chromium-review.googlesource.com/c/1264380Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597059}
-
Sylvain Defresne authored
TestingFactory is a base::Callback<> while TestingFactoryFunction is a function pointer. Convert ProfileInvalidationProviderFactory to the callback based type. Bug: 809610 Change-Id: Id6ddc4e75960f5fd1ed952877d4bebdca515b706 Reviewed-on: https://chromium-review.googlesource.com/c/1246166Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597058}
-
Matt Falkenhagen authored
This CL allows media to play and be seekable when service worker provides the response from cache storage. Live demo from Jake Archibald: https://static-misc.glitch.me/sw-audio-bug/ This CL fixes two things: - Supports blob responses from service worker for partial requests with a range of [x, -1] where x is not 0 (the zero case was already supported). This requires changes to ServiceWorkerLoaderHelpers::ReadBlobResponseBody and mojom.Blob.ReadRange(). - Sets ResourceResponseInfo.content_length based on the HTTP header Content-Length for service worker loaders. This allows Chromium's media code to allow seeking over the media source. Bug: 892227 Change-Id: I9e6f6faaae7b83ad3aee9c0f217834d62c214b85 Reviewed-on: https://chromium-review.googlesource.com/c/1263739Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/787bb77798ed..92d10833de63 git log 787bb77798ed..92d10833de63 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@92d10833de63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ie852c315e773c8c2ab5c47e35805b0cbc630592e Reviewed-on: https://chromium-review.googlesource.com/c/1263867Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 809610 Change-Id: I7c730e9e509e911411e693892b817ce8992517c6 Reviewed-on: https://chromium-review.googlesource.com/c/1259025Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597055}
-
Yuki Yamada authored
This CL implements these classes in Blink: JSBasedEventListener (The base class for | EventLisntener/EventHandler) +- JSEventListener (Implements EventListener) +- JSEventHandler (Implements EventHandler and | other special types) +- JSEventHandlerForContentAttribute (Supports lazy compilation for content attribute) EventHandlers start to support incumbent realm using blink::V8EventHandlerNonNull that inherits blink::CallbackFunctionBase. (EventListener already supports incumbent realm.) These four classes are no longer referenced from anywhere: blink::V8AbstractEventListener blink::V8EventListenerOrEventHandler blink::V8ErrorHandler blink::V8LazyEventListener Although these are no longer necessary, this CL does not remove them so that we can easily switch which classes to use in case new classes contains some problems. regarding crbug.com/759461 : OnErrorEventHandler for content attribute, which has different number of arguments, gets supported by blink::JSEventHandler and blink::JSEventHandlerForContentAttribute. regarding crbug.com/664676 : |js_event| in the relevant realm of |event|'s target is created in blink::JSBasedEventListener::handleEvent(). Bug: 872138, 849236, 759461, 664676, 606900 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I356734fc16611277ad9f3f279a676e7dc8083408 Reviewed-on: https://chromium-review.googlesource.com/c/1215512 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#597054}
-
Mythri Alle authored
V8 API will deprecate the non maybe versions of v8::Object::Has and v8::Object::Delete. Updated pepper implementation to use maybe versions. Bug: v8:7284 Change-Id: Ie582b1ef97f3943ba06e8f3f76d2225f9fffe616 Reviewed-on: https://chromium-review.googlesource.com/c/1254145 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#597053}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/file_manager. This CL was uploaded by git cl split. R=fukino@chromium.org Bug: 809610 Change-Id: I08597fe6bfc322399ae478451c9f2f9091d87ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1258175Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597052}
-
Vaclav Brozek authored
The test has a helper method CreateFormManager, which takes a FormData argument and should build a NewPasswordFormManager for that FormData. However, due to a typo, that method always builds the NPFM for |observed_form_| instead. This CL fixes that typo. Bug: 831123 Change-Id: Ibb313866f8f04d444f68f4af046716ac5ad264be Reviewed-on: https://chromium-review.googlesource.com/c/1262515Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#597051}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/extensions/users_private. This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 809610 Change-Id: Ie2a188fc12106a28474818c9e57dc4dbac233841 Reviewed-on: https://chromium-review.googlesource.com/c/1258769Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597050}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api. This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 809610 Change-Id: Iff395f785271dc038e2e9e07f3569d91d956f27e Reviewed-on: https://chromium-review.googlesource.com/c/1259034Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597049}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/spellchecker. This CL was uploaded by git cl split. R=groby@chromium.org Bug: 809610 Change-Id: Idc50a6ffd6c25fa2c321c0d39f4fa62412581a64 Reviewed-on: https://chromium-review.googlesource.com/c/1258918Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597048}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/downloads. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 809610 Change-Id: Ia28860b92100550ef7e0989566293b4e6ca302fd Reviewed-on: https://chromium-review.googlesource.com/c/1258908Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597047}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api. This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 809610 Change-Id: Id9e8d81f60c29865b75ea219472a029c0ba7e487 Reviewed-on: https://chromium-review.googlesource.com/c/1257793Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597046}
-
Kunihiko Sakamoto authored
This patch lets SignedExchangeSignatureVerifier ignore signature timestamp errors if the Signed Exchange's main certificate is listed in --ignore-certificate-errors-spki-list flag, and ContentBrowserClient:: CanIgnoreCertificateErrorIfNeeded() returns true. This enables us to write layout tests and web-platform-tests for signed exchange loading, without using UA-specific testing API that overrides signature verification time. This patch also removes setSignedExchangeVerificationTime() calls from existing layout tests, because they already run with --ignore-certificate-errors-spki-list flag. This means we lose layout test coverage for expired SXG loading, so I added a test case in signed_exchange_request_handler_browsertest.cc. Bug: 803774 Change-Id: Ia2f9dc5f28036c30e76acc344137ab8873bfb7c6 Reviewed-on: https://chromium-review.googlesource.com/c/1253167 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597045}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a213f73. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25866 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I6745f5932e622acf7f91d3d1aa34c94aea4ea8d9 Reviewed-on: https://chromium-review.googlesource.com/c/1263884 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc. This CL was uploaded by git cl split. R=jkrcal@chromium.org Bug: 809610 Change-Id: Idd87a49ccd46ebc7d7aedd0a8cf47916fcd6fffd Reviewed-on: https://chromium-review.googlesource.com/c/1258768Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597043}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/engagement. This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 809610 Change-Id: I903a5ae6c2d436837cfac97b3bfa1519be66bb1b Reviewed-on: https://chromium-review.googlesource.com/c/1259013Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597042}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdd620c6..be4324e9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d3728a514024eb16a3ff849278baef6b7688350 Reviewed-on: https://chromium-review.googlesource.com/c/1263886Reviewed-by:
-
Hiroki Nakagawa authored
Looks like GetExecutionContext() may return nulptr in terminate(). Bug: 884091 Change-Id: Ibd2756220a83ba490c0e23966650178e0b856423 Reviewed-on: https://chromium-review.googlesource.com/c/1264337 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597040}
-
sangwoo.ko authored
For cr_dialog to behave modaaly, it's better to stop propagation of 'keydown' events. To support this, introduce consume-keydown-event to cr_dialog. If this property is true, cr_dialog will consume keydown events. Bug: 883221 Change-Id: If2981794cad08dfa6dbca8e08d2d16351fad47bd Reviewed-on: https://chromium-review.googlesource.com/c/1254001 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
-
Mikel Astiz authored
UMA metrics Sync.ModelTypeMemoryKB.<datatype> are often used to compare two implementations of sync (pre-USS and USS), to analyze impact on memory use, and expected to improve with USS. With the recently introduced SyncableServiceBasedBridge, making a fair comparison requires accounting for the memory consumed by the bridge itself, which keeps an in-memory copy of all entities (similarly to the legacy directory itself). In this patch, we implement such accounting, by introducing a new method in ModelTypeSyncBridge. Bug: 870624 Change-Id: Idd632f7bccdd39a530aa2a1c024e55604bd9ba17 Reviewed-on: https://chromium-review.googlesource.com/c/1264375Reviewed-by:
-
Fergal Daly authored
Add addvice for base::Bind* Currently we are told not to use something, but it's not always clear what we should use instead. This allows adding advice for the correct alternative to the forbidden identifies. This reapplies 6592bd30, fixes a bug in that and adds a test to validate the compiled config. Change-Id: I4ac12f7748be3f7fbcc03de36e44f35a15cb033e Reviewed-on: https://chromium-review.googlesource.com/c/1260127Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597037}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /net. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error in //net/test/url_request/url_request_slow_download_job.cc. [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 890902 Change-Id: Idf97f430cc571be05d1b69615d43ff34ef1ce64d Reviewed-on: https://chromium-review.googlesource.com/c/1257843Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597036}
-
Mikel Astiz authored
If a model (or SyncableService) reports an error, let's plumb it through to base::debug::DumpWithoutCrashing() via ReportUnrecoverableError(), which does it only for canary&dev channels, with random sampling. This achieves feature parity with the directory-based setup and may allow future investigations if we see datatypes with high error rates. Bug: 870624 Change-Id: Idb3d00b178167a8b7b9eabb560858197e03aecb2 Reviewed-on: https://chromium-review.googlesource.com/c/1264198Reviewed-by:
-
