GitLab

Additional buildflags that are declared here are needed for internal
use.

BUG=internal b/63080838
TEST=Builds.

Change-Id: Ibc03adfe4063487c688d069b88880d3056c75a38
Reviewed-on: https://chromium-review.googlesource.com/562626Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Bryan Henry <bryanhenry@google.com>
Cr-Commit-Position: refs/heads/master@{#485489}

This change switches the Geolocation Mojo interface JS bindings to the
new style and updates the LayoutTests accordingly. The Blink Mojo
interfaces are switched to generating both styles of bindings as an
temporary step while some code has not yet been updated.

These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and
so it is removed.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie7001384afcdc812218d840c8fd0057360868354
Reviewed-on: https://chromium-review.googlesource.com/560544Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485488}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/15d0e7ca..d8c9af47

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I092380ecc74a46cb6b04d1bfc4d9977ebb4c0bfd
Reviewed-on: https://chromium-review.googlesource.com/565629Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485487}

I am working on re-implementing the Android text edit widget's spell check menu
in Chrome and the Android WebView. The buttons in the native Android spell check
menu use the value of android:colorAccent set by the embedding app. To make the
WebView spell check menu have the same behavior, we need to also make it use
android:colorAccent. But to make the menu use the correct (according to
hannahs@, our UX designer) blue color, and not the default green color, we need
to set colorAccent in our MainTheme. This change does that.

I'm assuming that we don't currently have anything that is relying on this being
the existing green color (since that wouldn't match the color our designer said
we're supposed to use for these UI elements anyway). We do currently have some
themes (e.g. FullscreenWhite and PreferencesDialogTheme) that are already
setting this color to other values for specific parts of the app though.

Note: I've tested this change on Jelly Bean and the app seems to run OK, despite
android:colorAccent having been added in a later API version.

Bug: 715365
Change-Id: I2690c014d18211304ace6894f5a2cea0db72a1af
Reviewed-on: https://chromium-review.googlesource.com/566031Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485486}

Bug: 732675
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1cb5f217d063c192d45d0ebeb2da07980f852e5f
Reviewed-on: https://chromium-review.googlesource.com/562900Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485485}

An upcoming version of clang removes the ability to suppress
availability warnings by redeclaring functions. The new way
to suppress warnings is to either annotate the caller with an
availability attribute or enclose the function reference in an "if
(@available)" block.

This patch does the latter for a reference to
CIDetectorTypeQRCode (which requires 10.10) in the constructor for
BarcodeDetectionImplMac. A test relies on being able to construct this
object even on pre-10.10 systems, so we cannot use the availability
attribute or assert that we are 10.10 or higher.

Bug: 735328
Change-Id: I64883a34911b95e624b6ccb0f638034920aef75d
Reviewed-on: https://chromium-review.googlesource.com/565028
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485484}

Fuchsia SDK doesn't yet provide access to Clipboard, so this is just
a dummy implementation to make it possible to compile ui/base

Bug: 740608
Change-Id: I3add17aad177787d2c7ee0f639ac9fc08286a54d
Reviewed-on: https://chromium-review.googlesource.com/565220Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485483}

This change removes the constructor parameter of ClientSession, which is used to
initialize DataChannelManager. Instead, a public function
ClientSession::RegisterDataChannelManagerCallback() has been added to achieve
the goal.

The motion of this change is to avoid the base::Bind() to be kept in a secondary
place in ChromotingHost other than ClientSession. And I think it's also
reasonable to public the Register callback function from ClientSession. So we
do not need to write all registering logic in ClientSession.

BUG=650926

Review-Url: https://codereview.chromium.org/2967793002
Cr-Commit-Position: refs/heads/master@{#485482}

This CL changes an argument name from raw_input, which conflicts a
builtin name. This is a minor clean-up CL.

Bug: 643937
Change-Id: I88821d6537f9d24b3f78de9b21e0ff690f9c3491
Reviewed-on: https://chromium-review.googlesource.com/564699Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485481}

. BrowserGpuMemoryBufferManager register itself as a dump-provider to
  MemoryDumpManager upon creation.
. Instead of getting the list of supported native gpu memory buffer
  configurations from BrowserGpuMemoryBufferManager, generate the list
  directly in GpuInternalUI. This is called only when the chrome:gpu page is
  loaded. So this should happen rarely enough that this should not introduce
  any latency, or any other kind of regression.

BUG=733482

Review-Url: https://codereview.chromium.org/2971083002
Cr-Commit-Position: refs/heads/master@{#485480}

1. GooglePlayInstallState was the wrong thing to check. Installation doesn't depend
on GMSCore and correctly handles if play is out of date.
2. Remove java-side caching of webapk enablement. As of https://codereview.chromium.org/2965233003/
it's unnecessary.

Note: this change will cause chrome to attempt to install webapks when
user clicks the "add to homescreen" menu item, even for devices without
google play. This should be fine as it doesn't depend on play 
being up to date.

Change-Id: I94761818deb58e5a226ea83a791813ffd16961dc
Reviewed-on: https://chromium-review.googlesource.com/563736
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485479}

The old Settings UI allowed editing of the VPN hostname property.
We should allow that in the new Settings also.

Bug: 738195
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56dff8a4f52d89add8940247047a667874a5d348
Reviewed-on: https://chromium-review.googlesource.com/558626
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485478}

Move the tests related to tracing observer, peak detector and periodic
schduler into client_process_impl_unittests.
Removed test CallbackCalledOnFailure since it is covered by
DumpWithoutInitializingTracing

Bug: 728199

Change-Id: Idb2fb0ed566e54ab6f6be825f844e2ffab9b4d16
Reviewed-on: https://chromium-review.googlesource.com/553585
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485477}

This introduces a single function CalculateCrc32, adapted from LZMA SDK, with stl-like interface.

Bug: 729154
Change-Id: Ie15fb95b143e92b8e0a1650386ef01b7b2de5401
Reviewed-on: https://chromium-review.googlesource.com/563876
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485476}

settings-change-picture re-factor 3/3.
This CL moves the picture selector to a separate element, leaving
just the localization and browser glue code in settings-change-picture.

Bug: 730031
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I36255a0da9562f6275830b0ddb39d41d7a969183
Reviewed-on: https://chromium-review.googlesource.com/558624
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485475}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/601f74b9033b..b708a0d15934

$ git log 601f74b90..b708a0d15 --date=short --no-merges --format='%ad %ae %s'
2017-07-10 simonhatch Pinpoint - Add a navbar for login.
2017-07-10 xunjieli Adds webpagereplay_go.py in telemetry

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic1f6e42bf651d361e06d52a5a46718ea4705008a
Reviewed-on: https://chromium-review.googlesource.com/566058
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485474}

This CL removes some old references to paper-icon-button within the
Md settings code. Removing these references doesn't appear to affect the
UI.

Bug: 736891
Change-Id: I09389ca5ffbe33e7b2057dd3fbc711abe3774715
Reviewed-on: https://chromium-review.googlesource.com/564204
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485473}

It's not clear if the ShelfWidget is null or something else is null.
Add CHECKs to sort that out.

Bug: 738011
Test: none
Change-Id: Icd1c281eeec362c88a08e601304e2c8cf4e6834e
Reviewed-on: https://chromium-review.googlesource.com/565934Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485472}

cpu may be offline and not report freq, the all_time_in_state looks like
this:
freq\t\tcpu0\t\tcpu1\t\tcpu2\t\tcpu3\t\t
126000\t\t1501\t\t1501\t\t
216000\t\t327\t\t327\t\t
408000\t\t86\t\t86\t\t

CpuDataCollector did not include the case like this, thus reports error.
This CL fixes this problem and adds unit test.

BUG=739574
TEST=CpuDataCollectorTest.ReadCpuFreqAllTimeInStateOff

Change-Id: If4bf584a81eac158c38069fa6228cfc79ffb7665
Reviewed-on: https://chromium-review.googlesource.com/564000
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485471}

The initial position for an overlay was not being adjusted for the
height of the status bar.  This CL adds the adjustment.

It also adds DialogOverlayImplPixelTest.java to verify that both
the initial position and updates via scheduleLayout() work as
intended.  These rely on UiAutomation, so that it can take a
screenshot that contains overlays.

Bug: 740136
Change-Id: Ib3194869972041a39a06a2d025e5f549d1319cc4
Reviewed-on: https://chromium-review.googlesource.com/563484
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485470}

No change in logic.

This changes the visibility of WebResourceRequestImpl to protected,
since we need to use it downstream for onSafeBrowsingHit().

Bug: 709236
Change-Id: Ie3f1534268667ef64d43dc7f8ae58e9424566cbb
Reviewed-on: https://chromium-review.googlesource.com/566022Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485469}

onUrlUpdated() should be called when the URL is updated. It doesn't
make sense to call onUrlUpdated() at didFinishNavigation() of the
iframes, since the main URL is not updated.

onUrlUpdated() triggers GoogleApiIcingClientImpl#reportContext(), and
excessive calls to onUrlUpdated() translates to excessive Icing calls.
This CL lowers reporting per navigation to <5 roughly.

In UMA, total count and Success bucket count of
Search.IcingContextReportingStatus per navigation should decrease.

BUG=739570

Review-Url: https://codereview.chromium.org/2971953002
Cr-Commit-Position: refs/heads/master@{#485468}

TBR=emircan@chromium.org

Bug: 740762
Change-Id: Ib1714450f52d2fb9634c68c9bc455f09484cca39
Reviewed-on: https://chromium-review.googlesource.com/566081Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485467}

Some followup changes from https://codereview.chromium.org/2969383003/

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2975663003
Cr-Commit-Position: refs/heads/master@{#485466}

This CL removes the note about an extension controlling the NTP from the
OnStartup URL list when the extension is disabled (since it's no longer
being controlled by that extension).

This fixes an error I'd made in CL 557971.

Bug: 740434
Change-Id: I80fea69068b24198ea28478210fbff6bebf8cb7a
Reviewed-on: https://chromium-review.googlesource.com/565998
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485465}

After landing the CL enabling WPT tests that don't necessarily
correspond to real files (crrev.com/c/461722/), 4 Timeout 
TestExpectations from that CL turned up as Failures on WebKit Linux 
Trusty Leak. 

Bug: 703837
TBR: qyearsley@chromium.org
Change-Id: Ideb2d49c866f04d5105c0ad30446b6c92124f0f2
Reviewed-on: https://chromium-review.googlesource.com/566019
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485464}

https://pdfium.googlesource.com/pdfium.git/+log/92e2276a8be4..00c3cfdbae07

$ git log 92e2276a8..00c3cfdba --date=short --no-merges --format='%ad %ae %s'
2017-07-10 npm Roll FreeType to c56d8851ea987023cc73981a70d261b3f6427545

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Id8dfcbbe74abfc5aec38128e39f5df4876d7a31b
Reviewed-on: https://chromium-review.googlesource.com/565943
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485463}

BUG=703369

Review-Url: https://codereview.chromium.org/2969603002
Cr-Commit-Position: refs/heads/master@{#485462}

Main change in this CL
======================

For a long time now the DOMAutomationController::automation_id_ value has
not been used for its original purpose (associating sends with
particular "jobs" / "automations" / render_views).  Right now, the
argument of domAutomationController::send is always routed back to
WebContents (not to any more granular/specific destination).

Right now the DOMAutomationController::automation_id_ field is still
used to enable/disable domAutomationController::send - the send only
works if setAutomationId was called previously (with a value different
than MSG_ROUTING_NONE).  In fact - in almost all cases, the scripts
say:
  domAutomationController.setAutomationId(0)
  domAutomationController.send(...)

This CL removes DOMAutomationController::automation_id_ field and
makes domAutomationController.send work unconditionally.

After this CL lands, we will be able to remove all calls to
setAutomationId (after this CL they will be no-ops).

Other changes needed by this CL
===============================

The CL needed to make the following, additional fixes:

1. ExecuteScript (in content/public/test/browser_test_utils.h / .cc)
   appends "; domAutomationController.send(0);" to the script provided
   by the caller.  This extra value would be usually ignored before
   this CL, but gets in the way after this CL (e.g. can get confused
   with other calls to domAutomationController.send(...)).  To account
   for this a new ExecuteScriptAsync function has been provided in
   this CL.

   Ideally ExecuteScript would become ExecuteScriptAsync, but
   there are multiple tests that depend on the extra pumping of the
   message loop that happens in ExecuteScript and not in
   ExecuteScriptAsync.  Therefore, ExecuteScriptAsync is
   a lesser evil, that minimizes amount of changes needed right now.

   To make sure that ExecuteScript stops waiting after the call to
   |domAutomationController.send(...)| that is added by ExecuteScript
   (and not by some other, accidental send) this CL sends a GUID that
   is unique in each call to ExecuteScript and verifies that the same
   GUID has been received back.  This change has flushed out a few
   additional cases where ExecuteScriptAsync needs to be used
   as well as cases where a call to domAutomationController.send
   can be removed.

   The following callers of ExecuteScript had to be switched to
   call ExecuteScriptAsync instead:

   - ExecuteWebUIResourceTest (consumes messages via DOMMessageQueue
     and relies on the fact that this queue is not stumped upon).
     Additionally, it turned out that client_renderer.js and
     media_internals.js (used by WebUIResourceBrowserTest tests) were
     always erroring out before this CL (this has gone unnoticed,
     because the "FAILURE" string would have been eaten by
     ExecuteScript).

   - SecurityExploitBrowserTest.InterstitialCommandFromUnderlyingContent
     (otherwise the artificual "0" ends up in interstitial->last_command()).

   - captive_portal_browsertest.cc (otherwise we trigger a CHECK in
     captive_portal_blocking_page.cc: Command 0 isn't handled by the
     captive portal interstitial).

     Note that CaptivePortalBrowserTest /
     ShowCaptivePortalInterstitialOnCertError was relying on message
     pumping done by ExecuteScript.  This was fragile - the timing of
     exiting the message pump was not related to the timing of the event
     the test needs to wait for.  This was broken after going through
     ExecuteScriptAsync.  This is fixed by introducing an explicit
     TabActivationWaiter.

   - ExecuteScriptInBackgroundPageNoWait (otherwise DOMMessageQueue
     used by ProcessManagerBrowserTest.ExtensionProcessReuse would
     have unexpectedly gotten a value sent by ExecuteScript, rather
     than the value send by the script itself;  additionally, calling
     Execute*Unmodified*Script here makes sense in a function named
     "NoWait" - ExecuteScript would have waited).

   - saml_browsertest.cc - there was undesired interaction with
     listening to the value sent by SetupAuthFlowChangeListener.

   - ChromeSitePerProcessTest.PopupWindowFocus - this would conflict
     with domAutomationController.send from
     chrome/test/data/page_with_focus_events.html

   The following callers of ExecuteScript were needlessly calling
   domAutomationController.send from the script:

   - ProxyAuthOnUserBoardScreenTest.ProxyAuthDialogOnUserBoardScreen
   - WizardControllerTest::JSExecute
   - NavigationControllerBrowserTest.PostInSubframe
   - SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs

2. autofill_interactive_uitest.cc used to call
   domAutomationController.send(true) from onfocus DOM event handlers.
   This would confuse expectations of ExecuteScriptAndExtractInt running
   "domAutomationController.send(42)" (it would sometimes receive a
   boolean rather than int back).  This is fixed by using a one-time
   onfocus handlers (rather than permanent handlers) from
   FocusFieldByName method.

3. After the changes some GeolocationBrowserTest would receive
   "geoposition-updated" message twice - once from the
   geoSuccessCallbackWithResponse callback (from
   chrome/test/data/geolocation/basic_geolocation.js)
   and once from a checkIfGeopositionUpdated function.

   There is no need to resolve the race via checkIfGeopositionUpdated if
   we start listening (via DOMMessageQueue) *before* trigerring an
   update in the geo position.  This way we can keep just the callback
   and remove the no longer needed checkIfGeopositionUpdated function.

4. content::IsWebcamAvailableOnSystem (via kHasVideoInputDeviceOnSystem)
   would call domAutomationController.send(...) twice before this CL.
   After this CL it is only called once.

Other, opportunistic changes
============================

I've noticed that DOMMessageQueue::message_loop_runner_ can be null
and therefore uses of this field need to be guarded.  This required
remembering result of DOMMessageQueue::RenderProcessGone, so that
it still has an effect when there was no runner when the renderer
crash notification happened.

BUG=662543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2478803003
Cr-Commit-Position: refs/heads/master@{#485461}

BUG=581021

Change-Id: Id6d7ab0cabc525cd575f6140281fdf5dc213a2b9
Reviewed-on: https://chromium-review.googlesource.com/565786Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485460}

This is needed for 10.13 SDK compatibility. See
https://github.com/google/google-toolbox-for-mac/commit/ec72a2bc500a716369c383837bffdc7d2a22855b.

2ef3625a9193 s/GTMAddressBook/GTMABAddressBook/
a86965088edd First pass removing all deprecated uses of
             GTM_IPHONE_USE_SENTEST
157a381522da Merge pull request #129 from thomasvl/sentest_cleanup
9656673748be Bump the pod version to do a release
857a3f0ac59d Merge pull request #131 from thomasvl/update
5207aee433c5 Change file type from UTF16 to ASCII
cc2054645ca7 Merge pull request #134 from sergiocampama/type
94d4ccfc1589 Change include to import for GTMDefines
ca53d4727a2a Merge pull request #135 from sergiocampama/copy
9822411a0fcb Remove trailing whitespaces
e0fc2bad1e98 Merge pull request #136 from sergiocampama/white
89055f58cb50 Support for tvOS (#139)
4ae69e6f0b00 Fixed PodSpec for tvOS (#140)
d49d04d53abe Added -Wreserved-id-macro and but exclude existing
             nonconforming macros (#141)
d9d3b228b735 Avoid error from reserved macro name for GTMRegex.h
7ae58d8e92ef Provides a testing entitlements files
c867eb4055d7 Add default_subspecs to help avoid testing code ended up in
             apps
ec72a2bc500a 10.13 SDK (and iOS 11 equivalent) compatibility for GTM

Bug: 740712
Change-Id: Ia795ff53e53c53067b560bcb9111063507ab2455
Reviewed-on: https://chromium-review.googlesource.com/565770Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485459}

This CL is based on the work tmoniuszko@opera.com did in CL
2962633004 which found a regression in a changed to ROLE_SYSTEM_LIST
(see https://codereview.chromium.org/2909853002).

BUG=703369

Review-Url: https://codereview.chromium.org/2969743002
Cr-Commit-Position: refs/heads/master@{#485458}

If a method is handled by a custom hook, we won't notify the browser
(where we normally would with an API request), and so the activity log
won't be updated. Add support for activity logging with native binding.

If a request is handled by a custom hook and a request is not sent to
the browser, notify the activity logger (which will send the information
along to the browser process).  This matches the logic we currently have
in the JS bindings.

Add unit tests for the same.  In addition to the unit tests, this fixes
ActivityLogApiTest.TriggerEvent with native bindings enabled.

BUG=653596

Review-Url: https://codereview.chromium.org/2962093002
Cr-Commit-Position: refs/heads/master@{#485457}

BUG=737926

Review-Url: https://codereview.chromium.org/2969843004
Cr-Commit-Position: refs/heads/master@{#485456}

Move the CanRenderBorderImage method from LayoutObject to ComputedStyle.
It only depends on information from ComputedStyle and it is not virtual.

Change-Id: I175d4b21b8d1e4f2f8e5535fc063dc65be0b841f
Reviewed-on: https://chromium-review.googlesource.com/565655Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485455}

We apply EnablePlayStoreAppSearch to decide whether to:

- search for uninstalled apps from Play Store;
- show a proper badge in the Play Store app result;
- show the review score and price of every searched app.

Currently using the IsFullscreenAppListEnabled flag is incorrect.

BUG=736552

Review-Url: https://codereview.chromium.org/2961923002
Cr-Commit-Position: refs/heads/master@{#485454}

Bug: 692811
Change-Id: Ic1a061020c1dc502655646c7a6e3ae80aee14535
Reviewed-on: https://chromium-review.googlesource.com/564681Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485453}

This change enables generation of both Mojo JS bindings styles in the
//third_party/WebKit/public:android_mojo_bindings target and updates the
LayoutTests for the MediaSession API to use the new style.

Bug: 699569
Change-Id: Ifebdcbe5cffffd61d3dfcb48b590c447416d8d7a
Reviewed-on: https://chromium-review.googlesource.com/563704Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485452}

BUG=730398
R=pdr@chromium.org

Change-Id: I61868a97e920d0131d672952b7d570181da11537
Reviewed-on: https://chromium-review.googlesource.com/565806Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485451}

In GpuImageDecodeCache::UploadImageIfNecessary, while we DCHECK that
uploaded_image is non-nullptr, we never actually dereferenced that
pointer until we added the call to uploaded_image->makeColorSpace.

This dereference has become the top crasher on Android, indicating that
the DCHECK was more hope than reality.

Bug: 738898
Change-Id: I02ba9098836115a7cde2f5370a0a4e1a72c23d85
Reviewed-on: https://chromium-review.googlesource.com/565010
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485450}