- 08 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66bd5d4deb12..482a6e85b167 Created with: gclient setdep -r src-internal@482a6e85b167 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7ddcc39602d8facd72ad19e82ca436013085d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703669}
-
Julie Jeongeun Kim authored
This CL converts UDPSocketListener from udp_socket.mojom to new Mojo types using PendingReceiver, Receiver, PendingRemote, Remote and Receiver. Bug: 955171 Change-Id: I6ce6be80e58a485ba7674db40fe55b6d95452eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831961Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#703668}
-
Christoph Schwering authored
Added copy and move constructors and move assignment operators to structs which had only a copy constructor defined. Set constructors to =default where applicable. Added |name_attribute|, |id_attribute| to FormData's comparison methods to be in line with FormFieldData's comparison methods. Bug: 1007974 Change-Id: I97cf61c8a5b3512b9d99f677f848fb74ca669041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844775 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703667}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d140f412..79eb4f5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1b6edbeeb7b92f47e718f9eac2bb0c28eddb8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703666}
-
W. James MacLean authored
Since we're still monitoring the performance of the new PDF codepaths and won't be removing the old codepath for at least one more milestone, extend the life of the histograms until M-81. Bug: 659750 Change-Id: I72c5d9d918ab885fdd41f8b151cb88bc5e1eb2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845874Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#703665}
-
Mikel Astiz authored
This allows verifying that the keys provided via Web correspond to the sync-ing user. Bug: 1000146 Change-Id: Ib6eed0d244679703d55b164d2f71432b43695e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847219Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703664}
-
Rune Lillesveen authored
When considering dirty nodes for style recalc roots, we did not consider nodes which were marked GetForceReattachLayoutTree(), but not marked for recalc, as dirty nodes. With the current code, it simply caused us to have the recalc root higher up the tree than strictly necessary, but with FlatTreeStyleRecalc enabled, it caused fullscreen test faillures. The reason is that Node::SetIsInTopLayer only marks node for forced reattach and since the Document node is no longer marked as ChildNeedsStyleRecalc(), a subsequent SetNeedsStyleRecalc on a descendant would walk all the way to the top without finding a dirty node or a child-dirty node. Bug: 972752 Change-Id: I640ce04afd86d8ca032460d72bd088418cee10c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844955 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703663}
-
Cathie Chen authored
When scrollbar wider than the scrollar, the size of OverflowClipRect is negative which will affect the value of scroll offset. This patch make the size non-negative. Bug: 987566 Change-Id: I7fa80e4a17bc48303713a1a191230d0b3e7d0dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840492 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703662}
-
Kamila authored
This cl adds the following metrics for the new notifications UI on desktop: - Metric tracking how many people click on the “Show for site” button. - Metric tracking how many people click on the notifications indication icon. - Sliding icon - Static icon - Metric on how many people click “Manage” in the notifications bubble. Bug: 986737 Cq-Depend: chromium:1726092 Change-Id: I1ffedbb96a76185afcb9adbaade4f72da4e6259f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780736 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703661}
-
Maksim Sisov authored
SetVisibilityChangedAnimationsEnabled has default impl provided by PlatformWindow. At the moment, only Windows may have real impl of that method. Though, it is not clear if other platforms like Scenic can have animations. Bug: 990756 Change-Id: I3ba648f04e061643a855eb5b24808a1a29acc1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834348 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703660}
-
Colin Blundell authored
Part of the effort to eliminate the legacy IPC system. Bug: 1007300 Change-Id: Idbe41f4be45af0be18eea4fd485bcf313dca480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836494 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#703659}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/603e7a0e5a97..f91a82bb1624 git log 603e7a0e5a97..f91a82bb1624 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 eseckler@google.com Merge changes I18393bb3,Ib75271f7 Created with: gclient setdep -r src/third_party/perfetto@f91a82bb1624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I965eef965cf18a0044f9381501220b44866f11d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703658}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/496c95ad404c..0b1af463167a git log 496c95ad404c..0b1af463167a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 perezju@chromium.org [Telemetry] Remove support for summary values Created with: gclient setdep -r src/third_party/catapult@0b1af463167a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:921000 Change-Id: Iee8eac3b4264aa5fc966e0b82d13ff93b7b6f7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847192Reviewed-by:
-
Michael Olbrich authored
Don't call surfaces_.erase() inside DCHECK(). Otherwise this is not executed when chromium is built without DCHECK. As a result deleted surfaces may be accessed. Call surfaces_.erase() unconditionally and only check the return value to fix this. Bug: 1006813 Change-Id: Id8f280afd0f92770dda1b7b66b892343d6939c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845755Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703656}
-
Yang Guo authored
Change-Id: I87d875c4ddc9fe23a7b9c200165443f84818623a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838193Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703655}
-
Jan Krcal authored
This CL changes the way we represent user's identity in the pill: we now show the user's first name (if available) and resort to email, otherwise. This CL also moves from Email specific naming of functions towards more generic "Identity" (as it is not always Name, either). Bug: 967317 Change-Id: Ibea8f2953687a32a54f70a8a59dbf147d4114db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832220 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703654}
-
François Beaufort authored
Following WebGPU spec change https://github.com/gpuweb/gpuweb/pull/461, this CL removes NONE=0 flags/bits. Change-Id: I675d6cbd9df8f30138276cef94f9a24e9e33a008 Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845762 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#703653}
-
arthursonzogni authored
In the constructor: ~~~ explicit WebContentsTracker(bool track_fullscreen_rwhv); ~~~ |track_fullscreen_rwhv| is always false. So it must be removed, with its implementation. Bug: None. Change-Id: Icccac2143d6150cd00d040853cb2c610aba4aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841340Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703652}
-
Jérôme Lebel authored
Adding kGoogleServicesSettingsViewIdentifier const variable for EarlGrey tests. Change-Id: Iea324479412bd7d5b3fbaf2df4dd5f7a719e616f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836504 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703651}
-
Julian Watson authored
Change-Id: I81cd0f7ac56d381662a9c644bcbe9699f54b9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840271 Auto-Submit: Julian Watson <juwa@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703650}
-
Benedikt Meurer authored
In `Timeline.TimelineUIUtils.eventStyle()` we used to return either a `Timeline.TimelineUIUtils` instance or a custom object literal, we even put a custom type annotation here to make that pass Closure type checking. But it's better to just use `Timeline.TimelineRecordStyle` consistently here, and also faster. Change-Id: Ie8834b7a4f8862fde3d2d7c6d6c5ee04dec76b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845752 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703649}
-
Marc Treib authored
The DB was read, but nothing was ever written to it. Note: This CL *could* introduce behavior changes if some previous versions of Chrome/ium wrote data to the DB. But that doesn't seem like a case we'd want to continue supporting. Bug: 1007942 Change-Id: Iaaf6efaf96e0b853cf176d693c7049179276696e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831873Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703648}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd88df5d116c..902cf1e12a74 git log dd88df5d116c..902cf1e12a74 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5e9d4ee99ea1..a333b87cfcbe (8 commits) 2019-10-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@902cf1e12a74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I6e934b3230cd64137c44d273f68249a82c0f413e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845917Reviewed-by:
-
Patrik Höglund authored
On Linux and Mac (only seeing it there). Tbr: danakj@chromium.org Bug: 1012185 Change-Id: Ibe501f10b7fd6c43ca02e7fec68259ec8eddf590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845769Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703646}
-
Mario Sanchez Prada authored
Convert the remaining references to this interface using the old mojo types in tests. Bug: 955171, 978694 Change-Id: I2b4bb0701f3d932b830c06be945ea1e0cdb643f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840691Reviewed-by:
-
Dominik Röttsches authored
In issue 976737 renderer fallback was moved to being purely based on DirectWrite API calls to remove an outdated and hard to maintain hardcoded list. On Windows 8.1 and 10 we use DWrite API in the renderer directly, which in turn calls to our proxied classes, where out of process calls are cached, compare the implementation in content/child/dwrite_font_proxy/font_fallback_win.cc. On Windows versions below that we were moving to a new OOP API call which was uncached. This turns out to trigger performance regressions on extremely fallback heavy tests such as html5_full_render, which contains a big list of characters that need fallback, as well as the loading.desktop test for ruten.com.tw, which specifies a Latin font as primary font even though the page is in Taiwanese. Add a LRU cache implementation which maps from a String to a Vector of SkTypefaces against which we can buffer the fallback calls. The cache is optimise to move the most recently used local and font up so that they are cheaper to access for subsequent fallback calls. This CL has been locally shown to improve loading.desktop ruten_warm at a 26% improvement for timeToFirstContentfulPaint:layout. Due to issue 1011728 it was not possible yet to verify this on Pinpoint. Issue: 1005234 Change-Id: I5cfc1f9ee9bc7557009d9b396816eed6aa9c2ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841333 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703644}
-
Abhijeet Kandalkar authored
This CL converts |mojom::TracedProcessRequest| to |mjo::PendingReceiver<mojom::TracedProcess>| to use new mojo types. Bug: 955171, 978694 Change-Id: Ife8d61ee2e18f81857fda8376992082fb1f28cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838891Reviewed-by:
-
Yifan Luo authored
Bug: 1012190 Change-Id: Id5029e303d1fc5e171f8efdd2946ffe5eeef52bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844823Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I153acefddfbb1d7e757c9d146f26437f0b3a102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845889Reviewed-by:
-
Thomas Tangl authored
Bug: 995720 Change-Id: I4e0779618f75c607f9c93cda928ec9c1c8cc9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845230 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Mythri A authored
Fix for this landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1800855 Bug: chromium:1003268 Change-Id: Ibf7056e406239b85275bb31e24ed39dd34577169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844970 Auto-Submit: Mythri Alle <mythria@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703639}
-
Jérôme Lebel authored
Adding EarlGrey test to swipe to dismiss in advanced sign-in view. Bug: Change-Id: Ia9b53cf8ad29e721890ccb337bb2b2e4c670fd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835506Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703638}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23293e8fa45f..5365f6a6b59d git log 23293e8fa45f..5365f6a6b59d --date=short --no-merges --format='%ad %ae %s' 2019-10-08 risan@google.com Increase timeout for tast_vm_canary_informational Created with: gclient setdep -r src/third_party/chromite@5365f6a6b59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ica7ef91f52951a44bf6e75ccf5cf213e393ccc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846789Reviewed-by:
-
Mihai Sardarescu authored
During the Chrome sign-in flow, if the user chooses to clear the cookies when switching their primary account, then the following actions take place (in the following order): 1. All cookies are cleared. 2. The user is signed in to Chrome (aka the primary account set) 2.a. All requests to Gaia page will include Mirror header. 2.b. Account reconcilor will rebuild the Gaia cookies having the Chrome primary account as the Gaia default web account. The Gaia sign-in webpage monitors changes to its cookies and reloads the page whenever they change. Reloading the webpage while the cookies are cleared and just before they are rebuilt seems to confuse WKWebView that ends up with a nil URL, which in turns translates in about:blank URL shown in the Omnibox. This CL works around this issue by waiting for 1 second between steps 1 and 2 above to allow the WKWebView to initiate the reload after the cookies are cleared. Bug: 1003578 Change-Id: I8dc460854b3047b515c0401bc4e2f233a3fcfa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844975Reviewed-by:Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#703636}
-
Mostyn Bramley-Moore authored
Change-Id: I1777730958e0e36fb65450abe2178669a6e29996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845216Reviewed-by:
-
Jan Krcal authored
This CL introduces two kill-switches that guards showing user email on startup and on sign-in in the avatar button. This way, we simplify the launch by decoupling the visual changes in the button (the master feature) from the individual trigger points. This CL also tweaks the startup trigger by only showing the pill for multi-profile or multi-account users. Bug: 1009441 Change-Id: I4f097b385a8469fc59d94494f5528fbefeda8b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831771 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Dan Elphick authored
Allows us to measure how much time is spent collecting source positions now that this is only done when an exception is symbolized or at the point debugging is enabled. Bug: v8:8510 Change-Id: Id3368778eb8c14776bc664b62ea263a5d3348def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845215 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703633}
-
Michael Olbrich authored
crrev.com/c/1732747 removed the support for UYVY but the list of valid buffer formats was not updated. As a result GetBufferFormatFromFourCCFormat() hits NOTREACHED() for DRM_FORMAT_UYVY. Remove DRM_FORMAT_UYVY from the list of valid buffer formats to fix this. Change-Id: Ic9687bbe399e957db81f7ae4e39e63f7b12ab69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824262Reviewed-by:
-
Clemens Arbesser authored
Not sure how this one fell through the cracks. Bug: 806868 Change-Id: Id94a4b8b6550aba450d32175012f4c72d1216de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844825 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#703631}
-
Colin Blundell authored
Part of the elimination of the legacy IPC system. Bug: 1007300 Change-Id: Ia0f3a49c09156d5a66cf8b7075c08f954d78e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833822 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
