GitLab

ButtonController::OnGestureEvent() should behave in the same
way as ButtonController::OnKeyPressed() and
ButtonController::OnMousePressed(); it should not change the
button state if the button is disabled, and just early out.

This bug caused the new desk button to show as enabled, even
though it is disabled, only when gesture tapped. This didn't
happen when mouse clicked.

BUG=1084241
TEST=Added a new test that fails without the fix.

Change-Id: Ifd007a8b123a26c7109b13e0a7929c0f77f4725b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233362
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776290}

This flag was flawed as it only signals the Assistant has started,
but not that it is ready to handle queries.
The NEW_READY flag does signal Assistant is ready to handle queries,
and will be used going forward (and will be renamed to READY in a
follow up CL).

Bug: b/142428671
Change-Id: I1343d9b36c1164d95e55e14f38f8bef57033b84f
Tests: ash_unittest, chromeos_unittest, and manually launched.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236284Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#776289}

https://skia.googlesource.com/skia.git/+log/7b1355e5093a..c14701a51232

2020-06-08 bungeman@google.com Remove SkStream_mac.cpp.
2020-06-08 bungeman@google.com Remove SkFontHost_mac.cpp.
2020-06-08 reed@google.com minor reordering of fields to save space
2020-06-08 johnstiles@google.com Update GrLumaColorFilterEffect to use a child FP.
2020-06-08 johnstiles@google.com Remove PremulInput and GrPremulInputFragmentProcessor.fp from Skia.
2020-06-08 johnstiles@google.com Fix housekeeper 'check generated files' warning.
2020-06-08 adlai@google.com Move lastRenderTask into drawing manager
2020-06-08 senorblanco@chromium.org Dawn: implement GrBackendTexture::isSameTexture().
2020-06-08 johnstiles@google.com Add JavaInputStreamAdaptor files into third_party directory.
2020-06-08 jlavrova@google.com Optimize findLimitingClusters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: I9d3d9800bc25aec04b2242d9801839d90a35741b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776288}

This reverts commit 45e0194e.

Reason for revert: Breaks tests:
virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-getStats.https.html
external/wpt/webrtc/RTCPeerConnection-getStats.https.html

-----
First build with broken tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/25785
------
Sample of the diff: 
https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=16ebfc26e79fdeaf98748ad686bbaa6208658dee&as=RTCPeerConnection-getStats.https-diff.txt
------


Original change's description:
> Revert "Disable tests for landing a WebRTC name change"
> and rebase changed tests.
> 
> This reverts commit 328f27b7.
> 
> Reason for revert: Change has now landed
> 
> Original change's description:
> > Disable tests for landing a WebRTC name change
> > 
> > Bug: webrtc:8787
> > Change-Id: I5a166726bf236e088426734456f2d503e3c6875e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232554
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#775594}
> 
> TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: webrtc:8787
> Change-Id: Ic074a1b1231f90363bf6af7a581c8044bef947c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235041
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776151}

TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:8787
Change-Id: I17941d275de9e918529944428f69fdec511684e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236471Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776287}

Adds crbug.com/1091410 as an example of weird GPU flakiness to
//docs/gpu/gpu_testing.md.

TBR=kbr@chromium.org

Bug: 1091410
Change-Id: I2431da72aa5408a8adac0fc87197d28181cd552c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236195Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776286}

The test has new expectations as mock scrollbars have been removed. We
expect it's not flaky with the improvements made to the test harness
and site isolation. If it is flaky, we will investigate.

R=vmpstr@chromium.org

Bug: 891427
Change-Id: I4791036524bcae1095f26b534d4416d941178bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232749
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776285}

Enterprise.UploadJobSuccess histogram was set to expire in M82,
this CL pushes the decision until M87.

Bug: chromium:1052976
Change-Id: Icaab2c14de1baad0f66841b560bc2e05d7aca8c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236455Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#776284}

Add an API for getting the feed items for a feed
when we want to display them and also feed items
for continue watching.

BUG=1053599

Change-Id: Id40e56035adb5fea25176f4ee9ed983d54c2f1da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227885
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776283}

Key-event processing logic is added to QuickAnswersPreTargetHandler.
Custom focus traversal logic is added for QuickAnswersView by
subclassing FocusSearch.

A new API is exposed from MenuController to allow keyboard accessibility
and better integration with the context menu for QuickAnswersView.

Bug: b:152057976
Test: Tested on Chrome OS VM.
Change-Id: I77aaa92fe6e32844766d66664e3c1b507b0b253f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231647
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776282}

Ensures that changes that occur to the Mojo definition inside
network_diagnostics.mojom do not require the routine files to be
changed.

BUG=chromium:1085290
TEST=network diagnostics related unit tests

Change-Id: If79490cacb89857084293d9cb06d1ce13f1f557b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236100
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776281}

Suppresses the trace_test DirectComposition failures on HD 630 machines
due to them using YUY2 instead of NV12.

TBR=ynovikov@chromium.org

Bug: 1079393
Change-Id: I8f4bfda45b85566e466f12baf3d4f0d86ec2ad21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236280Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776280}

The metric is removed as it is not longer needed.

BUG=chromium:1046125
TEST=none

Change-Id: I725464b237524848cccefe2470618d63d301eafa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227104Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776279}

Started from
https://chromium-review.googlesource.com/c/chromium/src/+/2208412
by tjohnsonkanu@

Bug: 1045266
Change-Id: I85b337a1a9ebbba0e1cff1853b8f3ef1aee5c8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233827
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776278}

The URI builder does not support relative paths, i.e. Path must be
empty or start with '/' character. This rule was not correctly
enforced and this patch adds correct verification of Path component.

BUG=none
TEST=run unittests on my laptop

Change-Id: Ib736aa3a7f80667e1e73a06d527d3996f1246c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236061
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776277}

Note, that this only affects dual-translator setups.

BUG=b:158136570
TEST=tryjob

Change-Id: I79247fe91c6969a15d52365190949ceec3d1516b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235735Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Lev Rumyantsev <levarum@google.com>
Cr-Commit-Position: refs/heads/master@{#776276}

Some concepts had the same message ID (e.g., "Proxy" is shared among
multiple network-related searches - Ethernet, Wi-Fi, Cellular).

This CL adjusts SearchTagRegistry to support this case by changing
search tag ID to be the concatenation of the concept ID and its message
ID instead of only using the message ID.

Fixed: 1091060
Change-Id: I263f91d2d36f465a5b080c2b7231b8de4cd2ad88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233996
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776275}

Bug: 1092047
Test: html/semantics/scripting-1/the-template-element/template-element/template-element-clone-into-inactive-document-crash.html
Change-Id: I7d515c25294fe661781d14d53053dbf1d3be49f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236245
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776274}

BUG=1088844

Change-Id: I93b49fb61e55ebeed7182eef0b019980869d8e47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227613Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776273}

In preparation for moving ui/chromeos/ime to
chrome/browser/chromeos/input_method/ui, fix presubmit errors.

Error encounter: declaration requires an exit-time destructor

Change-Id: I1c386ecba2da151f5b74303b4968495e5ed4fd08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228589Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776272}

Bug: 1080827
Change-Id: I3169327bd052397aab733636b65fdfe6270484ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236051Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776271}

Bug: None
Change-Id: Ic2bed812deec00ba7ef2cbdfb370ec410b77c01e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236595Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776270}

Ensure XSLTProcessor.transformToDocument() does not crash when called on a node from an inactive document

Bug: 1092276
Test: xslt/transformToFragment-on-node-from-inactive-document-crash.html
Change-Id: I0e3c42d1580eef0a499810f280bb997ef1e61740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236234
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776269}

This C++ test causes thousands of back and forth script execution
tasks between the browser and renderer process. Instead we should
just kick off the tests in JavaScript all at once and then feed
a single result back to C++.

This slowness makes it susceptible to issues with repeated
script execution and is just generally slow. In local testing, this
shaved ~7 seconds off a Windows run (a ~22% reduction in time). Some
of the speed up just comes from combining the 2 AVC tests and the 3
MPEG2TS tests.

Most of the changes here are mechanical. Simply grouping the not,
maybe, and probably results and then using a regex to replace the
necessary strings to convert the tests into JavaScript. Ones with
extensive comments are converted as is (e.g., AVC1,AVC3 tests) while
others with middling comments are converted to a map or list structure.

Fixes a real bug with 'video/ogg; codecs="vp8"' reporting unsupported
on Android. We allow vp8, just not theora.

Bug: 1090770
Change-Id: I85dbb4aede36ee38334108fd05b491746a3defa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233787
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776268}

This is a reland of 844410d2

Fixed the bug in the timeout case logic.  Tested it by reducing the
timeout value so that the timeout logic was exercised.

Original change's description:
> [fuchsia] Add ssh debug messages to the emulator output log file.
>
> This will give more information on startup connectivity issues.
>
> Bug: 1063106
> Change-Id: I90590eaeee7aaac19d8e277b42f42ce5cd6b4f85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212987
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Commit-Queue: Stephen Roe <steveroe@google.com>
> Cr-Commit-Position: refs/heads/master@{#775358}

Bug: 1063106
Change-Id: I8a28b9d41d5dce9bd444a04f623f6b260355c6f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235990
Commit-Queue: Stephen Roe <steveroe@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776267}

Bug: 1086733
Change-Id: I3c74a9cf7a98419a17fc70e74d7c8f3607526879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235163Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776266}

Bug: 1086733
Change-Id: I60b07c0a7fa573c4999c31f49a1c8973bb5ad601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235217Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776265}

Bug: 1086733
Change-Id: Idb692fb99ac6467746b5239fb83e0c002013a445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235572Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776264}

This CL introduces a couple variations parameters to the existing
omnibox flag omnibox-ui-hide-steady-state-url-path-query-and-ref
(whose expiration is also bumped in this CL).

The variations are:
- Reveal path on hover. In this variation, we hide the path until the
  user hovers over the omnibox for 0.5 seconds. This behavior is
  implemented in this CL.
- Show path until user interaction. In this variation, we'll show the
  path on page load until the user starts interacting (scrolls,
  keypress, etc.). This behavior isn't yet implemented.

Bug: 1090393
Change-Id: If712040ac6dc0028e1fe69ecc0de2229c83c5663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227256
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776263}

https://webrtc.googlesource.com/src.git/+log/08a16c09bcf3..09eb6e249d4e

2020-06-08 ilnik@webrtc.org [VP9 SVC] Round spatial layers dimensions to ensure integer scaling factors are used
2020-06-08 tommi@webrtc.org Remove SetRTCPApplicationSpecificData.
2020-06-08 mbonadei@webrtc.org Use absl_deps in order to preapre to the Abseil component build release.
2020-06-08 sprang@webrtc.org Fixes incorrect padding setting for VP9 SVC.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iacb0054b15ce68128a7eccd534dca945647efc6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776262}

Change-Id: I5c6a219afe20f27d441baac09c63105c613dfec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235167
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776261}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I4e7a485eecb16506bb357e6f80ffbb8c60a96988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236467Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776260}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Id795b9748949b12ae08fe1f2ede7c285a756daad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232896Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776259}

This CL also removes WebString::FromUTF16(NullableString16) and
WebString::ToNullableString16(WebString) which, after this change, have
no users.

Bug: 604860, 1039255
Change-Id: I26e1fe104aa208b2423c0d30112e5af0cb32ea71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232860Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776258}

Bug: 1088918
Change-Id: I18b179b6da4b10a021386d3afb35713de4b5636e
Fixes: 1088918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232765Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776257}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60bf7bf3310f..93f2980477a5

2020-06-08 tmathmeyer@chromium.org Remove little chevron arrows in favor of the general TabbedPane layout

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:794255
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I70bc1f07d67d8aa09d7d6852255f1f4b938a2c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776256}

Before this CL: the color of the arrow is determined once
and doesn't adapt to changes in the theme.

After this CL: the arrow color always matches the text color

Here is a screenshot for the dark mode on Linux.

Before:
https://screenshot.googleplex.com/6yK0cmkBQxJ

After:
https://screenshot.googleplex.com/ctW6pGELa1Y

Bug: 1044038
Change-Id: I62a056deb31d4ac87cfa85469fee868210519fc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232858
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776255}

Background: as part of bug 1066670, we're removing usage of Xlib and
switching to our own X11 protocol bindings.  In Xlib, constants are
usually defined as macros:
    #define GenericEvent 35
Our approach is different:
    struct GeGenericEvent {
      static constexpr uint8_t opcode = 35;
    };

There are many instances of the following snippet:
    DCHECK_EQ(event.type, GenericEvent);
which now need to be changed to:
    DCHECK_EQ(event.type, GeGenericEvent::opcode);

However, this causes a subtle link failure:
    ld.lld: error: undefined symbol: x11::GeGenericEvent::opcode
This is because CheckEqImpl's parameters are passed as const&, but
the static constexpr value doesn't have an address.

Alternatives considered:
* Change uint8_t to int to get the existing int overload of
  CheckEqImpl.  We want to avoid this because using int would
  imply there are more opcodes than can actually exist in the
  protocol.
* Change *::opcode to be non-constexpr static, defined in source
  file.  This won't work because it's common to switch() over the
  opcode, and that won't work unless the cases are constexpr values.
* Create a separate source file that provides redundant definitions
  of these constants.  This is a hack.

This CL extends the existing int-int overload meant to solve this issue
to any fundamental type.

BUG=1066670
R=thestig

Change-Id: If62c845cf590cca484e13cf482a67ef4cdd51cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236220
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776254}

Bug: 1077352
Change-Id: Ia70455d12f05f6cbd4ba90a5de74f04a98c79fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231256
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776253}

Add media_router::mojom::Logger, used by Media Router's native
components to record event logs.

Add LoggerImpl implementing the Mojo interface, which will be owned by
MediaRouterMojoImpl in a later patch.

Bug: 687380, b/154271334
Change-Id: Idefe67682a3c850ee99ab456083a489e4a400c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079535Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776252}

Uma has also been added to track the result of querying a specific source for a hint.

This also removes the former definition of PerformanceClassForURL.
PerformanceClassForURL wasn't called anywhere, so
PerformanceClassForURLInternal has been renamed and better documented.

Bug:1087123

Change-Id: Iac30bcece87f282f826bbf2eff6b19dd37d0d764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225831
Commit-Queue: Josh Simmons <jds@google.com>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776251}