GitLab

Makes LockContentsView observe DetachableBaseHandler, and display an
error bubble when it detects that the user has attached a base
different than the one they used last.
The bubble has the same style as the auth error bubble, but is not
supposed to be dismissable by the user (so untrusted user can't remove
the error bubble while the device is unattended).

Updates LoginBubble class to support non-dismissable error bubbles -
introduces kFlagPersistent flag that can be passed to ShowErrorBubble.
If the flag is set, the bubble will not be closed on key, mouse or
gesture events.

BUG=796300

Change-Id: I9723ba61450d03bdedb395462994d0b3546e5db0
Reviewed-on: https://chromium-review.googlesource.com/941726Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542298}

Bug: 803245
Change-Id: I645e82663991cd012ced5f19a056d08bbc2c797d
Reviewed-on: https://chromium-review.googlesource.com/952281Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542297}

Some of these tests expected a message from the child process, and would
verify that it was valid/invalid as expected, but would still pass if
no message were received at all.

Bug: 816620
Change-Id: Ie8acf85086f4416c7023118673c40d00a2e190d7
Reviewed-on: https://chromium-review.googlesource.com/955554Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542296}

Part of https://github.com/w3c/web-platform-tests/issues/7784 and
roundabout manner.

Change-Id: I7a11d22240784d94776d77ca07d0c28b1ef12736
Reviewed-on: https://chromium-review.googlesource.com/952670Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542295}

Thie is a manual reland of CL 953962.

This change wires up button hover and click sounds, and adds them to the
asset structure.

BUG=812026

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id349bfe17f01cfcc3f911fc1b69d7dc33879ced6
Reviewed-on: https://chromium-review.googlesource.com/957305Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542294}

ByteStreamReader is in content/ and download should avoid such dependency.
Replace all the ByteStreamReader mocks with mocks of download::InputStream

Bug: 803135
Change-Id: I3650d482943c604bedc39c0db8ec7b1021656fe4
Reviewed-on: https://chromium-review.googlesource.com/957446Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542293}

We are deprecating label() and moving to using id() for consistency and
spec compliance. This is part of the effort to support to multiple media
stream ids in webrtc.

Bug: webrtc:8977
Change-Id: Iab6a8930f26d4c00a3a5153dd1cac85b3b4b5730
Reviewed-on: https://chromium-review.googlesource.com/953165Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542292}

BUG=811812
BUG=811804
BUG=811803
BUG=811863
BUG=811816
BUG=811786
BUG=811782
BUG=819960
BUG=819959
BUG=731979
BUG=731958
BUG=759301

Change-Id: I3dca0071deea514bc99caff206abb5009984dbd4
Reviewed-on: https://chromium-review.googlesource.com/957485
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542291}

https://skia.googlesource.com/skia.git/+log/43f0ba073068..8c4cbf4cfb6d

$ git log 43f0ba073..8c4cbf4cf --date=short --no-merges --format='%ad %ae %s'
2018-03-09 herb Remove last use of DetachCache.
2018-03-09 liyuqian Revert "Check the boundary while cumulating deltas in a mask"
2018-03-09 halcanary SkPDF: filter out empty clip draws more often
2018-03-09 jvanverth Add a negative translation to one of the smallpath GMs
2018-03-09 halcanary SkPDF: simplify PathOp code, emit empty clips.
2018-03-09 caryclark add starting template support
2018-03-09 caryclark Revert "start hardening pathmeasure"
2018-03-09 liyuqian Check the boundary while cumulating deltas in a mask
2018-03-08 caryclark start hardening pathmeasure
2018-03-09 bungeman IWYU for test files starting with 'B'.
2018-03-09 mtklein roll clang_linux package to Clang 6
2018-03-09 reed harden line clipper against slight numerical drift.
2018-03-09 herb Remove use of attach/detatch cache from distance field text
2018-03-09 jvanverth Fix issue with negative translations of small paths
2018-03-09 liyuqian Do not set record to empty if it's already computed
2018-03-09 reed Ensure Y->X ordering when building a region from a path
2018-03-09 brianosman Shim to enforce that canvas virtuals are overridden
2018-03-09 bungeman SkResourceCache.h shouldn't include itself.
2018-03-09 herb Remove TLS glyph cache calls.
2018-03-09 bsalomon Add GPUSink getters to suppress unused field warnings in no gpu build.
2018-03-09 herb Remove another set of AttachCache
2018-03-09 csmartdalton ccpr: Simplify triangle corners

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Id78b31304ed7545ce1d228eea18ea48cec9582ee
Reviewed-on: https://chromium-review.googlesource.com/957552
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542290}

I have checked that these tests "unexpectedly" pass in
https://test-results.appspot.com/data/layout_results/Linux_Tests/68204/site_per_process_webkit_layout_tests/layout-test-results/results.html:
(and also in 68203 and 68202 and 68201), so let's try reenabling these
tests.

I have also tried 5 runs on linux_chromium_rel_ng trybot and all the
removed tests have passed there as well, except
external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html
which I can repro locally and which turned out to be the same as
https://crbug.com/793127.

Bug: 477150
Change-Id: I6b426a9ce0c9aa88f4c6945a2bec295acf9fc4da
Reviewed-on: https://chromium-review.googlesource.com/957343Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542289}

trial.

It's a flag, rather than a Feature, so that it can be marked as unsafe later on.

(Ideally we would make the existing #enable-site-per-process flag multi-state,
but there appears to be no ready way to do that without losing the old setting:
there's no migration scheme at present, and since flags storage isn't
versioned, all the ways I can see to build that would be dangerously clumsy.)

TBR=thestig@chromium.org (for printing)

Change-Id: I2225ded078a14b2ffcf6643e483ff995c48cb66a
Reviewed-on: https://chromium-review.googlesource.com/947398
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542288}

This reverts commit 3f7270c2.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add about:flag for feature PdfIsolation
> 
> Bug: 809614
> Change-Id: I63fb89898c9ed83e532fd148a0a4dd318c194693
> Reviewed-on: https://chromium-review.googlesource.com/956488
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542215}

TBR=isherman@chromium.org,jam@chromium.org,tsepez@chromium.org

Change-Id: Ifec7ccfc80d125bdef35f41f997aa412db7a8823
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809614
Reviewed-on: https://chromium-review.googlesource.com/957784Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542287}

Bug: 820620
Change-Id: I5f33231f7b7c8495bae2b3faf04085bfa8152ab5
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/957710
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542286}

As currently written, element nodes in Shadow DOM trees won't be
properly annotated with shadowRootType. Change an else if to a
plain if to address this. Tests fixed accordingly.

R=dgozman@chromium.org

Change-Id: Ie912de6663c8b4ed0a3638f80cd81ccbcf7e1b31
Reviewed-on: https://chromium-review.googlesource.com/951866Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jandro Alderman <aalderman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542285}

This reverts commit ceae97b0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 542162 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NlYWU5N2IwMDBmZDIwOWRmMDM0YjFiM2M1YjZkMTJlZjVkNTYxZTUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8413

Sample Failed Step: browser_tests

Original change's description:
> Don't share PDF plugins across origin boundaries.
> 
> Controlled by --enable-features=PdfIsolation, default is off.
> Stricter than required (full origin, not eTLD+1).
> Add pdf_extension_test for multiple domains.
> A subsequent patch may attempt to apply this to secure origins only.
> 
> Bug: 809614
> 
> Change-Id: Ic38c2c5074c7723210e38a754b930fb152c031b7
> Reviewed-on: https://chromium-review.googlesource.com/953979
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542162}

Change-Id: Idc8255cdc2ad8bfada325fa9e49069e5d32c0246
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809614
Reviewed-on: https://chromium-review.googlesource.com/957783
Cr-Commit-Position: refs/heads/master@{#542284}

Bug: 819289
Change-Id: I029d5adfef0a650998778c1b56ea8782a66ff3e2
Reviewed-on: https://chromium-review.googlesource.com/956573Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542283}

BUG=811812
BUG=811804
BUG=811803
BUG=811863
BUG=811816
BUG=811786
BUG=811782
BUG=819960
BUG=819959
BUG=731979
BUG=731958
BUG=731958

Change-Id: I6b2778332e7d29c7cd2d9144cea0949e9bde47ca
Reviewed-on: https://chromium-review.googlesource.com/957525Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542282}

Currently, Aura Overlay Scrollbar will fade out when user finding in the
page. This patch is to improve this UX.

In this patch, we check HasFindInPageTickmarks in root vertical Scrollbar Layer
then show and prevent it fadeout or post the hide animation the scrollbar at the
end of syncing pending tree to active tree.

After this, we will show Aura Overlay Scrollbar when user type the first
character in find in page box and post fade out animation when user
close find in page or delete last character in find in page box.

Bug: 759152
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id2baf95a6441ffa58a09597dba6b0bed5299a1c3
Reviewed-on: https://chromium-review.googlesource.com/946744Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542281}

This will help users customize for maximum productivity by
allowing them to hear more words per minute.

Bug: 819306
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2c760ddd66358d5cf4a96e3fc7f62aa95a14bc24
Reviewed-on: https://chromium-review.googlesource.com/952209Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542280}

The goal of this change is to track developer uptake of :focus-visible,
once it ships from behind a flag. We also want to monitor the usage
of :focus. This data will help us explore possibly switching the UA stylesheet
over to using :focus-visible someday.


R=aboxhall@chromium.org

Bug: 817199
Change-Id: I257ab590f03d28831ec517b67f42e6f86a156ee9
Reviewed-on: https://chromium-review.googlesource.com/954102Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542279}

This CL moves aways from the use of base::Bind from
//services/ui/service.cc.

BUG=714018

Change-Id: Id7dd062c7e54fc59e7a92fe8173195bdbaa84356
Reviewed-on: https://chromium-review.googlesource.com/957162Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#542278}

PowerVR drives that have problems with one component textures being
bount to an EGLImage require YUV->RGB conversion to be done early in
software. In that case it's not correct to pass the color space
of the video frame on to the compositor, because it doesn't reflect the
color space of the converted frame. Instead, just reset it to the
identity color space.

Bug: 818072
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I44751300a134d29240217cf80c6a5c663227745d
Reviewed-on: https://chromium-review.googlesource.com/955592Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542277}

Bug: 696345
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia471817b9eaaf3ea25c773c5292e2b21fafbcb94
Reviewed-on: https://chromium-review.googlesource.com/826491
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542276}

Remove the entry "Enabled_bg_limit_8", that was for the first field trial.
Also, remove "ReportRendererPeakMemoryStats" feature, that is not
planned to be used in a launching configuration, but it was just for
gathering memory metrics until Beta.

Bug: 775849
Change-Id: Ib496db8d69b6891915cfab453ad4abc13d66e522
Reviewed-on: https://chromium-review.googlesource.com/956945Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542275}

Add ChunkToLayerMapper to reduce repeated costs when mapping many rects
from the same chunk state to the same layer state. It also tries to
reuse computed transforms and clips across chunk states to the same
layer state.

Performance:
- cluster telemetry: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180308192816/html/index.html
 3.5% improvement of record_time
- pinpoint: https://pinpoint-dot-chromeperf.appspot.com/results2/17a3d0fc440000?r=chromium%4054ab408&s=%25%CE%94avg&g=name&c=0
 6% improvement of record_time

Bug: 803867
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8c20ff7525894767e601270e2cdd291828941f05
Reviewed-on: https://chromium-review.googlesource.com/952291
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542274}

Change-Id: I4b7e26985d4f3a66111cf70135c78fca4beed73a
Reviewed-on: https://chromium-review.googlesource.com/957483Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#542273}

Due to the app list UI migration, ServicesCustomizationDocumentTest.DefaultApps
will require AppListServiceImpl to be initiated. This is a preflight commit
to register more required preferences, and make sure we have a profile manager.

Bug: 733662
Change-Id: I777772cebedf2d7631fcc64c06a42e1933884a51
Reviewed-on: https://chromium-review.googlesource.com/957651Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#542272}

StackLayout#uiPreemptivelySelectTabModel() is a one-line method that just calls
StackLayout#onTabModelSwitched(). I don't think there's really any extra clarity
added by the separate method name, so I'm removing this method so I don't have
to deal with it when splitting a base class off of StackLayout.

Bug: 648314
Change-Id: I187051e51e0593060808ef4f6824bf742df483f9
Reviewed-on: https://chromium-review.googlesource.com/957560Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542271}

Approximately every 6 minutes VRDisplay would stop submitting frames
to OpenVRRenderLoop.  The reason for this is that VRDisplay won't
submit frames with a negative frame id.

Frame id is stored as a 16-bit signed int, overflowing after 32767.
32767 frames / (90fps*60sec/min) = 6.068 min before overflow

BUG=820525

Change-Id: Ie6131f3e246f7d38fa8790e1dd27cea7ff4cbb20
Reviewed-on: https://chromium-review.googlesource.com/957523Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542270}

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3fefd8951f9c28b00e98f1a42edaa9d24e5e5856
Reviewed-on: https://chromium-review.googlesource.com/944045
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542269}

https://chromium.googlesource.com/catapult.git/+log/e490e96cd7f3..21ff400bb488

$ git log e490e96cd..21ff400bb --date=short --no-merges --format='%ad %ae %s'
2018-03-01 kylechar Update VizCompositorThread name.
2018-03-09 dtu [pinpoint] Show error messages in new job dialogs.
2018-03-08 simonhatch Pinpoint - Have results2 generated on the backend.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ie65ff18fdf995ae00103a3d750d666312d7389eb
Reviewed-on: https://chromium-review.googlesource.com/957467
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542268}

changes:
Per crbug.com/740268, we get all launch review YES. Remove behind-flag
--ash-enable-persistent-window-bounds switch.

Bug: 805046
Test: device test
Change-Id: I33dfec4dd97e01c7ba159ab005cfd97cff51e215
Reviewed-on: https://chromium-review.googlesource.com/954067Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#542267}

StackLayout#setActiveStackState() is used by StackLayout to set the currently
active tab stack. This method currently takes a boolean (true for the incognito
stack, false for the normal stack). This CL changes this method to instead take
an integer representing an index, so we can support more than two tab stacks.

This CL also changes this method to return void (previously it was returning a
boolean: true if the active stack was actually changed, and false if it wasn't),
since the return value is never actually used.

Bug: 648314
Change-Id: Ief119b4a1a92f8345b2b3556f9003cf4e3092f61
Reviewed-on: https://chromium-review.googlesource.com/957274
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542266}

The bounds of displays in display::Screen space must have the display
rotation applied. This ensures that the geometry of screen
(display::Screen) space corresponds to the geometry in physical space,
and in particular ensures that all displays have the same rendering
orientation in screen space. This patch makes cast's usage follow this
rule, which fixes the --display-rotation flag in circumstances where it
currently does not work (e.g. DRM platform with 90 or 270 degree
rotation).

As an added complication, some components such as WindowTreeHost,
PlatformWindow, and DRM platform internals use a third space called
"host" space within which each display is also allocated pixel bounds,
but in its neutral orientation instead of its screen space (== rotated to
align with physical space) orientation. This is also the space in which
drawing surfaces are allocated. This space has nothing to do with
physical space or screen space when display configuration is enabled and
exists mainly as a way to match windows with drawing surfaces and
displays when we need to produce fullscreen buffers for direct scanout.

To determine bounds of the primary display in host space for our case, we
can simply assume a rectangle positioned at 0,0 whose size is the display
bounds in screen space with the display scale and rotation cancelled back
out. Multi display setups cannot be supported with this method, but we
don't need that. Ash has a great deal of code to deal with
transformations between host space and screen space that we avoid by
using this simplified method. Code that needs to map between screen space
and host space (such as CastWindowManageAura) must make this
transformation.

All of this is fairly confusing and there are a number of hacks in the
system due to account for the different orientations of displays in host
space and screen space, but until things are cleaned up we need to follow
the conventions in order for display rotations to work properly on Cast.

Bug: internal b/74248568
Test: Pass various --display-rotation flags and get rotated output.

Change-Id: I12a8f23cd1d4b01675dd78cf364ccb8c27b706af
Reviewed-on: https://chromium-review.googlesource.com/957476Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542265}

Because apparently the compass doesn't work so well and is what causes
spinning when using the thing indoors sometimes.

Bug: 695937
Change-Id: Id0e94520b1f509f133161e2c99edb9bd9775c616
Reviewed-on: https://chromium-review.googlesource.com/957471
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542264}

Looks like crbug.com/807627 has been fixed by the recent roll of wpt tools,
in which case this test won't be flaky any more.

Bug: 805463
Change-Id: I184560ed406a082c661f313047830d79d5d152d1
Reviewed-on: https://chromium-review.googlesource.com/957223Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542263}

Bug: 819761
Change-Id: I7d34886e5d12b1a77287463a6d15daf054192858
Reviewed-on: https://chromium-review.googlesource.com/956965Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542262}

Allow apps to reload themselves, and ensure the ShellDesktopControllerAura
keeps app_shell alive long enough for the app to come back up.

Add browser tests for ShellDesktopControllerAura and
chrome.runtime.reload() in AppShell.

Bug: 762642,759867
Change-Id: If09ad83e6d3073461ebf8b53afa69a6c2aab7e15
Reviewed-on: https://chromium-review.googlesource.com/912752Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542261}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ibe608cf1ef22ad569dfe9091ad5acb4036944cbd
Reviewed-on: https://chromium-review.googlesource.com/957601Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542260}

Change-Id: I5bc8b67bae8ecca593efa977270374ce6bf8fd9d
Tbr: sashab@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/956649
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542259}