- 13 Nov, 2020 40 commits
-
-
Nnamdi Theodore Johnson-Kanu authored
- Add provider name where possible Before: https://screenshot.googleplex.com/7EE62daLS47D2Y2.png After : https://screenshot.googleplex.com/9oHhYyy7TnbtVR7.png Bug: 1093185 Change-Id: I353580175952c83f83b9d430e46f7a8bc52179d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506169 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827111}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605203985-a72b3d0424c525881821dc3609a4c23423acaf56.profdata to chrome-linux-master-1605225603-3e78f0541b05b7200384abc9a699177331fd68ec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia8e5467db42ae8c36e77cca35096cc321bc2b6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827110}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was always returning 1 from FuchsiaVideoDecoder::GetMaxDecodeRequests() for encrypted streams. As result the decoder had at most one decode request and so it wasn't decoding quickly enough. As result the renderer was sometimes running of output buffers. This change updates GetMaxDecodeRequests() to return value that includes the number of input buffers in the decryptor which allows to run decoder pipeline more efficiently. Bug: b/172062874 Change-Id: I394513debc02b43ea1bad801adc21a5b9efa5d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536450Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827109}
-
Wan-Teh Chang authored
Call PostDecodeProcessing() when Decode() sets the status of an image frame buffer to ImageFrame::kFrameComplete. This matches the Decode() methods of the other image decoders that support animation (GIFImageDecoder, PNGImageDecoder, and WEBPImageDecoder). This is related to the UpdateAggressivePurging() call at the beginning of Decode(). Change-Id: Ib98db567cdb492fcbcdaad36d055e73177f651df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536112Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827108}
-
Alec Douglas authored
This commit makes extract_actions.py and its dependencies compatible with Python 3.8+. extract_actions.py and its dependencies are still Python 2 compatible. Bug: 941669 Change-Id: I4038e49449ef0cda8e7801ea49aef7e80a53c9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531120 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#827107}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/90bf4ba461d1..052885405c6c 2020-11-12 alexleung@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1a2add0e09ff64ddc3c8d71f34507f519371d243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827106}
-
Yuheng Huang authored
The following stories are added: tab_search:close_and_open:2020 tab_search:top10:loading:2020 tab_search:top50:loading:2020 tab_search:top100:loading:2020 Also increase buffer size and remove delay when adding tabs Bug: 1099917 Change-Id: I08268ff34760775142acdc38d48aa3603f1d4b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533236Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827105}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605203985-0458f2948c8ea3f9d90fd537422a290135941c1f.profdata to chrome-mac-master-1605225603-5553135a8604afd70a132d716de6c70ddfcfdb1a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2c67765e817727db746fa68daf8de26df075e6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827104}
-
Eric Orth authored
Not sure what this is, and it has no documentation that I can find. Looks like some sort of non-automated fuzzer, so I'm assuming it's a legacy thing from before the current fuzzing support and deprecated in favor of our many fuzzers covering HostResolver and DNS functionality. Removing because it would otherwise need to be updated for the switch to DnsResponseResultExtractor. Change-Id: I5266d145baf5ba012dbad9ac7db44c35744c23b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536154Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827103}
-
Ravjit Singh Uppal authored
This reverts commit 8f9cd957. Reason for revert: Fixed compile failure after mid-air collision. Re-added include that this CL needs but was removed by https://crrev.com/c/2532577 in-between try jobs and landing. Original change's description: > Revert "Added support for one-time geolocation permission grants on desktop." > > This reverts commit 6e5cadb7. > > Reason for revert: compile failure > https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/22520? > > Original change's description: > > Added support for one-time geolocation permission grants on desktop. > > > > Expanded the current permission request dialog to have the possibility > > to accept the permission for only one time. > > > > The permission will be invalidated when all the tabs with that origin > > are closed or navigated away from, or if a day has elapsed since the > > grant, whichever comes earlier. > > > > Bug: 1147918 > > Change-Id: I9f0cc029d0bd2cae56e433d8ba753e73495476f4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483832 > > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826981} > > TBR=vasilii@chromium.org,engedy@chromium.org,ravjit@chromium.org > > Change-Id: I511823b3a656f211c472d76a9cce2d30ca7ab644 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147918 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536153 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826987} TBR=vasilii@chromium.org,engedy@chromium.org,zmin@chromium.org,ravjit@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1147918 Change-Id: I1acdb5f0af83bc74c3307b8ba1ba3d6cbb9ad232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536430Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#827102}
-
Wan-Teh Chang authored
A future CL will eliminate the image_data_ member. Replace the use of image_data_ in the ImageHasBothStillAndAnimatedSubImages() method with direct use of the data_ member. Change-Id: Idd086243eb7aed6c72b0253ef15ee2c2cb49b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536085Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#827101}
-
Kevin Marshall authored
Implements support for setting the light/dark color theme via the fuchsia.web.Frame FIDL API or the fuchsia.settings.Display service. Fixed: 1119521 Change-Id: Iab2fb9d38cabd1af2e57886563c203440b15d74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518261Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827100}
-
David Black authored
UX prefers the non-material version of the chevron_right icon for use in system UI. Bug: 1147930 Change-Id: I7da0659212fc7087fdb23cf908ed77dc266b3fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536097Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#827099}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.60 R=rmhasan@google.com Bug: 1041619 Change-Id: I146db8315b102e994b606a7ff99e62e50a262eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535768 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#827098}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605128385-e428bee778404d65a307409bc6db7ad616d50a2d.profdata to chrome-win64-master-1605203985-641ad6c9d1aaad676b930873880400e5a1a9a471.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f6d78464a1931fa5b11b1563b095f6b4fc5a159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827097}
-
Scott Violet authored
I naively thought the wiring was so simple nothing could go wrong. Time has proven me wrong. BUG=11478276 TEST=test only change Change-Id: I4dfdd7a7613a1f6a04a2e4356f63b040da063b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535919 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827096}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/d3ffc411d154..90bf4ba461d1 2020-11-12 shawnq@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I54b01a6512375ff009c76cc5129336c6e2a77b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827095}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/01e969da3318..8d69298d9b29 2020-11-12 enga@chromium.org Rename DepthSamplingTests to DepthStencilSamplingTests 2020-11-12 rharrison@chromium.org Use remapped entry point name in D3D12 2020-11-12 enga@chromium.org dawn_wire: Reject new callbacks if the client is disconnected If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I7a6e1b135250f53b23b07b2b1b9f021d3fa47776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827094}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 16e6602a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ic4f5d093a5f09b606c44b21be5d842862c17bacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536490Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827093}
-
Esmael El-Moslimany authored
Bug: 1147287 Change-Id: I6dba473b3648615cf877dbd23186b3176d9fd891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532996 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#827092}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6dc3d37f58c..fd0d0441ca1e 2020-11-12 srisser@google.com Update vulkan headers to 1.2.160 2020-11-12 swiftshader.regress@gmail.com Regres: Update test lists @ 4804ac87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I427543c473f6f86b3e3c3f83d769bdfdc8e40b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827091}
-
Regan Hsu authored
Fixed by directly clicking on the element that has the corresponding click handler instead of its child elements. Fixed: 1146224 Change-Id: Ia7b98e89f9de280cd0e0d1bc73e8ad507fb97c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534697Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827090}
-
Juan Mojica authored
Bug: 1092713 Change-Id: I693ee59289d1f4380831c06fcef30d24c4fad3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498962 Commit-Queue: Juan Mojica <juanmojica@google.com> Auto-Submit: Juan Mojica <juanmojica@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#827089}
-
Clark DuVall authored
A few files needed to move from :lib to :automation_client_lib to avoid a circular dependency between those two targets. Bug: 949535 Change-Id: Ib4fea50d987b26ef76489393c838d067a082d0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535451Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#827088}
-
Josh Nohle authored
Record the result of starting advertising from the Nearby Share service, and if it fails, record the reason why. We emit to an aggregate histogram as well as one sliced by the advertising mode: BLE or high-visibility. Manually verified successes for BLE and high-visibility, but was unable to force an error for testing. Bug: 1105579 Change-Id: I60266e2f55a336e72f195c766ec99eace7764842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533868 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#827087}
-
Andrew Xu authored
This CL changes the scaling strategy for the images rendered from HTML code a little bit: shrink the image if it is higher/wider than the available space. Bug: 1146556 Change-Id: Ie690bfc3da293eee7c3371bd8892d21b3532f91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536431 Auto-Submit: Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827086}
-
Joe Downing authored
This CL introduces the class which will log events to a file. The files are placed in the same location as the host binaries and are cleaned up when the MSI is uninstalled (or reinstalled). The host log file name includes the date/time so that a new log is generated each time the host starts. I added a symlink called latest.log which points to the newest file. Bug: 1144185 Change-Id: I92669a2e05033bec39da75eb02460d776d4fcc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536045 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827085}
-
Regan Hsu authored
When a new device sync event occurs, the phone sends its encrypted metadata to the Chromebook. Previously, this wasn't considered a status change, since the same device is still set as the host. However, the encrypted metadata stores the PII device name, which is needed by Browser tabs. This CL ensures that when OnNewDevicesSynced() is called, a host status change is fired so that MultiDeviceSetup is aware of the decrypted PII name. Bug: 1143045, 1106937 Change-Id: I543c97b06185570755632b23adfea192f090376a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536055 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827084}
-
Jimmy Gong authored
Fixes an edge case where there are multiple phones associated to one GAIA account. If there is at least one device that is eligible but the others are not, the non-eligible phones will be marked as eligible incorrectly. This CL fixes that bug by verifying that the current host phone device is eligible for the feature. Bug: 1106937 Fixed: 1146619 Test: chrome_components_unittest, local Change-Id: I88686e2b1f819ea1e3d3a903fa8124778c4c2632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530897 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827083}
-
Kenichi Ishibashi authored
Bug: 1133143 Change-Id: I3f0f082402506138ce00e9228e58549fe8ca7db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532161 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827082}
-
Emily Stark authored
This string is no longer specific to the lookalike Safety Tip, so it's now PAGE_INFO_SAFETY_TIP_DESCRIPTION. Bug: 1146471 Change-Id: Ibf398beb5e83bbbb33cf4668ebc5ea9e98046e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535393Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#827081}
-
Austin Tankiang authored
This change makes the screenreader read both the banner text and the button text when focused on the "Learn more" button. Bug: 1129778 Change-Id: Id2953e7216edd2b4d9bd763dc8ba4805fa5d1f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533062 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827080}
-
David Bokan authored
The spec was recently updated in https://github.com/WICG/scroll-to-text-fragment/pull/148 to remove redundant restrictions on word boundaries. This CL makes the implementation match these updates and refactors the text fragment matching algorithm to more closely resemble the spec. This change actually fixes a few edge-cases. Updated tests to provide comprehensive coverage of the matching algorithm, linking test cases to individual algorithm steps. Bug: 1148178 Change-Id: Ia2621bcdf151e22b4029cfde3dd9e319e5fb281e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533585 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#827079}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40e2a6830ac5..daab6896e293 2020-11-12 philipp.hancke@googlemail.com doc: port release notes 2020-11-12 natim@webrtc.org Delay VoipCore initialization. 2020-11-12 natim@webrtc.org Name change on channel and channel_id for consistency. 2020-11-12 titovartem@webrtc.org Add support for loopback route on emulated endpoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1663d5e29e226c77d2bb3ae9c88addb712d9ff4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535798Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827078}
-
Brandon Wylie authored
TBR=roagarwal@chromium.org Bug: 1148556 Change-Id: I95f5c7c0b246a119c4e7b5db6c5492f16cc521eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536089Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c6215e29d0ea..6a79629904ea 2020-11-12 tmathmeyer@chromium.org Add freezing score property, and fix Date crash If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id36e9aae1e11ec4edab413a45f755844ee2d5ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827076}
-
Caitlin Fischer authored
Bug: 1144791 Change-Id: I3e66d25b9b92dc9662c29a6f5ea5a1ce21dc91bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527890Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827075}
-
Maggie Cai authored
This CL extends the metrics expiry date for ChromeOS.Apps.ExternalProtocolDialog, ChromeOS.Apps.ExternalProtocolDialog.Accept, and ChromeOS.Apps.ExternalProtocolDialog.Rejected. BUG=1138256 Change-Id: I77d8fe378040c2448ee1d76f94b85a7c4674399b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533217Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827074}
-
Daniel Hosseinian authored
Implement a custom hasher for base::GUID so it may be used in standard hash containers. Bug: 1026195 Change-Id: I4a6315b21543e374b7eb6e8863b0afc3ff57f334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533644 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#827073}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac95abdb4b12..420f7362d68a 2020-11-12 wenbinzhang@google.com [benchmarking] skip finding possible browser if it is found already If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1013630 Tbr: zhanliang@google.com Change-Id: I0880a9872ca13ba201b1ce66e7c721a0600c41b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827072}
-