- 26 Feb, 2018 40 commits
-
-
Koji Ishii authored
20 rebaselines for image failures from a manual review of the ToT bot result at: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/3954/layout-test-results/results.html TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I04454fc301af31a723a93e1fe2ba78a7d920d0aa Reviewed-on: https://chromium-review.googlesource.com/937742 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539234}
-
Marijn Kruisselbrink authored
This API can be used to replace download_to_file functionality in the network stack (currently only used by XHR) by letting blink instead pass the data pipe that is the result of fetching some data to the blob system. Bug: 754493, 712693, 791702 Change-Id: I75c5289a6e7e7823e32838d9ada76d74028d8e40 Reviewed-on: https://chromium-review.googlesource.com/916731 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#539233}
-
https://pdfium.googlesource.com/pdfium.git/+log/1dbea185e709..9141116074f9 $ git log 1dbea185e..914111607 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 dsinclair Fixup AFSimple_Calculate indexing bug Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9bbbfc27d5877342a1a0413390e559d9f29a14d6 Reviewed-on: https://chromium-review.googlesource.com/937885 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539232}
-
Robert Flack authored
ScrollAnimator continues to call ShouldUseIntegerScrollOffset and UpdateScrollOffset indirectly through the base class ScrollableArea. Bug: 815135 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I495f8ae408022b4e170b17b4392480224cd8114e Reviewed-on: https://chromium-review.googlesource.com/935041Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539231}
-
Patrick Noland authored
1) Fix crashes caused by premature/forbidden usage of javascript. Given that we don't need or want to produce a real exception, this is accomplished using DummyExceptionStateForTesting. 2) Add checks for layoutBox() truthiness. 3) Save the relative offset in FindAnchor so that it updates properly. 4) Make the implementation work nicely with root layer scrolling by adding RestoreAnchor to ScrollableArea, implementing it on PaintLayerScrollableArea, and calling restore on the view's LayoutViewportScrollableArea. Bug: 810161,810897,810474 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I820e572cef543ed85156622fd574684109488eec Reviewed-on: https://chromium-review.googlesource.com/922384 Commit-Queue: Patrick Noland <pnoland@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#539230}
-
Lei Zhang authored
Change-Id: I395f06f8c709c56c2e69e4a0706b437c51ec2ed7 Reviewed-on: https://chromium-review.googlesource.com/935265Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#539229}
-
Wez authored
This test flakily hangs, appearing to live-lock in a worker-thread creation/teardown cycle. TBR: gab Bug: 816575, 810464 Change-Id: I22c42740a2e9af229400bc2da077ae962a287804 Reviewed-on: https://chromium-review.googlesource.com/937984Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539228}
-
rbpotter authored
Cache the sticky settings until the destination capabilities are known. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic7b11b3e8cb1378a9d5c5f62f5e7d2d96c82ea70 Reviewed-on: https://chromium-review.googlesource.com/935082 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#539227}
-
Jialiu Lin authored
e.g. "Google password" instead of "google password", make the occurences of "users" and "the user" more consistent. b/73625708, b/73611799 Bug: 804490 Change-Id: I6313787f940230a228e7b66476ab49949cf4be9b Reviewed-on: https://chromium-review.googlesource.com/929343 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#539226}
-
Torne (Richard Coles) authored
sandboxed_service_extra_flags is only used to set visibleToInstantApps=true, which should always be true for both WebView and Monochrome. Just set the attribute in the manifest directly and remove the variable entirely to simplify the configuration and remove the possibility that someone makes a new target which forgets to set it (since the breakage caused by not setting this is subtle and easy to miss). Bug: 797014 Change-Id: Iec2075c23c4e71302a10d1f15b83b290618f1a32 Reviewed-on: https://chromium-review.googlesource.com/920262Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539225}
-
Ryan Landay authored
In StackLayout, which implements the Android tab picker, we currently have two places that implement essentially the same piece of logic for deciding whether a drag event should be interpreted as switching between the two stacks, or closing a tab in the current stack. Besides the redundancy making the code unnecessarily confusing, there are three other problems: - The inline logic in computeInputMode() computes switchDelta using x + dx or y + dy, but isDraggingStackInWrongDirection() uses x or y without the delta term. This introduces a small amount of judder when dragging a tab back and forth between the "swipe to close" and "swipe to change stacks" directions. - isDraggingStackInWrongDirection() always prohibits dragging if the horizontal movement is smaller than the vertical movement...even in landscape mode. This means swiping between stacks barely works in landscape mode (it only works if you put your finger on the other tab to start; this case works because it hits the "currentIndex != getViewportParameters().getStackIndexAt(x, y)" logic earlier in the method. - isDraggingStackInWrongDirection() is broken for RTL mode. This CL makes the code easier to follow and fixes these three problems. Change-Id: Idb507b75f2977859c561a93d13c7737dfd84b97a Reviewed-on: https://chromium-review.googlesource.com/935450Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#539224}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a0a9a1d..c1be8e2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3cba15d38a524ef3581f47a735ef349466308795 Reviewed-on: https://chromium-review.googlesource.com/937686Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539223}
-
Darren Shen authored
Add more property tests. Most test failures are because our Blink implementation for these properties are lagging behind spec. The only weird one is line-height, which seems to return 'normal' for negative values even though the spec doesn't say that anywhere. Bug: 774887 Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19 Reviewed-on: https://chromium-review.googlesource.com/936821Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#539222}
-
rajendrant authored
This metric tracks how long the user has to wait for a visible image to load completely. This metric will help understand how much delay does lazyload of images incurs users. Bug: 812684 Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9 Reviewed-on: https://chromium-review.googlesource.com/831530 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539221}
-
Adrienne Walker authored
These are all unused by gpu/config/gpu_driver_bug_list.json and so can be removed from the code. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie55daa02700f69b51c7e5c16bfc52962308b69be Reviewed-on: https://chromium-review.googlesource.com/935480Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539220}
-
Miguel Casas authored
This CL moves a few windows-specific files from //media/gpu to the (existing) //media/gpu/windows. I stumble upon these files while reading code during bug scrub. Run those commands in 15': $ git mv media/gpu/d3d11_* media/gpu/windows/ $ git mv media/gpu/dxva_* media/gpu/windows/ $ git mv media/gpu/media_foundation_* media/gpu/windows/ $ tools/git/mass-rename.py TBR=avi@chromium.org and sergeyu@chromium.org for the automatic path updates in gpu_main.cc and //remoting/ Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0eb8b8923d446a74c2e5c4e5cda8d1910d414355 Reviewed-on: https://chromium-review.googlesource.com/937569 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#539219}
-
Fredrik Söderquist authored
All the SVGGeometryElements share the same code-sequence for invalidation of attributes that define the geometric shape. Move this code to SVGGeometryElement::GeometryAttributesChanged. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I78eabe6245eff618dff810d7bcfc120b9a99f545 Reviewed-on: https://chromium-review.googlesource.com/931802Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539218}
-
Josh Karlin authored
If the last transaction in a Writers object is released, then free it. There is no need to wait for any pending cache writes or network reads to finish before truncating. Otherwise we wind up holding on to resources for far longer than necessary. Bug: 804868 Change-Id: I9480a801b0314c3be9d2aa4cbb579b96503ce638 Reviewed-on: https://chromium-review.googlesource.com/928845 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#539217}
-
Jacob Dufault authored
Bug: 809637 Change-Id: Ia3f111f1fc3840474be31150a1d3cb2028a28dc7 Reviewed-on: https://chromium-review.googlesource.com/919158 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#539216}
-
John Z Wu authored
This is needed because some keyed services need to be created using the recording browser state in areas of code where only the off the record browser state is available. Examples in //ios/web_view: 1. To share preferences in translate between incognito and non-incognito mode. 2. To share autofill data between incognito and non-incognito mode. This change also allows us to decouple CWVWebViewConfiguration from WebViewTranslateClient, which is needed to write unit tests for CWVTranslationController. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I284910979c799689110bab88ed101a703079506b Reviewed-on: https://chromium-review.googlesource.com/930335Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#539215}
-
Conley Owens authored
This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. We modify affected tests to handle the redirection appropriately, using either local_ntp_test_utils::GetFinalNtpUrl or search::IsInstantNTP. This reverts commit 01bea8ca. The previous commit triggered a new test failure in ExtensionURLRewriteBrowserTest.NewTabPageURLOverride, in which case we were wrongly anticipating a redirect to the local NTP. This commit does not alter the shared TestURLNotShown method, but only fixes the test directly affected by our change. BUG=802926,804055,808011,814545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia7735eee7beed3a49ecfcf9eeb8798539693c97a Reviewed-on: https://chromium-review.googlesource.com/931988Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#539214}
-
proberge authored
Bug: 812276 Change-Id: Ib5581eef0c5412c9ef9c157cf321efc964ace22f Reviewed-on: https://chromium-review.googlesource.com/927343 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
-
Joshua Peraza authored
CrashReportDatabase is being updated to hand out FileWriters instead of FileHandles when NewReports are created. This CL makes progress towards using that new interface. Bug: crashpad:206 Change-Id: I89cead94ede3b02ec076ab805a3e767317855076 Reviewed-on: https://chromium-review.googlesource.com/935744Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#539212}
-
Xi Cheng authored
Change-Id: I00bdabcef67870a2f145e8d4cae09243728eced4 Reviewed-on: https://chromium-review.googlesource.com/936473 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#539211}
-
Daniel Bratell authored
There is a PRESUBMIT test coming for include guards and these are some of the files that trigger that test. Both because of code outside the include guard (bug) and slightly wrong syntax for the #define (irrelevant). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I486fd56d6ef506064cda38504728771549ebc6fb Reviewed-on: https://chromium-review.googlesource.com/937709Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This CL implements most of the setKeyframes() algorithm from the web-animations spec[0]. The major missing piece is a lack of support for altering CSS transitions; adding that will likely require us to re-think the CSS transition stack. Bug: 799061 Change-Id: Ie82746681b499f774f26daecbaafa39e072ee40d Reviewed-on: https://chromium-review.googlesource.com/848037 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539209}
-
Kevin Marshall authored
Change-Id: I5858b7f7adf1b4fe8ed343a88132ae6a3af52f8f Reviewed-on: https://chromium-review.googlesource.com/937886Reviewed-by:
-
Mounir Lamouri authored
This CL works around the fact that cloning does not call the parser callbacks and the HTML specifications require the attribute to only have an effect when the element was created. There is unfortunately no notification that the element creation from `cloneNode()` happens so we instead rely on a callback meant for something slightly different. Bug: 811743 Change-Id: Ib7ac55088b9eaad23f9bce0cfc8366fec6fc5b0d Reviewed-on: https://chromium-review.googlesource.com/937504 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#539207}
-
Fredrik Söderquist authored
In preparation for passing/using an SVGResourceClient as the 'client', make sure the LayoutObject& is only used as a cache key by extracting and passing the object bounding box as a separate argument. Bug: 769774 Change-Id: I673ef74f2e65d645037a65d85e75846f37d3859b Reviewed-on: https://chromium-review.googlesource.com/931465Reviewed-by:
-
Matthew Jones authored
Previously onTabSwitcherTransitionFinished was only called when exiting the tab switcher. This change implements onOverviewModeFinishedShowing to call this method. BUG=710750 Change-Id: I1a34551a6cd93a54a9461441c25ce022144efa9e Reviewed-on: https://chromium-review.googlesource.com/929991Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Bailey Berro authored
This change removes an extra callback.Run() call in SmbFileSystem unmount(). BUG=chromium:757625 Change-Id: Iedc3eeadc28a50aca4ef5ead763eb19eda52dc1f Reviewed-on: https://chromium-review.googlesource.com/934979Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#539204}
-
Nico Weber authored
linux-win_cross-rel: Reenable most tests now that v8_use_snapshot defaults to false in 64-bit win/cross builds. crashpad_unittests remain disabled because crashpad still doesn't work in cross builds. Depending on impact on cycle time, I might re-disable browser_tests. Bug: 495204 Change-Id: I1623a80f26c0ff5ee775417b8045f7d0b64e7560 Reviewed-on: https://chromium-review.googlesource.com/937685Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539203}
-
John Abd-El-Malek authored
Add a check that network::URLLoader is only used by the browser process when network service is disabled. Bug: 814913 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7a3f7746491bdd2a6e65ea532af38147098a4c1a Reviewed-on: https://chromium-review.googlesource.com/936011Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#539202}
-
Morten Stenshorne authored
NG cannot always calculate the correct size of objects that are laid out by the legacy engine, so just lay them out if we need to know their size. The computed CSS width on a table may not end up as its used value, for instance. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iaa327ad21055d6c1af96241b5403193c8b4b5ba3 Reviewed-on: https://chromium-review.googlesource.com/937261Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539201}
-
Raymond Toy authored
Move the DelayNode, DynamicsCompressorNode, and GainNode tests to WPT. Manually verified that Firefox passes these texts, except for the no-dezipper tests which use suspend() on an offline context. The tests that weren't moved are Chrome-specific. Bug: 745778 Change-Id: Iea2d31fd556d51ddcd63e9d139e53f05732261fe Reviewed-on: https://chromium-review.googlesource.com/922544Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539200}
-
Chris Blume authored
The exact* same code shows up in RWHVA:: OnDeviceScaleFactorChanged() WasResized() InternalSetBounds() This patch refactors that code out to its own function. *There is one tiny difference, notifying the host of the resize or not. Bug: 814916 Change-Id: I9336d476a904930cd6a700ee0700d7685000c00c Reviewed-on: https://chromium-review.googlesource.com/932830 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#539199}
-
Theresa authored
The omnibox security icon and URL scheme weren't being updated correctly when loading an https page while another https load was still in progress. In addition to checking whether the security icon resource and http scheme emphasis has changed, we need to also check whether the location bar icon type has changed. BUG=816494 Change-Id: I18e01b329a475b44bea66d5b6568f015f3df1b03 Reviewed-on: https://chromium-review.googlesource.com/937656Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/534191e5068d..766143cf63df $ git log 534191e50..766143cf6 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 charliea Use normal platform/arch strings in BattOr binary dependencies Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I58831a69dd32cd657241487a45c2d617b1496974 Reviewed-on: https://chromium-review.googlesource.com/937648Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539197}
-
Alexis Hetu authored
Currently, ImageTransportSurfaceOverlayMac uses system gl functions instead of using functions from Chromium's gl bindings. The cl modifies the included files in order to solve this issue. The key change removing "ui/base/cocoa/remote_layer_api.h" and adding "ui/gl/gl_bindings.h". R=ccameron@chromium.org Bug: 517208 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic9a55b31e896ab9636655d806ce11f9fa622f3ca Reviewed-on: https://chromium-review.googlesource.com/937652Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539196}
-
Xi Cheng authored
This is a reland of issue 930368, which has a race condition with the following CL in the CQ: https://chromium.googlesource.com/chromium/src/+/6200d332518cd781f87ab86554bc71ff7a01ec4e%5E%21 This CL fixes the race condition by merging that CL. For chrome_switches.{h,cc}, this CL makes the following changes: 1) Remove function PowerOverlayEnabled() which is not used. 2) Remove function ExtensionsDisabled() which is not used. 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, which is the only call site. 4) Move them to lib "non_code_constants", as they don't contain any functions now. Now notification_helper can have a deps on lib "non_code_constants" rather than lib "constants", hence more lightweight. Bug: 734095 Change-Id: I2b5ca5ffa873537c8df21315cd0850b2433dbc4d Reviewed-on: https://chromium-review.googlesource.com/935826Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#539195}
-
