- 15 May, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35cefb8d8a2f..0273fdc65acb $ git log 35cefb8d8..0273fdc65 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 sullivan Move auto_triage to mark_recovered_alerts and correct logic. 2018-05-14 simonhatch Dashboard - Remove TestMetadata.monitored 2018-05-14 maxlg [CSMMerging] Refactor breakdown_tree_helper with findEmptyRangesBetweenRanges Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I335c37e39c62372c30aac7bf4d9076e18812fc61 Reviewed-on: https://chromium-review.googlesource.com/1060103Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558808}
-
Sergey Volk authored
This reverts commit c2b04a4c. Reason for revert: Caused Cast build break Original change's description: > Access UpdateManager via getInstance(). > > This API changes in AT O. > > Bug: internal b/77915277 > Test: Compile > Change-Id: Id3c651378d9ac12319cd5aa437e9c56d48ea3096 > Reviewed-on: https://chromium-review.googlesource.com/1033472 > Commit-Queue: Doug Horn <doughorn@google.com> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558312} TBR=halliwell@chromium.org,doughorn@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/77915277 Change-Id: I9bdb2c5c4a7c841fe26b2b5d212ebb32c6a544a2 Reviewed-on: https://chromium-review.googlesource.com/1059952Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#558807}
-
George Burgess IV authored
This CL turns AFDO on for official builds of Linux. This appears to be a <0.5% binary size regression, and should grant a pretty solid performance gain. This CL is also expected to increase build times of official builds by around 12% (wall and CPU time). A memory usage increase of around 210-225MB per TU is also expected. Depends on install-build-deps.sh change in r557698; it was re-run on bots in crbug.com/841983, and devs were asked to update in "FYI: Linux builds of Chromium need to run install-build-deps.sh after #557698". Bug: 805098, 821595, 837025 Test: See issue 821595 for perf reports. Change-Id: I9eafad1d20b897e77566de423f29c11cc8c13e83 Reviewed-on: https://chromium-review.googlesource.com/1025132 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558806}
-
David 'Digit' Turner authored
This is an attempt to fix the random crashes that happen in the crazy::RDebug::WriteLinkMapField() function on some devices (for more context, see related bug below). It is very hard to understand why these crashes happen, the best candidate hypothesis so far is that both the crazy linker and the system linker try to modify the same area of memory at the same time (the global _r_debug link-map list, see technical note in crazy_linker_rdebug.h for all details). This CL tries to reduce the occurence of such events by better synchronizing modifications performed by the system linker, and the crazy one. This is done by the following steps: - Create a new global mutex, and associated convenience class, used to synchronize modifications to the global _r_debug link map list. See Globals::ScopedLinkMapLocker. Before the CL, only *explicit* modifications to the list were synchronized through the global crazy lock, but this did not protect against other threads from native code that call the wrapped dlopen(), which end up calling the system ::dlopen() which may also modify the list. These explicit modifications would typically happen after the library was loaded, due to the fact that they are applied by a delayed callback running on the UI thread, not the thread that loaded the library. Ironically, this delayed callback scheme was introduced to try to reduce these kind of random crashes. We may consider removing it entirely if this patch doesn't fix the situation. - To solve this, wrap all calls to the system linker through a new convenience class: crazy::SystemLinker. And ensure that each call that may change the global list will properly lock/unlock the link map mutex. - Incidentally, this allows making the global crazy mutex non-recursive. + Initialize the RDebug instance properly when its GetAddress() method is called. Otherwise, it could return a nullptr value in certain cases. This was not an issue in practice, since it was only used to update the DT_DEBUG entry of a crazy-loaded library, which technically isn't used by anything at runtime (e.g. GDB would find the value from the executable image instead, not from one of the shared libraries already in the list). BUG=831403 R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org, lizeb@chromium.org Change-Id: I6aa5f622908fc56deb37825ffed4a816ec6e4cc2 Reviewed-on: https://chromium-review.googlesource.com/1059516 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#558805}
-
Charlie Andrews authored
Bug: 842232 Change-Id: I6c00da413a8e1138f62ff578224aa0d1a2e2f599 Reviewed-on: https://chromium-review.googlesource.com/1060122 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558804}
-
Min Qin authored
If the server doesn't support partial responses, Chrome should cancel parallel download requests. These requests result in the wrong write offset and makes the file larger than the original This is a Reland of the original CL. That CL fails because the BrowserTests need to wait for the 2 cancelled requests, or tsan bots will complain. There is no good way for ParallelDownloadJob to report cancelled requests. So this CL uses the histogram to check if 2 failed AddStream attempt was conducted. BUG=838627 Change-Id: I856f31c23f2f08ed63e761656b0ed7fc6d6addc4 Reviewed-on: https://chromium-review.googlesource.com/1055852 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558803}
-
Steven Bennetts authored
Bug: 836362 Change-Id: I677cffed597ce6dc50247916055bd3182d4a206e Reviewed-on: https://chromium-review.googlesource.com/1041567 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558802}
-
John Z Wu authored
Clients of //ios/web_view may wish to show a little icon to represent the network of the credit card. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8d35f18187f352529e8f47c33ddfe94b13ff7e81 Reviewed-on: https://chromium-review.googlesource.com/1058368Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#558801}
-
Joe Downing authored
Per UX feedback, we should not show [esc] in the context menu when we know that press and hold is required to exit fullscreen. This change updates the context menu to query the current keyboard lock state to handle that scenario. BUG=680809 Change-Id: Iea80d64b0c3f905521f9bf07473b6b26791fa042 Reviewed-on: https://chromium-review.googlesource.com/1055659Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#558800}
-
https://webrtc.googlesource.com/src.git/+log/28a325b52314..ef75ebef5520 $ git log 28a325b52..ef75ebef5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I25d85077e5e71a907aa4468888a5e6d1bc9e745b Reviewed-on: https://chromium-review.googlesource.com/1060099Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558799}
-
Hwanseung Lee authored
change highlight tab color to GB 600 in Clear Browsing Data, Manage certificates. and also drop the uppercase from Certificate manager's tabs to keep consistent. Bug: 842010 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I060112a47e9feac1ccba6b9dc20b48d4ca6843d0 Reviewed-on: https://chromium-review.googlesource.com/1055229 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Pavol Marko authored
If FRE is not performed, and initial enrollment is enabled according to command line flags and device state, performs initial enrollment check. Specifically, the initial enrollment check is done if all of the following conditions are true: - the device was not enterprise enrolled or in consumer mode before (according to the check_enrollment VPD variable) - the RLZ embargo date has passed (to ensure not to do initial enrollment exchanges on the factory floor) - Initial enrollment is enabled usinga command-line switch - serial number and RLZ brand code are available. Bug: 839353 Change-Id: I259c06a5e5274f3bdef54ccc0161e6f642f9499f Reviewed-on: https://chromium-review.googlesource.com/1052707Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#558797}
-
Steven Bennetts authored
This also eliminates a few unnecessary includes. Bug: 798569 For c/b/chromeos/policy DEPS changes: TBR=emaxx@chromium.org Change-Id: I80a73a68819f0295f9c81b910467c6e38dd2571e Reviewed-on: https://chromium-review.googlesource.com/1041568 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#558796}
-
Dirk Pranke authored
In order to roll GN 0fbf0789..ccbeab67 (r555198:r558753) and pick up the following changes: 443b70db Fix GN doc formatting. e8a3ce91 GN: do not make indirect dependency to direct dependency ea15ea06 Fully move PathService into the base namespace. ae62ba99 GN: Make the linker output file depend on the inputs. 629ba73c [MessageLoop] Fix message_loop.h includes TBR=brettw@chromium.org Change-Id: I982bbe01bad86a66e7aed379ee1155bdfaa76ff8 Reviewed-on: https://chromium-review.googlesource.com/1060095 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558795}
-
Ria Jiang authored
When we do async hit-testing for OOPIF, we can be trying to do hit-testing when the local main frame is not valid anymore. Add null check for that and return empty hit-test result in that case; it would then be handled in RenderWidgetInputHandler::GetFrameSinkIdAtPoint [1]. [1] https://cs.chromium.org/chromium/src/content/renderer/input/render_widget_input_handler.cc?type=cs&g=0&l=194 Bug: 842458 Change-Id: Ic6a90de54840973a8262ea88472ae9d295c6f773 Reviewed-on: https://chromium-review.googlesource.com/1058343Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558794}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=satorux@chromium.org Change-Id: I98e6da904435d11a232ccc554c1005df11cd2b7f Reviewed-on: https://chromium-review.googlesource.com/1059458 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558793}
-
John Z Wu authored
These resources were only bundled but not yet loaded. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2bf6ed5d04a12bc5a03dfc001061eb032941d8f3 Reviewed-on: https://chromium-review.googlesource.com/1058346Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#558792}
-
Weidong Guo authored
Background: Folder item's metadata (including position) is retrieved via syncable service and is set to the folder item. But the item's index in item list is not updated based on the metadata. Change: Update the index in item list if position in the metadata changes. BUG=842420 Change-Id: I27f67bf37a451f90c4d7654dac9152ea500bfd8d Reviewed-on: https://chromium-review.googlesource.com/1056064Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558791}
-
Lukasz Anforowicz authored
Bug: 842999 Change-Id: I97a64b1aa77c2991e0b20e80e985cbd4f7012e02 Tbr: tedchoc@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1060108 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#558790}
-
Vasilii Sukhanov authored
Previous attempt: https://chromium-review.googlesource.com/c/chromium/src/+/1054675 This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. They are interactive UI tests because actual typing is involved. Bug: 842643 Change-Id: I81e8f444374012272433e514d12d398d850a15b9 Reviewed-on: https://chromium-review.googlesource.com/1059627 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558789}
-
Evan Stade authored
Refactor code and share most of it by moving into FrameHeader superclass (which is no longer just an interface). Reduce code duplication and improve the chances the implementations will stay in sync. Bug: none Change-Id: I09d3ba209e9351c0c1980c35660212f7c1b7a96f Reviewed-on: https://chromium-review.googlesource.com/1053116Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#558788}
-
Mike Bjorge authored
Fix inconsistent variable names and pass missing paramaters to functions. Change-Id: I6eb4bed6a9fd77b820594b4ac1d5719207cd38b8 Reviewed-on: https://chromium-review.googlesource.com/1057906Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#558787}
-
Pete Williamson authored
To share a temporary page, we use a content: URI instead of a file URI so that we don't need to publish the page to the download directory. Bug: 758733 Change-Id: I873756591fc29537fa1290a0153980f1135db04b Reviewed-on: https://chromium-review.googlesource.com/1056214 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#558786}
-
Matthew Jones authored
Scrim visibility in the location bar is now completely controlled by a single function. The scrim observer is now added and removed based on the scrim visibility to avoid conflict with other observers (like the bottom sheet). Bug: 834927 Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d Reviewed-on: https://chromium-review.googlesource.com/1026168 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#558785}
-
Dan Sanders authored
Bug: 522298 Change-Id: I0450f150aed0c84935b1355f849331d97ed17ab2 Reviewed-on: https://chromium-review.googlesource.com/1056325 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558784}
-
Fernando Serboncini authored
Bug: 742360 Change-Id: I49c21ea926e8c228986dc041108ca7b9449966c5 Reviewed-on: https://chromium-review.googlesource.com/676088Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558783}
-
Hans Wennborg authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1059655 they should pass. Bug: 842698 Change-Id: Ia986149f107ba7d8de203aa5cf6f69e560008655 Reviewed-on: https://chromium-review.googlesource.com/1059656Reviewed-by:
-
Fady Samuel authored
In order to synchronize top/bottom bar controls with web content we need to allocate a new LocalSurfaceId on the impl thread whenever the renderer compositor wants to reposition them. This CL does so. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1cf41134ecaefa9df963769725b1af86c7739435 Bug: : 672962 Reviewed-on: https://chromium-review.googlesource.com/1058311 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558781}
-
kapishnikov authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6f6ce3b6bb80481c5862d44d36b7cb8590c57870 Reviewed-on: https://chromium-review.googlesource.com/1059730 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558780}
-
David Black authored
Changes include: - Stopping interaction on widget close (fixes ESC key bug). - Stopping interaction on input modality change (if not voice). Bug: b:79441527 Change-Id: I99e3de5ac8967e79a81bfbe1733da99df52ed03f Reviewed-on: https://chromium-review.googlesource.com/1052430 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 842995 Change-Id: Ia322131520ba004da8b6ab1e8c4c749971625006 Tbr: foolip@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1060024Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#558778}
-
Mark Pearson authored
Change-Id: Ifb8cc02dc6d7cd3379316e52f51b6b3303451b03 Reviewed-on: https://chromium-review.googlesource.com/1057996Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558777}
-
Rohit Rao authored
When the BookmarksUIReboot flag is enabled, uses TableViewPresentationController to present Bookmarks in the UIRefresh style. BUG=843108 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I036d6897ec99437707abc09c550da7e63ae7a028 Reviewed-on: https://chromium-review.googlesource.com/1059716Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#558776}
-
Sorin Jianu authored
Since the migration to the new urls has been completed, this change removes the deadcode. Bug: 685897 Change-Id: I1d3262cb857c4bc7d014bbd67161bdc751b300ad Reviewed-on: https://chromium-review.googlesource.com/1056088Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558775}
-
Navid Zolghadr authored
Measure the scrolling performance regardless of whether touch or wheel input triggered the scrolling. Bug: 842846 Change-Id: I04750f3537f4da326e9a2f3c0e16e895bc696c2a Reviewed-on: https://chromium-review.googlesource.com/1059583Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558774}
-
spqchan authored
Bug: 843180 Change-Id: I81b3bbfcf9f5762661e836a3bb69df48df6b061f Reviewed-on: https://chromium-review.googlesource.com/1059939Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558773}
-
Bence Béky authored
Bug: 819101 Change-Id: Ice48803d024d75ea1ea0311b098df29de25a4c63 Reviewed-on: https://chromium-review.googlesource.com/1057453Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558772}
-
Stephen Lanham authored
This wil help Chromium reviewers target the right folks for Android changes more quickly. BUG= Change-Id: I9ddabaafe79074202560bf02df7911abe47b19a9 Reviewed-on: https://chromium-review.googlesource.com/1059582 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
-
Ricky Liang authored
Fix an out-of-bound memory access bug in unit tests. Original change's description -------------------------------------------------- media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice This CL implements the TakePhoto() API for the Chrome OS camera HAL VideoCaptureDevice, including the following features: - Full size still capture - Auto-focus, auto-exposure, and auto-white-balancing stabilization BUG=chromium:832772 TEST=Run capture_unittests on DUT TEST=Make sure TakePhoto() API works on https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html TEST=Run capture_unittests on host with asan and lsan build TBR=wuchengli@chromium.org,emircan@chromium.org Change-Id: Ieafc98e07bbc39ac64347eea76baa3a496c0c775 Reviewed-on: https://chromium-review.googlesource.com/1059915Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558770}
-
Ria Jiang authored
To prepare for VizHitTestDrawQuad finch trial in beta, we need to add a field trial config which would enable VizHitTestDrawQuad feature by default in all perf bots and browser tests [1]. This CL explicitly disables VizHitTestDrawQuad feature in one of the test configs in SitePerProcessHitTestBrowsertest and PDFExtensionHitTestTest so we can still test both with and without VizHitTestDrawQuad feature before VizHitTestDrawQuad is turned on by default. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1053907 Bug: 804888 Change-Id: I42265f3c6249eb1c2b1c5c74a2e2b2fddfa35455 Reviewed-on: https://chromium-review.googlesource.com/1059699Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558769}
-
