- 13 Apr, 2018 40 commits
-
-
Christos Froussios authored
When the user selects a different password value in the password bubble, that is a signal that we detected the password field wrong. We now update the |password_element| of the pending |PasswordForm| which produces a vote uploaded to the autofill server with the password element which contains the selected password value. Since password_element is part of the password store key, updating it is possible by removing the old entry first. The new element name is stored in the |password_element| field. This conflicts with an obsolete feature, where we would use the element name to autofill. I changed the obsolete code where it conflicted with crowdsourcing. Change-Id: If14831da442eab3120d497c0643acf2e580b8b44 Reviewed-on: https://chromium-review.googlesource.com/941522 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550557}
-
Kenichi Ishibashi authored
ShouldBypassCacheDueToUpdateViaCache() is moved to ServiceWorkerUtils so that we can use the function in S13nSW code path. This fixes test failures in - http/tests/serviceworker/chromium.update-served-from-cache.html - external/wpt/service-workers/service-worker/registration-updateviacache.https.html Bug: 831998 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iff73827268f37b4fa2aa5826ff153bd92b3a3c92 Reviewed-on: https://chromium-review.googlesource.com/1011527 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550556}
-
Boris Sazonov authored
This CL changes to package-private the access level of getters for view elements in SigninView. Constructor has to stay public, as this class is instantiated by LayoutInflater. Bug: 814728 Change-Id: I91cbaa1c46917573ec0ead17d4ed50f161f544bb Reviewed-on: https://chromium-review.googlesource.com/1010289Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550555}
-
Bence Béky authored
Move four methods: GetSSLCertRequestInfo(), GetChannelIDService(), GetTokenBindingSignature(), and GetChannelIDKey() from SSLClientSocket to its base class's base class, StreamSocket. Also make GetSSLCertRequestInfo() const. Provide dummy implementations, with NOTREACHED(), in base class, to make it less painful to implement a new derived class. Remove 11 accounts of static_cast<SSLClientSocket*>(StreamSocket). The only remaining invocations are within SSLClientSocketImpl. Bug: 826713 Change-Id: I1f87d31204b95687e6552b7d6f02578de4321eaf Reviewed-on: https://chromium-review.googlesource.com/1010106 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#550554}
-
Mirko Bonadei authored
TBR=phoglund@chromium.org Bug: webrtc:8821 Change-Id: Iab26c960b3d5d796943deaf09edd2c5bd36a67ba Reviewed-on: https://chromium-review.googlesource.com/1011610Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550553}
-
Mirko Bonadei authored
Bug: webrtc:8821 Change-Id: I491118ef06695897f001a27ccd296501cf6b72d7 Reviewed-on: https://chromium-review.googlesource.com/1011608Reviewed-by:
-
Mirko Bonadei authored
WebRTC trybots are detecting more ODR violations in dynamic_annotations: https://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/27341 Bug: webrtc:8821 Change-Id: I2cfa4770b6dbfdb3419431d72de914f5a538fd82 Reviewed-on: https://chromium-review.googlesource.com/1009912 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL decouples the keyboard accessory from the suggestions. There is no visible change yet as suggestions will remain part of the accessory for now. They are not part of the MVP and might become optional/feature-guarded later. The main purpose of this CL is, that the existing accessory can exist without having to have suggestions to fill. Side-effects: - Deflaked the tests (mainly for emulators) a little bit. - Maybe improved the RTL difficulties (I intend a second pass when taking care of crbug.com/729916). Bug: 828832 Change-Id: I5baca03e93a04b174f3a36156b604b0c80f302b1 Reviewed-on: https://chromium-review.googlesource.com/998101 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550550}
-
Hwanseung Lee authored
unprefixed versions of the "grab" and "grabbing" CSS cursors were not supported at blink. so we should check how many use prefixed values before retire that values. and i will make another patch to support unprefixed values parallelly. Bug: 708197 Change-Id: Ic882d9d6d5bc18724f3802c8ab2336668074f17d Reviewed-on: https://chromium-review.googlesource.com/1011883 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550549}
-
Yuta Kitamura authored
The class now supports NonMainThreadScheduler, so its name should also be changed. File names are also updated. Bug: 826203 Change-Id: I49c08a359db10d28db5db434b8db5e5b0c985e6f Reviewed-on: https://chromium-review.googlesource.com/1011862Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#550548}
-
Ramin Halavati authored
Bug: 831566 Change-Id: I020d3829eeeb4fff098efaf751465fdc21e9edb4 TBR: chcunningham@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1011612Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550547}
-
Mirko Bonadei authored
This CL adds GCC compiler flags to the main absl BUILD.gn file. Before this CL, clang flags were used also on GCC. TBR=phoglund@chromium.org Bug: webrtc:8821 Change-Id: I9d84f03e5e6986d0b5fce836bd90057437029d8c Reviewed-on: https://chromium-review.googlesource.com/1011603Reviewed-by:
-
Christopher Cameron authored
Whenever the TextInputManager::TextSelection or the TextInputManager::CompositionRangeInfo properties of the RWHVMac change, forward them to the RWHVCocoa. This is in contrast to the previous behavior where we would do a synchronous IPC back to the RWHVMac to query their value. This is motivated by the attributedSubstringForProposedRange method in RWHVMac, which would be complicated to implement by a synchronous IPC. Remove RWHVCocoa's selectedRange_ member because it is now fully redundant to the cached copy of the selected range. Leave RWHVCocoa's markedRange_ member because it is not always equal to the cached copy of the composition range. While converting attributedSubstringForProposedRange, fix an overflow bug, and remove some roll-your-own NSString<->base::string16 conversions. Rename ClearMarkedText to CancelComposition. Bug: 821651 Change-Id: Ieace82d061f15c510762d37e110c70b10eeb2bde Reviewed-on: https://chromium-review.googlesource.com/1007981 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550545}
-
Christopher Cameron authored
The stability issues in 10.13's earlier releases appear to have been fixed in 10.13.4. Bug: 773705 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib483847c6b8b8779448b6d47d5ab3cd6a72d2c34 Reviewed-on: https://chromium-review.googlesource.com/1011252Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#550544}
-
Mark Cogan authored
This Cl fixes two problems that can occur when the OTR tab model is replaced. First, when the last incognito tab is closed, the tab grid should have its OTR tab model set to nil so it can stop observing the OTR web state list. Second, MainController should set _tabSwitcher to be the TabGridAdaptor as soon as its created, not when the tab switcher is displayed. This CL also has the TabGridCoordinator stop keeping pointers to tab models after it has created mediators. Bug: 831594 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61f674bde5d2a64645b8ccb7ed1129b6801eddcc Reviewed-on: https://chromium-review.googlesource.com/1010288Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550543}
-
Alexandr Ilin authored
This CL eliminates attachment water mark resetting and all code that uses it. This is done in order to allow passing objects owning descriptors through the IPC. This breaks support of reading messages with attachments from the IPC::TestSink that were already read before. This was used only in PrintRenderFrameHelperPreviewTests which were fixed. Note to sheriffs: This CL may break some untested code in NaCl; please revert in that case. Change-Id: Ib6f02f067a96c6c34a8f5404ebc867459e9d79cc Reviewed-on: https://chromium-review.googlesource.com/998102 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550542}
-
Yoshifumi Inoue authored
This patch changes "5131716-[1-6].html" to utilize |selection_test()| for ease of maintenance. Since "5131716-[1-6].html" does similar test steps, this patch integrates them into "5131716-1.html". Following patch will rename "5131716-1.html" to "click_edge.html" to provide a hint what this file tests. Bug: 679977 Change-Id: Idb9cd05933e0bea61f46592060ef2088d784a04a Reviewed-on: https://chromium-review.googlesource.com/1005651 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#550541}
-
Boris Sazonov authored
This CL dynamically hides and displays TextView in AccountPickerDialogFragment depending on whether the full name is available for an account. It also changes the layout structure to make sure that all elements are properly positioned when full name is not available and the secondary TextView is hidden. Bug: 814728 Change-Id: I7fffec089a7ee3f72d31a89211ebaefc46d192a7 Reviewed-on: https://chromium-review.googlesource.com/1010484Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550540}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0ec09a1ffe81e87f1f06e025a34c0c71d2c5acbe Reviewed-on: https://chromium-review.googlesource.com/1011568Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550539}
-
Malay Keshav authored
This patch performs multiple tasks: - Add EVIOCGPHYS field to EventDeviceInfo and plumbs it to InputDevice. - Adds a secondary identifier to TouchDeviceIdentifier that corresponds to the phys(or port) information of the device. - Add support for TouchDeviceManager to manage devices with same ID by using their port information. - Persistently stores the port mapping for each device in case of duplicate ID. Adds and updates unit tests. Bug: 827452 Change-Id: Ia224cd35125615705d1b94a13c4c0afa2bd25182 Component: TouchDeviceManager, EventDeviceInfo, InputDevice Reviewed-on: https://chromium-review.googlesource.com/1000548 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550538}
-
Rob Percival authored
The old histogram, "DnsQueryStatus", summarised the net::Error codes as a handful of enum values. This was unhelpful when a recent Finch experiment found that 75% of all queries were failing for reason "unknown". By recording the actual net::Error code, hopefully a little more light will be cast on the actual reason for the failures. Two histograms will be used - one for failures while obtaining the leaf index, and the other for the result of obtaining the audit proof. Bug: 506227 Change-Id: If143056dd284598b31152d57a41d5a86a9c53408 Reviewed-on: https://chromium-review.googlesource.com/1010483 Commit-Queue: Rob Percival <robpercival@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550537}
-
Esmael El-Moslimany authored
Bug: 711156 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I45c797eb4b653a9ae1c5a181b855595b9853d89f Reviewed-on: https://chromium-review.googlesource.com/1002861 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550536}
-
Karan Bhatia authored
By default, all unpacked extensions are granted file access. However, if the extension did not request scriptable or host permissions for the same, we don't show the "Allow access to file URLs" checkbox for the extension on the chrome://extensions page. This CL resolves this discrepancy by modifying the condition to show the file access checkbox, to also take care of the unpacked extension case. BUG=830112 TEST=Load an unpacked extension on chrome with no host or scripting permissions. Open chrome://extensions. Ensure that "Allow access to file URLs" checkbox is shown for the extension and is checked. Do this both for the old and the MD Extensions page. Change-Id: Idbb1deae88448f390576fb39ed18876314848f13 Reviewed-on: https://chromium-review.googlesource.com/1006196 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550535}
-
François Beaufort authored
This CL makes sure a video player in Picture-in-Picture doesn't get paused because of background video tracks optimization. Bug: 806249, 663999 Change-Id: Ia3453000a9107d28974428c1ab004227370dc28f Reviewed-on: https://chromium-review.googlesource.com/1008082Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#550534}
-
Maria Khomenko authored
We've seen multiple crashes in autocomplete code that point to timing mismatches in Java state of autocomplete and C++ state for autocomplete results. Specifically, we indicate user-chosen results via an index into the result list, which may get updated. Ensure that any result used on C++ side is matching the java result we wanted to select. Added a histogram to figure out how often mismatches occur. This can guide us to overhaul the implementation to fix this problem (if happens a fair bit) or remove this checking (if never happens). Bug: 818761 Change-Id: I9123e22404d10f87da4cf039e0a6e49922d02d7f Reviewed-on: https://chromium-review.googlesource.com/1008410 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Greg Thompson authored
Windows does not necessarily change the last-modified time of files that are modified via a r/w file mapping. This CL explicitly sets the last-modified time on PE files (.exes and .dlls) modified by alternate_version_generator.exe. This is significant because it appears that the Windows loader does some caching of data about an .exe and doesn't flush this cache if a new file with the same last-modified time as an old file appears. This caused Chrome launches to fail with STATUS_OBJECT_NAME_NOT_FOUND (0xC0000034). BUG=461856 R=huangs@chromium.org, mmeade@chromium.org Change-Id: Ic0e0f68ef9ca62e02bb828267352c2f7052ff908 Reviewed-on: https://chromium-review.googlesource.com/1009705 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#550532}
-
Xiaocheng Hu authored
This patch adds ToPositionInDOMTreeWithAffinity() and ToPositionInFlatTreeWithAffinity() to make PwA conversion easier. It is also a preparation patch for adding NG line functions. Change-Id: I4a802a183288fb7a1003ac9cf6e02fe7cad1d4a5 Reviewed-on: https://chromium-review.googlesource.com/1011392Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This is a preparation CL for enabling to establish WebSocket connections off the main thread. Before this CL, WebSocketSafeBrowsingThrottle is created by ChromeContentRendererClient::CreateWebSocketHandshakeThrottle(). This prevents the off-main-thread WebSocket because the function is bound with the main thread (render thread) and the throttle cannot be created from both the main thread and worker threads. To avoid it, this CL makes a new path to create the throttle in a thread-safe way. Specifically, this introduces WebSocketSafeBrowsingThrottleProvider that is created on the main thread, passed to a worker thread, and then provides the throttle on the thread. DocumentWebSocketChannel[*] accesses the throttle provider via FrameFetchContext/WorkerFetchContext. After this CL, WebSocket for Document and DedicatedWorker go through the new path by default. However, WebSocket for SharedWorker and ServiceWorker still go through the old path via WorkerShadowPage. This will be switched to the new path when the runtime flag is enabled. In addition, to test the new path, this CL makes safe_browsing_service_browsertest run with the off-main-thread WebSocket flag. [*] Although it's prefixed with "Document", DocumentWebSocketChannel is used for workers when the off-main-thread WebSocket is enabled. It'll be renamed to WebSocketChannel etc after the new architecture is enabled by default. Change-Id: If9e64e3291ab86ee4c836a66afede1fde9b24789 Bug: 825740 Reviewed-on: https://chromium-review.googlesource.com/985334 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#550530}
-
tzik authored
This removes 'use_once_callback = false' flag from BUILD.gn from cr/br/engagement, and fixes all implementations of the interface. Tbr: tommycli@chromium.org Bug: 714018 Change-Id: Ic139ba25eb020caa384735292ee62ddfb1272ba9 Reviewed-on: https://chromium-review.googlesource.com/1002220 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#550529}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1c21a5af2ec..53a115e67e50 $ git log b1c21a5af..53a115e67 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 asanka Add a '--inject-current' option to 'git new-branch' 2018-04-12 petermayo Remove petermayo from OWNERS 2018-04-03 ehmaldonado Reland "presubmit support: Run all tests in parallel." 2018-04-12 ehmaldonado gclient: Don't parse DEPS files that we won't recurse into. Created with: roll-dep src/third_party/depot_tools BUG=chromium:819774,chromium:830306 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9f5c9eed3ed2ee72ff566d0ff08f6e751e4d89d8 Reviewed-on: https://chromium-review.googlesource.com/1011301 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550528}
-
Darren Shen authored
Known failures: - all: computed value is always "", it should compute to something... - animation-name: <custom-ident> not mentioned in typed om spec. - cursor: 'grab' and 'grabbing' are still webkit prefixed. - list-style-type: Blink implements something different to the spec. - page: computed value is always "", <custom-ident> not mentioned in typedom spec - perspective: '0' seems to compute to none. - perspective-origin: Blink doesn't support 'none' keyword - quotes: computed value is always "" - size: computed value is always "" - speak: Blink implements something different to the spec. - transform-box: Blink doesn't support 'border-box' keyword - z-index: computed value is always 'auto' (might be something to do with stacking context) Bug: 820299 Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2 Reviewed-on: https://chromium-review.googlesource.com/1003434 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550527}
-
https://pdfium.googlesource.com/pdfium.git/+log/9e625db795ca..7afdad5ab7a1 $ git log 9e625db79..7afdad5ab --date=short --no-merges --format='%ad %ae %s' 2018-04-13 dsinclair Make CFX_XMLInstruction a subclass of CFX_XMLNode 2018-04-12 tsepez Add AsSpan() convenience method to fxcrt strings. 2018-04-12 thestig Rename one CPDF_Color::SetValue() variant. 2018-04-12 ralf.sippl Add index parameter to quadpoints getter and setter. 2018-04-12 thestig Make some CPDF_StreamContentParser methods const. 2018-04-12 thestig More CPDF_Color improvements. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9438b0696cafab79929cef2bd97329cc9b0d6d38 Reviewed-on: https://chromium-review.googlesource.com/1011298Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550526}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2c34b35c8b1..70bb7daa4183 $ git log d2c34b35c..70bb7daa4 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 pwang chromeos_config: kevin-arcnext in CQ/Android PFQ/Chrome PFQ 2018-04-12 laszio AutoFDO: more profile sources 2018-04-06 laszio afdo: refactoring to support multiple source of profiles Created with: roll-dep src/third_party/chromite BUG=chromium:829170,chromium:829170 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I725a6507963a3fa6e26222b62b5fddbcaffb6027 Reviewed-on: https://chromium-review.googlesource.com/1011822 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550525}
-
Ramin Halavati authored
Change-Id: I40593ec453e1cc5275703fa9d9fedc85528d4f32 Reviewed-on: https://chromium-review.googlesource.com/1010143Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550524}
-
Yutaka Hirano authored
As specified, RequestInit.body should be stringified, i.e., {toString(): () => 'hi!'} should be treated as same as 'hi!'. Bug: 831076 Change-Id: I4118c0faa9535d62b3db2529bf23716fdc25a997 Reviewed-on: https://chromium-review.googlesource.com/1004561Reviewed-by: -
Istiaque Ahmed authored
This is a reland of fef93a84 There is no change in the reland CL, the previous attempt collided with another CL that was reverted at 348808c0 Original change's description: > Extensions: Rename DictionaryBuilder::SetBooean -> Set. Same for ListBuilder. > > The overload resolution failure isn't any issue anymore after > https://chromium.googlesource.com/chromium/src/+/723fb47254fc5f49bda577df447303dc3554beb9, > so bool overload can be provided for DictionaryBuilder::Set and ListBuilder::Append. > > Bug: None > Test: Internal only change. > Change-Id: Id55283aeaa8868cf533f206b006c3c909a835df1 > Reviewed-on: https://chromium-review.googlesource.com/1009489 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550475} TBR=avi@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org Bug: None Change-Id: I2896a13c9421b1c08076bb5f756b7630f050c404 Reviewed-on: https://chromium-review.googlesource.com/1011711Reviewed-by:
-
Owen Min authored
It introduces new permission, IDL and skeleton of implementation. This privacy API is used to upload browsers and devices status that are collected by extension to the admin console. Bug: 826298 Change-Id: I60780d76c9e7680843acef38ce906e9cbe150025 Reviewed-on: https://chromium-review.googlesource.com/976819Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d969695. With Chromium commits locally applied on WPT: 47f17dae "[css-typed-om] Support offset-rotate." 2c0351ed "Allow feature policy to be used in opaque origins." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15488 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jfernandez@igalia.com: external/wpt/css/css-align yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: If94238ecb93e85e017a4ac9cff893b56249e1523 Reviewed-on: https://chromium-review.googlesource.com/1011120 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550520}
-
Trent Apted authored
They're currently backwards. Bug: 829974 Change-Id: I67440b14df2ad143e22741e4adf2b9055d4dd683 Reviewed-on: https://chromium-review.googlesource.com/1010057Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#550519}
-
Chris Harrelson authored
Bug:831762,783383 Change-Id: I3aea3afb2669f83f0d40674218c82a4f399b4e6f Reviewed-on: https://chromium-review.googlesource.com/1008270 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550518}
-
