GitLab

The toolchains now contain an up-to-date version
of thie header to its not longer needed here.

Review URL: https://codereview.chromium.org/666163004

Cr-Commit-Position: refs/heads/master@{#300534}

This is a simple search and replace:
  s/usage_mask/usages/g

There was some inconsistenty on when variables were called "usages" versus "usage_mask"; now they all read "usages".

Review URL: https://codereview.chromium.org/670773003

Cr-Commit-Position: refs/heads/master@{#300533}

BUG=401438

Review URL: https://codereview.chromium.org/644913006

Cr-Commit-Position: refs/heads/master@{#300532}

BUG=chromedriver:783

Review URL: https://codereview.chromium.org/613163004

Cr-Commit-Position: refs/heads/master@{#300531}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree. (Run on Linux, for the mojo
target.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/667223002

Cr-Commit-Position: refs/heads/master@{#300530}

Changes:
- r1991: Add (partial) support for assets catalog

BUG=415577

Review URL: https://codereview.chromium.org/667973002

Cr-Commit-Position: refs/heads/master@{#300529}

'X' delete button is now part of the focus order in the 'Manage search
engines' options page.

BUG=276874

Review URL: https://codereview.chromium.org/666823003

Cr-Commit-Position: refs/heads/master@{#300528}

BUG=

Review URL: https://codereview.chromium.org/661743004

Cr-Commit-Position: refs/heads/master@{#300527}

This patch adds a visible rect check for an early out from update
tile priorities.

The problem is that we can update tile priorities, then update
the visible rect in animation, and call update tile priorities
again. The second one would normally early out since it's called
in the same frame. This ensures the early out doesn't happen in
these cases.

BUG=423455
R=danakj, brianderson, enne

Review URL: https://codereview.chromium.org/667053003

Cr-Commit-Position: refs/heads/master@{#300526}

ByteCount(), rather than UnreadByteCount(), was being incorrectly used to
determine how to handle a size packet than needed a second byte.
ByteCount() includes read bytes, while UnreadByteCount() is the one that does
not. UnreadByteCount is the only one that should be used here. Fixed, and
added new tests.

BUG=424532

Review URL: https://codereview.chromium.org/643133003

Cr-Commit-Position: refs/heads/master@{#300525}

Assume 1 collated copy for print preview generation, the actual number of copies does not affect the generated PDF.

BUG=424514

Review URL: https://codereview.chromium.org/661083003

Cr-Commit-Position: refs/heads/master@{#300524}

Allow android build to include native client.  This CL removes the check
(on android only) that native client applications need to come from the chrome
web store.  It also fixes some inclusions of files that assert the extension
system is built in.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3032

Review URL: https://codereview.chromium.org/671573002

Cr-Commit-Position: refs/heads/master@{#300523}

BUG=chromedriver:916

Review URL: https://codereview.chromium.org/654713004

Cr-Commit-Position: refs/heads/master@{#300522}

Revert of Standardize usage of virtual/override/final in ipc/ (patchset #1 id:1 of https://codereview.chromium.org/645623006/)

Reason for revert:
Addressing reviewer comments in a followup patch.

Original issue's description:
> Standardize usage of virtual/override/final in ipc/
>
> This patch was automatically generated by applying clang fixit hints
> generated by the plugin to the source tree.
>
> BUG=417463
> TBR=agl@chromium.org
>
> Committed: https://crrev.com/39be52ebbd6681c7d79ad63e2a0ab028075af0c2
> Cr-Commit-Position: refs/heads/master@{#300481}

TBR=agl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417463

Review URL: https://codereview.chromium.org/669953003

Cr-Commit-Position: refs/heads/master@{#300521}

The next step is to fix crbug/423381 to improve
transitions from/to fullscreen after scrolling.

BUG=398485

Review URL: https://codereview.chromium.org/653633005

Cr-Commit-Position: refs/heads/master@{#300520}

Also adds changes for content_browsertests which share the
JavaScript files.

BUG=338830
TEST=new EME tests pass

Review URL: https://codereview.chromium.org/642813012

Cr-Commit-Position: refs/heads/master@{#300519}

The early exit watcher holds on to a reference to the waitable event which ChildProcessLauncher::GetChildTerminationStatus deletes, so it should be stopped first.

BUG=424024

Review URL: https://codereview.chromium.org/658253002

Cr-Commit-Position: refs/heads/master@{#300518}

I realized I used margin-right instead of the direction-neutral
-webkit-margin-end in the M40 fix, so the margin between
the About link and the search box will be too small in RTL.

This fix is already included in the M38 CL.

BUG=421236
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/655963005

Cr-Commit-Position: refs/heads/master@{#300517}

When right click on an extension browser action in the Omnibox, the contextual
drop down says "Manage", which is unclear. Make the string to be more specific
such as "Manage Extensions".
The string's casing matches the platform; i.e. "Managed Extensions" for Mac,
"Managed extensions" everywhere else.

grd file changes:
Modifying 1 line label and 1 line desc text each in title case and in non title
case responsible for the label in: chrome/app/generated_resources.grd

BUG=418691
R=rouslan@chromium.org

TEST=
1) Launch chrome and install few extensions.
2) Right click an extension and observe
3) The context menu option for managing extensions should be string
   "Managed Extensions" on MAC, "Managed extensions" everywhere else.

Review URL: https://codereview.chromium.org/659663004

Cr-Commit-Position: refs/heads/master@{#300516}

Chrome for Android now sets the content description for it's
ContentView's and we do not force (and potentially override) content
descriptions set on container views set by other content/ embedders
(e.g. the Android WebView).

BUG=422284

Review URL: https://codereview.chromium.org/669723003

Cr-Commit-Position: refs/heads/master@{#300515}

BUG=424575

Review URL: https://codereview.chromium.org/665923002

Cr-Commit-Position: refs/heads/master@{#300514}

This is and addendum to 604e5c18 (commit 300230), cf.
https://codereview.chromium.org/663463002/ .

BUG=none

Review URL: https://codereview.chromium.org/639823009

Cr-Commit-Position: refs/heads/master@{#300513}

This was only being used as a DCHECK() in once place.

Removed it because listing IDs in this function goes contrary to modularization of algorithm implementations.

Review URL: https://codereview.chromium.org/662403005

Cr-Commit-Position: refs/heads/master@{#300512}

R=xhwang@chromium.org,jamesr@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/650853003

Cr-Commit-Position: refs/heads/master@{#300511}

This reverts commit 31111d18.

Conflicts:
	content/browser/web_contents/web_contents_impl.h

BUG=407376
TEST=no crashing, we hope
TBR=rsesek@chromium.org, creis@chromium.org

Review URL: https://codereview.chromium.org/643793003

Cr-Commit-Position: refs/heads/master@{#300510}

The original review thread is in https://codereview.chromium.org/588523002/

Fix the way how we create webrtc::AudioProcessing in Chrome.

TBR=tommi@chromium.org,maruel@chromium.org

BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.

Review URL: https://codereview.chromium.org/663413002

Cr-Commit-Position: refs/heads/master@{#300509}

Followup to:
https://codereview.chromium.org/601263002

BUG=416594

Review URL: https://codereview.chromium.org/669883002

Cr-Commit-Position: refs/heads/master@{#300508}

BUG=425251

Review URL: https://codereview.chromium.org/670433005

Cr-Commit-Position: refs/heads/master@{#300507}

Behavior changes described here:
http://developer.android.com/about/versions/android-5.0.html

BUG=424680

TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/664163003

Cr-Commit-Position: refs/heads/master@{#300506}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9fbc3f3..dd5a1e0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/665333002

Cr-Commit-Position: refs/heads/master@{#300505}

BUG=391005

Review URL: https://codereview.chromium.org/669733008

Cr-Commit-Position: refs/heads/master@{#300504}

BUG=424679
TEST=-

Review URL: https://codereview.chromium.org/665033003

Cr-Commit-Position: refs/heads/master@{#300503}

This was mostly done in https://codereview.chromium.org/668663006/, but:
* it missed things deriving from testing::Test for some reason;
* it didn't touch Windows-only files (for more obvious reasons).

R=sky@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/670743002

Cr-Commit-Position: refs/heads/master@{#300502}

This CL fixes a crash that occurs when ExtractPerHostZoomLevels is
called with a legacy per-host zoom level dictionary. In this case the
sanitization code will fail to find a partition key and subsequently
dereference a null pointer.

Since the legacy dictionary will be deleted immediately after the
function exits, we just skip the sanitization in this case.

BUG=424540

Review URL: https://codereview.chromium.org/665283002

Cr-Commit-Position: refs/heads/master@{#300501}

Chrome Actions are designed to be actions that live on the
toolbar, like extension actions, but are actually components
of Chrome. Examples of this can be ChromeCast, Translate,
Password Manager, etc. This change partially implements the basic
infrastructure for these actions.

(The main goal of this patch is to provide a shell that
the chromecast team can expand upon and use to prototype.)

* Create a generic ToolbarActionViewController, which can
  be implemented by a specific chrome action or to handle
  the general extensions case.
* (Mostly) abstract the concept of extensions out of the
  BrowserActionView, so it can be used for either extension
  actions or chrome actions.
* Create a simple ChromeActionsRegistry.
* Display chrome actions in the overflow menu of the browser
  actions container.

Known limitations:
* Chrome actions cannot be reordered, dragged, or shown in
  the main action toolbar (we need to consolidate chrome
  actions with the extension toolbar in the model somehow).

BUG=422976

Review URL: https://codereview.chromium.org/661493004

Cr-Commit-Position: refs/heads/master@{#300500}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/642023004

Cr-Commit-Position: refs/heads/master@{#300499}

This reverts commit 8e84bfcc.

Original CL: https://codereview.chromium.org/637413003
Reason for Revert:
New test SyncBackendRegistrarShutdownTest.BlockingShutdown fails repeatedly
on android and causes other tests to hang.
Also fails on other bots.
http://chromium-build-logs.appspot.com/gtest_query?gtest_query=SyncBackendRegistrarShutdownTest.BlockingShutdown
Failures are timeouts, and don't have any useful logs or stack traces (sorry).

Reason for hand-revert: Conflict with crrev.com/0cd9ff92

NOTRY=true
TBR=stanisc@chromium.org
TBR=zea@chromium.org

-- Original CL Description --

Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown.

This deadlock involves SyncBackendRegistrar running on the sync thread and at least two
workers - one of them (worker A) running on UI thread and
another (worker B) running on some other background thread.
In this particular case it was a password worker running on Password model thread.

The deadlock occurs when the SyncBackendRegistrar shutdown
code running in the sync thread blocks on a waitable event
set by worker B, at the same time the worker B's thread is
blocked for whatever reason waiting to make a synchronous
call into the UI thread, and at the same time the worker A
is blocked on a lock owned by the sync thread while it attempts
to unregister itself with SyncBackendRegistrar.

I think the main issue here is that the sync thread might
block on a worker. This is possible in only one situation -
when that worker hasn't have a chance to run any tasks because
its own thread was blocked doing something else.

The fix removes this dependency. The only reason this
blocking occurs is because ModelSafeWorker has a mechanism
for subscribing / unsubscribing to the MessageLoop descruction
which has to be done in the right thread context.
In order to unsubscribe the worker needs to remember the message loop it runs on which is done
in SetWorkingLoopToCurrent callback, which is called from a task
posted on the worker's thread. There is also a waitable
event which is signalled at that time. The even is used to
block ModelSafeWorker::UnregisterForLoopDestruction from
delegating the call on an uninitialized message loop which
is possible only when SetWorkingLoopToCurrent has never been called.

There is no need to block in UnregisterForLoopDestruction.
If the registration for even loop destruction hasn't been
been done yet (because the thread is blocked) then there
really no reason to wait for that and then immediately
unsubscribe. We can skip both subscription to the even loop
notification altogether and let the registrar know that
it is OK to remove the worker. That's essentially what the
fix does.

I added a test that verifies that SyncBackendRegistrar::Shutdown
doesn't block on a blocked model type thread anymore.

BUG=423078
Committed: https://crrev.com/8e84bfcc1c33fc0b63392d48ee8288d73f4a7675
Cr-Commit-Position: refs/heads/master@{#300350}

Review URL: https://codereview.chromium.org/667573007

Cr-Commit-Position: refs/heads/master@{#300498}

BUG=422729
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/635233008

Cr-Commit-Position: refs/heads/master@{#300497}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

The generator for the GLES2 command buffers has also been updated.

BUG=417463
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/663363002

Cr-Commit-Position: refs/heads/master@{#300496}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/649283003

Cr-Commit-Position: refs/heads/master@{#300495}