- 13 Dec, 2019 40 commits
-
-
bttk authored
java.util.function.Function is added in Android API level 24 Currently Chromium sets `min_sdk_version=19` https://developer.android.com/reference/java/util/function/Function Bug: 1034012 Change-Id: I0f8d822f4c79058de8c7faef5f4d19c48c7713bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965943 Commit-Queue: bttk <bttk@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#724779}
-
Xiaoqian Dai authored
It's caused by updating backdrop while window scale animation is still in progress. This cL pauses the backdrop update during window scale animation. Bug: 1027269 Change-Id: I4fa357d8fbb3de35ad78ec1b5095b7c5b156d8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967804Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#724778}
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. TBR=agl@chromium.org, holte@chromium.org Bug: 1007757, 1007722 Change-Id: Id37fd0d0705664f727c75fe6f2ff0cb1c5bb7964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967604 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#724777}
-
proberge authored
When IS_INTERNAL_CHROME_CLEANER_BUILD is enabled, the tests take a long time since all scan locations are scanned. We know the created test UwS are in the startup folder, so we should be able to skip scanning of other locations. I didn't put this in a IS_INTERNAL_CHROME_CLEANER_BUILD block to avoid issues where someone changes where the test UwS is created, resulting on the change passing on the Chromium bots then failing on internal bots. Change-Id: I74988a8635395579141f095dc4803399ce8902a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967219Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#724776}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f94b736c58a6..64ee7cee386b git log f94b736c58a6..64ee7cee386b --date=short --first-parent --format='%ad %ae %s' 2019-12-13 hjd@google.com Merge "Fix CI timeout on android-clang-arm-asan benchmark" 2019-12-13 hjd@google.com Merge "Ban stoX and NULL" Created with: gclient setdep -r src/third_party/perfetto@64ee7cee386b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If0fd7ae3cccbfac6cb83fe16747593eaa41708aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724775}
-
Sebastien authored
The HighlightedGamesStore is now using the HighlightedGamesResponse data file to identify the currently highlighted Web game. Bug: 1018201 Change-Id: I65270363b6eb3cec9bced7b3bc84af0caaafee72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954151 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#724774}
-
Aaron Leventhal authored
Bug: 1006767 Change-Id: Ia6341b643545f00759142b787f7834afac991358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964830Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#724773}
-
Toni Barzic authored
BUG=1031673 Change-Id: I5286a06cb913568b50a5321ebeb92bf298566ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966430Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#724772}
-
Johannes Henkel authored
New revision: 3d1b8aed28506966cb1f084067b65d87eab683c3 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1967550 Change-Id: I844806074013f01562c053c29b4a25f6f1c7ee8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967195Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#724771}
-
Liquan (Max) Gu authored
Context: currently, PaymentRequest API overzealously triggers the Minimal UI when the WebPaymentExperimentalAPI flag is enabled. It interferes with the development of the other experimental features. Old behavior: the Minimal UI feature is enabled when the WebPaymentExperimentalAPI about-flag is enabled. New behavior: enabling WebPaymentExperimentalAPI doesn't enable the Minimal UI altogether. The Minimal UI has another flag in about://flags called "Web Payment Minimal UI". Change: move the Minimal UI feature out of the WebPaymentExperimentalAPI flag into a separate flag. Bug: 1000432 Change-Id: I7f77fd51ca22475123e68c652940dc8a282d748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967564 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#724770}
-
Sven Zheng authored
Gaia team already drop the support of this. See https://g3doc.corp.google.com/gaia/g3doc/faq.md?cl=head#id-like-to-create-real-accounts-in-an-integration-test-how-do-i-do-this Also I've tested this code doesn't work. Change-Id: Ic65eb0ac646071f837ac43527eccb34c3a4732b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965924 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#724769}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id276bec19e6b448e81557d0aa50b0291a1927653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967216Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#724768}
-
Renjie Tang authored
Change-Id: I1e282b8849372391256d7b8c4cd876aecdbd1a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965489 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#724767}
-
Joe Downing authored
Using the noDialogs flags is fine for an unattended scenario, however it there may be cases where we want to provide a notification on the desktop that a user is connected but still allow the remote user to connect w/o prompting or requiring periodic reapproval. This CL splits up the 'noDialogs' flag into 2 flags which control suppression of the user dialogs (to allow / reapprove the remote connection) and the desktop notification that is displayed. Change-Id: Ifd2eb4f9270fadb4ffc2267bd2b1dfbe0ec38ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962530Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#724766}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d76f03c247a..780d83a4fe7e Created with: gclient setdep -r src-internal@780d83a4fe7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6e369b9915f881cbc8c8963b5fb42cf4772ba6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967701Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724765}
-
Clark DuVall authored
These tests need the webview provider set correctly. Bug: 1033855 Change-Id: I7853aa583f8b128eb8a87c5c7a386abeab6b1735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967796 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#724764}
-
Regan Hsu authored
Currently, when the user tabs to a Learn More link (at the end of a sentence usually), ChromeVox only verbalizes "Learn More". The entire sentence that the "Learn More" refers to should be read out in addition to the "Learn More". There are two means of how "Learn More"s are presented with preceding sentences: 1) When the Learn More is already embedded in the settings_strings.grdp 2) When the Learn More is concatenated with preceding sentence in JS This CL demonstrates the handling of case 1). Case 2) will be converted to 1) in a later CL, as there are localization issues of concatenating "Learn More"s with preceding sentences in JS. A generalized polymer element that accepts a localized string that contains a link will be created. The linked contents will be aria described by the entire localized string rather than only the text within the anchor tag itself. The other parts of the localized string will be aria-hidden. If agreed upon, the handling of case 1) will be applied to all similar strings with "Learn more" embedded in settings_strings.grdp, and later extended to all cases (once cases of (2) are converted to (1)). Bug: 1015924d Change-Id: I222a20b79006dcceedcf3893d5e4f0f77765fc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941198 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#724763}
-
Vasiliy Telezhnikov authored
This CL changes DCHECK back to NOTIMPLEMENTED() in OnBeginFrameSourcePausedChanged in DisplayScheduler. The code was never implemented, but it's being called on WebXR and causes test crashes. Bug: 1033847 Change-Id: I7357ea2437472999888a9f62b250debb18cbcad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967607Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#724762}
-
Weiliang Chen authored
Merge the OverlayCandidateValidatorAndroid class's functionalities into an OverlayProcessorAndroid, which is a subclass of OverlayProcessorUsingStrategy. This is for Android pre-SurfaceControl code path. This is CL 9/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I0ee7c169489ade404b130de2ecb7f3c6891aacb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958617 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#724761}
-
Elly Fong-Jones authored
This package seems to encounter cipd edge cases fairly often, and when it does it invariably requires trooper intervention to repair the bots. Save some human-time by validating and trying to repair the package automatically first :) Bug: 1033987 Change-Id: Iacc043320b8ea02ca0a93c9a58ea4c96e1fcd174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967420Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 24037b7c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib49e423b38335e9ac5c107840ba424fcea071b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724759}
-
rbpotter authored
Increase the size of the dialog to 70% of the window width and a proportional height, if the browser window is much larger than 1000x660. Bug: 1033412 Change-Id: I9cf6bab3a5b38d57dba9f49d3f82aba850d61b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967805 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#724758}
-
Kurt Horimoto authored
These will be used in infobar tests for overlay integration, where the tests use the |infobarType| and |hasBadge| properties of the UI delegate, but don't require a fully functioning InfobarCoordinator. Bug: 1030357 Change-Id: I918cbb6c04686cef7dddd89b86e03bf86b12f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963032 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#724757}
-
Zhenyao Mo authored
We don't need to dump all the fields if type is kEmpty. BUG=1026447 TEST=viz_unittests R=sunnyps@chromium.org Change-Id: I14b306e4db88272e67102485514ba61031168750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966396 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#724756}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0004831d6898482d7d1a7f2e38bea479b17e518d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967774Reviewed-by:
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. TBR=sky@chromium.org Bug: 1007670 Change-Id: Ifaa4c742298e45dd0581a77ecb6566ff4bb914a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967697Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#724754}
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. TBR=sky@chromium.org Bug: 1007848, 1007847 Change-Id: I9b82f87ba1ba7c5f79f16b8215d12a11e4bd6a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967559Reviewed-by:
-
Toni Barzic authored
Resets the app list contents view when the app list view visibility changes to false - the goal is to ensure that the app list is in the initial state when it becomes visible again. This is in particular needed in tablet mode, where AppListPresenterImpl::Show might not get called when app list becomes visible (so app list contents is not reset that way). ResetForShow was also being called when app list was getting focused while in hidden state, but that might not catch all the transitions where app list becomes visible (and with this change becomes unnecessary). Additionally, change when the selected apps page is reset for app list visibility change - instead of doing it on focus change, the selected page is now down when the visibility change is starting (i.e. in OnVisibilityWillChange). This will make page reset happen sooner (before the app list UI is actually shown), and cover more visibility change cases in tablet mode. BUG=None Change-Id: I6240d7401091a8d778f5a3f8774db919a4cfd6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966374Reviewed-by:
-
Nate Chapin authored
This removes the need for custom pause/unpause logic for ScriptedAnimationController in Document. Also, construct ScriptedAnimationController in the Document constructor, rather than lazily. It will get initialized on the first frame, so we're not saving much by deferring its initialization. This simplifies a bunch of logic around its handling in Document, and guarantees that its lifetime will be predictable for leak detection. Bug: 1029822 Change-Id: I4cec7985258dd24154032b4cd1812b75cc858757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953643 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#724751}
-
Sahel Sharify authored
This cl manually reverts the v8 roll out to v8.1.32 which happened here: https://chromium.googlesource.com/chromium/src/+/e5cb6daa9a0748126627f010e373706113a36120 Reson for revert: V8 roll out to v8.1.32 seems to have caused a lot of test failures on debug builds in this range: https://chromium.googlesource.com/chromium/src/+log/ad7921a033b89eae85da556c2917f6df1328f41e%5E..55d0dad728ea958b6e18ef069cb805b7d1dd0056 TBR=hablich@chromium.org NOTRY=true Change-Id: Ic5006fd9005a7c5fcb35bfd3b2c1f7af12ae3f34 Bug: 1034059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967891Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#724750}
-
Henrique Nakashima authored
Prevent new calls to be added directly to SharedPreferences without passing through SharedPreferencesManager. Bug: 1022108 Change-Id: I1cda2df2fc47fed1182ccbfebd673d6bf8c82901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965935 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#724749}
-
Gabriel Charette authored
TBR=altimin (no-op mechanical change) Bug: 1026641 Change-Id: I04a12b17434041d88d315ab457e1696222d9340f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962019 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#724748}
-
Josh Nohle authored
When v1 and v2 DeviceSync are running in parallel, before v1 DeviceSync is deprecated, use the SoftwareFeatureManager to indirectly call CryptAuthFeatureStatusSetter::SetFeatureStatus(). This is to ensure an ordering of SetSoftwareFeatureState() and SetFeatureStatus() calls. These functions mutate the same feature states on the CryptAuth backend and the order of the calls matters; we need to avoid race conditions. When v1 DeviceSync is deprecated, the CryptAuthFeatureStatusSetter is used directly. Bug: 951969, 1019206 Change-Id: I0711b011dc91a0218503a01f3131d4062f51bc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944888 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1822727560b..e181f2f7cf17 git log e1822727560b..e181f2f7cf17 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 syoussefi@chromium.org Validate that image array indices are constant 2019-12-13 root@cybikbase.com Fix GGP build Created with: gclient setdep -r src/third_party/angle@e181f2f7cf17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliot@google.com Change-Id: I7eb70bf42001a19ba18e53db476fc133201e2201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967751Reviewed-by:
-
Ben Pastene authored
This arg never changes among all supported CrOS device builds of Chrome. By giving it a proper default val in those builds, we can reduce the amount of inputs needed when building for CrOS (ie: simple chrome & chromeos-chrome ebuild). Bug: 937821 Change-Id: I9c29024949a8c3b61a531069f8806ecc21c590ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963100Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Collin Baker authored
Previously, the event's root location was compared with a View's window-relative bounds. The root location is in screen coordinates in some (but not all) cases. Fixed: 1033679 Change-Id: I3921b24333751010a9b51d1ee6b05eb7ddc8960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965938 Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#724744}
-
Roman Aleksandrov authored
Add removing feedback form at destructor of SigninScreenHandler which is destroyed when the login is finished. Bug: 1033572 Change-Id: Idfb55003c238faa5c8d04d9e7c11861632b67156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967652Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#724743}
-
Guohui Deng authored
They are optional API to make it possible to enhance low latency performance. Bug: b/143238704 Test: Internal CQ. Merge-With: eureka-internal/344842 Change-Id: I6d231fbfc278e2d581dcaabb56c244c415335ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965553Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#724742}
-
Philip Rogers authored
Change-Id: I96f96a22200de739af73dfac4924c75baf375c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967603 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#724741}
-
Sahel Sharify authored
This cl adds a type converter for payment address init dictionary to ensure safe conversion from blink::PaymentAddressInit* to mojom::payments::PaymentAddressPtr. Without this change the renderer would crashe if the diconary returned by the payment app does not contain all PaymentAddress members. Bug: 984694 Change-Id: I40cf3692e459168994a05b92734c4195f2ac53f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966233 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
