- 22 Feb, 2019 40 commits
-
-
Jacques Newman authored
The implementation for this provider already existed, this change just hooks it up. Bug: 847971 Change-Id: Ie5c51eda5e28201e1fa2c8146c87aebb0cebc2a3 Reviewed-on: https://chromium-review.googlesource.com/c/1481115 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634778}
-
Gary Kacmarcik authored
There are 5 parts to this cl: (1) Give DesktopCapturerProxy a ref to the ClientSessionControl so that it can send display info to the ClientSession (2) Query Mac OS for display info (3) Fixup Mac display orientation (move origin from bottom-left to top-left) (4) Add display id to display info. On Windows, the display id is the index into the array, but Mac has a separate identifier we need to track. (5) Restrict the desktop to only those displays that match the main display's DPI. This is to match webrtc's behavior. Change-Id: Ia71c537bf521c1ccfcb1e4949792a61433160d3f Reviewed-on: https://chromium-review.googlesource.com/c/1479281Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#634777}
-
Xing Liu authored
On Nexus 7 devices on Android version M, L, K, when decoding H264 video thumbnail, the OEM decoder may not response, currently it will time out and fail in 8 seconds. This CL restricts the H264 test to run on phone. A better solution is still needed in the future. Bug: 933074 Change-Id: I6ee62eedf633f63af1b679c2c09a97d1a228443f Reviewed-on: https://chromium-review.googlesource.com/c/1479278Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634776}
-
Christian O. Andersson authored
See https://crrev.com/c/1185001 for details Design doc: https://docs.google.com/document/d/188BbgvTdhKf8bXikCL-JMduEclJOd9GxhKu79hmSVdo/edit Test: run_webview_instrumentation_test_apk -f AwSettingsTest#testWillSuppressErrorPage Change-Id: I71603bf906b58c9c42cb06ecf1abcee10360d5cb Reviewed-on: https://chromium-review.googlesource.com/c/1482900 Auto-Submit: Christian O. Andersson <cricke@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#634775}
-
wutao authored
This patch addes a window property to make the Assistant answer card scrollable in the embedded UI. Changes: 1. Refactor current code so that app_list_view can access the window property. 2. Modify app_list_view event targeter to handle Assistant answer card events. Bug: 924624 Test: manual Change-Id: Iad9650ca98589793ff065574b3971aa97c3ec3f5 Reviewed-on: https://chromium-review.googlesource.com/c/1482591Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#634774}
-
Bo Liu authored
Improve source layout. Add a minimal DEPS file. This CL is created mostly with the help of tools/git/move_source_file.py Still TODO: Move file listing in gn to gfx. Move java files to gfx package. Probably add an owners file Change-Id: I99906b2893abbc703d077a47985e7ef2bd37a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/1480696 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67e798b11f20..bf36568f5a9a Created with: gclient setdep -r src-internal@bf36568f5a9a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic36b90ff1383d056db7a4ebce2bcd10caa47b368 Reviewed-on: https://chromium-review.googlesource.com/c/1483116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634772}
-
Shuotao Gao authored
This CL updates the url of the coverage dashboard on https://ci.chromium.org/p/chromium/g/main/console The old one is being deprecated, and will be turned off soon. Change-Id: I0fd78e8d15cb56dd134a5d86bc6d4e27cc10a1eb Reviewed-on: https://chromium-review.googlesource.com/c/1482112 Commit-Queue: Shuotao Gao <stgao@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634771}
-
Peter Kasting authored
Bug: 714018 Change-Id: I8d9c183af32ce111afafdc4e3fa94af468b375bd Reviewed-on: https://chromium-review.googlesource.com/c/1480445 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#634770}
-
David Roger authored
The code is looking for an empty space in the ordered accounts list. When it finds one, it uses it to put the first account. The code was calling insert() though, which actually does not put the account in the empty space, but inserts it before and leaves the empty space untouched. This resulted in an additional empty space in the vector. This is a minor bug, because an extra empty space is similar to an extra invalid cookie, and does not cause a catastrophic failure. The only consequence is that some accounts were unnecessarily reordered in the cookie. Bug: None Change-Id: I0b0ec9d3650a31d4f21b5d0007fcf85a186690d6 Reviewed-on: https://chromium-review.googlesource.com/c/1483027 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#634769}
-
Bruce Dawson authored
IdleWakeups expects to build with VS 2015 which we don't otherwise use - this upgrades it to VS 2017. One of the IdleWakeups columns was "Working Set" but that is ambiguous so I confirmed that it is Private Working Set and changed the label appropriately. Change-Id: I49c0810de8b5ef1fce59764a05bf2b909ec9739a Reviewed-on: https://chromium-review.googlesource.com/c/1457670 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#634768}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/429a6ce38996..2e6cfed0e664 git log 429a6ce38996..2e6cfed0e664 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 pprabhu@chromium.org config: Migrate edgar, elm, eve, gale paladins to Skylab Created with: gclient setdep -r src/third_party/chromite@2e6cfed0e664 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If153f3bf1cc16bd4eb55163119110af53c008a28 Reviewed-on: https://chromium-review.googlesource.com/c/1483125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634767}
-
lgcheng authored
Fix usb_host mojom connection error when OpenDeivce is rejected. When app call OpenDevice from Android side, it can be rejected because 1. app has not requested for permission. 2. permission_broker decides the node is in use. In these cases we return mojo::ScopedHandle() from Chrome to Android. And case cause mojom connection error. connection error. Test: return mojo::ScopedHandle() to OpenDeivce and no more mojom Bug: 922675 Change-Id: I1de5eb17cca35d57f96afc7d10de6312659253b9 Reviewed-on: https://chromium-review.googlesource.com/c/1416132Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#634766}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d6b7287745c6..12aef8732ec6 git log d6b7287745c6..12aef8732ec6 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thestig@chromium.org Fix leak inside sycc420_to_rgb(). 2019-02-22 thakis@chromium.org Remove unused flag that should not be used. Created with: gclient setdep -r src/third_party/pdfium@12aef8732ec6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934638,chromium:none TBR=dsinclair@chromium.org Change-Id: I3469161414e4a7c5a00f7b7c7aa4f8cec4ed4330 Reviewed-on: https://chromium-review.googlesource.com/c/1483119Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/18e5841c0dae..698937087797 git log 18e5841c0dae..698937087797 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 robertphillips@google.com Move DrawingManager to RecordingContext 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b9039bf76bf3..cf9b2853a7e7 (1 commits) 2019-02-22 egdaniel@google.com Track GrVkResources in command buffer associated with pipeline barriers. 2019-02-22 benjaminwagner@google.com Upgrade MacBookAir7.2 to macOS 10.14; rename jobs to include OS version 2019-02-22 bsalomon@google.com Make it safe to enter the cache from a GrTexture idle proc. 2019-02-22 reed@google.com update docs for backdrop 2019-02-22 kjlubick@google.com [canvaskit] JS API in place for shaped text Created with: gclient setdep -r src/third_party/skia@698937087797 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:933526 TBR=jvanverth@chromium.org Change-Id: Iabe48dcbd4fc83e3b6db19f07f2404f78d4e0602 Reviewed-on: https://chromium-review.googlesource.com/c/1483117Reviewed-by:
-
Pauline Anthonysamy authored
Add equivalent component test. Bug: 823706 Change-Id: I4f4b549bde567ea70e25afae86704b45820b9acb Reviewed-on: https://chromium-review.googlesource.com/c/1475189Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Pauline Anthonysamy <anthonysp@google.com> Cr-Commit-Position: refs/heads/master@{#634763}
-
Ben Pastene authored
Currently failing after the last lkgm roll: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel Bug: 866062 Change-Id: Idbc62420a8d9cc100f00e661b72ff0bad8c000e3 Reviewed-on: https://chromium-review.googlesource.com/c/1483360Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#634762}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7aafb27453d3..8a718cb58343 git log 7aafb27453d3..8a718cb58343 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 chrisforbes@google.com Restore vertex fetch state update from context -> state 2019-02-22 chrisforbes@google.com Implement proper handling of constants Created with: gclient setdep -r src/third_party/swiftshader@8a718cb58343 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124177079,chromium:b/124934655 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1c69244e7bdfec10372db6a10b3f46de82e388cf Reviewed-on: https://chromium-review.googlesource.com/c/1483120Reviewed-by:
-
Peng Huang authored
Current SkiaRenderer support several draw modes, but in future we will only support one draw mode which is using SkiaOutputSurface. So we need make all tests switch to SkiaOutputSurface. Bug: 929843 Change-Id: I31de102b62450ac35ed5d440b69b60fd6ed872c3 Reviewed-on: https://chromium-review.googlesource.com/c/1479297Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#634760}
-
Adam Langley authored
In order to test this code we'll want to implement the authenticator side of the PIN protocol in |VirtualCtap2Device|. It'll be helpful when doing so to have access to some code from pin.cc. This change exposes some PIN-protocol internals via a |pin_internal.h| header for a future implementation in |VirtualCtap2Device|. Change-Id: I76f2441185b4d1a058240de5d2cb9bbf49dc1061 Reviewed-on: https://chromium-review.googlesource.com/c/1481083Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#634759}
-
Xiyuan Xia authored
The crash is caused by a race of WS and KeyboardControllerObserver mojo interface. When we close keyboard hosting window, we send OnKeyboardOccludedBoundsChanged and OnKeyboardUIDestroyed via KeyboardControllerObserver then close the hosting window. But the browser process could receive the hosting window close via WS first hence the crash. The CL wires the unembed code path that happens on hosting window close with ChromeKeyboardControllerClient::OnKeyboardUIDestroyed. After OnKeyboardUIDestroyed, the calls on KeyboardControllerObserver interface will be no-op and the crash would not happen. Bug: 931910 Change-Id: I2b777a56dca3c26e1f734b732d488165936a291a Reviewed-on: https://chromium-review.googlesource.com/c/1482948 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#634758}
-
Edwin Joe authored
Added some trace events in the viz.surface_id_flow category to trace surface id synchronization until Surface::OnWillBeDrawn is called on the surface. Bug: 933503 Change-Id: I7c51af6bc8cab90c4ff6b91341e2625d1bb67b0b Reviewed-on: https://chromium-review.googlesource.com/c/1478934Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#634757}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e83100437106..245337d62e22 git log e83100437106..245337d62e22 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 whesse@google.com Pass target branch from tryserver in bot_update module Created with: gclient setdep -r src/third_party/depot_tools@245337d62e22 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I34d15e2896d8c5cd3077e16502793f31793eee56 Reviewed-on: https://chromium-review.googlesource.com/c/1483115Reviewed-by:
-
jimmy gong authored
This reverts commit a64eb942. Reason for revert: <INSERT REASONING HERE> Original change's description: > Implement OnNetworkChangeObserver interface on SmbService > > - Implements Net::NetworkChangeNotifier::NetworkChangeObserver to > SmbService. > - Optimizes the workflow of host name resolution by calling on host > discovery whenever a network change is discovered, rather than > only running host discovery on an error returned by > StartReadDirectory. > > Bug: 922273 > Test: manual end to end > Change-Id: I6544c169fb1aa91ebd7d19fe22d854930ae4a928 > Reviewed-on: https://chromium-review.googlesource.com/c/1464651 > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634431} TBR=zentaro@chromium.org,baileyberro@chromium.org,jimmyxgong@chromium.org Change-Id: Ic731025eafe9fed7c33e6fdf61f56553ba502e81 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922273 Reviewed-on: https://chromium-review.googlesource.com/c/1482718Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#634755}
-
Yue Li authored
The activity control boolean pref has been replaced with a enum flag. Update the usage in Assistant settings. Bug: b/124934418 Test: Manual Test Change-Id: I648128163e701fcea9dc38e73e8734511c0f863a Reviewed-on: https://chromium-review.googlesource.com/c/1480817 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Bruce Dawson authored
We spent a while figuring out how and why mini_installer.exe avoids pulling in the C run-time and I wanted to make sure it was working correctly and was slightly better documented. This just adds some comments, for future generations. Bug: 934032 Change-Id: I917a7532d6d8e92a21d58e9cedf0af44fee488ed Reviewed-on: https://chromium-review.googlesource.com/c/1481956 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634753}
-
Pedro Amaral authored
When exiting the tab switcher the Activity Tab can be null. This CL adds a null check to safeguard against this. Bug: 934116 Change-Id: I2a0fdead0faf43a05dfe25e483664e5a2164f291 Reviewed-on: https://chromium-review.googlesource.com/c/1480701Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#634752}
-
Yue Li authored
String doc: go/CrosStrings Bug: None Test: Manual Test Change-Id: I4f0a64ee0cb0cf172101da40758952fb9ceb2bca Reviewed-on: https://chromium-review.googlesource.com/c/1481113Reviewed-by:
-
Fredrik Söderquist authored
When resolving style for the 'stroke-width' property we would use CSSToLengthConversionData::CopyWithAdjustedZoom() with an argument of 1 to get an "unzoomed" length. The FontSizes object was however not adjusted, so still carried zoomed base font sizes. Make a new method on StyleResolverState that returns an CSSToLengthConversionData that uses unzoomed unit bases, basing it on the existing FontSizeConversionData() method which does roughly the same thing except it uses the parent style for unit bases. Bug: 933689 Change-Id: Icfbc59a641f0dc2d94f00ba5f3e9a15b36f8c195 Reviewed-on: https://chromium-review.googlesource.com/c/1481417Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#634750}
-
Amit Hilbuch authored
The RtpSenderInterface::GetParameters() method was mistakenly not declared as const. This has been fixed in webrtc. This change aligns overrides to declare the const method as well. Bug: webrtc:10251 TBR: orphis@chromium.org Change-Id: I3bfb87f11e84d14c7bae9c3b1e6ec2b303aabb56 Reviewed-on: https://chromium-review.googlesource.com/c/1479411 Commit-Queue: Amit Hilbuch <amithi@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#634749}
-
git config --global authored
This cl might reduce number of 'purple' builds Bug: 933450 Change-Id: I2fe5425541bb1e794c225c853b1ee3279f16b86f Reviewed-on: https://chromium-review.googlesource.com/c/1477998Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f54db458. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context." 1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I48ca81c1e9aa7caa55b19d575127ccad9b95230e Reviewed-on: https://chromium-review.googlesource.com/c/1482943Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634747}
-
Jan Krcal authored
This is a reland of 5d1e827e, the CL is unchanged. This CL was reverted due to test flakiness. The test flakiness turned out to be pre-existing and thus likely unrelated to this metrics-only CL. Original change's description: > [AF Profile] Add metrics for debugging difference between USS/Directory > > This CL adds metrics that break up origin for each locally committed > change by autofill_profile sync. This is needed for debugging the USS > launch. The new code will be removed again after the investigation is > over. > > Bug: 904390 > Change-Id: I87175131fe2a4d298bf1e76e0fa1840b18dbe0f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1412477 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631629} TBR=jwd@chromium.org, treib@chromium.org, sebsg@chromium.org Bug: 904390 Change-Id: If1d0595f3576211a6956cfc090fc402285335d0b Reviewed-on: https://chromium-review.googlesource.com/c/1483085Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#634746}
-
Eyor Alemayehu authored
Bug: b:124778405 Change-Id: Ie2461294045761efa5215782c95a12393d633893 Reviewed-on: https://chromium-review.googlesource.com/c/1481957Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8aa00f037148..29f9cd9358ee git log 8aa00f037148..29f9cd9358ee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 andersc@webrtc.org Synchronize replaceRegion calls. 2019-02-22 perkj@webrtc.org Replace field trials with WebRtcKeyValueConfig in PacedSender 2019-02-22 kron@webrtc.org Add support for TransportSequenceNumberV2 in SDP negotiation 2019-02-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f39a1b89..a77f654a (634190:634608) Created with: gclient setdep -r src/third_party/webrtc@29f9cd9358ee The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I462371e0a4fe745732d16b452362491f27affb8e Reviewed-on: https://chromium-review.googlesource.com/c/1483155Reviewed-by:
-
Aleks Totic authored
This CL changes how NG deals with OOF Elements held by Legacy. NG and Legacy use different mechanisms to "bind" OOF Elements to their container. NG binds OOF Elements to their container by propagating them up the tree during layout. Legacy LayoutBlocks keeps a list of PositionedObjects, and add and remove from this list directly from OOF child. The case tackled in this CL is this: NG is the container, and has a positioned child that has not propagated trought the tree during NG layout because Legacy was on a path between child and its container. For example: <div#container position:relative> <div#legacy display:flex> <div#oof position:absolute> When #container is placing OOF descendants, its NG list of descendants will not contain #oof, because #legacy was laid out with Legacy code. Instead, #oof is in the Legacy's list of #container.PositionedObjects. The interesting part here is computing the static position of #oof wrt #container. What previous code did was this: - it let Legacy decide when PositionedObjects are laid out. - when NG positioned object got called to Layout(), it would compute abspos constraints (static_position, constraint_space), create a new NGOutOfFlowLayoutPart - NGOutOfFlowLayoutPart would place the object The new code changes who triggers layout of these objects. Instead of waiting of Legacy to layout its positioned objects, it pulls them out of Legacy, and places them during NGOutOfFlowLayoutPart::Run. This makes computing static position for Legacy elements tricky. Container has not copied its data back to Legacy, and its children have not had their offset set. Legacy code that computes static offset needs children's offset, and that information is no longer available from LayoutObjects. That information can be found in NGContainerFragmentBuilder. That is why builder gets passed in to LayoutBlock::ComputeBlockStaticDistance The code also contains some minor fixes: 1) to bugs that were exposed by this change. 2) for bugs that would otherwise be caused by this change. NGContainerFragmentBuilder::AddChild needed to take relative position into account when propagating OOF descendants. NGContainerFragmentBuilder::GetChildOffset could be called on a grandchild, if child is a linebox. Bug: 921396 Change-Id: Ib9a26596f21971374854cf6ec2729b10b3cd834a Reviewed-on: https://chromium-review.googlesource.com/c/1476087Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634743}
-
Ben Kelly authored
This CL corrects some typoes added in in crrev.com/c/1468144: 1. The ServiceWorkerCache.Cache.*.Match histogram contains its own values in addition to have child suffixes. It should not be marked as a pure base. 2. The ServiceWorkerCache.CacheStorage operation suffixes were applied to the ServiceWorkerCache.Cache.* histograms incorrectly. Bug: 927537 Change-Id: I3d46f1aca0b6d7f90ee14a8b18694cfeb5b0f51a Reviewed-on: https://chromium-review.googlesource.com/c/1481470Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#634742}
-
Etienne Bergeron authored
This CL is adding the missing constuctors receiving the Location information to ScopedBlockingCall. The location information is added to the trace event with the same format than the top-level run tasks events. The ScopedBlockingCall constructors will be moved to the new constructor with the Location in the following CLs. R=gab@chromium.org Bug: 934302 Change-Id: I6247a1ae099c45ebe9454cd74e9953a2add6e70f Reviewed-on: https://chromium-review.googlesource.com/c/1479846Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634741}
-
Caleb Rouleau authored
https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/doc/Bot.md#graceful-termination_aka-the-sigterm-and-sigkill-dance test_env.py already has support for this, but it looks like a lot of the scripts aren't using it. One reason for that could be that there wasn't a run_command function there yet. I added a simple run_command function, and made a bunch of scripts use it. This should fix up all the test suites that use common.py's functions to run subprocesses including: - run_telemetry_as_googletest.py - run_chromedriver_test.py - telemetry_gpu_unittests.py - telemetry_perf_unittests.py - telemetry_unittests.py And many more! Also delete common's run_integration_test function since no one is using it. Bug: 921662, 910584 Change-Id: If670e1b5725e3a7dcfda471b7141d47c73c5ef82 Reviewed-on: https://chromium-review.googlesource.com/c/1461512Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#634740}
-
Yue Ru Sun authored
Add an observer to the tab life cycle unit that will receive the discard reason every time a tab is being discarded or reloaded, and log the event type and reason of this state change to the browser-level TabStatsTracker, which will report the statistics to User Metrics Analysis at regular time interval as histograms. Follow-up to CL/1455472. Change-Id: I7f39dc7693e81cd2a06250dccc685525c11ff590 Reviewed-on: https://chromium-review.googlesource.com/c/1460071Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#634739}
-
