- 23 Mar, 2020 40 commits
-
-
Matthew Mourgos authored
This change updates the OOBE gesture intro page to have vertical spacing between items set at 16px. Also, spacing between the icons and text to the right is set to 8px. On the marketing OOBE screen the accessibility link has been moved down to go along side the dialog button (next button). Also the color of the link is change to be google blue 600. Bug: 1062090 Change-Id: Ic1714ed07b19f3575702ed436f1e71f8778632f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106750 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#752564}
-
Demetrios Papadopoulos authored
There are two such entry points and only one should be shown at a given time, based on whether signinAllowed is true/false. Incorrectly, both of them were showing when signinAllowed=false. Existing tests were failing to catch the problem, and erroneously succeeded. Fixing tests as well. Fixed: 1063451 Change-Id: Ic0b6046b2f6e5934a76133ca95a702f9bc79bd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112899 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#752563}
-
Rafael Cintron authored
If CreateSwapChainForComposition fails, we cannot draw content to the browser window. Failure here is indicative of an unrecoverable driver bug. Hence, terminate immediately and let the browser process start a fresh new instance. Bug: 1054217 Change-Id: I1f8af2893a4e23159b6fb543ed669fe6f9e34ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111056Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752562}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1058196 Change-Id: I712b731ebe31811aa07cdea42f3adb2b819a2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111776 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752561}
-
Wei-Yin Chen (陳威尹) authored
The device can be wrongly in landscape mode before the test starts, which make the test flaky. Now we force portrait mode before testTabSuggestionMessageCard_orientation starts. Bug: 1063639 Change-Id: Ic532a252f9ccaebb70ed7fb4ca0bc1ab96bc8f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114391Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752560}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99ede42ffe50..165b68ebb6ad git log 99ede42ffe50..165b68ebb6ad --date=short --first-parent --format='%ad %ae %s' 2020-03-23 reed@google.com Add onProgram to ModeColorFilter 2020-03-23 reed@google.com skvm for picture-shader 2020-03-23 robertphillips@google.com Make TessellationTestOp and GrPipelineDynamicStateTestOp surface their programInfos at record time 2020-03-23 mtklein@google.com impl A8/G8 skvm image shaders 2020-03-23 mtklein@google.com pass paint color and full dst info to shaders Created with: gclient setdep -r src/third_party/skia@165b68ebb6ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ic6fa8c2265690206b39b6477a2454dceb3584a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752559}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d1f72852e98..7eab0a820f9c git log 8d1f72852e98..7eab0a820f9c --date=short --first-parent --format='%ad %ae %s' 2020-03-23 saza@webrtc.org Split RMS level measurement utility from APM Created with: gclient setdep -r src/third_party/webrtc@7eab0a820f9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I22b0e34bbcdcbe822fd3d2d0f6d15b9a2d0a7d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115928Reviewed-by:
-
Eric Willigers authored
This histogram expired with M82. Bug: 1053186 Change-Id: I7d101743909c4f2339aed1a32ab3f5fbf14a6314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108216 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
In instrumented tests, annotations like @CommandLineFlags.Add("enable-features=FeatureA") can propagate to CachedFeatureFlags.isEnabled("FeatureA"), but "FeatureA<Trial" doesn't. This CL fixes that. Bug: 1056327 Change-Id: I672743ffddd0604bc655def440e8d7c047bf5b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113913Reviewed-by:Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752556}
-
John Lee authored
Change-Id: Iac4ebc3dd3a60f85e798a53ab9af6346e37fe6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112968 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752555}
-
Aaron Leventhal authored
This strange check seems to imply that being focusable would make it more likely for a node to be ignored. Bug: None Change-Id: I57fbdab2ece01294af78158b3f2b3400ff5d811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113680Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#752554}
-
Avery Musbach authored
The unit test in the present CL also tests the old user actions Accel_Window_Snap_Left and Accel_Window_Snap_Right. Test: ash_unittests AcceleratorControllerTestWithClamshellSplitView.WindowSnapUma Bug: 1059477 Change-Id: I022764de378ea0c9818a3e8e2d50ee961f88965b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108604Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Adam Goode authored
Chrome OS supports socket:// and lpd:// printers when specified manually. Both these backends have corresponding mDNS service types and can be automatically discovered using almost all of the existing infrastructure. https://www.cups.org/doc/network.html says: "Due to limitations in the LPD protocol, we do not recommend using it if the printer or server supports any of the other protocols." For this reason, and because the LPD backend is more complicated, this change only adds support for socket printers. Another good reason to not support LPD is that its zeroconf implementation specifies the use of multiple TXT records, which is confusing and hard to debug (avahi-browse does not show all 4 records for my printer, though they are visible with tcpdump). This misfeature is explicitly called out in the DNS-SD RFC: https://tools.ietf.org/html/rfc6763#section-6.8. This enables my HP LaserJet 1320 to be discovered and configured with the correct PPD. Bug: 1063535 Change-Id: I9b84b4e6b0e726d5410af31e71013c569d61ef8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113674Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Adam Goode <agoode@chromium.org> Cr-Commit-Position: refs/heads/master@{#752552}
-
Mingjing Zhang authored
This CL adds five substages, each corresponding to a Viz breakdown, under the SubmitCompositorFrameToPresentationCompositorFrame stage of the PipelineReporter in the trace viewer. Bug: 1059032 Change-Id: I8473f69353ac21e9c63ccc093c504339d751d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110771 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#752551}
-
Ovidio Henriquez authored
This change refreshes the expiration date on the following histograms: * Bluetooth.Web.RequestDevice.UnionOfServices.Services * Bluetooth.Web.RequestDevice.OptionalServices.Services Bug: 1063889, 1063888 Change-Id: Ia2803a89f28c68bb31faacfecd933ddd948eaa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115779Reviewed-by:
-
Katie Dektar authored
This reverts commit c9ac6664. Reason for revert: Flaky, see crbug.com/1063961 Original change's description: > Improves distilled page metrics code health. > > Refactors a test DistillabilityObserver for use in multiple > browsertests. > > Adds DCHECK and adjusts tests to use an observer so as not > to hit the DCHECK. > > Bug: 1061928 > Change-Id: I152d2be5adab1da96cebae5cf2654a5fc8e82e35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112581 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752464} TBR=ellyjones@chromium.org,wychen@chromium.org,katie@chromium.org Change-Id: Ifa43f21a52c66d0ab3c55f665b027ec93a4de39d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116533Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#752549}
-
Ahmed authored
Dropped windows to other desks should not animate while restoring their transform. This ensures that the hotseat state will be calculated correctly. BUG=1063536 TEST=Added a new test. Change-Id: Idbb525b8380b1e326db31d79256ab7e22d24c032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113805 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#752548}
-
Roman Sorokin authored
Test was checking the brand while initializer was in CollectRlzParams function. Added a closure to wait until InitRlzImpl is finished. Bug: 997360 Change-Id: I23af618472396b660b82b3f4ed76fa50fb45d879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113473Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752547}
-
Yue Zhang authored
This CL adds M5-related histograms and user actions. Naming: * TabGroups.UserNamedGroupCount: Histogram recorded at the same time as TabGroups.UserGroupCount, recording the number of groups which are named. * TabGridDialog.TabGroupNamedInDialog: Action recorded when a name is initially set. Ungrouping: * TabGridDialog.RemoveFromGroup.TabMultiSelect: Action recorded when one or more tabs are successfully removed from the group. Re-ordering through accessibility delegate: * TabGrid.AccessibilityDelegate.Reordered: Action recorded when a tab is reordered through the accessibility delegate. Sharing: * TabGridDialog.SharedGroupAsTextList: Action recorded when a group is successfully shared as a text list of links. Bug: 1017502 Change-Id: I9a4eef32543df32b050ad91f2f5c0d1664fd5128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107428Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#752546}
-
Joshua Pawlicki authored
Bug: 1024318 Change-Id: I600616ea823fe398f58c18622c0a4831a17426f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116570 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752545}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/079cda55..96e601c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb9a51c006b831fce7046651b90cfe03fd0721af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115756Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752544}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bf306f5ba556..1dea10da0ae8 git log bf306f5ba556..1dea10da0ae8 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 sadrul@chromium.org Revert "cros: Update guest mount check." 2020-03-23 phoglund@google.com Implement proto writing in the dashboard. 2020-03-23 achuith@chromium.org cros: Update guest mount check. Created with: gclient setdep -r src/third_party/catapult@1dea10da0ae8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452,chromium:1057755 Tbr: sadrul@google.com Change-Id: I5778a545240d92bc86863a7cb5b60030c7517270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115925Reviewed-by:
-
Tarun Bansal authored
Bug: 1048736 Change-Id: I0550f8ba1e34a151a645c1bd2204dde1ad0fafbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115881 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#752542}
-
Tarun Bansal authored
Remove Data Reduction Proxy (DRP) unused code. All of this code is only called by tests. Deleted code is related to (i) Proxy bypasses on http:// requests (ii) Refetching client config if the server responded with auth denied error when Chrome attempts to proxy http:// requests. Change-Id: I3554899d4e40ca904501a711736ab46d34975fab Bug: 1048736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112331 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Bettina authored
If a user is already opted in to enhanced protection, there is no need to show the extended reporting opt in option in the security interstitial. Bug: 1063421 Change-Id: Id4319b643fadeeddd738bd04ce1ded7b609c2150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112073 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#752540}
-
Xianzhu Wang authored
The previous OcculusionTracker logic assumed that any exotic blend mode created a render surface, and skipped occlusion for blend mode only when applying occlusion of render surfaces. However, the new mask layer mechanism using kDstIn blend mode doesn't always create a render surface for the mask layer, so we need to skip occlusion for such mask layers. Previously an opaque mask layer would mistakenly occlude the masked layer. This didn't actually happen because we had never set contents_opaque for a mask layer, even if it was opaque. However, this will happen with a more sophisticated layer opaqueness detector (crrev.com/c/2113806). Change-Id: I6f9f8d6c521553c62bcaff2d31d4f2f4778b1317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115696Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#752539}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I06627da332ec630cdb5fc6f83544613ea9df7ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115477 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752538}
-
https://github.com/web-platform-tests/wpt/pull/22262kyle Ju authored
Change-Id: I243d80d24387317e9b72a01a03b033400587170d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111270Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#752537}
-
Wei-Yin Chen (陳威尹) authored
Some render tests in StartSurfaceLayoutTest fails consistently on Marshmallow 64 bit Tester. Bug: 1063619, 1063620 Change-Id: I90efbf4839be7687a74c06ac28af5ce9ea85e51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114168Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie307be8941d31a8a18bfd5cc49f31f62d87a60e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116330Reviewed-by:
-
Wei Li authored
Remove the unused default color setting functions; Also remove the default color values by using optional colors. BUG=1059867 Change-Id: I96940c0e4bb064e6505299e396a96a3c196aa024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114449 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752534}
-
Nico Weber authored
This code has been dead since https://chromium-review.googlesource.com/c/chromium/src/+/1372464 Bug: 912743,346399 Change-Id: I92e690ff6dae9d89ea0fa96b8e8fee8ff4233e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115761 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#752533}
-
Liquan (Max) Gu authored
Change: Add more test coverage for: * WebPaymentIntentHelper#parsePaymentResponse * WebPaymentIntentHelper#createIsReadyToPayIntent Bug: 1063430 Change-Id: Ie9347e287fbdfb702850d09d8b54d3140f68e10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112933 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752532}
-
rbpotter authored
Bug: 1026426 Change-Id: I75ecb95eb9f3232c0e18974f24b0088ae3de2c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113512Reviewed-by:
-
Brett Wilson authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/9499562d..5ed3c9cc 5ed3c9cc Match all toolchains by default. 2a18133d Update the "getting started". 7943a470 Remove a few unused macros. 74397090 Add an "outputs" command. bee89163 Make CONFIGURATION_BUILD_DIR represent location of binaries 818b8851 Add missing header for using with std::move Change-Id: I5cb02c2e4fbc574e437a43f6cc37a500b65b03ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116131 Commit-Queue: Brett Wilson <brettw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#752530}
-
Xida Chen authored
It could happen that after a BeginImpl(Main)Frame is reported, a tracker is scheduled to terminate. In this case, any subsequent handling of that impl(main)-frame will be lost. In other words, we completely lost track of the last frame. This CL fixes the impl frame, the fix for main frame comes later because this CL is already big. Bug: 1055844 Change-Id: I1cc65e9a5d973ecb67c83105be03f7bc08139dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079134 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#752529}
-
Matthew Mourgos authored
Currently the gesture navigation screen metrics are recorded using a different name that what was added to histrograms.xml (in this cl crrev.com/c/2098770). This CL fixes the error by changing the strings used to record the metric. Name in Histograms.xml: "OOBE.GestureNavigationScreen.PageShownTime" Incorrect name used right now: "GestureNavigationOOBEScreen.PageShownTime" Change-Id: I0d8f70774ad6c95ffa0d5af4b7c2d322b71ebed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113812Reviewed-by: -
Adrienne Walker authored
This is a followup to: https://crrev.com/c/2099463 There are no existing origin trial tokens at the moment, so this is hooking up code that will eventually work, with some test overrides. Bug: 1015227 Change-Id: Iac23203c59d0246f38b9d02b55a5c9c21fe17ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107834 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752527}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/befc2993d549..01ed358917aa git log befc2993d549..01ed358917aa --date=short --first-parent --format='%ad %ae %s' 2020-03-23 ehmaldonado@google.com depot_tools: Run using Python 3 by default. Created with: gclient setdep -r src/third_party/depot_tools@01ed358917aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7037275e02094760c0fe33f843d4a86e66754afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116230Reviewed-by:
-
Samuel Huang authored
This CL migrats SuperSize (and Python scripts that use it) to Python 3. Details: * Use futurize to perform standard migration changes: * {raw_input(), xrange()} -> {input(), range()}. * {Queue, SimpleHTTPServer} -> {queue, http.server}. * __builtins__ -> builtins. * .iter{items(), keys(), values()} -> {.items(), .keys(), .values()}. * Explicit iter() added at some places. * itertools.{ifilter(), imap(), izip()} -> {filter(), map(), zip()}. * Explicit list() added at some places. * exec(): Use function syntax. * Make classes inherit from objects. * Generators: .next -> .__next__. * Remove __future__ usage (including those added by futurize). * Remove auto-launch using PyPy. * Benchmarking shows PyPy 3 confers no advantage over CPython3! * json.dumps(): Remove File parameter. * Main challenge: String changes: {str, unicode} -> {bytes, str}. * basestr -> str. * subprocess.Popen(): Add encoding='utf-8' param. * Need to disable pylint warning. * subprocess.check_output(): Explicitly decode('ascii'). * Replace cStringIO.cString() with io.BytesIO or io.StringIO. * io.stringIO(): .truncate(0) does not bring write head to origin; need to call .seek(0) explicitly. * gzip.open(): Use text mode instead of binary mode. * String literal replacement for file parsing. * Replace 'literal' with b'literal' for these usages. * b'bytes'[idx] is an int! Adapt wherever used. * archive.py: _NameStringLiterals(): Redo '\n\t' removal and printable character detection. * file_format.py: * Use io.TextIOWrapper() to iterate lines from |file_obj|. * Caveat: Needs to specify newline='\n' so '\r' does not wrap! * Replace shutil.copyfileobj() with simple dst.write(src.read()). * Tests: * assert{Not}Equals() -> assert{Not}Equal(). * PRESUBMIT.py: Limit tests to use Python 3 only. Notes on scripts that use SuperSize: * Change shebang & invokes: {python, vpython} -> {python3, vpython3}. * sizes.py: * Kept in Python 2, owing to dependence on tracing.value. * trybot_commit_size_checker.py: * _SizeDelta: Replace __cmp__() with __lt__(). Bug: 1054018 Change-Id: Ib374331dec67c027db9f95ab3d5e3dfb780b62a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107794Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#752525}
-
