GitLab

This reverts commit fa1f0b26.

Reason for revert: Looks to have broken the build.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F26445%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

In file included from ../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.cc:5:
../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.h:10:10: fatal error: 'sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h' file not found
#include "sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h"

Original change's description:
> Create sandbox::SeatbeltExtension to dynamically expand the Mac sandbox policy.
> 
> Sandbox policy extensions can be issued for resources in a trusted process,
> which generates a token that may be passed over Mojo IPC. The receiving process
> can then consume the token to be granted access to the resource. Currently only
> file-read extensions are permitted.
> 
> Bug: 510604
> Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317
> Reviewed-on: https://chromium-review.googlesource.com/685583
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505819}

TBR=jschuh@chromium.org,rockot@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

Change-Id: Ic0fc32e651db586169ecd127c1674cd8dc205915
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 510604
Reviewed-on: https://chromium-review.googlesource.com/696343Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505843}

BUG=763260
TBR=ccameron@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic487862b1da9406c2d38947b9f9826631c18c63d
Reviewed-on: https://chromium-review.googlesource.com/692997
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505842}

This reverts commit fa1f0b26.

Reason for revert: Causing build failure on Mac official builder:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F26445%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> Create sandbox::SeatbeltExtension to dynamically expand the Mac sandbox policy.
> 
> Sandbox policy extensions can be issued for resources in a trusted process,
> which generates a token that may be passed over Mojo IPC. The receiving process
> can then consume the token to be granted access to the resource. Currently only
> file-read extensions are permitted.
> 
> Bug: 510604
> Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317
> Reviewed-on: https://chromium-review.googlesource.com/685583
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505819}

TBR=jschuh@chromium.org,rockot@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

Change-Id: I943e64875b7d83d61d85ad3f4626d8abdc44e553
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 510604
Reviewed-on: https://chromium-review.googlesource.com/696302Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505841}

This CL has consists of several small changes:
  * The browser process now asks the profiling service to dump all profiled
  processes. Previously, the browser process was incorrectly iterating through
  all processes on the system and requesting dumps.
  * The profiling service now only requests a single global vm_regions dump from
  the memory_instrumentation interface.
  * The browser process now emits the results with the correct dump guid and
  pid.

Bug: 769579
Change-Id: I67778d806729df1fe7c2d82a27a2cf4cf6b62745
Reviewed-on: https://chromium-review.googlesource.com/688717
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505840}

Because legacy audits is deprecated and has very low usage, 
we should make it a remote module to slim down Chrome's binary size.

Bug: 717085
Change-Id: I9e79912853a1340f059b8787d53de36b3f2343ad
Reviewed-on: https://chromium-review.googlesource.com/692991
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505839}

The test has sometimes been timing out.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fanimations%2Fresponsive%2Fzoom-responsive-transform-animation.html

BUG=750549

Change-Id: I66df550c126985f597ab391b16dd8f217f6955bc
Reviewed-on: https://chromium-review.googlesource.com/695421
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505838}

Bug: b/67038254 (Google-internal)
Change-Id: Id26940af69e8d56b0f4740ef447226d29b2368ef
TBR: palmer@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/695935Reviewed-by: Lucas Garron <lgarron@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505837}

- Always overwrites the destination, if it is a file.
- Does not touch destination permissions when overwriting.
- On POSIX, preserves and follows destinations that are symlinks.
- On POSIX, file permissions for the destination is platform dependent.

Then document these in the header, since these details may be important
to the caller.

Change-Id: Ibd47fa95aac29a35d798e5c19d1da1a64df63754
Reviewed-on: https://chromium-review.googlesource.com/686001
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505836}

The only functional changes are on RPM:
* Removed zlib dependency.  The package only provides libz.so, and
  none of our binaries link against that.
* Added ca-certificates dependency.  It is now available on all
  supported RPM-based distros.

BUG=750947
R=thestig@chromium.org
TEST=install on minimum supported distros

Change-Id: I87555ed26e5fb44630b8fbfcaf049a21e093fa9c
Reviewed-on: https://chromium-review.googlesource.com/691300Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505835}

R=rsesek@chromium.org

Change-Id: I32957da792c6a3ab6820edae373fdd9917328e1a
Reviewed-on: https://chromium-review.googlesource.com/696036Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505834}

Creates a ToolbarCoordinator which is now the public interface of
ToolbarController for BVC.

Makes ToolbarCoordinator the IncognitoViewControllerDelegate for NTP
instead of BVC.

Bug: 
Change-Id: Ie46c5bf50892b46aa04c370dbc9acf3328a26bcc
Reviewed-on: https://chromium-review.googlesource.com/691048Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505833}

In a soon-upcoming change, GLRenderer will want more fine-grained
control over the read-back process. Therefore, this change splits the
impl that reads-back RGBA textures as Y+U+V planes in system memory:
It introduces a I420Converter, which is just the impl that converts RGBA
textures into Y+U+V textures. Then, the existing ReadbackYUV retains its
full functionality, but now uses I420Converter for the everything that
happens before the read-back.

Testing note: All new/changed code is implicitly tested by existing unit
tests because ReadbackYUV depends on the new I420Converter. :)

Bug: 760351
Change-Id: I9cea7f110b1eb415b8b7e72d66b24391447978d8
Reviewed-on: https://chromium-review.googlesource.com/693381
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505832}

Bug: 769098, 756046
Change-Id: I134d37276c02e38f38e9d3677683912dbceb7b39
Reviewed-on: https://chromium-review.googlesource.com/688475
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505831}

Add flag in chrome://flags that allows the turning on and off of
downloads a foreground service for all versions of Android.

Bug: 747563
Change-Id: I27a0495c93560f0a8915162228b9d51d5420e060
Reviewed-on: https://chromium-review.googlesource.com/679607
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505830}

The tests have flaked recently because transition end
events were not received within a second of the expected
time.

We now allow 3 seconds (instead of 1) before the tests give up and
report failure. Note that in the common case, the events are received
almost immediately after the transitions complete, and the tests
finish without waiting for the timeout.

BUG=769879

Change-Id: I1b28cc0f1b9f29b0cb4b47f9a59b97af2213ebed
Reviewed-on: https://chromium-review.googlesource.com/694702Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505829}

Add usecounter for counting occurences of XHR within page dismissal (unload path) and histogram to see the distribution across callbacks (unload, pagehide etc)

Bug: 764104
Change-Id: Ic7ea74c5b79e35cee3935e3697f539ea668980d0
Reviewed-on: https://chromium-review.googlesource.com/668140
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505828}

We currently have one `console.log` in bluetooth-helpers.js.  This isn't
strictly needed and it's also disallowed by the presubmit check for
wpt/.

This change also rejects unexpected messages from iframes in
getHealthThermometerDeviceWithServicesDiscovered.

BUG=509038

Change-Id: I06dceb20ada4b0123ed7a4af3e25641fc019a338
Reviewed-on: https://chromium-review.googlesource.com/691414Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505827}

This issue was uncovered by a libFuzzer test, apparently the video
config read from the input stream might be invalid.

Bug: 763023
Change-Id: I83b181ad2ce0a9f0e1cbae27497252b339381f51
Reviewed-on: https://chromium-review.googlesource.com/695386Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505826}

Adds the ability for devtools to know where a file was saved on disk
when a save dialog was saved. This will allow us to serve files from
disk for interception.

R=pfeldman,dgozman
BUG=760316

Change-Id: Ic4477032219c66d00439bc7adecdb4783512a418
Reviewed-on: https://chromium-review.googlesource.com/690625Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505825}

ManagedDisplayInfo does not need to know about input devices. The reason
input devices were introduced to this class was to work with stylus. But
even then, the stylus appears like a touchscreen that generates touch
events for ManagedDisplayInfo.This means that ManagedDisplayInfo does
not need to know about the stylus and should only care about
touchscreens. This patch removes the concept of arbitrary input devices
from ManagedDisplayInfo and instead replaces it with touch devices only.

This patch also migrates from using input device ids, which are
dynamically generated at runtime, to using a persistent input device
identifier that stays the same across every system shutdown. This is a
stronger association that is necessary if we want to store touch
calibration and touch association preferences across system shutdown
or device dis/connections.

Bug: 599985
Change-Id: Ia5da98a587402d37b06b5f46a10a2bb7e861cb81
Component: ChromeOS, Touch device, ManagedDisplayInfo, Touch Calibration
Reviewed-on: https://chromium-review.googlesource.com/691514
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505824}

Since it is possible to have a PPS (Picture Parameter Set)
before a SPS (Sequence Parameter Set) in a stream.
In this case, any PPSes that comes before the SPS will be
ignored.

Bug: b/64957546
Test: run media_unittests
Test: manual
Change-Id: I53f7d8252f5205655e139e4f955947dd0ed13a5e
Reviewed-on: https://chromium-review.googlesource.com/673833Reviewed-by: Kongqun Yang <kqyang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505823}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=wjmaclean@chromium.org

Bug: 666525
Change-Id: I2adf34e7e6d72b4e8391fa3b1e141cddaf0c9288
Reviewed-on: https://chromium-review.googlesource.com/688769Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505822}

Needed to build DRM ozone on jessie.

Bug: 
Change-Id: I58634440075d49b873e55951cb97c11da51c8047
Tbr: adlr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/693160Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505821}

This CL adds missing MIPSEL support for creating .deb/.rpm packages.
Also fixes issue with crosscompile and calling "install -s".

BUG=758654

Change-Id: I1fee33fab48db644e3ff9870bd315e9c8f134877
Reviewed-on: https://chromium-review.googlesource.com/674872Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505820}

Sandbox policy extensions can be issued for resources in a trusted process,
which generates a token that may be passed over Mojo IPC. The receiving process
can then consume the token to be granted access to the resource. Currently only
file-read extensions are permitted.

Bug: 510604
Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317
Reviewed-on: https://chromium-review.googlesource.com/685583Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505819}

This change was accidentally removed from CL 685694 before landing and was already 
reviewed by dmazzoni in that CL.

It listens to the events for the passed-in process and uses out-of-context mode to capture 
the MSAA/IA2 events for general listening when not linked against the browser itself.

Bug: 768984
Change-Id: Ied391e3bcf8718b5ca09b9e657a5317444f5f1a4
Reviewed-on: https://chromium-review.googlesource.com/695727Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505818}

In Android O "ps" only returns the user's processes (generally just the "ps"
command itself). Run both the bare "ps" command and with the flag "-A" to
handle Android O.

Move to using ps && ps -A for chromedriver process inspection

Bug: chromedriver:2013
Change-Id: I1cc667f2ec6ff9ac5363ad7f8d34614a16badf3b
Reviewed-on: https://chromium-review.googlesource.com/696163Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505817}

Also refines the client-side criteria for when the menu header is
showing. If the toolbar is not showing, the menu header shouldn't show
since there is nothing to for the IPH bubble to point to.

BUG=756473,767794

Change-Id: I3343dcf768611133753a0a38badef46863765086
Reviewed-on: https://chromium-review.googlesource.com/690447
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505816}

This histogram records how much, in bytes, of the response body has been read
from network by a URLLoader before it pauses reading, when it receives a
PauseReadingBodyFromNet() call. If there are multiple calls to
PauseReadingBodyFromNet(), only a single value is recorded for the last call.
This histogram is recorded by URLLoader implementations that fetch from network.
When SafeBrowsing indicates that a resource may be unsafe and therefore a more
time-consuming check is required to classify it, reading response body from
network is paused in order to reduce the chance of writing unsafe contents into
cache. This histogram is useful to evaluate how much data is cached during this
window.

BUG=715673

Change-Id: I4e0878b10f4622ce48113b25a107df6248f16126
Reviewed-on: https://chromium-review.googlesource.com/685747
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505815}

This is used for the "manage people" bubble accessible from the avatar
menu. It doesn't compile on Chrome OS so the USE_ASH blocks are
obsolete.

The JS is shared with the Chrome OS login screen, which still uses
kKeyCanRemove, so we can't delete the flag altogether.

Bug: 770866
Change-Id: I55f63800f98e28ebd9358812c3b634b65041a904
Reviewed-on: https://chromium-review.googlesource.com/695944Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505814}

Adds a warning triangle if request interception is currently active.

R=pfeldman,dgozman
BUG=760316

Change-Id: I7ad10215bc20885fd78b13c5d870c3c9f0745e6f
Reviewed-on: https://chromium-review.googlesource.com/690954
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505813}

This cleans up several call-sites in the new test framework that's just
copy-and-paste code.

Bug: 667560
Change-Id: I7da98a1d25f4103f7e1789067f6f0ed3651830d1
Reviewed-on: https://chromium-review.googlesource.com/693144Reviewed-by: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505812}

This increases the number of samples used in the primary framebuffer.

Bug: 752085
Change-Id: I869ae41943db925aff845b3d1da15e8130b14e45
Reviewed-on: https://chromium-review.googlesource.com/680374Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505811}

Bug: 768167
Test: fast/loader/navigate-during-javascript-url-commit.html
Change-Id: I4d02d38faeb877febd84b5ba800276c8be95d7ca
Reviewed-on: https://chromium-review.googlesource.com/671462
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505810}

This CL suports generating code coverage report for multiple targets.

Bug: 757515
Change-Id: Ic74dfab8fd33f8f9b93cad647405effad49fb1ba
Reviewed-on: https://chromium-review.googlesource.com/692572
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505809}

The documentation only gave examples of calling base::Passed
with a pointer.

Change-Id: I86c516546b55e6dcd62f8c83cdff859cba64578d
Reviewed-on: https://chromium-review.googlesource.com/688685
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505808}

Forcing the structure of the handlers to be like this will help avoid
TOCTOU errors.

BUG=602688

Change-Id: I50626770f3f123c40f45680661d97ca9e1416129
Reviewed-on: https://chromium-review.googlesource.com/695842Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505807}

https://pdfium.googlesource.com/pdfium.git/+log/1cfdb58521aa..951b1119d4c7

$ git log 1cfdb5852..951b1119d --date=short --no-merges --format='%ad %ae %s'
2017-10-02 dsinclair More define cleanup
2017-10-02 dsinclair Remove extraneous ;s
2017-10-02 art-snake Remove useless code.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I6f3289e09d69054e1f95d318c61a1010cf32b472
Reviewed-on: https://chromium-review.googlesource.com/695816
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505806}

This CL changes AutofillQueryResponseContents proto in order to support
multiple field predictions. A field may have several server-side
predictions. For example, for the same field we can have two different
classifications: |EMAIL_ADDRESS| and |USERNAME| and both are important.
This CL also updates how the response proto is parsed and the process of
choosing the autofill predictions which are useful for password manager.

The CL was almost done by Madalina (https://chromium-review.googlesource.com/c/chromium/src/+/664704). 
Here I applied a couple of comments from reviewer when Madalina's internship finished.

Bug: 699530
Change-Id: I65b3ca8683e03b5d85049f3180971bcdeb1a1309
Reviewed-on: https://chromium-review.googlesource.com/677298Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505805}

BUG=761655

Change-Id: Ib3bde429ea024b97a8713daa1d870f10de69daff
Reviewed-on: https://chromium-review.googlesource.com/692852Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505804}