GitLab

Autofill no longer supports segmented key/value pairs when entering data through the DOM UI.

 - testFillProfileCrazyCharacters - fixed data file by removing all segmented phone/fax key/value pairs.
 - testSegmentNumbersNotSupportedInDOMUI - verifies that segmented data no longer supported through DOM UI.

TEST=none
BUG=83686
Review URL: http://codereview.chromium.org/6992049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86709 0039d316-1c4b-4281-b951-d872f2087c98

Insert meta tag turning on content-security-protection for chrome://settings, history, downloads pages now that the webkit inspector has been revised to stop calling JS eval().
Review URL: http://codereview.chromium.org/7038046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86708 0039d316-1c4b-4281-b951-d872f2087c98

Also added an OWNERS file to that subdirectory.
Review URL: http://codereview.chromium.org/7066035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86707 0039d316-1c4b-4281-b951-d872f2087c98

Reenable the ChromeFrame ContextMenuTest.CFSaveLinkAs test. Increased the timeout for the file save as
operation. Fixed a bug in the SaveFile action where there was a sleep before checking whether the timeout
had occurred.

BUG=83114
TEST=ChromeFrame ContextMenuTest.CFSaveLinkAs test should pass.
Review URL: http://codereview.chromium.org/7069023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86706 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none
Review URL: http://codereview.chromium.org/7004040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86705 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6987029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86704 0039d316-1c4b-4281-b951-d872f2087c98

Include change to CrosMock::SetNetworkLibraryStatusAreaExpectations() so that tests pass.
Original CL+Review: http://codereview.chromium.org/7031040/

BUG=none
TEST=ChromeOS tests pass, 'Private networks' option should always show up in ChromeOS Networks menu.

Review URL: http://codereview.chromium.org/6992074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86703 0039d316-1c4b-4281-b951-d872f2087c98

Behavior should now be close to Windows in this regard.
BUG=75035
R=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/6987028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86702 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kinuko@chromium.org
BUG=83944
TEST=heapcheck should cycle green

Review URL: http://codereview.chromium.org/7008017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86700 0039d316-1c4b-4281-b951-d872f2087c98

Initializing a decoder is asynchronous, so add a callback to tell client
when the decoder is ready to use.
I confirmed that this works locally using a C plugin that I wrote on my machine.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7065010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86699 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change the posix implementations are used, so the return values are "Darwin" and the Darwin version.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/7065041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86698 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6979014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86697 0039d316-1c4b-4281-b951-d872f2087c98

Return NSDragOperationCopy for BookmarBarButton drags and NSDragOperationMove
for other drag types. Updated unit tests to set a BookmarkBarButton as the
mock |draggingSource| for bookmark bar dragging tests and made the tests
check for the expected drag operation type.

BUG=83228
TEST=Drag a link from a page and hover over the BMB. Cursor should be a (+).
Drag a bookmark button. Cursor shouldn't be a (+).

Review URL: http://codereview.chromium.org/7048009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86696 0039d316-1c4b-4281-b951-d872f2087c98

Change GetVisitCountToHost() to GetVisibleVisitCountToHost(), and restrict it to returning "user-visible" visits.  This makes the Page Info bubble and the download system more restrictive about considering when someone "first visited" a site, so that they don't consider things like subframe navigations or redirects.

BUG=81741
TEST=Page Info bubble should not say you've visited a site before today if your only visits in previous days were subframe navigations.
Review URL: http://codereview.chromium.org/6990074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79251
TEST=manual

Review URL: http://codereview.chromium.org/7004058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86694 0039d316-1c4b-4281-b951-d872f2087c98

set the expected errors accordingly with touch build

BUG=
TEST=AssertionTest.* & CheckFalseTest.* pass on touch build


Review URL: http://codereview.chromium.org/7053019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86693 0039d316-1c4b-4281-b951-d872f2087c98

The changes for the codereview.chromium.org/6992047 include some added binary
test files, which don't work with try jobs. I'm submitting them in this
separate CL in order to be able to run try jobs.

BUG=none
TEST=none

TBR=mpcomplete@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/6992079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81741,83836
TEST=Memory bots go green
Review URL: http://codereview.chromium.org/7053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.*

R=tsepez@chromium.org,evan@chromium.org

Review URL: http://codereview.chromium.org/7008005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/7008015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86688 0039d316-1c4b-4281-b951-d872f2087c98

Had to move from content/gpu to content/common/gpu to allow gpu_video_service.cc
to depend on the decoder.
Removed some dead code and did some random cleanup while I was in there.

BUG=none
TEST=chrome compiles on cros/arm!

Review URL: http://codereview.chromium.org/7057027

TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/6979017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/6987030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=can connect w/o ClientLogin token.

Review URL: http://codereview.chromium.org/7008003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86685 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2.  Fixes flake.

Without change: 18 failures out of 250 runs on my machine.  3 out of 250 on Linux try bot.

With change: 0 failures out of 250 runs on my machine.  0 out of 250 on Linux try bot.

TEST=Run ExtensionApiTest.Notifications many times.
BUG=42314


Review URL: http://codereview.chromium.org/7064038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86682 0039d316-1c4b-4281-b951-d872f2087c98

Had to move from content/gpu to content/common/gpu to allow gpu_video_service.cc
to depend on the decoder.
Removed some dead code and did some random cleanup while I was in there.

BUG=none
TEST=chrome compiles on cros/arm!

Review URL: http://codereview.chromium.org/7057027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7066039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86679 0039d316-1c4b-4281-b951-d872f2087c98

- added ViewsDelegate::GetDispositionForEvent() pure virtual
- added MenuModelAdapter
- added unit test for MenuModelAdapter
- added comment for MenuModel::GetFirstItemIndex() that callers may pass NULL for NativeMenu argument
- fixed index offset bug in MenuModel::GetModelAndIndexForCommandId()
- fixed spurious call to MenuDelegate::IsCommandEnabled()

BUG=none
TEST=included


Review URL: http://codereview.chromium.org/7067032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83761
TEST=Print preview always work on Mac

Review URL: http://codereview.chromium.org/7031044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86676 0039d316-1c4b-4281-b951-d872f2087c98

with CHECK_EQ, so on failure, value will appear in minidumps.

BUG=69198
TEST=none

Review URL: http://codereview.chromium.org/7031054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no

Review URL: http://codereview.chromium.org/7067024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86674 0039d316-1c4b-4281-b951-d872f2087c98

Add web_ui_util::ChromeURLHostEquals and update some checks.
RIP kChromeUIAppLauncherURL (arv:r46266 - tfarina:r62866).
RIP kDefaultOptionsSubPage (zelidrag:r56816 - estade:r76329/r76490).
Remove unnecessary stdlib.h include and some extra spaces.

BUG=55771
TEST=None

Review URL: http://codereview.chromium.org/7049004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86673 0039d316-1c4b-4281-b951-d872f2087c98

This should fix some crashes that end up calling the event filter of a
destroyed message pump.

BUG=none
TEST=some randomly failing unit tests (e.g.  SessionServiceTest.GetCurrentSession)

Review URL: http://codereview.chromium.org/7031057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86672 0039d316-1c4b-4281-b951-d872f2087c98

Also added a comment. This string should only be passed in for
WebGL. If it is being passed in for any other reason it is a bug
and needs to be fixed.

TEST=none
BUG=none

R=jamesr@chromium.org

Review URL: http://codereview.chromium.org/7067034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83537
TEST=In compact nav mode, ensure that clicking an active (foreground) tab shows the compact location bar with the text selected.
Review URL: http://codereview.chromium.org/6992034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7031053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86669 0039d316-1c4b-4281-b951-d872f2087c98

Please not that a couple of clean-ups will follow this. Consider this really stable once bug 60099 is labeled as fixed.

BUG=60099
TEST=no

Review URL: http://codereview.chromium.org/6992022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82590,77090
TEST=Prerender*

Review URL: http://codereview.chromium.org/6966017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60099
TEST=no

Review URL: http://codereview.chromium.org/6990054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86666 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash when creating a desktop shortcut for apps with missing icons (use the default app icon instead).

BUG=79282
TEST=See bug.


Review URL: http://codereview.chromium.org/7065037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86665 0039d316-1c4b-4281-b951-d872f2087c98