GitLab

Android framework does not provide an easy way to remove keyboard app
from the testing (unless you use Robolectric).

So far we have been allowing the current keyboard app to interfere with
test and thus flaked test results. Especially, when you make selection
change, Google Latin Keyboard tries to look at the new status by running

beginBatchEdit() -> getTextBeforeCursor() -> endBatchEdit().

And this disrupted batch edit logic such as mInBatchEditMode.

With this change, onCreateInputConnection() will now return null, so
keyboard app cannot interact with the text. Also, dispatchKeyEvent
will ignore key events when it has to.

Note that the test can still interact with BaseInputConnection's method
and thus affects EditText's Editable through UrlBar#getInputConnection().

In doing so, I've guarded KeyUtils#dispatchKeyEventToView() to work with
UI thread.

BUG=723901

Review-Url: https://codereview.chromium.org/2894073002
Cr-Commit-Position: refs/heads/master@{#473782}

Instead replace it with an appropriately styled div.

As a fortunate side-effect, this CL makes the box-shadow effect work
in Vulcanized mode, because it side-steps https://github.com/Polymer/polymer-css-build/issues/13

BUG=598516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885363006
Cr-Commit-Position: refs/heads/master@{#473781}

Clarified that the crx_file.* refers to CRX₂, moved verification out of the CRX₂ code to allow callers to specify CRX₃-permissive policies.

Also fixed a potential crash in extension_creator.cc.

BUG=720092

Review-Url: https://codereview.chromium.org/2874503002
Cr-Commit-Position: refs/heads/master@{#473780}

https://skia.googlesource.com/skia.git/+log/bcd8637772e3..5592382a7ad1

$ git log bcd863777..5592382a7 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 egdaniel Remove setting of alpha coverage in text ops when in LCD mode
2017-05-22 jvanverth Cache ambient and spot shadows at a canonical position
2017-05-22 egdaniel Fix to lcd blending in ganesh
2017-05-22 mtklein Revert "Revert "mark SkRasterPipelineBlitter final""
2017-05-22 brianosman Revert "Remove compressed (ETC1) texture support from Ganesh"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I4df06228d04a5eb3354998ed45ca124c03ae6185
Reviewed-on: https://chromium-review.googlesource.com/511643Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473779}

When user selects "Always translate page", if the page is untranslated,
then translate the page, and make UI changes to indicate selected
tab on the infobar.

BUG=724670

Review-Url: https://codereview.chromium.org/2899663002
Cr-Commit-Position: refs/heads/master@{#473778}

Revert of Switch BrowserAccessibilityStateImpl to the TaskScheduler API. (patchset #3 id:40001 of https://codereview.chromium.org/2888773002/ )

Reason for revert:
This is causing some issues on ChromeOS.

See crbug.com/725247

Original issue's description:
> Switch BrowserAccessibilityStateImpl to the TaskScheduler API.
>
> It doesn't look like the #if defined(OS_WIN) block is necessary here, everything could be handled by the task scheduler directly.
>
> BUG=689520
>
> Review-Url: https://codereview.chromium.org/2888773002
> Cr-Commit-Position: refs/heads/master@{#473281}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e0346d1ef0851ad07bf00fafefdd747bf30baed

TBR=dmazzoni@chromium.org,fdoray@chromium.org,aboxhall@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=689520

Review-Url: https://codereview.chromium.org/2899623003
Cr-Commit-Position: refs/heads/master@{#473777}

https://pdfium.googlesource.com/pdfium.git/+log/ed75ee25f40a..355954b8f09a

$ git log ed75ee25f..355954b8f --date=short --no-merges --format='%ad %ae %s'
2017-05-22 weili Fix crypto calculation regression due to typo

Created with:
  roll-dep src/third_party/pdfium
BUG=725267


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iad57886e1fbfd37c21a956653333f1d820415c46
Reviewed-on: https://chromium-review.googlesource.com/511187
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473776}

These are the first Web Platform Tests for the Individual Transform
Properties.

Spec:
https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=722696

Review-Url: https://codereview.chromium.org/2882153004
Cr-Commit-Position: refs/heads/master@{#473775}

This regressed in r472101 wich made the network service pointer get initialized in non-test code earlier.

BUG=720374

Review-Url: https://codereview.chromium.org/2895353002
Cr-Commit-Position: refs/heads/master@{#473774}

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy. WebPresentationReceiver::RemoveConnection() is invoked when receiver connection changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_ pointer to ReceiverConnectionProxy

BUG=713227

Review-Url: https://codereview.chromium.org/2874483002
Cr-Commit-Position: refs/heads/master@{#473773}

When non-base-level texture image is attached, it is required that texture is
mipmap complete for the fbo to be complete. Currently command buffer doesn't
check this.

BUG=722684
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2895493002
Cr-Commit-Position: refs/heads/master@{#473772}

This CL allows us to override the AXPlatformNode's GetFromUniqueId
method.  In BrowserAccessibilityComWin we implement this by using the
BrowserAccessibility GetFromUniqueId.

BUG=703369

Review-Url: https://codereview.chromium.org/2894673003
Cr-Commit-Position: refs/heads/master@{#473771}

BUG=725265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2901643002
Cr-Commit-Position: refs/heads/master@{#473770}

This CL:

1) Replaced AwContentsIoThreadClient with AwContentsIoThreadClientImpl
2) Replaced InputStream with InputStreamImpl
3) Replaced AwWebResourceResponse with AwWebResourceResponseImpl, and
   moved implementation into browser/net/.

Replacing them due to the merge of native/ and browser/

BUG=716604

Review-Url: https://codereview.chromium.org/2889193004
Cr-Commit-Position: refs/heads/master@{#473769}

With BLE, we only check the RSSI, so we can now remove all references to the TX
power proximity strategy.

Review-Url: https://codereview.chromium.org/2898513002
Cr-Commit-Position: refs/heads/master@{#473768}

Links the native visualizers into the PDB so that Visual Studio will pick up the visualizers with no user action.

Adds visualizers for base::flat_set, base::flat_tree (these two had the info buried in several levels of tree), base::ManualConstructor (requires a cast), and base::Value (decodes the union).

Removes some aura visualizers. I didn't see these as adding much value.

Simplifies many of the other visualizers to only improve the summary and not list any <Expand> items. This causes VS to show the default expansion. Many of these seemed unhelpful and possibly confusing (converting gfx::Point's "x_" to "X"), dangerously misleading (converting Skia's rect which is left, top, right, button to use width, height format), and broken (GURL's components had typos and didn't work).

Review-Url: https://codereview.chromium.org/2895043002
Cr-Commit-Position: refs/heads/master@{#473767}

check whether the printing render frame host has been initialised before accepting a message in the headless print manager

BUG=

Review-Url: https://codereview.chromium.org/2890133002
Cr-Commit-Position: refs/heads/master@{#473766}

Notable changes:
 - Do not use WaitForCondition method that times out (tests should not
   timeout) and use one that returns bool.
 - Moved setup code from constructor to SetUp, so it is executed after
   the server actually started.
 - Increased timeout for the test to 5 seconds, which is a reasonable
   timeout to allow page load and one roundtrip message exchange.
 - Marked test as flaky to let it run on bots before fully enabling it.

BUG=720098

Review-Url: https://codereview.chromium.org/2895333003
Cr-Commit-Position: refs/heads/master@{#473765}

FontList::Derive(..) is slow (typically requiring IPC with the font
server), has unpredictable results with special UI fonts on Mac, and
encourages use of magic numbers like "-1".

Instead, use context and style constants from the Chrome typography
spec, where available. When an equivalent font is not available, use
ResourceBundle to avoid a behavior change in this CL.

BUG=721834

Review-Url: https://codereview.chromium.org/2899653002
Cr-Commit-Position: refs/heads/master@{#473764}

This class contains GC pointers and should be traced. Due to
a bug in the GC plugin, this wasn't being enforced. This also
changes the class to be a part object to clarify lifetimes.

Bug: 724418
Change-Id: I46d037d7f5040bc942b6bdf54d8d8a134914134b
Reviewed-on: https://chromium-review.googlesource.com/509149Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473763}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2876273004
Cr-Commit-Position: refs/heads/master@{#473762}

The add printer dialog was crashing in Guest Mode because a
PrinterDetector could not be constructed.  It is okay for
PrinterDetector to be shared between logged in profiles.

BUG=724278

Review-Url: https://codereview.chromium.org/2898833002
Cr-Commit-Position: refs/heads/master@{#473761}

Revert of Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (patchset #2 id:20001 of https://codereview.chromium.org/2893523004/ )

Reason for revert:
This test passes after the fixes on issue webrtc:7532. See the explanation https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they are related.

Original issue's description:
> Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots.
>
> BUG=chromium:722746
>
> Review-Url: https://codereview.chromium.org/2893523004
> Cr-Commit-Position: refs/heads/master@{#472824}
> Committed: https://chromium.googlesource.com/chromium/src/+/7498e9b31a8ed8fd1d1fac071916cf824e48e2c5

TBR=tommi@chromium.org,philipel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:722746

Review-Url: https://codereview.chromium.org/2903463002
Cr-Commit-Position: refs/heads/master@{#473760}

BUG=724441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898023002
Cr-Commit-Position: refs/heads/master@{#473759}

We're getting CL patches raw from Gerrit, which means we were trying
to take a patch with non-exportable changes and apply it wholesale
to WPT. This fixes that problem by filtering all Gerrit patches
and removing the Chromium WPT directory prefix from all applicable
files in the patch.

Bug: 722435
Change-Id: I1e7e27fabddbb6c2d4d2851c4c9a4b1426893d05
Reviewed-on: https://chromium-review.googlesource.com/506559
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473758}

(landing for holte@ who is OOO; original CL is https://codereview.chromium.org/2883563002/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte

Review-Url: https://codereview.chromium.org/2893943004
Cr-Commit-Position: refs/heads/master@{#473757}

retrieve the current exposure time and use it for the exposureMode == manual

Bug: 724730
Change-Id: I6a4e7dff5a89f72d31be45c85668c3e7d1ba9f99
Reviewed-on: https://chromium-review.googlesource.com/509173Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473756}

In network quality estimator (NQE), change the minimum number of
requests in flight required before a throughput observation can be
taken. The parameter is controlled using field trial params, with
default value set to 1.

BUG=725146

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2893933004
Cr-Commit-Position: refs/heads/master@{#473755}

BUG=526324

Review-Url: https://codereview.chromium.org/2886363002
Cr-Commit-Position: refs/heads/master@{#473754}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/248d445e..2282ee55

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2899893002
Cr-Commit-Position: refs/heads/master@{#473753}

This CL adds several Storage.BytesRead.XXX and Storage.BytesWritten.XXX histograms.
The size of each read or write is logged at a low level for:
CacheStorage, IndexedDB, ServiceWorker, and AppCache.

Storage.BytesXXX.LevelDBEnv.IDB corresponds to IndexedDB. Some other leveldb consumers
are also instrumented, for example LevelDBEnv.ServiceWorker, but not all of them are
differentiated from one another, they are logged as LevelDBEnv, and some aren't
instrumented at all.

Here are the labels...

<histogram_suffixes name="Storage.Bytes" separator=".">
  <suffix name="DiskCache.AppCache" label="AppCache usage."/>
  <suffix name="DiskCache.CacheStorage" label="CacheStorage usage."/>
  <suffix name="DiskCache.ServiceWorker"
      label="ServiceWorker scriptcache usage."/>
  <suffix name="LevelDBEnv" label="Undifferentiated leveldb usage."/>
  <suffix name="LevelDBEnv.IDB" label="IndexedDB usage."/>
  <suffix name="LevelDBEnv.ServiceWorker"
      label="ServiceWorker database usage."/>
  <suffix name="MojoLevelDBEnv" label="Mojo leveldb component usage."/>
  <affected-histogram name="Storage.BytesRead"/>
  <affected-histogram name="Storage.BytesWritten"/>
</histogram_suffixes>

BUG=605758

Review-Url: https://codereview.chromium.org/2858133002
Cr-Commit-Position: refs/heads/master@{#473752}

Removes the flags guarding the new NTP over the tab switcher design
and replaces ChromeHomeNewTabPageTest with
BottomSheetNewTabControllerTest.

BUG=695973

Review-Url: https://codereview.chromium.org/2891343003
Cr-Commit-Position: refs/heads/master@{#473751}

BUG=724905

Review-Url: https://codereview.chromium.org/2895323002
Cr-Commit-Position: refs/heads/master@{#473750}

TBR=smut

Review-Url: https://codereview.chromium.org/2896113002
Cr-Commit-Position: refs/heads/master@{#473749}

* Uses window.location.href over mainTarget.inspectedURL when available

BUG=724558
R=dgozman,paulirish

Review-Url: https://codereview.chromium.org/2895913003
Cr-Commit-Position: refs/heads/master@{#473748}

This change defers syncing TopSites with history until the first tab
closure and ignores any TopSites updates that arrive before that time.
It also makes the category titles ever-present in the JumpList and
removes the old balancing strategy that used to show more most visited
items when there were fewer than 3 recently closed items.

The JumpList will now retain its items from a previous launch until
the first tab closure, making it more useful early on in the browser's
lifetime. Also, there will be no unnecessary TopSites syncs now if an
user launches Chrome but shuts it down before opening any tabs. After
that initial tab closure, all old recently closed items are lost as it
is not possible to query Windows for them. Removal of the balancing
strategy trims out waste resulting from fetching 9 items initially,
which are then trimmed down as tabs are closed.

BUG=721484, 721486

Review-Url: https://codereview.chromium.org/2865133003
Cr-Commit-Position: refs/heads/master@{#473747}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2875393003
Cr-Commit-Position: refs/heads/master@{#473746}

There were issues in the past, I think, so this might not work, but we
do need release builds.

Bug: 
Change-Id: I29306490e9cb322fd136613b90478b3900b8e725
Reviewed-on: https://chromium-review.googlesource.com/511224Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473745}

Not enabled on Android because it requires calling video.play().

BUG=717732

Review-Url: https://codereview.chromium.org/2886893010
Cr-Commit-Position: refs/heads/master@{#473744}

Change-Id: I27b300eeb8d08b0deba54393cf872b54afbf8714
Reviewed-on: https://chromium-review.googlesource.com/509333Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473743}