- 30 Jul, 2018 40 commits
-
-
Ian Kilpatrick authored
This does two things: 1. Allows a new formatting context to be sized and positioned outside its layout opportunity when negative margins are present. This occurs when a layout opportunity inline dimensions matches the initial child available space (ignoring floats). Additionally when a new formatting context "jumps out" of its layout opportunity it ignores any floats which might impede it. 2. Performs layout inside an opportunity, and then checks if the result can fit within the same opportunity. Previously we were trying to position in an arbitrary layout opportunity, which fails the new-fc-relayout.html test. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6b44b6273be5c0f633e39a8875cc54ea0bc54480 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1150849 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#579064}
-
Owen Min authored
The MachineLevelCloudPolicy needs to support extension cloud policy with a new policy type kChromeMachineLevelExtensionCloudPolicyType. The ComponentCloudPolicyStore/Service has been created earlier for the new type but the store class doesn't aware of the new type. Add this type into the store class so that MachineLevelExtensionCloudPolicy can be applied to the extensions. 1) Update DomainConstants so that the new policy type is mapped to POLICY_DOMAIN_EXTENSIONS. 2) Append policy type as the new parameter of ctor. 3) Using the policy type from ctor to verify the policy data. 4) The policy type must match its associated policy domain. 5) The new policy type's scope is machine. 6) Load() and Clear() function only works on the policy data that is owned by the instance of ComponentCloudPolicyStore. Also refactor associated unit test and add test for the new type. Bug: 867028 Change-Id: I2117906153d0135b1372ae42bb884abce72fc9d6 Reviewed-on: https://chromium-review.googlesource.com/1148883Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579063}
-
Vadym Doroshenko authored
Form Parsing might be unsuccessful. This CL implements graceful behaviour in NewPasswordFormManager::CreatePendingCredentialsForNewCredentials when it happens. Bug: 831123 Change-Id: Ie354bfcfbb751569ffa326691f8ba90f5fbff42e Reviewed-on: https://chromium-review.googlesource.com/1154913 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579062}
-
Nicolas Ouellet-payeur authored
This is a thread-safe validity check for WeakPtr-based Callbacks using the recently added WeakPtr::MaybeValid(). Bug: 730693 Change-Id: I174efb30bb16d2776e33ec64d48a913943e770a0 Reviewed-on: https://chromium-review.googlesource.com/1144208 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579061}
-
Ioana Pandele authored
This aims to fix the case in which when moving focus to a different field (for which the action doesn't apply), the accessory is first shown and then the action is removed. When this happens, there is a perceivable delay before the action button disappears. Bug: 856971 Change-Id: I1dfb63c513d109b74592870d3d63277b8237df25 Reviewed-on: https://chromium-review.googlesource.com/1142150 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579060}
-
Joe Downing authored
This issue is due to a limitation in the tool used to curtain the session (CGSession). This is a known limitation which has existed for at least 10 years. Due to this platform problem, we cannot ensure success when in headless mode (in fact it is practically guaranteed to fail). My approach is to still try to curtain but disconnect the session with a host configuration error if it is running headless. If CGSession somehow succeeds, then the session will be curtained and the user can reconnect and the second attempt will succeed. Note that I am not adding a new error code for this condition yet. I'd like to avoid updating the web app / other clients until we know how often users actually encounter this issue. BUG=832748 Change-Id: Ic07c280b19d9dc44e290585e1a16bae835d37851 Reviewed-on: https://chromium-review.googlesource.com/1153560 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#579059}
-
Gauthier Ambard authored
This CL adds a trigger to the InProductHelp for the LongPress menu when a new Tab is opened from the TabGrid. Bug: 868789 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1fb6b128a4fc59c6f6c349f4cbe01d9c64bf94bf Reviewed-on: https://chromium-review.googlesource.com/1154908 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579058}
-
Ian Vollick authored
This change contains updates to the test app to cope with interface changes introduced in crrev.com/c/1147754. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia2491fd96819ba2f4fc95ab2cbaec2aedcee05f5 Reviewed-on: https://chromium-review.googlesource.com/1155003Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579057}
-
Marshall Greenblatt authored
Fix clang/scripts/update.py failure with DEPOT_TOOLS_WIN_TOOLCHAIN=0 and non-standard VS install location. If GYP_MSVS_OVERRIDE_PATH is set that value should be used instead of calling vs_toolchain.DetectVisualStudioPath(). R=brucedawson@chromium.org Bug: 863130 Change-Id: Id72b1a22f74c5fa9174a76d611fef9ca69bb8319 Reviewed-on: https://chromium-review.googlesource.com/1135761Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Marshall Greenblatt <marshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#579056}
-
Charlie Andrews authored
As decided in https://goo.gl/g5Srzn, we're no longer doing BattOr power measurement on the waterfall and consequently can't justify maintaining the significant C++ code required to do interactive BattOr tracing. This is the first Chrome-side CL to delete that code. (For additional context, see https://goo.gl/P9AR84 (google internal) or ping me to chat.) TBR=avi for BUILD.gn Bug: 859514 Change-Id: I4b6c0c6ac40abe9c593ce24e1bb0d68a4eeacd42 Reviewed-on: https://chromium-review.googlesource.com/1122489 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#579055}
-
crystallambert@chromium.org authored
a11y article contained outdated links and information. This gives a small update to content and links. Bug: none Change-Id: Ic820abc9aff3290043d346da20a01472e4c04bf3 Reviewed-on: https://chromium-review.googlesource.com/1101485 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579054}
-
Koji Ishii authored
This patch fixes to restore collapsed spaces when non-space was inserted before. This is seen in LayoutTest results.html, when it updates the number of failures, once collapsed space needs to be restored. Also, fixing this case ended up optimizing the re-using NGInlineItem conditions further. Allowing more cases to re- use hits hidden bugs. This CL includes fixes for them too. For instance, the re-use is possible when preserving white- spaces (e.g., <pre>) with this CL. It was almost always determined as not re-usable. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1d1224812b4e92e6582e3112f73372577a332bc3 Reviewed-on: https://chromium-review.googlesource.com/1154242Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#579053}
-
Mounir Lamouri authored
When EmbedSurface() is called, always check the playback state of the associated media player if there is one so we can guarantee that the Picture-in-Picture window matches the current known state. Bug: 868449 Change-Id: Iad61dcc67d5b6f4acc75dc5490883ea9733e75ad Reviewed-on: https://chromium-review.googlesource.com/1153464Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#579052}
-
Ian Swett authored
R=rch@chromium.org Bug: 698786 Change-Id: Ibb0e8edf1537b4da7e1948b97df02c55ed4af8ba Reviewed-on: https://chromium-review.googlesource.com/1148472 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#579051}
-
Charlie Andrews authored
TBR=brucedawson@chromium.org Bug: 861876 Change-Id: Icc3bafdf91fdf5a696ddf983442c1a7742ff40c5 Reviewed-on: https://chromium-review.googlesource.com/1154992Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#579050}
-
James Cook authored
We no longer have mash vs. classic configs in ash, and there's only one implementation of ShellPort. As a step towards eliminating ShellPort, remove the lock state methods from it. Bug: 866425 Test: ash_unittests Change-Id: I8c02c89b62ef43a1f14727e0baae79d07ed3c4b5 Reviewed-on: https://chromium-review.googlesource.com/1153844Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#579049}
-
Tobias Sargeant authored
Originally the evaluateJavaScript call was present to ensure renderer startup, but the convenience method now explicitly loads about:blank synchronously to achieve the same result. Bug: 865062 Change-Id: I81c19fe7cfe3257f44e379de5f05a5337c92ea4b Reviewed-on: https://chromium-review.googlesource.com/1154918Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#579048}
-
Boris Sazonov authored
This CL changes the strings used in the streamlined sign-in screen and 'Sync and Google services' Settings page to clarify how browser activity and interactions are used. Bug: 814728 Change-Id: I2d77d0129a23cd3a387a26166dcf8a3ebb066f8e Reviewed-on: https://chromium-review.googlesource.com/1153049Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579047}
-
Fernando Serboncini authored
If BeginFrameProvider is invalid, we should not pass RAF calls. Bug: 860102 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4bf971316bf93c19d4613f38c413575a0c2be17a Reviewed-on: https://chromium-review.googlesource.com/1147429Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579046}
-
Michael Thiessen authored
This reverts commit 3bb7dfb7. Reason for revert: Breaks other chromium-based browsers. Original change's description: > Hide VR Intent Dispatcher from Android Default Browser list. > > The Android platform's Default Browser code has a bug where it allows > the same package to show up multiple times despite not being able to > differentiate between the multiple components within the package that > caused it to detect multiple browsers within the package. > > We can trick it into thinking the VR intent handling code isn't default > browser material by providing a wildcard host, making Android think > the intent handler uses a URI authority when it really doesn't. > > Bug: 847921 > Change-Id: I2b271fc1c99495a0e80e301ff432690dd5a2d0a6 > Reviewed-on: https://chromium-review.googlesource.com/1079261 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574281} TBR=yfriedman@chromium.org,mthiesse@chromium.org,tedchoc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847921, 867583 Change-Id: I5580c3d43444a177e99f5f57fa93ca725312261d Reviewed-on: https://chromium-review.googlesource.com/1155068 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#579045}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d1d8f9815d76..009d0969867e git log d1d8f9815d76..009d0969867e --date=short --no-merges --format='%ad %ae %s' 2018-07-30 mbonadei@webrtc.org Add missing dependencies to sdk/android:native_unittests_java. Created with: gclient setdep -r src/third_party/webrtc@009d0969867e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8eebc69153c467342ae222518d664a374c666946 Reviewed-on: https://chromium-review.googlesource.com/1154947Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579044}
-
Gauthier Ambard authored
This CL adds a unit test for the force touch gesture recognizer added to the toolbar buttons, triggering the popup menu. Bug: 864430 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I756b16fea096cda8b1f3f1e563236d12e2d11e34 Reviewed-on: https://chromium-review.googlesource.com/1152926Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#579043}
-
Sergey Ulanov authored
Now the ContextProvider process passes data directory to the context process as /web_context_data namespace. If the caller doesn't provide dataDirectory then the ContextProvider start Context in incognito mode by adding --incognito flag. Bug: 852145 Change-Id: Id873d4334d59bac8781cb595ea836a0ace3434d4 Reviewed-on: https://chromium-review.googlesource.com/1149262Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579042}
-
David Bienvenu authored
The fix is to make menus without a parent widget take focus when run. Bug: 837520 Change-Id: I2dd286e4b10051c8a4fa460f1187eef8292cf517 Reviewed-on: https://chromium-review.googlesource.com/1142201 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579041}
-
Dave Tapuska authored
Follow up from https://chromium.googlesource.com/chromium/src.git/+/9d0fd86cf833cd7f35eea342f15c827516938d67 Adjust mojo template. It built correctly with clang but failed to build with GCC. BUG=652586, 819294 TBR=jam@chromium.org Change-Id: I985bf855d5fce1f2c774123a8f6103e97aedb9f6 Reviewed-on: https://chromium-review.googlesource.com/1154990 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#579040}
-
Michael Lippautz authored
Replaces the custom backlink from V8->Blink that was using a v8::External with a GC-aware backpointer that is encapsulated in the CustomWrappableAdapter interface. CustomWrappableAdapter establishes a link from a given JavaScript object to the Blink object inheriting from CustomWrappableAdapter. The link is known to garbage collectors and thus the Blink object will be kept alive as long as the JavaScript object is alive. The adapter can be used to model liveness across V8 and Blink component boundaries. In contrast to ScriptWrappable, there is no IDL definitions required and the JavaScript object must not escape to user-visible JavaScript. This reverts commit c1d0a59d. Bug: chromium:843903 Change-Id: I8763cdf56ff3cbeff5fa7ae508bc1be8a5deb1c3 Reviewed-on: https://chromium-review.googlesource.com/1154926Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579039}
-
Parastoo Geranmayeh authored
Problem: When we Autofill, to decide if we should fill a field or leave it as is, we check if the last edit was user's edit. If so, we would not autofill (clear, etc). But sometimes, the website writes on the top of the autofilled value (exp: formatting a phone number). So, if the user adds a value on the field, the JS would edit it, and it would be overwritten by autofill. Solution: Instead of looking at the last edit, look if the user has ever edited that field. Bug: 860542, 867556 Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa Reviewed-on: https://chromium-review.googlesource.com/1150683Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#579038}
-
Mythri Alle authored
We want to decouple the code cache from the HttpCache and recently added a separate code cache [1]. This cl is a follow up that actually writes the generated code into the code cache. There will be a followup cl that also fetches from the code cache. [1] chromium-review.googlesource.com/c/chromium/src/+/1120179 Bug: chromium:812168 Change-Id: I2866f8689b83ccba13ea8e0bcf7c60558997380d Reviewed-on: https://chromium-review.googlesource.com/1150237 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba191605..74c725b6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6816c9581b3caad59990787750c3483693b6fe94 Reviewed-on: https://chromium-review.googlesource.com/1154889Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579036}
-
Ebrahim Byagowi authored
After several tries it seems it is stable now so lets remove this bit. Bug: 792131 Change-Id: I54df2450ff46477473d0e68b3ab9448bfa599ff3 Reviewed-on: https://chromium-review.googlesource.com/1076808Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579035}
-
Thomas Tangl authored
When the unified consent toggle is switched off, the sync section and the non-personalized services section are expanded. Bug: 811517 Change-Id: I25e288e498c9397660f214ce61a1bed744c2cbf3 Reviewed-on: https://chromium-review.googlesource.com/1152986 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579034}
-
Kevin Schoedel authored
TouchExplorationController provides audio feedback for certain actions. This provides an interface for a platform-specific implementation of these sounds. Bug: b/73383411 Test: manual and touch_exploration_controller_unittest Change-Id: Ic6a6e4163ee651bf2446b6ebb3121f4372c32b17 Reviewed-on: https://chromium-review.googlesource.com/1153505Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579033}
-
Elly Fong-Jones authored
This UI was only reachable in !mac_views_browser (last shipped in M66) with !ShowAllDialogsUsingToolkitViews (last shipped in M65). Bug: 832676 Change-Id: I3097f0de0b09c28e72c5e3a4c0977739cb0da2cc Reviewed-on: https://chromium-review.googlesource.com/1151655Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#579032}
-
Dominik Röttsches authored
Bug: 867866 Change-Id: If25d954db330ee2dfa32779fb1e8e7f40b2152f4 Reviewed-on: https://chromium-review.googlesource.com/1151203 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579031}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e05f902a6929..dd9e5b9c8c10 git log e05f902a6929..dd9e5b9c8c10 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 anthonyalridge@google.com Finish api change in preparation for integration. Created with: gclient setdep -r src/third_party/catapult@dd9e5b9c8c10 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ia08daf0c7c0191d8f38740e3e7f602341dc0a7ad Reviewed-on: https://chromium-review.googlesource.com/1154468Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579030}
-
Denis Kuznetsov authored
Change-Id: Ib3dc4a3b6bfd52250ee5a97d5bc5833117aec952 Reviewed-on: https://chromium-review.googlesource.com/1151633 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#579029}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da846e65f8a2..c06b8a4e0ca3 git log da846e65f8a2..c06b8a4e0ca3 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 borenet@google.com [infra] Fix expectations 2018-07-30 benjaminwagner@google.com Upgrade Test/Perf Mac bots to 10.13.6. 2018-07-30 benjaminwagner@google.com Add a TSAN GPU job running in Skolo. Created with: gclient setdep -r src/third_party/skia@c06b8a4e0ca3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862292 TBR=scroggo@chromium.org Change-Id: Ic70c37cd91a1ba2968d23db37aefc1d22375bceb Reviewed-on: https://chromium-review.googlesource.com/1154927Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579028}
-
Koji Ishii authored
From a review of build 8466. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib51559660e234a8dedb345b0072d6bd2ece49e4d Reviewed-on: https://chromium-review.googlesource.com/1154860 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579027}
-
Guido Urdaneta authored
A result was unnecessarily moved and possibly used after move in content::MediaDevicesManager::OnDevicesEnumerated. Existing unit tests cover the affected code path, although it does not result in a crash, perhaps because the move is unnecessary and might be optimized away. No crashes have been observed in the wild either, except on a clusterfuzz build that performs IPC directly instead of going through the getCapabilities() JavaScript API. Bug: 868241 Change-Id: I2a3d9704a789c67b9eb763e1257504187201f941 Reviewed-on: https://chromium-review.googlesource.com/1154911Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#579026}
-
Yuki Shiino authored
As blink::Range::extractContents uses EventQueueScope that runs arbitrary author code internally, we cannot apply a auto-generated test for [NewObject], so this patch stops generating it by specifying [DoNotTestNewObject]. Ideally, it's better to have an alternative test, but we need a v8::Isolate to do it, and using [CallWith=ScriptState] looks a bit overkilling. So, this patch doesn't add an alternative so far. Bug: 865279 Change-Id: Ief434a2c7a4df9c75f5c0d3f4cdc198fa880c702 Reviewed-on: https://chromium-review.googlesource.com/1154746Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#579025}
-