GitLab

BUG=
TEST=Ran on views and verified that things looked ok.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96306

Review URL: http://codereview.chromium.org/7566050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96311 0039d316-1c4b-4281-b951-d872f2087c98

Remove name parameters from StreamChannelCallback and
DatagramChannelCallback. This argument is redundant: callback currying
can be used instead where neccessary.

BUG=None
TEST=compiles.

Review URL: http://codereview.chromium.org/7605018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran on views and verified that things looked ok.

Review URL: http://codereview.chromium.org/7566050

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/7622001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran on views and verified that things looked ok.

Review URL: http://codereview.chromium.org/7566050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96306 0039d316-1c4b-4281-b951-d872f2087c98

This patch extends the existing AutofillSyncPerfTest class to also measure add and
delete time for autofill keys.  Updating an individual autofill key is not possible,
as far as I can tell.

BUG=none
TEST=sync_performance_tests


Review URL: http://codereview.chromium.org/7590007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92111
TEST=

Review URL: http://codereview.chromium.org/7607036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96089

Review URL: http://codereview.chromium.org/7508044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ovdatest passes, gles2 works & closing tab mid-play tears down OVDA.


Review URL: http://codereview.chromium.org/7587004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96300 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6340: (mcgrathr) Remove __pthread_shutdown
r6341: (mseaborn) Add test for repeated, sequential pthread_create()+pthread_join()
r6342: (mseaborn) Get more information about failures of the multiple-sandboxes test
r6343: (jvoung) Warn on unused results when calling nacl thread ctors and check return values where missing.
r6344: (krasin) service runtime: remove unused work_queue field from NaClApp.
r6345: (sehr) Eliminate browser API agnostic base classed from the plugin.
r6346: (mcgrathr) Update glibc revision to facb66a
r6347: (polina) PPAPI Proxy: remove calls to remote PPP_Instance::DidDestroy and
r6348: (mcgrathr) Build IRT and in-tree tests with private libraries, drop non-IRT support from libnacl
r6349: (mcgrathr) Fix leak_test after r6348
r6350: (kschimpf) Compress the prefix/opcode tables, removing approximately 2300 entries.
r6351: (kschimpf) Modify the x86-32 validator to generate more detailed messages when not in
r6352: (kschimpf) Fix bug in revision 6351.
r6353: (mcgrathr) Bump toolchain DEPS to 6349
r6354: (bradnelson) Revert 6353 - Bump toolchain DEPS to 6349
r6355: (khim) Pull 84d7d30. Enable static tests in glibc-tests.
r6356: (eaeltsin) Get rid of old tool names completely
r6357: (mseaborn) x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S
r6358: (khim) Bump DEPS file, enable run_glibc_static_hello_test.
r6359: (khim) Fix the bots.
r6360: (khim) Fix *-spec bots.
r6361: (khim) Fix lucid_64-newlib-x86_64-spec bot.
r6362: (jvoung) Run pnacl sandboxed translators with IRT blob loaded (ask sel_universal to).
r6363: (ncbray) Refactored NaClAppLoadFile by pulling code out into seperate functions.
r6364: (khim) Final (hopefully) fix for *-spec bot.
r6365: (mcgrathr) Initialize "second TLS" pointer in thread_create syscall
r6366: (jvoung) Scoot pnacl DEPS revision back until the toolchain with the driver
r6367: (mseaborn) Revert r6357: "x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S"
r6368: (robertm) Added secondary event queue so that we do not overflow
r6369: (mcgrathr) Add valgrind trybots to default set
r6370: (pasko) Bump REVISIONS for newlib
r6371: (mseaborn) atomic_ops_test: Simplify by using joinable threads
r6372: (jvoung) Add steps to build pnacl sandboxed toolchain prerequisites if they aren't
r6373: (sehr) Remove the now-obsolete nacl_startup function.
r6374: (sehr) Revert r6373.
r6375: (bsy) enable manifest file access before pepper initialization.
r6376: (mcgrathr) Reimplement pthread thread-specific data using __thread
r6377: (mcgrathr) Don't build all of libpthread for the IRT
r6378: (sehr) Second try to remove obsolete startup function, nacl_startup.  This change
r6379: (mseaborn) Multiple sandboxes test: Use NaClExit() instead of an implicit exit()
r6380: (mcgrathr) Remove irt_elf_utils
r6381: (mcgrathr) Remove __nc_adopt_thread
r6382: (jvoung) Bump toolchain deps.
r6384: (pasko) Toolchain DEPS up(6382).
r6385: (pasko) Bump REVISIONS for newlib.
r6386: (mseaborn) x86 CPUID check: Fix inline assembly to declare that it clobbers %eax

Re-enable NaCl tests on Mac since the Mac Clang build is fixed by r6386.

BUG=91371
TEST=trybots


Review URL: http://codereview.chromium.org/7462016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96298 0039d316-1c4b-4281-b951-d872f2087c98

Instantiate OriginBoundCertService in relevant places and do plumbing to pass it down to HttpNetworkSession.

BUG=88782
TEST=None

Review URL: http://codereview.chromium.org/7493025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96296 0039d316-1c4b-4281-b951-d872f2087c98

Change some DLOG and NOTREACHED to LOG, to make debugging component extensions on Release build easier
Add a ValidateExtension call after loading a component extension to find errors such as file loading failure
Change the signature of ValidateExtension for const correctness

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7585003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96295 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.

This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Apps, Extensions and Themes datatypes to the new model, and contains the following changes:

- LiveAppsSyncTest is no longer a class that inherits from LiveSyncTest, but is now a namespace called apps_helper, and contains a bunch of methods that perform various operations related to Apps. Similar changes were made to Extensions and Themes.
- SingleClientLiveAppsSyncTest is renamed to SingleClientAppsSyncTest, and is a subclass of LiveSyncTest. It uses the methods in namespace apps_helper by including its header file and attaching itself to the helper. Similar changes were made to Extensions and Themes.
- LiveSyncExtensionHelper is renamed to SyncExtensionHelper.

BUG=88510
TEST=sync_integration_tests, sync_performance_tests

Review URL: http://codereview.chromium.org/7599019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96292 0039d316-1c4b-4281-b951-d872f2087c98

"FILES" is used when producing zip snapshots of Chromium.  This file
is read by chrome/trunk/tools/build/scripts/slave/chromium/archive_build.py.

This will allow NaCl to invoke crash_service64.exe in the NaCl
standalone build, although this is mainly for consistency across
standalone and non-standalone test runs, since the NaCl standalone
build won't support producing Breakpad crash dumps.

Add to "FILES.cfg" for consistency.  This file is read by
chrome-internal/trunk/tools/build/scripts/slave-internal/stage_build.py.

BUG=89730
TEST=untestable


Review URL: http://codereview.chromium.org/7610006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91729
TEST=None
Review URL: http://codereview.chromium.org/7462021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91990
TEST=otool -h Whatever.app/Contents/MacOS/Whatever should show the 0x1000000
     bit set in the |flags| column
Review URL: http://codereview.chromium.org/7608027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96288 0039d316-1c4b-4281-b951-d872f2087c98

Now, we cap the # visits for each node to 100 items, to avoid hitting the 10K
node size limit on the server. We also ignore all reload visits, since those
are not used by the omnibox suggestion algorithm and tend to be the bulk of
the visits in the large nodes we've encountered.

BUG=89460
TEST=Run unit tests.


Review URL: http://codereview.chromium.org/7550062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80654
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7583046

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/7616001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87500
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7583055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92154
TEST=navigate to ftp://ftp.os4.su/ - no errors should appear

Review URL: http://codereview.chromium.org/7590011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96275 0039d316-1c4b-4281-b951-d872f2087c98

cancellation reason, due to my change in r95721.

BUG=91799
TEST=Coming soon (As a net-internals test).

Review URL: http://codereview.chromium.org/7604002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=print preview works after code changes.

Review URL: http://codereview.chromium.org/7604042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96273 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to http://codereview.chromium.org/7606012

BUG=none
TEST=nothing changes


Review URL: http://codereview.chromium.org/7611005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96272 0039d316-1c4b-4281-b951-d872f2087c98

Mousewheel events, like keyboard events and unlike other mouseevents, are sent
to the focused view from the focus-manager, instead of sending to the view at
the location of the LocatedEvent. So This needs to be handled from the
dekstop/window-manager to send the events to the focused window.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7462017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96271 0039d316-1c4b-4281-b951-d872f2087c98

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Windows. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7601006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96268 0039d316-1c4b-4281-b951-d872f2087c98

Automation for step 1-9 testplan @ go/NACL-SDK-testing
BUG=89467, 89470, 89479, 89610, 89612
TEST=None

Review URL: http://codereview.chromium.org/7541046

TBR=chrisphan@chromium.org
Review URL: http://codereview.chromium.org/7612013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96267 0039d316-1c4b-4281-b951-d872f2087c98

This is to diagnose the bug referenced below. I think it is possible that a third party DLL is hooking TerminateProcess with a replacement that uses the wrong calling convention or has the wrong number of arguments, which causes Process::Terminate to return to the wrong address, causing a crash.

I put it in ThreadFunc because this is visible on the stack when the crash happens and because it is a windows specific .cc file.

BUG=81449

Review URL: http://codereview.chromium.org/7606016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96266 0039d316-1c4b-4281-b951-d872f2087c98

wait for page loads.
Also, be able to launch chromium and chrome regardless of what branding
we're built with.
BUG=89757
TEST=none


Review URL: http://codereview.chromium.org/7582005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83609
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7462023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96264 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90443
TEST=none


Review URL: http://codereview.chromium.org/7604033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96263 0039d316-1c4b-4281-b951-d872f2087c98

Committing for rogerm@google.com, original review at http://codereview.chromium.org/7583042/.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7461149
Patch from Roger McFarlane <rogerm@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92274
TEST=Browser does not crash if Chromoting client is used to connect from a machine with at least one network interface with no IP address.

Review URL: http://codereview.chromium.org/7552030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18984
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7462022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=sync_performance_tests

Review URL: http://codereview.chromium.org/7605012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96259 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7613001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7590005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92396
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7611004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96255 0039d316-1c4b-4281-b951-d872f2087c98

No functional change.

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7461145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7608032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96252 0039d316-1c4b-4281-b951-d872f2087c98

alter the HTML.

This is a follow up to http://codereview.chromium.org/5151006/ .

Review URL: http://codereview.chromium.org/7606007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96251 0039d316-1c4b-4281-b951-d872f2087c98