GitLab

Calling logically-const methods like GetHeightForWidth() would change the
layout.  This resulted in graphical bugs unless Layout() got called after each
such case, which in theory shouldn't be necessary (and was not happening after
crrev.com/699335 ).

Bug: 1015717
Change-Id: I06bd35f273a9192b29fbaabfae9b5cc1aba66532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884455
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711595}

This is a followup to https://crrev.com/c/1874816 that brings the same
a11y fix to browser settings.

Bug: 987406
Change-Id: I6a22bd509ffcf75312c2897af4374ce5bf418718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888315
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711594}

FlexibleArrayBufferView allows small ArrayBufferViews to be passed as a
temporary on the stack. This saves creating global handles and weak
roots in V8.

Bug: 852089
Change-Id: Ic0e8ee941c5175ac5232d5b6a2c1f3f1a315bf9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894409Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711593}

Bug: 1019947
Change-Id: Ie19d410e0fc5e07b1ebc1fcdf3d94a94dfce9a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888188Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711592}

This is a reland of 5a0adcbe

Looks like some platforms don't support sophisticated fonts to render fancy
unicode characters. Let's use simple "+" ASCII character.

Original change's description:
> WebApp: Check pixel at the center of the generated icon.
>
> We generate an icon placeholder using a letter with some solid
> background color.
>
> Let the test check if letter_color is actually presented in the icon.
>
> This is a follow up test enhancement for the previous CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1888234
>
> Bug: 1019102
> Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711143}

Bug: 1019102
Change-Id: I25f09ff941b8256d7fae9a7121aa439dc2ef2b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893596Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711591}

The new test case verifies that pipeline initialization of encrypted
playback waits for a CDM to be set, and a CDM that doesn't support a
Decryptor or a valid CDM ID will cause initialization error.

Bug: 1018854
Test: New test cases
Change-Id: I67fe51fb5012059533a5113ac929b89f47fdfe29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885022Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711590}

Rename shadowed variables in PDFiumPage::GetLinkTarget()

Bug: 993548
Change-Id: I88e660b6df99c4f3e2140014e1bb5e6626d56ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893504
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711589}

Bug: 635205
Change-Id: Ia35549688605986b88eb06b373f9d63c3bd3a26b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882761
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711588}

R=gab@chromium.org

Bug: N/A
Change-Id: Ie4779514a78a37f5fdf55d17e713eea46138a8ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892551Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711587}

Adds tests for opening and restoring various sites.  Also tests that
only the activate webState is restored.

Currently there is no support for background/restore in EG2, so those
portions of the test suite are #ifdefed out.

Change-Id: I5a8e4e3d019ba1598ec806175e369b7dae3cba84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874447
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711586}

blink::WebThreadType is only used in //third_party/blink. This CL moves
it to //third_party/blink/renderer/platform/scheduler/{public,common} as
blink::ThreadType.

Bug: 919392
Change-Id: I8dffa04c3c7be7dd1c31c4c5714461494b5a534c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886859
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711585}

Circular progress indicators default to radius 10, stroke width of 3.

This increases the stroke width to 4 if the radius of the indicator is
set to any value above 10.

Bug: 1014771
Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel
Change-Id: I48b602cebcdad709c64b7e39094cb03602ac118a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893594
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711584}

This CL converts SpeakerIdEnrollmentClient to new Mojo types
using PendingRemote, Remote, and Receiver.

Bug: 955171
Change-Id: I1132efd95d7a748e27903698bb2c45d22b5d3f96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871594Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711583}

Bug: 1003238
Change-Id: Ic4f462e62d5642cb4122b2d98d2b79d7dcacdddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890400Reviewed-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711582}

It's much clearer to have a single include rule than to include
everything in a single list, and then have exclude rules at the bottom
of the file.

Bug: None
Change-Id: Ife0cd5b984c6422f47b5e4caa99593ff4b48816f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890722
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711581}

Updates swipe_home_to_overview_controller to start overview session if:
*   user drags the pointer far enough above the shelf
*   holds for 350 ms

As the user is dragging up, the home view is scaled down, with minimum
scale being 0.92 (the home will have the target scale at a poing
little above the transition threshold line - if the user keeps going up,
the home scale will remain at 92).

If the gesture ends before the the hold time-out has exipred, or below
the minimal vertical distance from the shelf, the gesture is canceled,
and the home screen.

Note that the transition might trigger before the drag finger is lifted
(in that case subsequent drag events will be ignored).

BUG=1005366

Change-Id: I89be582f91322595031d699dc0d335d9c97b1ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894316
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711580}

https://screenshot.googleplex.com/ihaqzrJ6nyG.png
https://screenshot.googleplex.com/D1Y74zXf1UM.png

BUG=993850

Change-Id: I22c9cddd60625f6620cc329f269a46d8ab379459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888539
Commit-Queue: Alfonso Garza <alfonsogarza@google.com>
Auto-Submit: Alfonso Garza <alfonsogarza@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711579}

In MojoCdm, if a remote CDM supports a Decryptor directly, it should be
returned via |decryptor_ptr_info_|. Otherwise, the Decryptor may be
supported via CdmProxy, and MojoCdm can request the Decryptor using
|cdm_id_|.

This CL puts the second part under #if BUILDFLAG(ENABLE_CDM_PROXY) to
avoid complicating decoder selection logic when CdmProxy is not enabled,
e.g. the DecoderSelector may assume there is a Decryptor available and
setup the media pipeline to use DecryptingDemuxerStream.

Bug: 785563
Change-Id: Id0c3557620f22c443cad0cd79a9ae0236b4e4575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894187Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711578}

We support GpuMemoryBuffer-based buffer in FakeVideoCaptureDevice now [1],
so update the comment accordingly.

[1]: https://crrev.com/c/1863055

Bug: 982201
Change-Id: I8108e3f45caf4d9eead3d3c88ea1a8e5f31adc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890381Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711577}

This is a cleanup in prepration for performing the changes laid out in
crbug.com/995131#c24

Bug: 995131
Change-Id: I177069c21782ccd38231c483da5469bc47932158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891119
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711576}

We no longer need the code.

BUG=b:136128691
TEST=try

Change-Id: Ifd2440ee7e913530954899516234f3e4244553cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894325
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711575}

This CL re-introduces the code allowing the MultipartUploadRequest to
function. It also removes the old endpoint for the BinaryUploadService.

This reverts https://crrev.com/c/1869028

Bug: 1020434
Change-Id: Ie8c652d1e4b53facd03dfdbe858394c0873286f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892092
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711574}

https://android.googlesource.com/platform/external/perfetto.git/+log/f016a6633058..a936069d60ce

git log f016a6633058..a936069d60ce --date=short --no-merges --format='%ad %ae %s'
2019-10-31 fmayer@google.com Merge "Proto format fixes."

Created with:
  gclient setdep -r src/third_party/perfetto@a936069d60ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ibb91572ae68b7563a8e535d8fa39c32b420cbf2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894059Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711573}

When not receving into a buffer pool, it was not accounting for the
padding correctly.

Also, make sure connection error only happens once.

Change-Id: I04d3b171828fc8f35b6cfa2ac5872e02f6f2145e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894811
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711572}

This change hides the arrangement section of Display settings when
there is only one display connected to the device. Since no action can
be taken in this section when there is only one Display, we hide it to
avoid wasting space.

Bug: 997471
Change-Id: Idf367efbeac835b77e99b70671741a60dd42ae58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881335
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711571}

Removes unneeded parameter and mistaken firing of location changes for every call to FireEvent.

Change-Id: Id1e3e75980d6c3459485cb2e02dd184e499fd936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893355Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711570}

To check whether the BackForwardCache is enabled or not, we choosed from
the beginning not to check the content::feature directly, but use a
function wrapping it.

It means everyone is checking against IsBackForwardCacheEnabled()
instead of using the feature::kBackForwardCache flag.

The goal was to be future-proof. If the decision should not be entirely
based of the feature flag, we would just have to update the
implementation of the function instead of every callers.

One future patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1875091
will modify the implementation of this function.

So far so good!

The problem is that patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1654739 landed
using the content::feature directly instead of the "canonical" function.

It means the blink/ part may be using the BackForwardCache while the
content/ isn't. Moreover, this might forces users with low-memory
devices to be reported in one of the enabled or control group.

Bug: 511340

Change-Id: I68da6c7ca4cd48716b9ba092a0c5d84bb59b7073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893262Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711569}

The public method is used for test only. Moved it to ChromeTabUtils,
one of the call sites.

Bug: 995903
Change-Id: Icc03cefc3b289a5fb20722d4aec77c2f4755ba08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888862Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711568}

Treat package_name as the publisher_id for ARC++ apps.

BUG=1008311

Change-Id: I9fa90f2c04477180794ed6ab77fcac8e9b81abe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892333
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711567}

Multithreaded WebAssembly applications need to be able to pass a
Uint32Array that points to a SharedArrayBuffer as |code|.

This CL also updates the bindings generator for dictionaries to consider
extended attribute annotations.

Bug: 852089
Change-Id: I1595a20e95b7f5cd9583ba73592619fcf9646671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894400Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711566}

When a new permission is needed to show the chooser (e.g. camera
permission), the chooser was not showing up. This is because the
permission request was routed through the Activity instead of the
Fragment. This fix is similar to what was done to send the Intent
through the Fragment in http://crrev.com/c/1880072.

Bug: 1018955
Change-Id: Ie0226d388b8a9148afeeda2ccec8907f1b547dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891748Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711565}

This CL converts old Mojo types of ContentDecryptionModule
interface to new Mojo types. Major changes are as below,

  - Convert mojom::ContentDecryptionModulePtr to
    mojo::Remote<mojom::ContentDecryptionModule>
  - Convert mojo::Binding to mojo::Receiver

Bug: 955171
Change-Id: I19068217af7a0a315dd8c46405ab0839c2fb22f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890406
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711564}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c87ed60623e4..540178c7543f

git log c87ed60623e4..540178c7543f --date=short --no-merges --format='%ad %ae %s'
2019-10-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@540178c7543f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I4ef9ad788ca0503bc2736897d885998c2888f81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711563}

The size of Identity Disc was decided once based on visibility of bottom
toolbar. Toolbar can be shown/hidden based on experiment combination
(enabled duet, disabled tab grid layout) and device orientation.

This CL adds support for adjusting IDentityDisc size. Images are
retrieved on demand. Images for both sizes are cached since the user is
likely to rotate the device multiple times.

R=twellington@chromium.org

Bug: 971711
Change-Id: I456168b7e1fe9956691a344e162dc9c4455e521a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877189Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711562}

Fixed: 1020340
Change-Id: I5152492b0683537fc1dbabfc2bca332f3923e5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894237
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711561}

BUG=841098

Change-Id: I09726ccc545f09da0913e78f0b4e842306cbdd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894137
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711560}

For further refactoring: removing createHelperIframe() and
unifying requestViaForm() with other navigables.

This can enable referrer-policy tests for <form>,
while it is not spec'ed yet though:
https://github.com/whatwg/html/issues/4320.

Bug: 906850
Change-Id: I96c43ec8c8b39f794f8bf8291f2af798f1a30c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562120
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711559}

No functional change, but simplifies the code, and is a necessary precursor for
fixing bug 1015717.

Bug: 1015717
Change-Id: I0f5212ce85841540a2ca85b8c73d8a1149576240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884814
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711558}

Specifically, if the child height is odd and the line height is even, this
shifts the child down by 1 px compared to the current behavior.

This behavior seems reasonable and KeyboardShortcutItemView expects it.  Without
this change, a later CL to position KeyboardShortcutItemView children based on
line heights instead of first child centers can change behavior unexpectedly.


Bug: 1015717
Change-Id: I66b92baae5a8ca0dd83db454fbf0349925bdb169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892291
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711557}

This also adds api to activate accelerator, which is used
to change the launcher state.

Bug: 1001728
Test: covered by unittests
Change-Id: I9e545a4ab5a646a5260f59b821e3229e87ad5466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869991
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711556}