GitLab

This CL removes the TranslateDelegate interface and introduces
TranslateService and TranslateDownloadManager.

This will enable (in a future CL) to move TranslateScript and
TranslateLanguageList in the Translate component, and
TranslateDownloadManager will own them.

BUG=332736

Review URL: https://codereview.chromium.org/145023015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247724 0039d316-1c4b-4281-b951-d872f2087c98

> <webview>: Fix text selection features in mac.
> We still need to pass RWHVGuest::SelectionChanged() call to platform_view_.
> This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod).
> 
> Wrote a browser_test to catch the regression.
> 
> BUG=331722
> Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work.
> 
> Review URL: https://codereview.chromium.org/148433007

Suspected of causing flakes in

WithoutThreadedCompositor/WebViewCaptureTest.Shim_ScreenshotCapture , see

http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5692
and
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/928

TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/139803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=-
TEST=fixing unit test
R=bshe@chromium.org, dpolukhin@chromium.org
TBR=dpolukhin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/141103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247719 0039d316-1c4b-4281-b951-d872f2087c98

This change allows KIF (an iOS integration test framework) tests to be
analyzed appropriately by presubmit checks such as
_CheckNoProductionCodeUsingTestOnlyFunctions.

BUG=NONE

Review URL: https://codereview.chromium.org/133233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247718 0039d316-1c4b-4281-b951-d872f2087c98

Add four new events to RenderFrameObserver: DidCreateDataSource,
DidStartProvisionalLoad, DidFailProvisionalLoad, DidFinishLoad; add code to send
the former three as needed.

TEST=unit,trybot
BUG=none

Review URL: https://codereview.chromium.org/137463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247717 0039d316-1c4b-4281-b951-d872f2087c98

In https://codereview.chromium.org/137793008/ phoglund@
changed the test filter for desktop tests after the renames in
https://codereview.chromium.org/131203005/ and
https://codereview.chromium.org/137753004/

This CL makes similar change for Android.

BUG=none
TBR=frankf@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/144483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247716 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247713 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 247533 / 3d2a6e2e
Old Skia revision: 13188
New Skia revision: 13227
Control CL: https://codereview.chromium.org/148583012

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true
R=reed@google.com

Review URL: https://codereview.chromium.org/132103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247712 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336824
TBR=willchan@chromium.org, jyasskin@chromium.org
(lgtm'ed in https://codereview.chromium.org/145663004/)

Review URL: https://codereview.chromium.org/148183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247711 0039d316-1c4b-4281-b951-d872f2087c98

Since the function manipulates Args::declared_arguments_, it needs to
hold the lock to avoid heap corruption.

BUG=335587

Review URL: https://codereview.chromium.org/136783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247710 0039d316-1c4b-4281-b951-d872f2087c98

Allow Chromium to start under TSAN by removing the threading checks
before fork() in that environment.

Note that TSANv2 doesn't reliably support non-spawn fork() for now:
https://code.google.com/p/thread-sanitizer/issues/detail?id=44

But at least this allows using it on Chrome despite risks of running
into deadlocks.

NOTRY=true

Review URL: https://codereview.chromium.org/130423014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247708 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247707 0039d316-1c4b-4281-b951-d872f2087c98

This basically causes it to get updated from
glCopyTextureCHROMIUM() also which is used with
canvas/webgl.

BUG=309162

Review URL: https://codereview.chromium.org/148513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247699 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit d95595eb, and it fixes the
original bug where |requests_| was being accessed from the UI thread.

BUG=338848,332261

Review URL: https://codereview.chromium.org/140633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247697 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes a recent regression, which was incorrectly taking the selection instead of the element the eject button is on.

TEST=Tested manually with archives.
BUG=337577

Review URL: https://codereview.chromium.org/131103020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247696 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247695 0039d316-1c4b-4281-b951-d872f2087c98

The Forwarder class used to operate on its own internal thread. This was
leading to e.g. 256 threads being spawned since Chrome keeps a lot of sockets
around in its socket pool.

This CL makes the ForwarderManager have an internal thread performing a single
select() on all the socket file descriptors and it notifies all the Forwarder
instances when some events occur.

The fact that ForwarderManager has an internal thread that joins on destruction
also makes the interactions between ForwarderManager and its clients much
simpler. In particular it allows us to remove its ref-counted thread-safe
delegate.

This CL should make the device_forwarder daemon more lightweight and make the
results in page_cyclers hopefully more stable.

The internal buffer used to forward the traffic is also shrunk to 32 KBytes
since 128 KBytes was way too big (read() rarely returns more than 16 KBytes).

BUG=332403

Review URL: https://codereview.chromium.org/148113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247694 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165982:165995&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/137263016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337048
NOTRY=True

Review URL: https://codereview.chromium.org/137143011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247692 0039d316-1c4b-4281-b951-d872f2087c98

> Use webrtc::MouseCursorMonitor for cursor shapes
> 
> Use webrtc::MouseCursorMonitor for cursor shapes instead of
> webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
> functionality in the latter.
> 
> BUG=324033
> 
> Review URL: https://codereview.chromium.org/92473002

TBR=dcaiafa@chromium.org

Review URL: https://codereview.chromium.org/149563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247691 0039d316-1c4b-4281-b951-d872f2087c98

Use webrtc::MouseCursorMonitor for cursor shapes instead of
webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
functionality in the latter.

BUG=324033

Review URL: https://codereview.chromium.org/92473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247689 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke Linux ASAN Tests (3) bot.

Original issue's description:
> Pinch/Zoom Infrastructure & Plumbing CL
> 
> This CL supplies the necessary changes to CC to support the
> inner/outer viewport model for pinch-zoom and fixed-position
> elements. The specification for these changes is contained in
> the document "Layer-based Solution for Pinch Zoom / Fixed
> Position".
> 
> It incorporates a change to how scrollbar parameters are
> computed (removes the notion of max_scroll_offset as a
> quantity set be the embedder, and instead inferred from the
> relative sizes of a clip layer w.r.t. the scroll layer).
> 
> Scrollbars are generalized so that a layer may have more than
> two scrollbars, and the parameters of the scrollbar are set
> w.r.t. the sizes and positions of a clip and a scroll layer.
> Further, changes to the scrip/scroll layer automatically
> notify any attached scrollbars.
> 
> The CL also removes existing references to root_scroll_layer
> from LTH, LTI and LTHI and replaces them with either
> Inner/OuterViewportScrollLayer (dual-layer operation only
> exists at present if the --enable-pinch-virtual-viewport flag
> is specified, otherwise behavior is unchanged).
> 
> Logic is added to (i) combine scroll offsets for the two
> viewports before passing it to the embedder, and (ii)
> splitting any offsets received from the embedder
> appropriately between the two viewports.
> 
> This CL relies on https://codereview.chromium.org/138453004/
> for changes in Blink to support it.
> 
> BUG=148816
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246812
> 
> R=aelias@chromium.org, enne@chromium.org, joi@chromium.org, piman@chromium.org, sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247684

TBR=enne@chromium.org,aelias@chromium.org,joi@chromium.org,sky@chromium.org,piman@chromium.org,tony@chromium.org,wjmaclean@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148816

Review URL: https://codereview.chromium.org/135183016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247687 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/139903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247686 0039d316-1c4b-4281-b951-d872f2087c98

Allow specifying multiple CT logs through the command line. This is
necessary in order to allow testing of multiple new logs at the same
time.

BUG=

Review URL: https://codereview.chromium.org/148283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247685 0039d316-1c4b-4281-b951-d872f2087c98

This CL supplies the necessary changes to CC to support the
inner/outer viewport model for pinch-zoom and fixed-position
elements. The specification for these changes is contained in
the document "Layer-based Solution for Pinch Zoom / Fixed
Position".

It incorporates a change to how scrollbar parameters are
computed (removes the notion of max_scroll_offset as a
quantity set be the embedder, and instead inferred from the
relative sizes of a clip layer w.r.t. the scroll layer).

Scrollbars are generalized so that a layer may have more than
two scrollbars, and the parameters of the scrollbar are set
w.r.t. the sizes and positions of a clip and a scroll layer.
Further, changes to the scrip/scroll layer automatically
notify any attached scrollbars.

The CL also removes existing references to root_scroll_layer
from LTH, LTI and LTHI and replaces them with either
Inner/OuterViewportScrollLayer (dual-layer operation only
exists at present if the --enable-pinch-virtual-viewport flag
is specified, otherwise behavior is unchanged).

Logic is added to (i) combine scroll offsets for the two
viewports before passing it to the embedder, and (ii)
splitting any offsets received from the embedder
appropriately between the two viewports.

This CL relies on https://codereview.chromium.org/138453004/
for changes in Blink to support it.

BUG=148816

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246812

R=aelias@chromium.org, enne@chromium.org, joi@chromium.org, piman@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/23983047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247684 0039d316-1c4b-4281-b951-d872f2087c98

utils.expose now accepts a third parameter (readonly properties).

BUG=324859

Review URL: https://codereview.chromium.org/141803016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247683 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Unify desktop and Android tab helper instantiation. (https://codereview.chromium.org/144443003/)

Reason for revert:
This causes Clank to crash at startup, and makes tests fail http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11575

Tried the revert locally, and Clank started normally.

Original issue's description:
> Unify desktop and Android tab helper instantiation.
> 
> BUG=337600
> TEST=zero visible change
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247676

TBR=yfriedman@chromium.org,jam@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=337600

Review URL: https://codereview.chromium.org/149393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247682 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/149213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331712
NOTRY=true

Review URL: https://codereview.chromium.org/147023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=325685
R=pliard@chromium.org, bulach@chromium.org

Review URL: https://codereview.chromium.org/130913011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337600
TEST=zero visible change

Review URL: https://codereview.chromium.org/144443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247676 0039d316-1c4b-4281-b951-d872f2087c98

Adds the Readability CSS and also makes the DOM Distiller viewer load it.

BUG=319881

Review URL: https://codereview.chromium.org/138923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247675 0039d316-1c4b-4281-b951-d872f2087c98

We have quite a few number (12) of files for providing interfaces
to FileSystem API. They can be clearly separated from other
files under drive/.

BUG=none

Review URL: https://codereview.chromium.org/148913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247674 0039d316-1c4b-4281-b951-d872f2087c98

Also works with unprefixed reports.

BUG=325685
R=glider@chromium.org, bulach@chromium.org

Review URL: https://codereview.chromium.org/148763008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263749,325685
TEST=cc_unittests on ASan/Android bot
R=glider@chromium.org, thakis@chromium.org, bulach@chromium.org, navabi@chromium.org

Review URL: https://codereview.chromium.org/136113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247670 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Revert of Remove threading from RendererGpuVideoAcceleratorFactories (https://codereview.chromium.org/135393004/)

Reason for revert:
It turned out the reverting the patchset was effective after all, so I am reverting the revert of the revert.

Original issue's description:
> Revert of Revert of Remove threading from RendererGpuVideoAcceleratorFactories (https://codereview.chromium.org/145103004/)
> 
> Reason for revert:
> Reverting the revert as it did not fix the failures.
> 
> Original issue's description:
> > Revert of Remove threading from RendererGpuVideoAcceleratorFactories (https://codereview.chromium.org/27420004/)
> > 
> > Reason for revert:
> > Sorry, it looks like you broke the Win 7 Tests (dbg)(2) bot. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/19785
> > 
> > Original issue's description:
> > > This change removes all the threading considerations from
> > > GpuVideoAcceleratorFactories (and its implementation,
> > > RendererGpuVideoAcceleratorFactories).  Most notably, it removes Abort() and
> > > associated functions and state.  And with the removal of Abort() and friends,
> > > we can also remove its Clone() interface.
> > > 
> > > All of the previously abortable operations on the RGVAF (with the exception of
> > > ReadPixels()) can be made non-abortable, with no functional difference, due to
> > > the way the users of RGVAF function.  These three users are
> > > WebMediaPlayerImpl/GpuVideoDecoder, RTCVideoDecoder, and RTCVideoEncoder, and
> > > they can be made non-abortable because:
> > > 
> > > WebMediaPlayerImpl/GpuVideoDecoder:
> > > * Abort() is called from WebMediaPlayerImpl::Destroy().  It has no effect, as:
> > >   * All the RGVAF entry points are called from the the RGVAF message loop
> > >     from GpuVideoDecoder (except for ReadPixels()), so the Abort() has no
> > >     effect on them.
> > > 
> > > RTCVideoDecoder:
> > > * Abort() is called from RTCVideoDecoder::WillDestroyCurrentMessageLoop() for
> > >   the RGVAF message loop.  It has no effect, as:
> > >   * Amost all the RGVAF entry points are called from the RGVAF message loop
> > >     (except for ReadPixels()), so Abort() has no effect on them.
> > >   * The other exception is CreateVideoDecodeAccelerator(), which is called from
> > >     RTC's main thread.  But as the Abort() is called from
> > >     WillDestroyCurrentMessageLoop() for the RGVAF message loop itself, it is
> > >     guaranteed to occur after any tasks posted to the RGVAF message loop by
> > >     CreateVideoDecodeAccelerator() has completed, and so the Abort() has no
> > >     effect.
> > > 
> > > RTCVideoEncoder:
> > > * Abort() is called from RTCVideoDecoder::Release().  It has no effect, as:
> > >   * All the RGVAF entry points are called from the RGVAF message loop.
> > > 
> > > The only functional difference remaining is that making ReadPixels()
> > > non-abortable.  This is preferable, as as long as a completed video accelerator
> > > texture is available, it should be readable.  We also specify that all calls to
> > > ReadPixels must be made on the RGVAF message loop, like all other entry points,
> > > and leave it up to the users of ReadPixels() to handle thread trampolining if
> > > necessary.
> > > 
> > > BUG=306333
> > > TEST=local build, run on CrOS snow; build, run unittests on desktop Linux
> > > 
> > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247480
> > 
> > TBR=fischman@chromium.org,wuchengli@chromium.org,jamesr@chromium.org,jam@chromium.org,hshi@chromium.org,sheu@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=306333
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247655
> 
> TBR=fischman@chromium.org,wuchengli@chromium.org,jamesr@chromium.org,jam@chromium.org,hshi@chromium.org,sheu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=306333
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247662

TBR=fischman@chromium.org,wuchengli@chromium.org,jamesr@chromium.org,jam@chromium.org,hshi@chromium.org,sheu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=306333

Review URL: https://codereview.chromium.org/144303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316568
NOTRY=true

Review URL: https://codereview.chromium.org/141543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247668 0039d316-1c4b-4281-b951-d872f2087c98

Take 2 on insets.

BUG=333499
TEST=none
R=sadrul@chromium.org
TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/148223015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247667 0039d316-1c4b-4281-b951-d872f2087c98

- Remove unused #include's.
- Remove obsolete comments.
- Prefer not to access error_ protected member directly.

BUG=none

Review URL: https://codereview.chromium.org/141473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247666 0039d316-1c4b-4281-b951-d872f2087c98