GitLab

Roll Chrome Mac PGO profile from chrome-mac-master-1597341503-4f5bca114f9d97d0c5a366353ca44da70cbc454a.profdata to chrome-mac-master-1597363129-a36e46938cb7f6611b8efddbaf720b98c4f2f1a3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com
Change-Id: Ibecca84d6d16107fca8154e9ca375c0ecf119492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355124Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797981}

Bug: 1107690
Change-Id: Ib94f111c3f4080c658f37dd8f25a4d8da751d5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354905
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797980}

Revert "Replacing "blacklist" with "blocklist" in IDS_EXTENSION_ALERT_ITEM_BLACKLISTED_MALWARE.png.sha1"

This reverts commit 8aaf5430.

Reason for revert: Caused Deterministic Linux build failure:
https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/28789


Original change's description:
> Replacing "blacklist" with "blocklist" in IDS_EXTENSION_ALERT_ITEM_BLACKLISTED_MALWARE.png.sha1
> 
> Bug: 1097279
> Change-Id: Ie4ee96134433cd45432df96b047ff331eaeac573
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353400
> Commit-Queue: Elaine Chien <elainec@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797879}

TBR=karandeepb@chromium.org,elainec@chromium.org

Change-Id: I3eec50e43777b1b77825185ab10242eb8fbc2e23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355350Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797979}

Render pass with pixel-moving filters will now report its |output_rect|
as its damage if any of its quads has damage. Surfaces' damage reporting
is no longer directly affected by pixel-moving filters.

gfx::Rect PrewalkRenderPass(RenderPass* render_pass) {
   gfx::Rect damage_rect;

   // Go through quads back to front to accumulate damage and update |damage_rect|.
   for (DrawQuad* quad : quad_list)  { // in reverse order
       .....
   }
   // Expand the damage to cover entire |output_rect| if the render pass has pixel-moving foreground filters.
   if (!damage_rect.IsEmpty() && render_pass.filters.HasFilterThatMovesPixels())
       damage_rect.Union(render_pass.output_rect);

   return damage_rect;
}

For more details and pseudo-code, please see:
https://docs.google.com/document/d/1D1MTNTaJnZjbmMZGMz0u150N3u5evEFSmJU-ou2vcFw/edit#heading=h.qxb209uq3j9k

Bug: 1110016
Change-Id: I3c495d8ea1ed25585c636a0989a3c7f51fdce7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321114Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797978}

This reverts commit 9ae09da8.

Reason for revert: The following tests start to fail since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1824
org.chromium.chrome.browser.ntp.cards.promo.HomepagePromoTest#testDismiss_Large
org.chromium.chrome.browser.ntp.cards.promo.HomepagePromoTest#testToggleFeed_WithHomepage

Original change's description:
> Introduce CriteriaHelper#pollUiThreadNested
> 
> This change adds an assertion that pollUiThread is not called from the
> UI thread, which is equivalent to calling sleep(), and won't actually
> run any UI thread tasks.
> 
> In the few cases where polling the UI Thread from the UI thread is
> necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests
> the looper in order to continue running UI tasks.
> 
> Bug: 1115220
> Change-Id: I834251df334c80d657e45dddeab5ae744de0fe17
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340004
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797436}

TBR=yfriedman@chromium.org,mthiesse@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1115220
Change-Id: Icf5edbfe7f22f48a78ce25e5e49480419edfc897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355096Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#797977}

This patch extends the validity of the histogram
Printing.PrintServers.ServersToQuery to M90.

BUG=chromium:1104975
TEST=none

Change-Id: I87b78e01dadfb9e43d16c65093a008c5db394d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333195
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797976}

https://skia.googlesource.com/skia.git/+log/5b27846491d0..283c230fa18a

2020-08-13 bungeman@google.com Improve ASSERT_RETURN in SkScan_Path
2020-08-13 johnstiles@google.com State lambda return types explicitly when multiple returns exist.
2020-08-13 johnstiles@google.com Return the `T*` pointer back to the caller in SymbolTable::add.
2020-08-13 bsalomon@google.com Make asserts in EllipticalRRectOp::Make agree with calling code.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1114968
Tbr: fmalita@google.com
Change-Id: I926e9ef71c718a60bd9881119d5d4ef7de79b066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354586Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797975}

org.chromium.weblayer.test.InfoBarTest.testTabDestruction is flaky on
Android,
https://analysis.chromium.org/p/chromium/flake-portal/flakes/
occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydwsSBUZsYWtlImxjaHJvbWl1bUB3ZWJs
YXllcl9wcml2YXRlX2luc3RydW1lbnRhdGlvbl90ZXN0X2Fwa0BvcmcuY2hyb21pdW0ud2Vi
bGF5ZXIudGVzdC5JbmZvQmFyVGVzdCN0ZXN0VGFiRGVzdHJ1Y3Rpb24M,
disable it for now until it is fixed.

TBR=blundell@chromium.org

Bug: 1116247
Change-Id: I98a6348a7120de2adb121b221084965ab6cac1e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355389Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797974}

https://android.googlesource.com/platform/external/perfetto.git/+log/8fa7957ea438..4faa62a0e9f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I454ca5fa1081a93a1dd405225512d9e6f0f10ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797973}

This CL removes the restriction that a web app's manifest display mode
must be one of "standalone", "fullscreen" or "minimal-ui" in order to
participate in manifest updating.

Bug: 1095860
Change-Id: I48241e339c442f8fba341adb85012231b53391f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352457Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797972}

Having initWithMessage call initWithPrimaryAttributedString:secondaryAttributedString:, so we would have only a single designated initializer and we wouldn't have code duplicated between the two initializers.

Bug: 1094420
Change-Id: Ic1aaf0d7f37e75af5ebe17d6578f44e7acb50f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355129Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797971}

https://android.googlesource.com/platform/external/perfetto.git/+log/78d7b4b8250e..4faa62a0e9f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I3d14beb01bce4ded4a62483f78b397b6c78672ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355006Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797970}

Add mojo interface for communication between ash and lacros. For now,
just add the fields needed for simple text notifications.

Notifications are handled in a new class MessageCenterAsh. It lives
in //chrome/browser/chromeos/crosapi instead of //c/b/notifications
for consistency with other crosapi implementations.

On mojo disconnect (e.g. lacros-chrome crash) all notifications
created by lacros are removed.

I'm working on tests now. They are not in this CL because this CL
is getting too large.

Test: Spawn basic notifications from test app Notifications Galore
      in chrome/test/data/extensions/api_test/notifications/galore/
Bug: 1113889

Change-Id: I6363b0e7568756b9087f089651a7fdc6d0901902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343849Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797969}

This reverts commit bc08f94f.

Reason for revert: Not needed. There was an issue with the CLA not being accepted.

Original change's description:
> Add a chromium author that could not add himself
> 
> BUG=1116202
> 
> Change-Id: I10738961da81ad153b770210e3d969210b0bcd0f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354557
> Commit-Queue: Donn Denman <donnd@chromium.org>
> Commit-Queue: Theresa  <twellington@chromium.org>
> Auto-Submit: Donn Denman <donnd@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797916}

TBR=donnd@chromium.org,twellington@chromium.org

Change-Id: Iaffe8f52f36455ba0c7746b0ed47fa2d9f5db209
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354562Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797968}

https://crrev.com/c/2352519 stopped attempting to load the GvrKeyboard,
and the original bug that it fixed had the same error stack as seen in
this bug. Re-enable the Permissions Tests that were failing with the
same error.

Fixed: 1091800
Change-Id: Icc2bf2d29ddd8ffbf0016df2be6e9e6d310a1ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354721
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797967}

This reverts commit 261661bb.

Reason for revert:
BluetoothSocketTest.TestInputStream/TestOutputStream fails on Linux TSan Tests
https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982

Original change's description:
> [Nearby] Create concrete BluetoothSocket and implement ConnectToService.
> 
> Implement a concrete location::nearby::api::BluetoothSocket, created via
> a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly
> implemented BluetoothClassicMedium::ConnectToService().
> 
> Nearby Connections uses this BluetoothSocket to communicate with a
> remote device. At a high-level, it first exchanges frames to encrypt
> the connection, then delegates to its caller (e.g., Nearby Share)
> to authenticate the connection, and finally expects its caller to
> send and receive application-level messages. The following precautions
> are taken to handle untrusted bytes received from remote devices:
>   * Nearby Connections (including the code being added in this CL) is
>     hosted in a Nearby utility process.
>   * Whenever Nearby Connections provides bytes received from a remote
>     device to its caller, even after it has been authenticated, the
>     caller must not trust those bytes, and is responsible for first
>     passing those bytes through the trusted NearbyDecoder interface
>     (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same
>     Nearby utility process.
> 
> api::BluetoothSocket is a synchronous interface, so this
> implementation consumes the synchronous signatures of
> bluetooth::mojom::Socket methods.
> 
> api::BluetoothSocket's subclasses are also synchronous interfaces,
> but the Mojo DataPipes they consume only provide asynchronous
> interfaces. This is reconciled by blocking on the caller thread when
> waiting (via a mojo::SimpleWatcher) for the DataPipes to become
> readable or writable (this is expected by the callers of
> api::BluetoothSocket's subclasses). Mojo DataPipe operations are
> handled on a separate task runner so that blocking on the calling
> thread will not deadlock.
> 
> Please see design doc go/nearby-chrome-bt for more details.
> 
> Bug: b:154849033, b:158848873
> Change-Id: I2e945277aa1f75b4ca378d0b961f7682ff25d812
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322166
> Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
> Reviewed-by: Alex Chau <alexchau@chromium.org>
> Reviewed-by: James Vecore <vecore@google.com>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797758}

TBR=reillyg@chromium.org,hansberry@chromium.org,alexchau@chromium.org,vecore@google.com

Change-Id: Ia33d32ae93a8900032e81f77d298553c5de82874
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:154849033
Bug: b:158848873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355253Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797966}

https://android.googlesource.com/platform/external/perfetto.git/+log/8fa7957ea438..4faa62a0e9f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I29bbbb11504a671706c05fa15577c8c24c3fb4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797965}

For CrOS, since the Task Manager is showing tasks for all of CrOS
and not just “Chromium”, it's not appropriate to label it as such.

Bug: 1109438
Change-Id: Iba02159483b124601a90123b0eed4a215f7851a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354415Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797964}

This reverts commit 34bca2e3.

Reason for revert: Suspected for TSan error (data race) in
BluetoothSocketTest.TestOutputStream and BluetoothSocketTest.TestInputStream.

https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982


Original change's description:
> Implement key verification for incoming connection.
> 
> Implements the key verification module that to verify remote device
> before requesting introduction and beginning the transfer flow.
> 
> Bug: 1085068
> Change-Id: I4bb75dce474042ef43ca86199db3456d63406874
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346325
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
> Reviewed-by: Alex Chau <alexchau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797868}

TBR=alexchau@chromium.org,nohle@chromium.org,himanshujaju@chromium.org

Change-Id: I04ef174610f0e3751299ea7aeccdd16c4bf8683f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352300Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797963}

https://chromium.googlesource.com/angle/angle.git/+log/5c8c6b4296e5..5559351c907d

2020-08-13 timvp@google.com Vulkan: Correctly determine mip level in resolveColorWithCommand()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Test: Test: FramebufferTest_ES31::MultisampleResolveIntoMipMapWithBlit()
Change-Id: I949ddd444d7586521289ffbd5cb458419d3eb9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355130Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797962}

This is intended to replace the NativePrintersBulkAccessMode policy.
The old policy will still be used in the absence of the new one for at
least a few releases of Chrome.

BUG=chromium:1113370

Change-Id: Iec6aeb20a1e0755e4985c849dc98280c4658659a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340513
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797961}

There are missing includes that are transitively included. But updating
these files requires these missing includes be added.

This CL adds those missing includes.

Change-Id: I3bcf6d894d50cd57a3219e8b7a4ad0c5b83e76c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353486Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Auto-Submit: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797960}

AuthDialogDebugView was used in in-session auth dialog in the early
development stage. Now that it has the correct views and is close to
the final contents view, rename it to AuthDialogContentsView. This
change also removes the dev flag "show-auth-dialog-dev-overlay" so that:

1. developers (especially Chrome's WebAuthn team) can test the flow end to
   end without having to enter dev mode on ChromeOS.
2. UX reviewers can evaluate the user flow.

Note that the feature is still behind a feature flag "base::Feature
kWebAuthCrosPlatformAuthenticator". Developers can toggled that via
chrome://flags.

No functionality change.

Bug: b:156258540
Change-Id: I7c8e0a94993cc6d483d5280cd91fa970846930f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355000
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797959}

Adds basic usage metrics to the main API methods. This will give us a
basic quantitative view on how the API is used during Origin Trial.

Fixed: 1116107
Change-Id: I79e2717f49b645eac5f065c7b5346ca10b3521ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354607
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797958}

This reverts commit b207aafb.

Reason for revert: On android-marshmallow-arm64-rel bot, weblayer_instrumentation_test_apk flakily
fails by assertion failure at BrowserControlsContainerView.java:206.

Examples:
https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/633073
https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/633096


Original change's description:
> [WebLayer] Let the embedder animate top controls in/out.
> 
> This CL adds an "animate" flag to Browser.setTopView that allows the
> embedder to tell WebLayer to animate the top view off the screen when
> setting it to null, or to animate it down from the top when setting it
> to a non-null value.
> 
> The animation off the screen is achieved by removing the View from the
> view tree, but keeping the bitmap layer in place, hiding the top
> controls, and then deleting the layer after the animation is complete.
> 
> Bug: 1108956
> Change-Id: Idb9bce6c2633ef6d1d369ccb2741ae6fd1fe43a2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335800
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797826}

TBR=sky@chromium.org,bokan@chromium.org,boliu@chromium.org,khushalsagar@chromium.org,rmcelrath@chromium.org

Change-Id: Idce18f8f22c3533a7124bb2688a60b0cb2cc28f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1108956,1116246,1116247,1116248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354124Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797957}

Bug: 1112563
Change-Id: Ic39af14db9a5771a63dec3a153e63aa21339379d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339403Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797956}

Virtual keyboard can be enabled and not visible. When it's not visible,
suggestions should still be shown normally.

Bug: b/162293447
Change-Id: I3a9ef621abe4ab70031ea7ef0c1154ac61a7e11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355152Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797955}

This patch adds a cross-platform way for Web Payment feature to query
the IS_READY_TO_PAY intent of an Android app. As a first step, only the
Android apps installed on the Android subsystem of Chrome OS are
supported.

Bug: 1061503
Change-Id: I3055874e96e046a233c5bb223c9e4422d7e8e966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248427
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797954}

The DialogModelField pointer is instead used to identify the field.

Bug: 1106422
Change-Id: I2cd8ddd5bc4d79f4afa85bce47556fc31299155e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353408Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797953}

This CL adds basic tests, verifying VideoTrackReader construction, start
and stop.

Bug: 1094194
Change-Id: I945b49c83b30fb18e1b92f2263fbdb050a431d02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353533Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797952}

This matches other parts of the code.

BUG=1076463
TEST=none

Change-Id: I995b0f3449d5a4e4c20fb504a723681e9c8c14d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354792
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/53090ac8..a6dff6f4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5fc979b7c9edf64af9b377110c06a01089e38510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353491Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797950}

This CL adds NotificationAccessManager::AttemptNotificationSetup(),
which starts the flow for enabling notification access. Note that the
real implementation for this flow has not yet been completed. However,
the new code added to FakeNotificationAccessManager will unblock UI
work which needs this code in place to write unit tests.

A follow-up CL will actually implement the flow itself.

Bug: 1106937
Change-Id: I2d0ccedbe758252857ec2238a294b8a2a1f31eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354657
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797949}

When enabling unbundled consent for GetAuthToken in the extensions API,
the scopes returned by the server may not be the same as the requested
scopes. In some cases, the returned scopes may also include multiple
scope strings for the same requested scope. This CL addresses this
mismatch between the requested and granted scopes by adding the ability
for the access token cache to return tokens when only a subset of its
scopes was requested. This change would prevent repeated cache misses
when such mismatch occurs.

Bug: 1100535
Change-Id: I4000dc6a6782504ffa1781ef4ab7916bb64a1aa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330939
Commit-Queue: William Lin <williamlin@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797948}

Bug: b/162293447
Change-Id: I04ea807ba7944a9fb216b367910254556c2440c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355229Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797947}

Updates the README in WPT to reflect this, and Chromium's roll script so
that it doesn't roll into WPT.

And, unrelatedly, removes JusSn from the suggested_reviewers as he is
no longer actively working on WebGPU.

Rationale:

These tests test an unstable, constantly changing API. Because of this,
it's not practical for browser implementations to try to sync on a
single version of the test suite which is auto-imported/exported from
WPT. Auto-imports in any browser will necessarily result in test
failures just because the tests have changed to match some API change.

Instead, for the moment, browsers should pin ("vendor") a particular
version of the WebGPU CTS, and may include a built version of it in
their equivalent of "wpt_internal" for automated testing.

Discussion: https://github.com/web-platform-tests/wpt/issues/24699

Bug: None
Change-Id: Iaabd81ef646404ab7f6e8cc19a884b15f5306bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353550Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797946}

This removes the VideoTrackWriter interface so that it will not become
visible when the WebCodecs feature is enabled.

The VideoTrackReader unittest depends on the VideoTrackWriter C++ code,
so that has been left for now.

Bug: 897297
Change-Id: I1c328d7ca995cf9019ca50c65f8cb7257fbb06ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353538
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797945}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c71a9c2930fa..1d054a1f6d99

2020-08-13 brgoddar@microsoft.com Source Order: add user action to histogram

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1094406
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3ba28ee403197e95c32aa05fea5bb5a474e262db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797944}

This decouples ongoing work to refine the keyword button from our plans
to experiment on button row and Pedals.

Bug: 1046523
Change-Id: I3eddce8880f7473c837f393231e708bd5a07f56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343845Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797943}

ExtenionUserScriptLoader was calling
ChromeComponentExtensionResourceManager::IsComponentExtensionResource()
on the extension file task runner. But
ChromeComponentExtensionResourceManager should only be accessed on the
main sequence, because LazyInitData needs BrowserProcessImpl, which must
only be accessed on the main sequence (https://crbug.com/1033644).
Besides, LazyInitData() was racy in the previous setup.

Bug: 1113374
Change-Id: Ie1929a024213141a2ae431221e905c73134da65e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343344
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797942}