- 17 May, 2020 3 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/728fc6277285..c4fb1974191f git log 728fc6277285..c4fb1974191f --date=short --first-parent --format='%ad %ae %s' 2020-05-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c4fb1974191f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If9af66c1a1649c1caf625a8c086307841cdf5710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769542}
-
Xianzhu Wang authored
Though some GraphicsLayers don't contribute to final cc layer list, we may need to recognize them in the legacy GraphicsLayer tree. Also we may dump legacy GraphicsLayer tree before the debug name of cc layer is set. Change-Id: I729fc2f326c68050d8c3c2998f52d92a909725b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205320 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#769541}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I23e839ae1c91d56162abc8d04e14e467030f6258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205331Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769540}
-
- 16 May, 2020 37 commits
-
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I566f78ff444b3e2afded55f70f2f6a78a34cb14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205397Reviewed-by:
-
Satoshi Niwa authored
This reverts commit 1cafd8a4. Reason for revert: The CL made SELinux to be enforced even on userdebug images BUG=b:156699275 TEST=android-sh -c getenforce Original change's description: > arcvm: Remove androidboot.selinux=permissive > > The guest kernel boot parameter is no-op now. > > BUG=None > TEST=arc.Boot.vm > > Change-Id: I3097b4a8d1276b11d23dd8c436bf10cb3355e9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191319 > Auto-Submit: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Satoshi Niwa <niwa@chromium.org> > Reviewed-by: Satoshi Niwa <niwa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#767091} TBR=yusukes@chromium.org,niwa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I3d5523a368fce7b08c6b3a9b211a44bcaac27afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203349 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#769538}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I1b460814255e3943b2148a1d76e3bcc456c275f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204084Reviewed-by:
-
Brian Manthos authored
InstallerState::GetCurrentVersion used the pattern of returning a pointer, with "no current version" being represented as a nullptr. To simplify, it now returns a Version object. This affects a variety of consumers: - ModifyParams struct - InstallParams struct - AddUpdateDowngradeVersionItem() - DetermineCriticalVersion() - GetInstallerDirectory() - SetCurrentVersionCrashKey() Change-Id: Ib21f3773a0d5252151d4cbc82d8156140874e043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203488 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#769536}
-
David Maunder authored
The EndpointFetcher currently calls an arbitrary endpoint. If JSON is returned we want to ensure it is not malformed. Bug: 1083463 Change-Id: I2d7a473029902c26462c2d0bb6d2bafb8ab9b115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204962Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#769535}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I17b6611459d0685dc01474d66349b7b38bb2bcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205160Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I66c968bbd18db89e2c1ee132907a9332e0f07b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204082Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Id45535b95a8e4a942b92091625b088da080c6e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205126Reviewed-by:
-
Esmael El-Moslimany authored
Change-Id: Ie7f6e8d90e95118b9d4384268f19d6ce633d70d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204833 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769531}
-
Kyle Milka authored
Make a few small adjustments from UX. Make each item slightly wider to prevent text wrapping in certain cases. Remove padding from the end of the bottom row, it caused unwanted clipping. Bug: 1082033, 1009124 Change-Id: I1cb26845a8b81e161bbf1a24bb7d8a83822f9038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204547 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#769530}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I34ca328f3777aa22914e1f732a6e6293d6772bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202651Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769529}
-
dpapad authored
Closure compiler disallows optional parameters appearing before required parameters, by throwing JSC_OPTIONAL_ARG_AT_END. With this modification the auto-generated JS externs files are compliant with Closure Compiler, by being stricter compared to what is actually allowed at runtime by those APIs. Bug: 469920 Change-Id: I348e1465e66c05cdd827d9bdb39cf883b8f3ddbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203708Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#769528}
-
Victor Fei authored
Reverted due to failed win7 test for menulist-collapse-expected-uia-win7 This change disables AutomationFocusChanged UIA event in that test file, to avoid win7 bots flakiness. This is a reland of d4da4b0e Original change's description: > IsUIAControl to return false for ignored & invisible nodes > > Consider the following buttons that are hidden in the a11y tree: > <button aria-hidden="true">button</button> > > Whose a11y tree is the following > rootWebArea > ++button invisible "button" > > Currently, Windows Narrator is able to perceive an aria-hidden="true" > button. The expected behavior is that Narrator should not see the > button. > > The issue here is that Windows Narrator looks at UIA Control View to > determine if an element should be announced. AXPlatformNodeWin:: > IsUIAControl() determines if a node should be in the control view. > Currently, IsUIAControl does not take into account of ignored or > invisible state for web content elements. > > This CL fixes this Narrator issue by making IsUIAControl return false > for all web content elements with invisible or ignored state, thus > excluding them from the UIA Control view. > > This change also revealed one quirk with UIA. If an element is marked > as ignored or invisible (i.e. IsUIAControlElement return false), in > the UIA event model, UIA event listener will normalize the event > source to be the parent of the ignored or invisible element. I also > updated some of the UIA event tests due to this UIA quirk. > > Bug: 651614 > Change-Id: Icc997c09da29cbfdbcee2be3cc1026957c9a7e41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182168 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#767491} Bug: 651614 Change-Id: Ie579c6bfe58eeb15bdf17ac89f99c950db4dbb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195065 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769527}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc1bf875..f868d509 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a919f913309be2122ad8afa7a767d45f3b7f169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202883Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769526}
-
Yusuke Sato authored
For ARCVM, the new code generates a single combined file in ExpandPropertyFiles(). The generated file will later be mounted as guest's /factory/factory.prop. This depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2203717 BUG=b:155128030 TEST=try Change-Id: I60b9bbd3ed9f3565e99937f66d64131ec19a1e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200256Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769525}
-
Toby Huang authored
This CL adds UMA metrics for supervised users enabling and disabling extensions that have already been approved by the parent. Bug: 1022620 Change-Id: Ic66abfd6a6468fc0c12bf30faf268c626286a9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199407 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Id64f0a795fff05c2d015674966e6f45ed6a8ebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205113Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/660c3bc97e0b..57eb48aed361 git log 660c3bc97e0b..57eb48aed361 --date=short --first-parent --format='%ad %ae %s' 2020-05-16 capn@google.com Fix processing OpExecutionMode for the requested entry point Created with: gclient setdep -r src/third_party/swiftshader@57eb48aed361 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6b7f4ea3c2c309504081a9627f2650a43dc41b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204927Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec4698056847..20f0d0ba3aff Created with: gclient setdep -r src-internal@20f0d0ba3aff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1083498 Tbr: tluk@google.com Change-Id: I3792a5be0fe8276407e4cacc7bce2d9571a3d13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769521}
-
David Tseng authored
chrome.automation added the automation::TREE_CHANGE_TYPE_SUBTREEUPDATEEND to support, in part, live regions, since ChromeVox handles the low level tree updates in js. This was done because ChromeVox needed to wait until all deletions, creations, updates were made. There can be > 1 of these per call to AXTree::Unserialize. However, when trying to post automation::TREE_CHANGE_TYPE_SUBTREEUPDATEEND we need a node to deliver the js event to. Since Chrome started adding more ignored nodes, it's possible this event might have been posted on an ignored node e.g. role=div with child role=alert which is exactly what happens in the bug below. This change fixes this by simply posting the event on the root. The target doesn't matter to ChromeVox for this tree update event. R=dmazzoni@chromium.org Bug: 1082973 Change-Id: I9ee5cab87d1e38763d5c960879c24d5b880b05cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204419 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#769520}
-
Kenneth Russell authored
This test is passing on ANGLE's default D3D backend on this hardware. Tbr: shrekshao@google.com Bug: 1082565 Change-Id: Ic406aa9eacb3d3c7e1e1a52e89d4c349f07cbaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204694Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769519}
-
Rakesh Soma authored
Change-Id: Ia9b9677a9b5b33f86691a9da3e2d2055c14c03fc Bug: 1079070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184954Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#769518}
-
Maggie Chen authored
cmd_line->AppendSwitchASCII(switches::kGpuDriverVersion) caused a crash. No version string copying if the string empty. Added a debug::Alias for debugging purpose. Bug: 1083239 Change-Id: I606493112468957b4fc80dca941e7aca39b081b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204840 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769517}
-
Xianzhu Wang authored
This reverts commit 58c14d05. Reason for revert: The CL (crrev.com/c/2203495) causing the flakiness has been reverted. Original change's description: > Mark two flaky tests as flaky. > > Tests are consistently (but not always) failing on Win7 builder. > > Bug: 1082804 > Change-Id: I92628ee5f12e4ae574291a3f225803fab5b699bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202318 > Commit-Queue: Dana Fried <dfried@chromium.org> > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Auto-Submit: Dana Fried <dfried@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768868} TBR=rogerta@chromium.org,dfried@chromium.org,dfried@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1082804 Change-Id: Ia5e8bcde18c1fe2a791f4c6673d46592f53dfaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204849Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5e0a4a6b8088..728fc6277285 git log 5e0a4a6b8088..728fc6277285 --date=short --first-parent --format='%ad %ae %s' 2020-05-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@728fc6277285 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic2f92414dfc259cf58a31626f169f8ab3219afc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204921Reviewed-by:
-
manuk authored
*Rich autocompletion background* Currently, autocompletion is limited to when the user types a prefix of the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Rich autocompletion will allow autocompletion even when the input is from the suggestion title or middle of the URL. E.g. 'thecoo' and 'recip' will also autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Design doc with further details: go/richomniboxautocompletion Previous CLs: - crrev.com/c/2107796 added chrome://flags flags - crrev.com/c/2108780 supported multiselection in textfield views. *This CL* This is the 3rd CL for rich autocompletion. It adds a label view to the location bar to display the complementary omnibox text. I.e., while the omnibox displays either the URL or title depending on which matches the user input, this label displays the other field. This label is placed either to the right of or below the omnibox, depending on the 'two line omnibox' param. This CL has a small user facing change not guarded by the rich autocompletion flag. The location bar now redirects mouse events to the omnibox in order to handle mouse events on the complementary label. This has the beneficial, user facing side effect that clicking in the leftmost or rightmost 20px's of the location bar will now correctly focus the omnibox when the location bar decorations are hidden (i.e., when user input is in progress). This CL has no other user facing changes when the yet-non-functional rich autocompletion flag is disabled. Followup CLs will wire in rich autocompletion to make use of these changes. Bug: 1062446 Change-Id: Iedb681babdb03e05b80a8252444bf5882ab408cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199859 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#769514}
-
Wei-Yin Chen (陳威尹) authored
StartSurfaceTest#testScroll_OmniboxOnly fails on Lollipop builders as well. Disable it on all builders below Pie. TBR=peconn@chromium.org Bug: 1083174 Change-Id: I74a634296ef3230ff9e3bc34d31ce3c3aeb6a39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204534Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769513}
-
mark a. foltz authored
Previously, the origin check was only done for sink availability and not at route creation. It also did some brittle string parsing of the media source ID. The updated check covers all streaming app IDs, adds the meet.google.com origin, and checks origins for both availability and route creation. Follow up changes will add additional checks to prevent opaque origins from also launching streaming apps (see bug for details). Bug: 1047834,1081503 Change-Id: I081822796524ec2c72af29c544382cb4c9d9542d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095928 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#769512}
-
David Tseng authored
R=dmazzoni@chromium.org Test: manual; verify a cell size of 8 on a display, when call chrome.brailleDisplayPrivate.getDisplayState, on a 8-dot celled braille display. Change-Id: I25a2517e2a6ff29b38746a7ddfb8294669476d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194339 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769511}
-
Donn Denman authored
Adds support for displaying Related Searches using the existing Contextual Search UX. The main differences are: 1) Tap does not select anything when Related Searches is enabled. 2) Clicks in the Overlay don't promote to a new tab when they are only one level deep but do promote to a separate tab after that. When Related Searches are enabled the Long-press triggering is automatically enabled so a Long-press resolves normally but a Tap generates a Related Search without any selection. The treatment of the selection is gated by the Feature with a non-empty selection unless the Feature is active (allowing an insertion point). All significant functional changes are behind the RelatedSearches Feature flag. Functions that have been changed to accommodate this Feature have tests: Context allows an insertion-point and the SearchRequest allows non-Google URLs when the Feature is active. Also removed some unused code. BUG=1062737 Change-Id: I4b8f133398890c214d26e968c2ede6a1ba08618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200437 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Generalize some helper functions within Switch Access tests, and clean up tests. AX-Relnotes: n/a. Bug: None Change-Id: I7c0ced18e600a8a641a959d8e958a724045b47a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203403 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#769509}
-
Karandeep Bhatia authored
Improve CompositeMatcher interface to allow overwriting and erasing RulesetMatchers. This helps simplify client code. This has no behavior change. BUG=754526 Change-Id: I1e59bae5e06e3a3f123221f41619fa5d4e00dc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203224 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
This CL makes some small changes to allow the top 500 list to be less than 500 domains long. This allows us to remove domains that should no longer be in the list without having to regenerate the whole thing. This CL also incidentally fixes a bug wherein some domains were treated as top-500 domains even though they weren't. This CL keeps some statically-defined variables that are defined in a generated .cc file as having 500 entries, even though they actually have fewer than that. This prevents us from having to regenerate the header file as well, but eventually that's the right answer. I'm hoping we can merge this CL to M84, which necessitates simplicity and safety over elegance. Bug: 1083489,1083487 Change-Id: I45a5425cd4a8c4a9135d6f723b08d628f164f7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204554 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#769507}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31d722dc6723..21bceb888974 git log 31d722dc6723..21bceb888974 --date=short --first-parent --format='%ad %ae %s' 2020-05-15 thestig@chromium.org Use std::extent to figure out the size of member arrays. 2020-05-15 tsepez@chromium.org Convert pdfium::MakeUnique<> to std::make_unique<> in fpdfsdk Created with: gclient setdep -r src/third_party/pdfium@21bceb888974 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ieb8dce4526b5f59d81accc6fe0f02681597a730d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204916Reviewed-by:
-
Behnood Momenzadeh authored
This CL removes the now-superfluous EV_SECURE security state, as Chrome no longer treats EV certificates different than DV certificates in browser UI. Refer to https://crbug.com/1006943 for more information. Bug: 1006943 Change-Id: I330f5005fc07f18fc9edabd5a904bb136f577256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191191Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#769505}
-
Sean Topping authored
Bug: None Test: CQ Change-Id: I218520ae263aa2f597a6ac81703087ec5ad9c8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204847 Commit-Queue: Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Auto-Submit: Sean Topping <seantopping@chromium.org> Reviewed-by:
Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769504}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/212eb74a..bc1bf875 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d941c3f95b3af68d790bdfaae5d305461b72be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203985Reviewed-by:
-
