- 22 Jan, 2021 40 commits
-
-
Daniel Hosseinian authored
De facto enable the feature by default. Meanwhile: - Add a check that the plugin never starts in edit mode on non-CrOS platforms. - Update and clean up some tests. Fixed: 1169292 Change-Id: If34290490f6eec6cf2bcefb1ec15eaa7d51e2f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643267Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845969}
-
Alan Cutter authored
This CL adds a test for having multiple query params in the launch query params for a web app. Change-Id: I28475fd7b81355a9cca1077767e8a0e2380dd2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639335Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845968}
-
Andrew Grieve authored
Using function pointers rather than lambdas to address binary size regression from the introduction of ForEachObserver. Recovers 11,468 of the original 15,600 regression. Bug: 1116531 Change-Id: I56352c559931859610b00a7dfad615052147ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639396 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845967}
-
Joe DeBlasio authored
This CL changes the local allowlist, used when a user ignores a safety tip or interstitial, to apply eTLD+1-wide instead of just to a particular origin. This is particular important for the interstitial to avoid multiple warnings on sites that redirect, for instance from a bare domain (google.com) to a subdomain (www.google.com), or from nonsecure (http://google.com) to secure (https://google.com). A future CL, not merged back to M89, will adjust this allowlist to handle pairs of domains (i.e. (lookalike domain, canonical domain) pairs). Bug: 1154702 Change-Id: Ic112ca11b4fd66ebbe393822da0651ee832f6aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640741 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845966}
-
Wojciech Bielawski authored
Python 3 doesn't define 'long', but has 'int' type capable to store python's 2 'long' values. In addition most of places where 'long' is used seems to be not relevant, so 'long' can be relpacled with 'int' anyhow. Bug: 1168119 Change-Id: I971ea9044ce6dc5f084df122ba6d2571a8bb68cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640256Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#845965}
-
Anupam Snigdha authored
This CL is a continuation of crrev.com/c/2619002. We are planning to remove |VisiblePosition| usages in editing commands and selection because it leads to issues related to positions being snapped to incorrect location. Bug: 669811 Change-Id: I2f1f668033d3e1bc2d4209c9610878beaefd2c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643708 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845964}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/302f83f07614..5b2a5204087d 2021-01-22 ythjkt@google.com Merge "Enable subprocess support for chrome os." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I95e438a0d5fb1f223da12ff067a84de706d22a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845963}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/70f493d6e6ab..ff5f715e5c4a 2021-01-22 stevenan@google.com Properly fail upon program binary version mismatch 2021-01-22 timvp@google.com Capture/Replay: Capture all indexed buffer bindings during MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ide69ed962820cc01f2a979c29d47abec3b8f8681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845962}
-
Minju Kim authored
SkPath from |PlatformWindowDelegate::GetWindowMaskForWindowShape| needs to be transformed in DIPs by the given |buffer_scale_| before converted to rectangles. TEST: test with --force-device-scale-factor Bug: 1126828 Change-Id: I268e7266ba9131cf8eba481b1c30b93d2f1c3788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637098Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: MINJU KIM <mkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#845961}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ib1bdd895ef7872d940cebcf8825a90f575db5082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643671 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845960}
-
Adam Rice authored
They are now enabled by default. BUG=614302 Change-Id: Ied5e70e3bd6405e296d9b6fa0fccec5beb9ce1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643419 Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845959}
-
Peter Kotwicz authored
src/third_party/guava dependency in DEPS is redundant with src/third_party/android_deps/libs/com_google_guava_guava BUG=None Change-Id: I6b3fa4f90cb73ea90474c249c2e23e2c52463b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642940Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845958}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/9aef115356ce..47d67c37230e $ git log 9aef11535..47d67c372 --date=short --no-merges --format='%ad %ae %s' 2021-01-21 haoyuewang Add PeerIssuedConnectionIdManager that handles NewConnectionId Frame. 2021-01-21 bnc Add TlsServerHandShaker::GetAcceptChValueForOrigin() to configure ACCEPT_CH value. 2021-01-21 bnc Parse received ALPS data in QuicSpdySession. 2021-01-20 vasilvv Disable feature flags that broke Chromium unit tests in order to move the roll forward. 2021-01-20 fayang Add debugging logging for b/177651625. 2021-01-19 renjietang In QuicConnection, log the most recent frame type in a packet. 2021-01-19 danzh Refactor QuicConnection::OnConnectionMigration() to use active_effective_peer_migration_type_ instead of passing in the address change type as a parameter. 2021-01-19 bnc Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 wub Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 fayang Internal QUICHE change 2021-01-19 ianswett Internal QUICHE change 2021-01-18 ianswett Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src Change-Id: I0d83d35fbde4d6ffd5a426f2d4969ea3f8d772c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642861Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#845957}
-
Hiroki Nakagawa authored
This CL is a preparation for implementing the Omnibox trigger. This removes dependencies on the initiator RenderFrameHost from PrerenderHost(Registry) so that the Omnibox trigger that doesn't have a concept of the initiator frame will be able to trigger prerendering. Before this CL, PrerenderProcessor passed the identifier of the initiator frame up to PrerenderHost in order to retrieve BrowserContext. After this CL, StoragePartitionImpl passes BrowserContext when instantiating PrerenderHostRegistry, so the registry and hosts no longer need the initiator frame. Bug: 1166085 Change-Id: I0da9a95427c10ef65be7f2539311d50c002d68db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639352 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845956}
-
spdonghao authored
This CL does some refactoring work: 1. Save existing MV tiles info instead of only SiteSuggestion data. 2. Remove MV tiles favicons saving codes - the cached favicons are not always consistent with post-native ones so we show the default grey background icon instead. 3. Since favicons are no longer cached, we don't need to keep |mUrlToIdMap| and |mUrlsToUpdateFavicon|. 4. SiteSuggestion#faviconId is no longer needed. Bug: 1067386 Change-Id: I2f05ea32a04c30ef8ed21504a78a77771edb4043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611670Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#845955}
-
Adam Rice authored
The README file for chromium-specific stream web tests made reference to the SimpleQueue class, which no longer exists. Update it to reflect the current situation. Change-Id: Iea48716869617d2963dc2e7a13c465a83d44da44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644417 Commit-Queue: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#845954}
-
Hongbo Song authored
UKM privacy review: https://docs.google.com/document/d/1Vmbwz9ehnM-XHV2ueYj2nESTyTm57Inel0CLyX1ehXY/edit?usp=sharing&resourcekey=0-57VBdHDe9OSSTynCVtpatg Change-Id: I8055032fd2ce0b88667abb81248476690ba4c331 Bug: 1167755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640900Reviewed-by:
Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#845953}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/arc. Code previously using base::AdaptCallbackForRepeating now uses the more purpose-specific base::SplitOnceCallback. Bug: 1148570 Change-Id: Ie087afe3f6be92b267f2e36a7785052107344580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644344 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845952}
-
Ken MacKay authored
In Cast code, we often use a SequenceBound instance to handle calls from multiple sequences and forward them to a single sequence for execution (for example for methods that need to run on an IO thread, or simply to avoid thread-safety issues by running all business logic in a single sequence). A typical usage looks like: * A wrapper class exposes some API that is called in several places in our codebase, from multiple sequences. * The implementation of the wrapper class forwards the API calls to a SequenceBound<T> instance (using Post()) that implements the actual logic. * The wrapper class creates the SequenceBound<T> in its constructor, and deletes it in its destructor. Since we have to ensure that callers do not call into the wrapper after it is destroyed anyway, this usage of SequenceBound is safe. Change-Id: I40d67cd56e34a938492a8c528ec87bc25332fd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639652Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#845951}
-
Joel Hockey authored
The FileSystemURL from ConvertPathInsideVMToFileSystemURL will be used with the clipboard to copy and paste files between VMs and FilesApp. It needs to be valid with the real FilesApp Origin in order for this to work. Bug: b/162602338 Change-Id: I3ac2961e762dd26104b5f2461997b3175a5f7367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643737 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#845950}
-
Ye Kuang authored
Bug: 1141780 Change-Id: I2c3dc3a97b6c6a3ba70744e4b38475144b406897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639435 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#845949}
-
Yoshifumi Inoue authored
This reverts commit 8e907715. Reason for revert: Build failed on mac-arm64-rel bot. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3537 ../../third_party/swiftshader/third_party/marl/include/marl/pool.h:236:27: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer MARL_NO_EXPORT inline ~Storage(); ^ Original change's description: > Roll SwiftShader from 1d5174b9dc3b to 5b36fbc5ed2b (3 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..5b36fbc5ed2b > > 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM > 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members > 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I986f61efb56c3c3ca18b0100ae6ca3dfee2fed7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643117 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#845830} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I318bd80475234a7b9b7b5ef3d61602182f2f6dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644401Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845948}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I66bf05e42815ba0bd51b0769b784a2aefe2f9570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643169Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845947}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ife65dd1f215e0bb5afaa22ef0763644f8acc2c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845946}
-
Austin Tankiang authored
This is part of the plumbing to allow DriveFS to display confirmation dialogs in Files App. Now, when DriveFS calls into Chrome to display a dialog, this called is plumbed via DriveFsEventRouter to the Files UI as a fileManagerPrivate API event. This also exposes an interface, notifyDriveDialogResult, for the UI to send the result of the dialog back to DriveFS. Bug: 1166058 Change-Id: I25d1bc97eafb38e140cd20af152b53929550eb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637124 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#845945}
-
Joel Hockey authored
Refactor only change. Refactor GetFilenames to return internal FileInfo struct which includes FilePath and FileSystemURL so that it can be reused by CreateClipboardFilenamesPickle in crrev.com/c/2638967. By keeping the FileSystemURL in addition to the FilePath, it saves duplicating the code to crack the URL from the path. Bug: b/162602338 Change-Id: I91356840303bc6f15e11fcf43cad75c06e29fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643736 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#845944}
-
dpapad authored
- Delete testOpenCloseBookmarks() test case in basic_test.js (bookmarks no longer shown in a popup). - Make testToolbarDropdownShowHide() test case only run on CrOS in material_elements_test.js, since viewer-toolbar-dropdown will only be included on CrOS as a dependency of viewer-annotations-bar. - Remove references to the "pdf-viewer-update-enabled" HTML attribute. Bug: 1164004 Change-Id: Ic88fad7d01266a007005a18d37e4f3d3c39fb04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642128 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845943}
-
Nancy Wang authored
This is the follow up for CL:2624273. Move icon_standardizer* from c/b/ui/app_list to c/b/apps to prevent spaghetti code. BUG=1083331 Change-Id: I16d983966a6100786c539cfc20e2a708fb055373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636897 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845942}
-
Hidehiko Abe authored
In order to make crosapi more isolated from actual ash/lacros implementations, this CL renames AshChromeService and its corresponding variables to Crosapi. Also, AshChromeServiceImpl is renamed to CrosapiAsh, following the common naming convention in Chrome that it is the crosapi implementation in Ash. BUG=1148448 TEST=Launch lacros on a device. Change-Id: I600188445949a4de60325f5419f137f61360d0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640523 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845941}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37d16f135265..c09761f57605 2021-01-21 jmbetancourt@google.com [SkottieView] handle calls to setSource after first animation initialization 2021-01-21 brianosman@google.com Update particle system to use skvm, rather than ByteCode 2021-01-21 johnstiles@google.com Remove unnecessary _out pointer in Metal. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: If4e59cab861b232ceb73636052aa8fd5ec5ff7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845940}
-
Varun Khaneja authored
Fixed: 1140100 Change-Id: I7652027e47f71321002875eb511db5af666697ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591709 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845939}
-
Timothy Loh authored
- Add missing enum values from plugin_vm_installer.h and plugin_vm_metrics_util.h - Fix PluginVm.DlcUseResult to use enum= instead of units= Change-Id: I81fb268cb31e1be63310dd1ad25906cfbfcdbc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640315 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845938}
-
Lukasz Anforowicz authored
Extension operating in "split mode" has a separate background page for the regular profile VS the incognito profile. This CL adds a test that shows that currently (unexpectedly / undesirably) an ActiveTab permission granted to an origin in an *incognito* tab will not only affect CORS permissions in an incognito background page, but may also affect CORS permissions granted to the an extension background page of the *regular* profile. Bug: 1167262 Change-Id: Ica6f27efc989a0171819fef7211dc1190c9647d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633783Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#845937}
-
Ye Kuang authored
I will use this in https://crrev.com/c/2639435. Bug: 1141780 Change-Id: I4dc8b43cd364e7c3aaee74d2184736a15b26270c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642643Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#845936}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c153a21c203..be163e76ce9c 2021-01-22 annabelzhou@google.com Basic rendering and click handler unit tests for AccessibilityNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16695189f14875dbef08142f039daf31742c15be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644278 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845935}
-
Andrey Kosyakov authored
This reverts commit dabacbb8. Reason for revert: broke downstream CDP tests again (please see crbug.com/1164610 for details) Original change's description: > Reland "Cleanup for LayoutView overflow clips" > > This reverts commit 17de3187. > > Reason for revert: the root cause of crbug.com/1164610 has been fixed > by https://chromium-review.googlesource.com/c/chromium/src/+/2636883. > > This is a clean reland of the original CL. > > Original change's description: > > Revert "Cleanup for LayoutView overflow clips" > > > > This reverts commit 49dd6b58. > > > > Reason for revert: The scale of the devtool override frame size seems > > incorrect, causing crbug.com/1164610. > > > > Original change's description: > > > Cleanup for LayoutView overflow clips > > > > > > 1. Move the code checking requirement of overflow clip for printing > > > from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). > > > > > > 2. Combine LocalFrameView::ClipPaintRect() into > > > LayoutView::ViewRect(), so that all code paths calling ViewRect() > > > (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport > > > overriding aware. This means that the overriding viewport is > > > reflected in the paint property tree, and > > > CompositedLayerMapping::RecomputeInterestRect() no longer needs to > > > apply the viewport clip separately. > > > > > > Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388 > > > Reviewed-by: Stefan Zager <szager@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#841701} > > > > Bug: 1164610 > > > > TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: I18249c79339935b381ae3a05984d5f139d5194a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622514 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Stefan Zager <szager@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Stefan Zager <szager@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842140} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Bug: 1164610 > Change-Id: I38bd98f55387ac85e441ab3cfa4dc7a310e1c9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628315 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845804} TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6f95c387914a55e7588bc881378327d4567e050d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644496Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845934}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6031b74664d0..e4fd1ba31989 2021-01-21 danilchap@webrtc.org Delete mutable rtc::CopyOnWriteBuffer::data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9613ce0845b162ca281c45d88c0e77f8c861705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibe85c253a84f75e9a9c393ca159a92dcaadf3dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845932}
-
John Delaney authored
Removes instances of master/slave. Bug: 1169441 Change-Id: I3f937efb0c1a4f49d31514c0c5db5e8e0037d146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643630 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#845931}
-
Giovanni Ortuño Urquidi authored
Manifest install was replaced by WebApplicationInfo install. This CL removes all the macros to parameterize tests and run them with both install paths. Two of the three remaining macros use a single argument, so we could replace them with a two classes than tests inherit from. We don't do that in this CL to keep the size reasonable. Bug: 1158686 Change-Id: Id59984d48e462011c5c179601b0a8cc002f3f19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637096Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#845930}
-