GitLab

TBR=sky
BUG=159366

Review URL: https://chromiumcodereview.appspot.com/23003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217780 0039d316-1c4b-4281-b951-d872f2087c98

By applying changes from the top of the result tree, it should be guaranteed that there is no cycle in the metadata graph at any timing during the apply process.

BUG=269938

Review URL: https://chromiumcodereview.appspot.com/22988003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217779 0039d316-1c4b-4281-b951-d872f2087c98

The current icon for the OSX App Launcher is too big and looks out of
place in the Dock.

Since the app launcher app shim is not bound to an extension (or a
profile), it does not have a manifest to draw version information. This
CL introduces a new local pref, kAppLauncherShortcutVersion, that stores
an integer. Incrementing this integer in the code causes the app
launcher shim to be recreated, and store the new version in the local
pref.

Official icons in http://go/chromerev/9610014 .

Note that a reboot of OSX is required for the new icon to be observed in
the dock, because OSX caches icon resources aggressively and does not
have a reliable way to invalidate the cache.

BUG=270899
TEST=Have the app launcher already enabled via the webstore in old
version of Chrome. Run new chrome. Reboot (eventually). Dock should now
have the new app launcher icon.

Review URL: https://chromiumcodereview.appspot.com/22785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217778 0039d316-1c4b-4281-b951-d872f2087c98

Now that translate.js runs in an isolated world, it is safe to expose
API key as an isolated world global variable.
Of course, reusing this key outside Chrome is not permitted if it's possible:)

BUG=none
TEST=browser_tests --gtest_filter='Translate*.*'

Review URL: https://chromiumcodereview.appspot.com/22645015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217777 0039d316-1c4b-4281-b951-d872f2087c98

I partially fixed vertical alignment of views::Textfield, and I'm now working on the same issue of views::Label.  However, it will take time.  So I'd like to apply this temporary fix to IME autocompletion in Omnibox.  This CL puts the Label of IME autocompletion so its baseline is aligned to Omnibox Textfield's baseline.

BUG=270442
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/22563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217776 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some tiny bugs - just unlabeled controls and colors that aren't
sufficiently high-contrast.

If any of these fixes are undesirable we can just suppress those errors
instead.

BUG=265583

Review URL: https://chromiumcodereview.appspot.com/21944004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217775 0039d316-1c4b-4281-b951-d872f2087c98

> Adding key press detection in the browser process.
> It works like this on the browser side: 
> A new object KeyPressMonitor is created on BrowserMainLoop and passed to AudioInputRendererHost to pass to AudioInputController.
> AudioInputController::DoRecord calls KeyPressMonitor::AddKeyPressListener --> KeyPressMonitor listens to system key events through UserInputMonitor(only implemented on Linux) --> AudioInputController::OnKeyPressed is called and sets key_pressed_ --> When AudioInputController::OnData called, it writes key_pressed_ to shared memory along with the audio data buffer.
> On the renderer side a new param "key_pressed" is added through the code path of passing the flag to the webrtc voice engine.
> This CL includes all these changes except the implementation of UserInputMonitor for Windows and Mac. The impl of UserInputMonitor is mostly copied from remoting/host/local_input_monitor_linux.cc
> 
> 
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/21183002

TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/22871007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273047
TBR=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/23200002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217773 0039d316-1c4b-4281-b951-d872f2087c98

This turned out to be a tricky patch to land, so I'm landing https://codereview.chromium.org/18769010/ on behalf of elham@google.com. The original patch has all the requisite LGTMs so I'm just force-committing it here.

BUG=WebRTC bug 1198
TEST=Tested with Chrome and FireFox browser

Review URL: https://codereview.chromium.org/23172002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217770 0039d316-1c4b-4281-b951-d872f2087c98

These were disabled a long time ago.  I just tried a local
build and it seems to work, so perhaps some bugs were fixed,
or they were disabled for wrong reasons before.

BUG=161709
TEST=browser_tests --gtest_filter=NaClBrowserTest*

Review URL: https://chromiumcodereview.appspot.com/12087042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217769 0039d316-1c4b-4281-b951-d872f2087c98

It works like this on the browser side: 
A new object KeyPressMonitor is created on BrowserMainLoop and passed to AudioInputRendererHost to pass to AudioInputController.
AudioInputController::DoRecord calls KeyPressMonitor::AddKeyPressListener --> KeyPressMonitor listens to system key events through UserInputMonitor(only implemented on Linux) --> AudioInputController::OnKeyPressed is called and sets key_pressed_ --> When AudioInputController::OnData called, it writes key_pressed_ to shared memory along with the audio data buffer.
On the renderer side a new param "key_pressed" is added through the code path of passing the flag to the webrtc voice engine.
This CL includes all these changes except the implementation of UserInputMonitor for Windows and Mac. The impl of UserInputMonitor is mostly copied from remoting/host/local_input_monitor_linux.cc


BUG=

Review URL: https://chromiumcodereview.appspot.com/21183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217768 0039d316-1c4b-4281-b951-d872f2087c98

Leak is being reported from PageLoadTest.Reliability.

TBR=sadrul
NOTRY=true
BUG=273385

Review URL: https://chromiumcodereview.appspot.com/23160003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217767 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217766 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156114:156131&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23170003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217765 0039d316-1c4b-4281-b951-d872f2087c98

Recently, access to oem data has been disabled by default, and it is enabled only for Files.app. However, TimeScapes is an external extension and lost ability to play the movie which is in the oem directory. This patch temporarily whitelists TimeScapes to let it access the video.
Note, that this is just a temporary solution, and we should either restore access to read only native file systems to everyone, or grant it to TimeScapes in a proper way.

TEST=TimeScapes should play correctly in M-30.
BUG=262265

Review URL: https://chromiumcodereview.appspot.com/23233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217764 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=groby@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/23118004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217763 0039d316-1c4b-4281-b951-d872f2087c98

Create explicit 'navigate' and 'javascript' actions

BUG=263103

Review URL: https://chromiumcodereview.appspot.com/21174002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217762 0039d316-1c4b-4281-b951-d872f2087c98

Trace events now carry Dictionary arguments
(https://codereview.chromium.org/23088002/), which cause TraceEventAnalyzer
to fail hard. Changing the behavior to issue a warning instead and ignore the
unsupported arguments.

R=phajdan.jr@chromium.org
BUG=266101, 264308

Review URL: https://chromiumcodereview.appspot.com/23189006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217761 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23019005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217760 0039d316-1c4b-4281-b951-d872f2087c98

    
This CL makes the following two changes for the case where the service property
"Cellular.ActivationState" has value "flimflam::kActivationStateUnknown" and
payment portal URL is unavailable:
    
  1. NetworkConnectionHandler won't fail to connect with an activation error.
  2. InternetOptionsHandler will hide the "View Account" and "Activate" buttons
         if a payment portal URL is unavailable.
    
This CL also removes the NetworkConnectionHandler behavior that causes
a connect operation to fail with an activation related error when
Cellular.OutOfCredits is set to true, which leads to a confusing user
experience.
    
BUG=272324

Review URL: https://chromiumcodereview.appspot.com/22950007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217759 0039d316-1c4b-4281-b951-d872f2087c98

ManageProfileOverlay gives focus to the profile name text field in didShowPage()
function. However OptionsPage.showOvelay_ called document.activeElement.blur()
after the didShowPage() call. We should avoid to call blur() if the overlay
already has focus.

BUG=271297

Review URL: https://chromiumcodereview.appspot.com/23039009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217758 0039d316-1c4b-4281-b951-d872f2087c98

When we receive a mouse move event, there may be more events behind it
in the queue. Prevent those further mouse events from also triggering a
nested drag message loop.

BUG=268797

Review URL: https://chromiumcodereview.appspot.com/22934007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217757 0039d316-1c4b-4281-b951-d872f2087c98

The webview has changed and this patch upgrades it to reflect these changes. WebView.onBeforeSendHeaders is not accessible via WebView.request.onBeforeSendHeaders.

TEST=browser_tests
BUG=none

Review URL: https://chromiumcodereview.appspot.com/22828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223572

Review URL: https://chromiumcodereview.appspot.com/22303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217755 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217754 0039d316-1c4b-4281-b951-d872f2087c98

Manifest patch follow up. Adds manifest property nesting (to an arbitrary depth), fixed a bug that prevented some properties from displaying properly, removed some invalid pages, and added annotation support.

Rewrote manifest.json and the data source to make merging manifest.json with _manifest_features.json in the future painless. It is now much much easier to add properties to manifest.json! Annotations are added automatically and appropriately to designate which properties are optional/required/etc and additional annotations added in manifest.json are supported.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16410002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272078
TEST=n/a (renaming only)
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/23167002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273230

Review URL: https://chromiumcodereview.appspot.com/23164007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217751 0039d316-1c4b-4281-b951-d872f2087c98

This fix makes all alarms operations wait till alarms data is loaded from storage. Also fixing a bug in scheduling.

BUG=236684

Review URL: https://chromiumcodereview.appspot.com/22900005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272762

Review URL: https://chromiumcodereview.appspot.com/22210003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217749 0039d316-1c4b-4281-b951-d872f2087c98

An example chrome://devices/ page (behind flag) that lets users register devices with Google Cloud Print. Currently supported features:

- Device listing (addition/removal)
- Registration using Privet

BUG=245375

Review URL: https://chromiumcodereview.appspot.com/20070002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217748 0039d316-1c4b-4281-b951-d872f2087c98

They're flaky on all platforms.

TBR=sehr@chromium.org
BUG=272492

Review URL: https://codereview.chromium.org/23080004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217747 0039d316-1c4b-4281-b951-d872f2087c98

than the parent frame's.

BUG=272373

Review URL: https://chromiumcodereview.appspot.com/23057005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217746 0039d316-1c4b-4281-b951-d872f2087c98

valgrind was taking > 2 minutes when running PipelineIntegrationTest.AudioPlaybackBenchmark. This change gets the time for a small file down to < 1 second.

BUG=272550

Review URL: https://chromiumcodereview.appspot.com/22999010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264471
TEST=includes new Python test

Review URL: https://chromiumcodereview.appspot.com/22263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217742 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217739 0039d316-1c4b-4281-b951-d872f2087c98

> Whitelist TimeScapes to access restricted native local filesystem.
> 
> Recently, access to oem data has been disabled by default, and it is enabled only for Files.app. However, TimeScapes is an external extension and lost ability to play the movie which is in the oem directory. This patch temporarily whitelists TimeScapes to let it access the video.
> Note, that this is just a temporary solution, and we should either restore access to read only native file systems to everyone, or grant it to TimeScapes in a proper way.
> 
> TEST=TimeScapes should play correctly in M-30.
> BUG=262265
> 
> Review URL: https://chromiumcodereview.appspot.com/23011002

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22825010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273286
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23220003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217736 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=sadrul
BUG=269965

Review URL: https://chromiumcodereview.appspot.com/22893008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217734 0039d316-1c4b-4281-b951-d872f2087c98

(Optimized) binaries from http://crrev.com/22785002.

BUG=270899
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/22909010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217733 0039d316-1c4b-4281-b951-d872f2087c98