- 02 Jun, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
We currently adjust the computed value of 'color' on the document element to simulate 'canvastext' behavior. However, there's an incorrect assumption that it's safe to adjust whenever there are no 'color' declarations in the cascade. During a transition, the base ComputedStyle is the destination style for the transitioning element, and on the final frame of the transition, the StyleEngine simply emits a copy of the base style, without adding any declaration to the cascade. This causes color- transitions on the document element to "snap back" to black (or white, depending on color-scheme) when the transition ends. This CL fixes this by adding an explicit value (CSSInitialColorValue) which represents this behavior to the cascade. The value is added only when computing the base style, which prevents incorrect adjustments on top of the final transition frame. Bug: 1087188 Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224222Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#774178}
-
Mark Cogan authored
The CL has the base iOS Chrome unit tests set the plist key for the UIScene APIs when the gn flags for multiwindow/scene startup are set. Change-Id: I278be41b16e26d1078c043f936b3febc65dde6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199144 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774177}
-
David Roger authored
There are multiple styles for signin interception: - profile switch - enterprise - multi user These are not implemented yet, but this CL adds the logic to determine which one should be used. Bug: 1076880 Change-Id: Id90b558daa0dfb8f8b29feb5b1712d06b55e00bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218110 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#774176}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3bd1c1858f93..a0cf1eabb73e 2020-06-02 peah@webrtc.org Add peah as OWNER to common_audio 2020-06-02 kron@webrtc.org Reland "Add trace of enqueued and sent RTP packets" 2020-06-02 peah@webrtc.org Updating the Ooura FFT to take SSE2 usage specification in the ctor 2020-06-02 yinwa@webrtc.org Revert "Add av1 test running real video clips." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idcd2cc05da6df01a9b77f4bbf5e8cea3b2313c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774175}
-
Owen Min authored
Extension with blocked required permissions should be blocked. Extension with manifest type that is not whitelisted should be blocked. These blockings have higher priority than installation mode. The function will be used by webstore API. Bug: 1083500 Change-Id: I477dbf7bf2084cfa93c432295f226fb2900ca179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204685 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774174}
-
Kevin Babbitt authored
Follow-up to https://crrev.com/c/2225334. Adds a test similar to other tests for accessibility hit testing. While developing this test I noticed that the point passed to BrowserAccessibilityCocoa::accessibilityHitTest is actually in frame coordinates rather than screen coordinates. Noted this in a comment. Bug: 1086819 Change-Id: I052a78d2bbef54662e171889080e7089c510653d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225818 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774173}
-
Chih-Yang Hsia authored
- Add a enum class DeadStreamDetection to AudioInputDevice constructor to control the detection of dead stream. - Don't use the detection for hotwording and keep using the detection for other streams. Bug: 961890 Test: Test assistant with DSP hotword device Change-Id: I5e9a54275bc6f1d39cc125b0a54aac540eaf1e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220417 Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774172}
-
Xida Chen authored
These histograms are already replaced by other histograms, but didn't mark as obsolete. Bug: None Change-Id: I64142a4df8818d6a886657925ce216035b3fdcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222898Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774171}
-
Timothy Gu authored
Currently, window.event is implemented as a private symbol property stored on the Window JavaScript object itself. While doing so may have simplified memory management when the code was first written versus storing the event in C++, it does not anymore with Oilpan and unified heap. This also has no performance benefits, since each call to event() has had to jump through multiple C++/JS boundaries. The custom setter for Window.event was previous removed in r538391. This CL removes the custom getter. Bug: 236420 Change-Id: I67e862dda8c5a0248436ea90553fbf0b9b37aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225505 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774170}
-
Jonathan Ross authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2225586 this test was suppressed. The core failure was identified as crbug.com/1085899 In https://chromium-review.googlesource.com/c/chromium/src/+/2225979 the root cause was disabled for WebGL conformance tests. So I am re-enabling the test to maintain coverage. TBR=kbr@chromium.org Bug:1088465 TEST=deqp/data/gles3/shaders/preprocessor.html Change-Id: Ibbe1b22d434dc092cb6c0808dad239e5cc681db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226770Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774169}
-
Becca Hughes authored
Add tests for clear-site-data which should reset the media feed. BUG=1053599 Change-Id: If539e178aad9c04c3891930420f9f7b8cbbe7a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225231Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#774168}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8729c26f..113bf7f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1972092e17ec655f7e75466431d912606df40473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774167}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8121e57ab51..a5ced794731b 2020-06-02 herb@google.com Move addOp to SubRun and rename 2020-06-02 mtklein@google.com trim down skia_select() 2020-06-02 mtklein@google.com Wsign-conversion for public headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I93cf78b50a9f7fe015e545f974e2b60a23422e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774166}
-
Adam Langley authored
Noise says[1] that identity keys should be hashed after the prologue, but I missed this during the switch to KN handshakes. Thanks to Dirk Balfanz for picking up on that. Mobile counterparts will need to be updated to match this. BUG=1002262 [1] http://www.noiseprotocol.org/noise.html#:~:text=once%20for%20each%20public%20key%20listed%20in%20the%20pre-messages%20from Change-Id: I6b4fef90e640371100fa1b1be64113141099c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224987 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#774165}
-
Yi Gu authored
When the decoration layer was initially introduced [1], we used the same size as the foreground layer for it. After years of changes the TODO seems to be obsolete at the moment. [1] https://codereview.chromium.org/2439113003/diff/280001/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp Bug: None Change-Id: Id8a40a75abe5f611b55a6d9f85f722544b7096f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226772Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774164}
-
Filip Gorski authored
When view is recycled it may carry old action buttons. If color scheme is set before the action buttons, there is a chance we try to iterate a null list of actions. Bug: 1090314 Change-Id: If4efae6aaa147b6356c3d70d91c2775cc69c12cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225519Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#774163}
-
Robert Liao authored
The coupling of a views::View to a WidgetDelegate led to the unnecessary use of set_owned_by_client(). BUG=1044687 Change-Id: I4718fa4cceedc8ad378ea7d47165a17b9c728c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223014Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774162}
-
Andrew Grieve authored
* Don't use SwissArmyKnife in scripts to avoid the need to -keep it. * Confirmed with R8 team that -debug is sufficient for maintain all stack traces (no need for -dontoptimize). Bug: 1090335 Change-Id: Icdd9d4de4d9e7682e003439e60c983983b1cadc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226305 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#774161}
-
Sebastien Marchand authored
These 2 objects should always have the same lifetime (the facade factory is the UI thread counterpart of the PM cache factory). Bug: 1064859 Change-Id: Id68549fce593de5d473940902f9460e4b1a72210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137521Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#774160}
-
Anders Hartvoll Ruud authored
It's a bit annoying that unit tests for core/style are in core/BUILD.gn, but unit tests for core/css are in core/css/BUILD.gn. Change-Id: Iaf2285f4c9298eb4db9b35f5b51725697244909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224864Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#774159}
-
Side Yilmaz authored
This CL removes |getLastUsedProfile| function from Profile.java, since all usages of the function is removed on Android code. In addition to that, it corrects the comment on RevampedContextMenuCoordinatorTest class. Bug: 1041781 Change-Id: I10cefa67f6517a768228eabb52fed05009606fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172833Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774158}
-
Katie D authored
Does not yet expose cursor color to users. Bug: 1085442 Change-Id: I0104014abfffe5187f7f4f1ec4263c2d23da115d AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219095Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#774157}
-
Thomas Tellier authored
Bug: 1080866 Change-Id: I177f63704e3a8758c635d73adc46dee5fd134cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201918Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#774156}
-
Tanmoy Mollik authored
Extend the expiry date to M87 Bug: 1089518 Change-Id: I604be6f4c5721b7ed726d51451c20867841f8311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226732Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774155}
-
Denis Kuznetsov authored
Bug: 981472 Change-Id: Iae930244fd08f1017110a78e64ac11439084dc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218125 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#774154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc8777166676..72f885bd4df9 2020-06-02 changhaohan@chromium.org Add ARIA support to adorner interactions with minor optimizations 2020-06-02 bmeurer@chromium.org [wasm] Handle disassembly on the editor level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1043047,chromium:1047356,chromium:1066772,chromium:1071432 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id5d5179c5045a438a4518ed8cea847d16b6b5c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774153}
-
Maksim Moskvitin authored
Bug: 1083924 Change-Id: I386a41dfdc83b5bf5fb0ffb7025a07f70309e2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224867Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#774152}
-
Kyle Milka authored
Use a Supplier<Tab> instead of ActivityTabProvider to access the current tab from the share sheet. Bug: 1022172 Change-Id: Iadc972986713f436bcdbb036d6e0f3629eca18eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225332 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#774151}
-
Stephen Chenney authored
The histogram had expired yet nobody notified the Blink Core Rendering Team, who track this metric. So update the expiration and change the owners. Bug: 1052950 Change-Id: I140524c279f6957372950f4d3d742d11587dae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225826 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#774150}
-
Pin-chih Lin authored
To support 5.1 and 7.1-channel audio of Chrome on ChromeOS, the key point is the complete implementation of function GetPreferredOutputStreamParameters() in AudioManagerCras, which we have always fixed to report STEREO layout. With the corresponding CRAS patch, "MaxSupportedChannels" info is exposed via dbus GetNodes API for each output device node. Then function GetPreferredOutputStreamParameters() is able to obtain the supported channel count from specified device ID or the primary active device ID. BUG=b:120646399 BUG=b:152282570 TEST=tested HDMI 5.1-channel and internal speaker 2-channel support on Soraka w/ the corresponding CRAS patch to expose "MaxSupportedChannels" info. TEST=build media_unittests, browser_tests, and ash_unittests TEST=run media_unittests --gtest_filter=AudioManagerTest.CheckOutputStreamParametersCras Change-Id: Ibbed49813647efe721dd84a89c3ca5463d05581c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181254 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Auto-Submit: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774149}
-
Kenichi Ishibashi authored
We no longer check these histograms. Bug: 1088930 Change-Id: I28f8f996ef795d9be29b680ba7d85ed99241d95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226254 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774148}
-
Fergal Daly authored
https://crbug.com/1006814 has been tracked down. Bug: 1006814 Change-Id: If990c2ef1c648ea7a8e83575a213cb8e99afe6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225999 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#774147}
-
Chris Lu authored
Change-Id: Icbca11cbfbe8bdf7110d97ff7b1cbcbdbb4568f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225825 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#774146}
-
Roman Sorokin authored
Fixed: 1088683 Change-Id: I1b0623d23a425267b935ce71f73043f3047781e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224418 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774145}
-
Majid Valipour authored
For these cases we cannot calculate a meaningful scroll offset: 1. When target is not a descendant of timeline's source. 2. When target has no layout box. The current draft spec [1] asks for these situations to result into unresolved scroll offset which keeps timeline inactive. [1] https://github.com/w3c/csswg-drafts/pull/5124 TEST: wpt/scroll-animations/element-based-offset-unresolved.html BUG: 1023375 Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#774144}
-
Harkiran Bolaria authored
Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Change-Id: I1f1ab81d7718cc8ea4c48edf823a261cbf86e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212934 Auto-Submit: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Cr-Commit-Position: refs/heads/master@{#774143}
-
Kyle Milka authored
Extend the expiration to M87. Bug: 1089509 Change-Id: Ie2419c94cc305aa20cd2fae5b32ee784b67f1199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224973Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#774142}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for InitInlinedBuffer. However, specialization is not really necessary here with templates and can be moved into InitInlinedBuffer method without changing generated code. Bug: 819294 Change-Id: Ia8060152bf4ba21c85dfc4d99cd7cc64983de077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179122Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774141}
-
Robert Kaplow authored
Bug: 1089395 Change-Id: Ic64be041d58e97c3216e586c66ffaa6d2c662f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219279Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774140}
-
Javier Fernandez authored
We perform a pre-layout, based on a estimation of the grid area, of the grid items in two different situations: orthogonal and baseline aligned items. In the case of baseline aligned items, we were doing this pre-layout only in the case of items with relative inline and block sizes. However, items with 'auto' block-size also depend on this estimated grid area size to properly compute the baseline offset. It was discarded in the past due to performance concerns, since the 'auto' height is a very common case. However, this codepath is only executed for baseline aligned items. Since we already applied several optimization to the baseline alignment logic, I think we can try this approach to solve the bug and evaluate potential perf regressions when they appear. Bug: 1086132 Change-Id: I73c39e6c3ad6cd74aa50fe33106e25cd63b7625f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215054Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#774139}
-