- 01 Dec, 2020 40 commits
-
-
Morten Stenshorne authored
Bug: 1153517 Change-Id: I9f79bb90041fc8527f2add1121d664de9759c5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567152Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#832361}
-
Javier Ernesto Flores Robles authored
Experiment caused problems on iOS 12 and 14. On iOS 12 input accessory views had a bug where they were not being added most of the time. On iOS14 a divergence on some usage was observed in UMA, but there is no clear explanation for this. Bug: 816427 Change-Id: I98441836d208a30e5ea270c84e23f50b320eba52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565696Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#832360}
-
Yunke Zhou authored
Bug: 1145539 Change-Id: I1e75c7517e56a858478d6fd3681d3dfccad3779d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563474Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#832359}
-
Jeremy Roman authored
Rather than copy to the heap to make a dynamically modifiable flat_map, we can build the map into .data.rel.ro at compile time. To support current static_assert, base::flat_tree::size is made constexpr if the underlying collection is, as it is for fixed_flat_map and fixed_flat_set (specifically, std::array). For consistency, max_size and empty are similarly updated. Bug: None Change-Id: Ia21850b48e928e328f9cb85702b561925cca2d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566034Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832358}
-
Benoit Lize authored
Allocate multiple objects at a time for the thread at a time. This is meant to amortize allocation costs. Bug: 998048 Change-Id: I837216fcb3cb76302a6d09e7890b52313ebf8fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562302 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832357}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4654f2b60f7a..e50a1d65fa41 2020-12-01 jophba@chromium.org Add LICENSE file checking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iff8644f91ac55906b166a6cb1cc779b038b4c002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832356}
-
Roman Sorokin authored
Small cleanup Bug: none Change-Id: Ifce493d3c876fa1d067900fe8cba00c77582fb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563462 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832355}
-
Yuki Shiino authored
Implements accessor functions of new IDL unions. Also implements constructors and 'Clear' member function. Bug: 839389 Change-Id: I4d51261e96a23b63c33ac3c43553a779e978053e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522861Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832354}
-
Arthur Hemery authored
It has been the case several times now that this CHECK fails for speculative SiteInstance selection. It should not be an issue since the SiteInstance choice will be reevaluated with all information available. In this specific case: - We have a cross-origin isolated page from origin A with an iframe from origin B. The iframe opens a new window from origin A with COOP and COEP. - Because the iframe is from origin B, we should consider the window.open a no-opener. Doing so we force the new about:blank document to have an "unsafe-none" COOP. Done in RenderFrameHost::CreateWindow. - We then rely on the COOP mismatch mechanism to identify that we should swap browsing instances. This happens at response time. - During the speculative creation of the RFH, before receiving the response, we haven't yet processed the COOP part. We think no swap is required. Bug: 1150938 Change-Id: I9cf9bcb6393f298d669635a36e71ae8c3f6c7b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558610Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#832353}
-
Liquan (Max) Gu authored
Context: isServerAutofillInstrument, mHideServerAutofillCards are not being used and so should be removed. This will make a less complicated BrowserPaymentRequest#notifyPaymentUiOfPendingApps because pendingApps is no longer filtered. Changes: * Removed the related code of isServerAutofillInstrument. * Removed the related code of mHideServerAutofillCards. Bug: 1025619 Change-Id: I2b836226802cbaa2e464f8f1c94d59fbba4b848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565450 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#832352}
-
Harald Alvestrand authored
Since oauth is now part of webrtc-extensions, the test for it should be in that directory. This is preparatory to reviewing the rest of the iceServer tests. Bug: chromium:1044901 Change-Id: I588a3469ab62c6c7866c4fc80a654bcd155f8661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567872Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#832351}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606759191-849e6110591039c862ea10277c9aceb1aa0b28d5.profdata to chrome-win32-master-1606802354-2e3be99fee27d60bc23828ee78c917e6dcb3614e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic4b0623780915b9bca570be8346d3ac3f846ca2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567666Reviewed-by:
-
Carlos Knippschild authored
Change-Id: Ifc9ec865d8046bc11e0cf6c22a1a33d2dfb349d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565735Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832349}
-
Jan Krcal authored
This CL refactors tests for startup browser creator so that (more of) the real production startup code is exercised. This change is needed by CL 2547040 and splits off refactoring and behavioral change. Bug: 1150330 Change-Id: Ia81dc71ea092ad12001d355c93557f77ee5d7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563548Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832348}
-
Changhao Han authored
Temporarily disable this test to allow incoming change: DevTools Frontend CL: https://crrev.com/c/2560322 Bug: chromium:1150797 Change-Id: I6388873df89cff308c265a3b71a45e2fcf4340c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567154 Commit-Queue: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832347}
-
Bo Liu authored
Change-Id: Ic08863f36271341de848ddffe6c2971cb941b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562753Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832346}
-
Mike West authored
https://github.com/mikewest/embedding-requires-opt-in suggests that we shift the default behavior of <iframe>, et al. to require embedees to opt-into embeddings. This would protect developers by default, and seems like a reasonable state for us to aim towards. This patch implements this behavior in AncestorThrottle behind a new feature flag for experimentation. Bug: 1153274 Change-Id: Ib164cfde00fef836b409e7a684734862141d030f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563300Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#832345}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/05e6cccec435..a3bcd1c0e2e9 2020-12-01 primiano@google.com Merge "Roll zlib" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0b13b9b653b86fb8406ede5d365cefff98b1998a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567933Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f303e8141bc..fda47e8bb6cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tschumann@google.com Change-Id: I4246cb5d0a33d7706a7614204727060eb2094833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832343}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I857f1c73e17fd2d3899d5c6f978f77e9aa0db32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565774 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#832342}
-
Alexander Surkov authored
DumpAccessibilityTreeFromManager is small and has only one consumer: web_contents, which can use tree formatters directly. Bug: 1133330 Change-Id: I76aba176ec5a240fcfe1b1fe00742ac52880dafe AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532669 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#832341}
-
Bret Sepulveda authored
This is a reland of 39053ccc. The failing test that caused this to be reverted was deleted in crrev.com/c/2550812. There are no changes to this CL. Original change's description: > Add PermissionChip feature to fieldtrial_testing_config.json. > > As a prerequisite to landing cr/339683181. > > Bug: 1134294 > Change-Id: I95a0774957c5ba1cae28faad5916865f50e5a8d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510054 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829185} TBR=bcwhite@chromium.org Bug: 1134294 Change-Id: I16c604b1a46a924d497fc62424a7edcb2d4653fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566994Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#832340}
-
Vasiliy Telezhnikov authored
When resolution changes midstread in ImageReader/SurfaceControl mode it is possible that ImageReader currently have no buffers available. We request 3 buffers and they can be: * One is on screen, owned by SurfaceFlinger * One is in pending transaction to be presented. * One is queued by Chrome to submit when pending one will be presented. This CL delays rendering of the frame for getting FrameInfo until we will have slot available. Bug: 1115307 Change-Id: I65d5002e338f4a445e7cd15a5b975954a5e64912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563280Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#832339}
-
Liquan (Max) Gu authored
This CL causes no behavioural change. Motivation: This CL adds structural hooks to encapsulate the following methods: - ensureHasSupportedPaymentMethods - showAppSelector - triggerPaymentAppUiSkipIfApplicable Changes: * Added two structural hooks: - OnShowCalledAndAppsQueried(), for ensureHasSupportedPaymentMethods, showAppSelector - OnShowCalledAndAppsQueriedAndDetailsFinalized(), for triggerPaymentAppUiSkipIfApplicable Bug: 1153353 Change-Id: I12f4996a48d0110d7bf858151530694204d59acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563020 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832338}
-
Koji Ishii authored
This patch changes |SelectionControllerTest| to use the unified |HitTestResult::GetPosition()| added in r827165 <crrev.com/c/2535890>. This makes the tests to run the same code when |LayoutNGFullPositionForPoint| is enabled. By switching to the unified code, the test for crbug.com/985779 started to fail, because when inner node is inline, |LocalPoint()| is in the content coordinate system, not in the container coordinate system, that |PositionForPoint| should not add |ScrolledContentOffset|. Before |LayoutNGFullPositionForPoint| is enabled, this was done in |LayoutObject| virtual functions. Bug: 985779, 1150362, 829028 Change-Id: Ie16d228679778e64170720da105ba47bc6c3557f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567059Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#832337}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606802354-31ea8b5273cb9879cfc7599870323fbd7fd3af58.profdata to chrome-mac-master-1606823843-0f5277758f530be04bbb2f9dce57100bc533b372.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib40620e11a8828ea10d1e6d5bd8cfae556adf63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567804Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606802354-d1c692a560ec6fde56aef2f398f74e894835d223.profdata to chrome-linux-master-1606823843-898956163ed2fa02f28039f4033baf36c9ffa10d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ice44b046732fe1cb98bbbcc8eaa28a3192500a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567806Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1eadcfb3be99..bfb211914759 2020-11-30 aeubanks@google.com Fix swiftshader_reactor_llvm_unittests under UBSan Vptr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1152803 Tbr: swiftshader-team+autoroll@google.com Change-Id: I32ffdffb69ebdd0a62e327ef5c598c910a5316fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566870Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/56c610b14521..8cc4d0dc32a1 2020-12-01 wl@gnu.org * src/tools/chktrcmp.py (trace_use_pat): Update to current use. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I81294af2fa018b248ec5ed199602e1c5709a1796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567659Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#832333}
-
Bao-Duy Tran authored
Certain unit tests are having environment-specific failures due to mixed usage of hermetic test data and non-hermetic prod configs. This refactor is in preparation for fixing such non-hermetic-ness. Besides, it's also in preparation for further reduction in usage of deprecated input_methods.txt [1][2] (remnant from before the migration to extension-based input methods circa 2011), towards its full removal. Nowadays the canonical configs for 1P input methods on CrOS is google_xkb_manifest.json [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea [2] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707 Bug: 970790, 1134526 Change-Id: I622bb36e8cd054d26431870cb2d0e70a3e1fe472 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg;luci.chromium.try:linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554276 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#832332}
-
behdad authored
The crash reported in bug might have been caused by compiler deducing auto to refer to a BeginFrameArgs rather than a refference to BeginFrameArgs. So this change is going to fix this. Bug: 1153583 Change-Id: I2943230dc92b09ce3e352aff77d03a087e00b985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566710Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832331}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606780634-4bcba867177e99782f7fa7f8d4c0822ffa36a5f3.profdata to chrome-win64-master-1606802354-186e0b734d39b05126048ed00a5f975d199f5c7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6952206a58353475364e8870d4caea0f7a702fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567664Reviewed-by:
-
Koji Ishii authored
Applies the same changes as |LayoutNGBlockFlowMixin|. This patch should have no behavior changes. Bug: 1061423 Change-Id: Id33a5fdda4c05dd3e4f16e8e16727a963da3a9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567055 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..e644010395ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iba35af5ba8cd13ab49c2eb5ffbd51739671043fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567801Reviewed-by:
-
Leo Lai authored
BUG=b:172748724 TEST=chromeos_unittests. TEST=deploy a test-only function in DBusHelper, make sure the signal arrives with CL:2563522. Cq-Depend: chromium:2563522 Change-Id: I3fb14ff069cd710a9df496df7a293cc73466cec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563430 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832327}
-
Omar Morsi authored
Before this CL, enterprise.platformKeys API tests were run by the C++ side of the test opening a web page (basic.html) which runs the javascript code (basic.js). This CL is implemented with the following two goals. 1- Moving the JS tests to a background script which will run automatically after the extension is force-installed. This is a first step towards extending this background script to test the API behavior on the loginscreen. 2- Extending the tests to allow the C++ side to control which tests will run. Bug: 1148294 Change-Id: Iac04b0fbfd8951b1095fa3e93c24366c7c0aa338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560301 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#832326}
-
Christoph Schwering authored
The condition had been weakened in crrev.com/c/2550785 to the effect that the cached form is updated when the language has become available or changed since the seen was form last. This uncovered a bug in the sectioning. Especially since we may have an alternative way of receiving the language in crrev.com/c/2561838, the sectioning bug outweighs the benefit of the cache update. This CL is essentially a revert of crrev.com/c/2550785. Bug: 1154080 Change-Id: If70e8c4806ec2215c5a9f7c342789b7d53925656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566752Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#832325}
-
Alex Ilin authored
To force the light mode on the Reauth confirmation screen, we override the preferred_color_scheme web preference in SigninReauthViewController. However, a web preference overridden via WebContents::SetWebPreferences doesn't survive a recomputation of WebPreferences. This means that the preferred_color_scheme returns back to its default value. The comment to the SetWebPreferences method suggests to put the recomputation logic in ChromeContentBrowserClient. This CL does exactly that. This CL also adds a browser test to verify the behavior and catch possible regressions. Bug: 1153368 Change-Id: I8697e13095ba58d120f6ce61352caa32a982be0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565684 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#832324}
-
Clemens Arbesser authored
This CL (hopefully) fixes several flakily failing integration tests. - In one case, the translate popup could block the tap on a website element. Furthermore, possibly related to crbug.com/1140957, tapping some of the elements did not reliably work. The workaround is to disable translate and tap a different element. - In two other cases, tests were flaky because espresso timed out waiting for the UI to be idle. I was not able to reproduce, but since we have had similar issues in the past who were related to animations, I have removed the progress bar from those tests. We will have to monitor the builders to confirm that this fixes the flakes. Bug: 1149965 Change-Id: I149b7c930d6e57f496ab4c1f0991c34aac04b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567393 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#832323}
-
sandromaggi authored
After noticing that other attribute changes (e.g. "checked" on an type="checkbox" element) might also require sending out a "change" event, I no longer consider |SetFieldValue| atomic enough: It already does 2 steps (setting the attribute + sending the event). I propose to remove (or rather not introduce) |SetFieldValue| and use |SetElementAttribute| + |SendChangeEvent| instead. This CL does *not* change the current |WebController::SetFieldValue| method. To reduce duplications it should however be removed and its using actions changed to the above approach as well instead. Note: The swap in the |action_info| oneof is safe, because the mini-actions are not yet implemented on the backend. The fields are currently only reserved to prevent their use. Bug: b/172542134 Change-Id: I8330bc68565be5f07d3055e471653a787049c600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563303 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#832322}
-
