GitLab

X11 headers create a lot of macros using fairly normal names which
causes collisions in code that was written without X11 headers in
mind.

DeviceMode is also a type in components/policy and if that and
X11 includes end up in the same translation unit, there will be
compilation errors.

This was encountered in non-standard jumbo configurations and will
not affect currently supported code.

Bug: 782184
Change-Id: I84f9874d2858fc60c7e7c0e017d028dc8b710661
Reviewed-on: https://chromium-review.googlesource.com/847577Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526524}

The new flag enables SSH port forwarding from the host to the VM. It
will be useful for layout tests to start VM with --no-autorun and
then start and communicate with content_shell over SSH.

Bug: 778467
Change-Id: Ied45b3dd0a5f545def85274a91cc96cae2399832
Reviewed-on: https://chromium-review.googlesource.com/843481
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526523}

There are two sets of kDataPrefix and kMetadataPrefix in
components/sync and they have different values. In non-standard
jumbo configurations (much larger jumbo chunks than normal) those
will end up in the same translation unit and clash.

This renames one set of constants, leaving the other one as is
since its name already matches the use well.

Change-Id: I3640f1c1e7bc599c7d20317cd60d2f1ac7d90b15
Reviewed-on: https://chromium-review.googlesource.com/847593Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526522}

To help jumbo compilations, this code has already renamed
Children -> LayerChildren so this follows the same pattern
to help some other jumbo configurations where the plurality
of ChildAt and Parent methods caused problems.

Bug: 786926
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I086022931622b1bb670bc1313987ff69182c0990
Reviewed-on: https://chromium-review.googlesource.com/847473Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526521}

This fixes some short bookmark button titles getting truncated.

Bug: 796836
Change-Id: I7bf68b5b5ccc7d48923da231feccb97f9c0caa34
Reviewed-on: https://chromium-review.googlesource.com/845821Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526520}

Following bot results are included.
2736 2744 2747 2751 2753 2755

Manual rebaselines for css1 and css2.1.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I63b309df9edcbe77d9ad1d59ff9719af5f27ed3d
Reviewed-on: https://chromium-review.googlesource.com/846653
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526519}

Change-Id: Ifb6e45ae0a53af02a7b03ca3f1da404f40fea76e
Reviewed-on: https://chromium-review.googlesource.com/846808Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#526518}

This CL fixes a one-character typo in the method name of one of the new
TabModelObserver methods in the BVC.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1b1f72d4053452a3e11c6b283f99b8214def4d39
Reviewed-on: https://chromium-review.googlesource.com/847006Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526517}

Bug: 792315
Change-Id: I2809ba53f68694092535500b299f05a270d45119
Reviewed-on: https://chromium-review.googlesource.com/841725Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526516}

Make private mLock member and ensureChromiumStartedLocked() method package accessible
in order to use them downstream in a subclass inside the next/ layer.

This patch needs to land before:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/530279

BUG=781249

Change-Id: I6795fc45fa1d5e1ec8bdadad5bd1b62e577e8bb5
Reviewed-on: https://chromium-review.googlesource.com/843027
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526515}

Now that VideoFrame's ReleaseMailboxCB is called for mojo video
decoders, MCVD can use it.

This cl also converts VideoFrame::ReleaseMailboxCB => OnceCallback.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ice3031090cbfd43d10374294d9443f440a03b2f8
Reviewed-on: https://chromium-review.googlesource.com/815139
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526514}

Bug: 796913
Change-Id: I34cbb6075a33cc529ccd511199d5f274cb0ec735
Reviewed-on: https://chromium-review.googlesource.com/847454Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526513}

This CL reimplements Back button handling in AccountFirstRunFragment -
it no longer recreates every fragment in ViewPager, updating
AccountSigninView instead. This removes the need for custom
getItemPosition implementation.

Bug: 783344
Change-Id: Iaaa580802729551bb549c9848af8da9f7e9f7bd4
Reviewed-on: https://chromium-review.googlesource.com/844794Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526512}

This change fixes small issues in the U2F BLE classes.

Bug: 763303
Change-Id: Ib4b54b05d6952dbecb35b18ee53601b8d8c0ea67
Reviewed-on: https://chromium-review.googlesource.com/847477Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526511}

ProxyResolvingClientSocket accesses socket pools, http auth cache,
client certs cache directly.  As a part of the network servicification
effort, all interactions with //net need to be done using mojo APIs.
Socket usage will also be through mojo APIs. This CL moves this class to
services/network so the API surface that we need to export is smaller.

This CL:
- Moves ProxyResolvingClientSocket to services/network.
- Adds a few additional unit tests.

See design doc:  https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit?usp=sharing.

Bug: 721401

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbc0cb2e3a9713ef111ddd8b5845f27b1445574e
Reviewed-on: https://chromium-review.googlesource.com/763651
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526510}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bfbaf6ac..bb5733a4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ie4c2628fca6c2c44d7080cd778cba9355ab74dea
Reviewed-on: https://chromium-review.googlesource.com/847419Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526509}

They've been working in this codebase for a while now and this can help
expedite reviews for simple cases.  Obviously defer to dominickn@ if
unsure

Change-Id: I77eeaa91ec4e9690b7fedd8fa5dc3167416e3017
Reviewed-on: https://chromium-review.googlesource.com/817619
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526508}

It was being reversed in build_configs, then again in
process_resources.py

Bug: 782316
Change-Id: I654a77d8e859f068101fadf99400c26582844d82
Reviewed-on: https://chromium-review.googlesource.com/842950Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526507}

This CL removes the last usages of
SigninPromoController.arePersonalizedPromosEnabled and the method
itself.

Bug: 792430
Change-Id: Ib169667f755d87fc170b121654c59d50cb5d2b8e
Reviewed-on: https://chromium-review.googlesource.com/844318Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526506}

Makes a few updates to about:gpu.

* Add a "Copy to Clipboard" button, and removes the "To properly save
  this page" instructions. (797440)
* Fixes blacklist URLs on CrOS: fall back to the 0.0.0.0 version
  identifier whenever the 40-char hash is not available. (786605)
* Print the date in ISO format, rather than localized format, so that
  Chrome developers will be able to read it consistently. (no bug)

Bug: 786605
Bug: 797440
Change-Id: I6ab25b19248c49e8ba16bedad5060a48dc16b8b8
Reviewed-on: https://chromium-review.googlesource.com/846283Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526505}

content::Shell::PlatformExit() may be called more than once: ~Shell()
and Shell::CloseAllWindows() call it. Aura implementation of
PlatformExit() had a CHECK() that didn't allow to call it more than
once. Removed that CHECK().

Bug: 778467
Change-Id: I6ee25c57c3df75431033c000b20febf1bcdc3e2b
Reviewed-on: https://chromium-review.googlesource.com/846340Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526504}

bindings: Implement basic support for converting to/from Optional<> for nullable types in records and sequences.

This enables NativeValueTraits and ToV8 to support this mapping, which allows
constructs like sequence<double?> to work without losing the nullability of the
element type (which would cause coercion of null to 0 in this case).

This only handles some fairly simple types as the T in sequence<T?>:
- primitive types (numbers, booleans, etc.) map to Optional<T>
- string types map null to String()
- GC object types map null to nullptr
- unions map null to the default (null) union value

In particular, this doesn't handle:
- dictionaries (where the right solution isn't immediately clear)
- sequences of nullable sequences or records (which already doesn't
  work correctly in many cases, even without nullability)

Such cases are punted to later.

Bug: 792241,702145
Change-Id: I6dc1f488d4c98b908ec03c6789e6b713c05becb7
Reviewed-on: https://chromium-review.googlesource.com/831497Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526503}

Took me a while to realize that trace categories are case-sensitive..
otherwise all the pipeline to write the categories to the file and load
them in Chrome at startup seems to be working.

Bug: 795013
Change-Id: I27691f0e8464e375130fe74640de36dbd71785ac
Reviewed-on: https://chromium-review.googlesource.com/846800Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526502}

update virtual/scroll_customization/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html expecations

Bug: 795250
Change-Id: I1f66094298e9019ef2a04526f9ba772148903d20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/846533
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526501}

https://webrtc.googlesource.com/src.git/+log/5f99e656792b..9185bde7ee18

$ git log 5f99e6567..9185bde7e --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iab56978335dd5bfee1870112686970df593a53b2
Reviewed-on: https://chromium-review.googlesource.com/846525Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526500}

BUG=719977

Change-Id: Ia72e8bd5c4825fc66aedab5b6b4b1b7bd2964644
Reviewed-on: https://chromium-review.googlesource.com/846299Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526499}

The placeholder does not interact with high-level UI from chrome,
and from of the point of view of chrome is a web-level API, so it
make sense to have the tab helper be self-contained.

Bug: none
Change-Id: I12c7f9601aaf3e86d4d57bdd40ae4760ece03b5d
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/842547
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526498}

When adding telemetry_perf_unittests_viz I thought the isolate would just run
the targeted script. However it also tries to build a target of the same name.
Since this is an override, there is no target.

This change adds the executable override to the isolate definition.

TBR=dpranke@chromium.org

Bug: 795760
Change-Id: I2482275fffd3cfdee542ddb509f287d37fb75d1a
Reviewed-on: https://chromium-review.googlesource.com/847420Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526497}

Remove the GR_TESSELLATOR_LEGACY_INVERSION_HANDLING #ifdef.
This enables the partial straight skeleton (phase 2) in Skia.

BUG=756823,754612,754293,723980,728070

Change-Id: I70b4daef016dc950002cb0e98073bc90696b2ab9
Reviewed-on: https://chromium-review.googlesource.com/843082Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526496}

Bug: None
Change-Id: I497e5e058d148610bfeb813b287e6bd1961b17ee
Reviewed-on: https://chromium-review.googlesource.com/839601Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526495}

This CL fixes a crash when trying to clear on-demand icons when the
databases haven't been inited yet.

Since this is a non-critical task that can be arbitrarily delayed, we
use a simple early return in this case.

Bug: 794299
Change-Id: Ie4c0945a7f2d1136bfbb91428f4f815617ad9a83
Reviewed-on: https://chromium-review.googlesource.com/824238
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526494}

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//components/npt_snippets.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016

Bug: 755727
Change-Id: I7628bd96729646ee03b94835e220021b04564eb7
Reviewed-on: https://chromium-review.googlesource.com/846644
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526493}

https://skia.googlesource.com/skia.git/+log/adc78d52024f..8716b50aae94

$ git log adc78d520..8716b50aa --date=short --no-merges --format='%ad %ae %s'
2017-12-27 brianosman Update per-geo color after simplifying FPs in GrAtlasTextOp

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I6441ebb8706a905d256d68059f42813dca38a447
Reviewed-on: https://chromium-review.googlesource.com/846432Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526492}

WebState::IsEvicted() returns [CRWWebController isViewAlive]. The latter
is true if there is a presented web view or native view. With
WKBasedNavigationManager, a web state may be incorrectly considered
evited when transitioning from NTP to a web URL: the native controller
is already freed at this point, but the web view is not yet presented.
This is not a problem in LegacyNavigationManager because web view is
created after the navigation for the web URL starts and is immediately
presented. With WKBasedNavigationManager, web view is created when
loading the NTP (placeholder page). When loading the web URL, because
a web view already exists, |-displayWebView| is not called again even
though it should.

The bug causes incorrect page load counts in TabUsageRecorder.

Bug: 789993
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I68433c477cedebda29d08ec9716b0e92cb9d6442
Reviewed-on: https://chromium-review.googlesource.com/831049Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526491}

The accessibility is now done downstream.

Bug: 798075
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71243ea8769212737d1b6d4650254b4363e364ab
Reviewed-on: https://chromium-review.googlesource.com/846987Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526490}

In preparation for introducing more implementations of this interface,
this CL gives the three methods empty implementations. The
soon-to-be-added implementations of this interface need to override only
one of the methods.

Change-Id: I76e547a2ca3d2e56f361195071beb23481566707
Reviewed-on: https://chromium-review.googlesource.com/844634Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526489}

In HTML 5 there is an option to have input elements that are not inside <form>
tag, but which are associated to some <form> with form attribute. An example is
changes in this CL in password_controller_unittest.mm.

This CL replaces usage of form.getElementsByTagName('input') which returns
only elements that are inside form to call corresponding function from common.js
(which uses form.elements under hood) in order to get associated elements.

Bug: 775831
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I20f0f7b49b2bccd31db473a38b110802e28b24f1
Reviewed-on: https://chromium-review.googlesource.com/846768Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526488}

This was missed when upstreaming O-specific changes to WebView, and is
required for Instant Apps to be able to use WebView. Add it as a jinja
variable instead of to the template to avoid a downstream breakage (will
clean up in followup.

Bug: 797014
Change-Id: I21f94eb5f84388421804562d820fbfcdec1ca19b
Reviewed-on: https://chromium-review.googlesource.com/843167Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526487}

With this change, pressing "b" in the test app will dump the scene
hierarchy with a text representation of the bindings.

The extra strings are not included in release builds.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iab31e5d81ad7c594c903555fad28e8eae978205d
Reviewed-on: https://chromium-review.googlesource.com/847278
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526486}

Fix the implementation of get local storage keys and get session storage
keys functions.

Bug: chromedriver:2177
Change-Id: Iac8e8155081190d92dc14a54f9c367337f2ebe86
Reviewed-on: https://chromium-review.googlesource.com/844354Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526485}