GitLab

- Refactors app_banner_settings_helper to reuse for instant app banners
- Adds persistence for app banner behaviour. Record when an instant app
has been opened, dismissed, or ignored to decide whether the app should
be opened by default, or the banner should be hidden.
- Adds all the needed intent extras to the instant app intent.

BUG=639497

Review-Url: https://codereview.chromium.org/2379783002
Cr-Commit-Position: refs/heads/master@{#422544}

This CL reflows comments based on new Blink format in the following folders:
third_party/WebKit/Source/core/html/
third_party/WebKit/Source/core/offscreencanvas/
third_party/WebKit/Source/modules/canvas/
third_party/WebKit/Source/modules/canvas2d/
third_party/WebKit/Source/modules/offscreencanvas2d/

This CL has no behavior change.

BUG=563793

Review-Url: https://codereview.chromium.org/2387093002
Cr-Commit-Position: refs/heads/master@{#422543}

The offline page info from extra request headers needs to be persisted
in serialized navigation entry in order for it to be restored when
Chrome restarts. Otherwise, we may be opening an online page without
this info.

The design doc for this can be found here: https://docs.google.com/document/d/1vz0a9N-9egdm3yMDYMHcNVmQHOL8Qglz54lgG4ATwhc

BUG=644553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2310363002
Cr-Commit-Position: refs/heads/master@{#422542}

With this CL, the shutdown behavior of a task posted with a delay to a
BLOCK_SHUTDOWN TaskRunner is automatically adjusted to SKIP_ON_SHUTDOWN.
This ensures that a delayed task never blocks shutdown before being
scheduled. This matches the behavior of SequencedWorkerPool.

TBR=danakj@chromium.org
BUG=553459

Review-Url: https://codereview.chromium.org/2383193002
Cr-Commit-Position: refs/heads/master@{#422541}

This could happen for Reader mode, as it generates a new webcontents.
Enabling download on Reader mode will cause other issues like
overwrite infobar.
As a result, we should disable download in reader mode.
Will work on removing the download button from media controller in
reader mode.

BUG=650738

Review-Url: https://codereview.chromium.org/2392673002
Cr-Commit-Position: refs/heads/master@{#422540}

Call ShortcutManager#reportShortcutUsed when the user seelcts a shortcut or
completes an action that is equivalent to selecting the shortcut.

BUG=652023

Review-Url: https://codereview.chromium.org/2387193002
Cr-Commit-Position: refs/heads/master@{#422539}

FileDescriptorWatcher is a new API that should be used
instead of MessageLoopForIO::WatchFileDescriptor
when possible.

BUG=645114

Review-Url: https://codereview.chromium.org/2391743002
Cr-Commit-Position: refs/heads/master@{#422538}

DesktopViewFactory is no longer used after DesktopView becomes renderer
independent. This CL removes the interface.

Review-Url: https://codereview.chromium.org/2386693003
Cr-Commit-Position: refs/heads/master@{#422537}

Add a README file in the metrics histograms directory indication best
practices for emitting and documenting histograms.

I borrowed a sentence or two here or there from header files where I thought the header files explained things well. I hope the original authors of those words don't mind this repurposing.

I decided not to talk about user actions here.

There is nothing here about how to analyze the histogram results.  The
current scope for this document felt right without that.  We may want
to consider adding that later, probably to another doc.

I did not yet check how this rendered in markdown.  I thought I'd
send it for review now, as I likely won't be able to double-check the
markdown for some time (another day?).

BUG=

Review-Url: https://codereview.chromium.org/2381233002
Cr-Commit-Position: refs/heads/master@{#422536}

Also cleans up some comments.

R=rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2383903003
Cr-Commit-Position: refs/heads/master@{#422535}

This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.

BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.

Review-Url: https://codereview.chromium.org/2384843002
Cr-Commit-Position: refs/heads/master@{#422534}

These were removed in https://codereview.chromium.org/2162783002.

bug=none

Review-Url: https://codereview.chromium.org/2388243002
Cr-Commit-Position: refs/heads/master@{#422533}

Sampling profiler data shows this takes 10ms on the startup path,
mainly due to querying parental controls. Since we only need to
check parental controls if the incognito flag was specified on
the command line, the code is refactored to only query them in
that case.

BUG=651848

Review-Url: https://codereview.chromium.org/2382023003
Cr-Commit-Position: refs/heads/master@{#422532}

BUG=563793

Review-Url: https://codereview.chromium.org/2387083002
Cr-Commit-Position: refs/heads/master@{#422531}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/01c3773f..8341c698

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2387163002
Cr-Commit-Position: refs/heads/master@{#422530}

Also add some helper code to make updating the ocsp-test-root easier.

BUG=none

Review-Url: https://codereview.chromium.org/2382423002
Cr-Commit-Position: refs/heads/master@{#422529}

This stabilizes ChromeLauncherControllerArcDefaultAppsTest.
DefaultApps when it gets executed in batch mode.

TEST=Multiple runs of unit_tests showed no retries for this test.
TEST= out/Debug/unit_tests --gtest_filter=*ChromeLauncherController*.
BUG=651969

Review-Url: https://codereview.chromium.org/2385223004
Cr-Commit-Position: refs/heads/master@{#422528}

This CL changes the icon on the sync settings row to a right arrow.

BUG=652349
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2386213003
Cr-Commit-Position: refs/heads/master@{#422527}

Style [1] requires newlines between rules in CSS, but MD extensions
haven't been abiding (my bad). Conform.

[1] https://google.github.io/styleguide/htmlcssguide.xml?showone=Rule_Separation#Rule_Separation

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392573002
Cr-Commit-Position: refs/heads/master@{#422526}

BUG=347333, 369209, 640170

Review-Url: https://codereview.chromium.org/2386313002
Cr-Commit-Position: refs/heads/master@{#422525}

https://pdfium.googlesource.com/pdfium.git/+log/e5393582a7f5..d61f958385be

$ git log e5393582a..d61f95838 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 weili Detect resursive loading of type3 font char to avoid infinite loop

BUG=651304

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2390823002
Cr-Commit-Position: refs/heads/master@{#422524}

Step 3/4 of separating feedback and help in the navigation menu.

BUG=650813

Review-Url: https://codereview.chromium.org/2376203003
Cr-Commit-Position: refs/heads/master@{#422523}

BUG=563793
NOTRY=true

Review-Url: https://codereview.chromium.org/2392623002
Cr-Commit-Position: refs/heads/master@{#422522}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1b48ca5d8ef0..6efaefc15ef4

$ git log 1b48ca5d8..6efaefc15 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 sullivan Remove slow-to-compute 'subtests' field from /group_report

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2391713002
Cr-Commit-Position: refs/heads/master@{#422521}

Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update.

Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp.

These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/

BUG=622920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2376883002
Cr-Commit-Position: refs/heads/master@{#422520}

Currently CreditsActivity is not marked as exported, which means the internal
Help&Feedback library doesn't have permission to launch CreditsActivity and
therefore we can't move the Credits menu item back to Help&Feedback's overflow
menu.

This CL marks CreditsActivity as exported to solve the problem above.

BUG=613604

Review-Url: https://codereview.chromium.org/2384803002
Cr-Commit-Position: refs/heads/master@{#422519}

BUG=648281

Review-Url: https://codereview.chromium.org/2389453002
Cr-Commit-Position: refs/heads/master@{#422518}

BUG=504347

Review-Url: https://codereview.chromium.org/2383423002
Cr-Commit-Position: refs/heads/master@{#422517}

BUG=563793

Review-Url: https://codereview.chromium.org/2392653002
Cr-Commit-Position: refs/heads/master@{#422516}

This should allow most (all?) SPv2 paint invalidation tests to pass without
any changes to expectation files.

BUG=647831

Review-Url: https://codereview.chromium.org/2383323002
Cr-Commit-Position: refs/heads/master@{#422515}

R=dpapad@chromium.org
BUG=651730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2385873002
Cr-Commit-Position: refs/heads/master@{#422514}

This change adds a new top-level compiler config to GN, so that we can
control whether AFDO should be enabled or not per-target in CrOS
official builds (which is where we use AFDO).

R=brettw@chromium.org, llozano@chromium.org
BUG=633719

Review-Url: https://codereview.chromium.org/2375783002
Cr-Commit-Position: refs/heads/master@{#422513}

BUG=651874

Review-Url: https://codereview.chromium.org/2379053004
Cr-Commit-Position: refs/heads/master@{#422512}

Added service-worker-pause.html.
Updated expectations on some tests.

BUG=648775,480769,564403

Review-Url: https://codereview.chromium.org/2388933002
Cr-Commit-Position: refs/heads/master@{#422511}

DisplayCompositor => CompositorFrameSink
SurfacesState => DisplayCompositor

BUG=647852

Review-Url: https://codereview.chromium.org/2386763002
Cr-Commit-Position: refs/heads/master@{#422510}

Revert of Move synthetic gesture input to be aligned with BeginFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2372873003/ )

Reason for revert:
Appears RenderWidgetHostViewChildFrame ends up calling a virtual during the constructor and this isn't getting called. This is an existing bug.

But the change in this CL reveals this bug so reverting this change for now.

Original issue's description:
> Move synthetic gesture input to be aligned with BeginFrame.
>
> The timing of synthetic events seems almost random. It is best to align
> it with something that doesn't fluctuate. Android already rAF aligns its
> synthetic input so do this for aura and mac as well.
>
> BUG=646369
>
> Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539
> Cr-Commit-Position: refs/heads/master@{#421528}

TBR=sadrul@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=646369

Review-Url: https://codereview.chromium.org/2390813002
Cr-Commit-Position: refs/heads/master@{#422509}

This allows UdevLinux to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.

BUG=645114

Review-Url: https://codereview.chromium.org/2392583002
Cr-Commit-Position: refs/heads/master@{#422508}

BUG=651903

Review-Url: https://codereview.chromium.org/2388223002
Cr-Commit-Position: refs/heads/master@{#422507}

Also restore a few tables in text to their pre-formatted
form.  They need up to 243 columns to look at, so they
should probably be formatted differently eventually, but
not today.

BUG=563793

Review-Url: https://codereview.chromium.org/2385283002
Cr-Commit-Position: refs/heads/master@{#422506}

sheetText() has proper null checks for the underlying data buffer.

This CL also adds a check for hasClient() to prevent notifying a client
that has already been removed.

This CL also adds a regression tests for a previous issue, 645331.

BUG=646869, 645331

Review-Url: https://codereview.chromium.org/2381193004
Cr-Commit-Position: refs/heads/master@{#422505}