- 28 Sep, 2017 40 commits
-
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I703d25575a1fbd487c5703633e652afea83cee4d Reviewed-on: https://chromium-review.googlesource.com/688897Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505024}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=cmumford@chromium.org Bug: 666525 Change-Id: I74f82c441f22fa1809d8d8262fe5c71881843729 Reviewed-on: https://chromium-review.googlesource.com/689137Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505023}
-
Jared Saul authored
Bug: Change-Id: I72f6e575a30a9d3a9fef4d52cb0ca988270e5f70 Reviewed-on: https://chromium-review.googlesource.com/688820Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505022}
-
Miriam Gershenson authored
To prepare for running a new experiment on Android, the AsyncDns field trial needs a command line flag and a chrome://flags entry. Migrating it to the new FeatureList API was the easiest way to do that. Also deprecate the old pref source histograms. Bug: 768874 Change-Id: I7858ffdc1b18a01701c75c3fca7d0269f8ed4455 Reviewed-on: https://chromium-review.googlesource.com/685036 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505021}
-
Xida Chen authored
This reverts commit b6a0794d. Reason for revert: <INSERT REASONING HERE> Causing build error: https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/103347 Original change's description: > Disable TileGridLayoutTest#testModernTileGridAppearance_Two > > TBR=dgn@chromium.org > NOTRY=true > > Bug: 769738 > Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea > Reviewed-on: https://chromium-review.googlesource.com/690238 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505016} TBR=dgn@chromium.org,xidachen@chromium.org Change-Id: I546039abb34116b5897a9ffaf1f9134229d5659b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769738 Reviewed-on: https://chromium-review.googlesource.com/690674Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505020}
-
Elodie Banel authored
The omnibox is hidden when launching the app, but shown again if the startup params are set to focus omnibox. This causes a visual flicker. Passing around this argument makes it possible to not hide the omnibox in the first place if it will be focused. Bug: 754119 Change-Id: I4a4e4f759c2be2bbdaa028ec7c34e49745848189 Reviewed-on: https://chromium-review.googlesource.com/687774 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505019}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Idbab88621758712b7d3d6cdf3decdb023e5e65f2 Reviewed-on: https://chromium-review.googlesource.com/688899Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505018}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=avi@chromium.org Bug: 666525 Change-Id: I041a49290baec644180bd3f40c658dd0458d4cbe Reviewed-on: https://chromium-review.googlesource.com/689118 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505017}
-
Xida Chen authored
TBR=dgn@chromium.org NOTRY=true Bug: 769738 Change-Id: Ied6cdecac72229353f3c41ca769b6d872ea7a2ea Reviewed-on: https://chromium-review.googlesource.com/690238Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505016}
-
tzik authored
RefPtr<>::Get() is being renamed to get() for a preparation of the unification of RefPtr and scoped_refptr. This CL updates calles of Get() in modules/ to use get(). Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I62a7652bbfca4cb9bdfe30b58a261c420047836e Reviewed-on: https://chromium-review.googlesource.com/690354Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#505015}
-
Xida Chen authored
TBR=schenney@chromium.org NOTRY=true Bug: 769729 Change-Id: I51b2f08827a09602ced344f9d3413a198d333b4a Reviewed-on: https://chromium-review.googlesource.com/690534Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505014}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Iea1d1570be5b3f35e6811c2faa1d0f0411f8a379 Reviewed-on: https://chromium-review.googlesource.com/688895Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505013}
-
Henrik Grunell authored
Changes: https://webrtc.googlesource.com/src.git/+log/433b11e..7e9c614 $ git log 433b11e..7e9c614 --date=short --no-merges --format=%ad %ae %s 2017-09-28 ivoc@webrtc.org Added configurable offsets to the per-packet overhead in the ANA frame length and bitrate controllers. 2017-09-27 danilchap@webrtc.org Remove unused mocks of process thread 2017-09-27 buildbot@webrtc.org Roll chromium_revision ff8cef57..888713f6 (504574:504840) 2017-09-27 solenberg@webrtc.org Revert of Remove various IDs (patchset #7 id:120001 of https://codereview.webrtc.org/3019543002/ ) 2017-09-27 deadbeef@webrtc.org Try creating sockets again if network change occurs after bind failed. 2017-09-27 solenberg@webrtc.org Prepare to remove ADM APIs that are to be deprecated. 2017-09-27 solenberg@webrtc.org Remove various IDs: 2017-09-26 steveanton@webrtc.org Add base fixture and PeerConnection wrapper for unit tests 2017-09-26 philipel@webrtc.org Move PacketQueue out of paced_sender.cc to its own packet_queue.{cc,h}. 2017-09-23 magjed@webrtc.org Remove unnecessary video factory references in PeerConnectionFactory 2017-09-27 kjellander@webrtc.org Update build_aar.py after webrtc/ dir was removed. 2017-09-27 ehmaldonado@webrtc.org Rename test output to test artifacts. 2017-09-27 brandtr@webrtc.org Add support for SW fallback decoder in VideoProcessor. 2017-09-27 nisse@webrtc.org Add lock annotations and const declarations to RtpReceiverImpl. 2017-09-27 magjed@webrtc.org Revert "Android: Generate JNI code for VideoSink and VideoEncoder" 2017-09-27 ehmaldonado@webrtc.org MB: Make it possible to specify timeout. 2017-09-27 aleloi@webrtc.org Disabling CallPerfTest.{CaptureNtpTimeWithNetworkDelay,CaptureNtpTimeWithNetworkJitter}. 2017-09-26 magjed@webrtc.org Android: Generate JNI code for VideoSink and VideoEncoder 2017-09-27 sakal@webrtc.org Update documentation for getData methods in VideoFrame.I420Buffer. 2017-09-27 alessiob@webrtc.org audioproc_f with simulated mic analog gain 2017-09-27 aleloi@webrtc.org Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss on Mac. 2017-09-26 alessiob@webrtc.org Export script bug fixed. 2017-09-26 magjed@webrtc.org Android: Suppress lint warnings in JNI generator header 2017-09-27 aleloi@webrtc.org Disable flaky test OrtcFactoryIntegrationTest.BasicTwoWayAudioVideoRtpSendersAndReceivers. 2017-09-25 kthelgason@webrtc.org Reland "Remove precompiled header for AppRTCMobile." 2017-09-26 peah@webrtc.org Reland of Added logging inside AEC3 for render API buffer 2017-09-26 nisse@webrtc.org Delete redundant logic for setting is_first_packet_in_frame 2017-09-26 ehmaldonado@webrtc.org Fix isac_fix_test on swarming perf bot. 2017-09-26 buildbot@webrtc.org Roll chromium_revision 69fe0e1a..ff8cef57 (504538:504574) 2017-09-26 buildbot@webrtc.org Roll chromium_revision a5e331cc..69fe0e1a (504494:504538) 2017-09-26 solenberg@webrtc.org Remove unnecessary send codec initialization from voe::Channel. 2017-09-26 buildbot@webrtc.org Roll chromium_revision 524a99e5..a5e331cc (504439:504494) 2017-09-26 buildbot@webrtc.org Roll chromium_revision 2f37bb9a..524a99e5 (504378:504439) 2017-09-26 lliuu@webrtc.org Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss on Linux due to flakiness. 2017-09-22 zhihuang@webrtc.org Reland: Completed the functionalities of SrtpTransport. 2017-09-26 solenberg@webrtc.org Remove the VoiceEngineObserver callback interface. 2017-09-26 buildbot@webrtc.org Roll chromium_revision 99e3e3dd..2f37bb9a (504346:504378) 2017-09-26 magjed@webrtc.org Android: Add header for generated JNI code 2017-09-25 saza@webrtc.org Add PostProcessing interface to audio processing module. 2017-09-25 charujain@google.com Presubmit: Add check to support b/xxx entry in bug reference. 2017-09-26 buildbot@webrtc.org Roll chromium_revision 83821ae6..99e3e3dd (504327:504346) 2017-09-26 alessiob@webrtc.org Total Harmonic Distorsion plus noise (THD+n) score in APM-QA. 2017-09-26 philipel@webrtc.org Push back on the video encoder to avoid building queues in the pacer. 2017-09-26 asapersson@webrtc.org Modify some rate control and quality thresholds due to flakiness. 2017-09-26 buildbot@webrtc.org Roll chromium_revision f1b84062..83821ae6 (504296:504327) 2017-09-26 philipel@webrtc.org Continuously request keyframes if decoding does not recover. 2017-09-26 nisse@webrtc.org Delete member VideoReceiveStream::Config::Rtp::ulpfec. 2017-09-26 sakal@webrtc.org Revert "Improve unit testing for HardwareVideoEncoder and fix bugs." 2017-09-25 sakal@webrtc.org Improve unit testing for HardwareVideoEncoder and fix bugs. 2017-09-25 buildbot@webrtc.org Roll chromium_revision 81f3a6b9..f1b84062 (504277:504296) 2017-09-25 buildbot@webrtc.org Roll chromium_revision b4889436..81f3a6b9 (504239:504277) 2017-09-25 zijiehe@google.com Add more logs in DX capturer 2017-09-25 buildbot@webrtc.org Roll chromium_revision 548147b1..b4889436 (504172:504239) 2017-09-25 buildbot@webrtc.org Roll chromium_revision d6e517c1..548147b1 (504112:504172) 2017-09-25 henrik.lundin@webrtc.org NetEq: Simplify the dependencies of GetNetworkStatistics 2017-09-25 buildbot@webrtc.org Roll chromium_revision 5cea913a..d6e517c1 (504068:504112) 2017-09-25 buildbot@webrtc.org Roll chromium_revision 29ce025c..5cea913a (504034:504068) 2017-09-25 aleloi@webrtc.org Disable flaky test VideoProcessorIntegrationTestMediaCodec.ForemanCif500kbpsVp8. 2017-09-25 sakal@webrtc.org Return EGL_NO_CONTEXT instead of throwing an exception. 2017-09-25 charujain@webrtc.org Revert "Remove precompiled header for AppRTCMobile." 2017-09-25 magjed@webrtc.org Android: Add CalledByNative annotation interface 2017-09-25 oprypin@webrtc.org Remove remaining mentions of gflags 2017-09-25 henrika@webrtc.org Fixes issue in ADM on Mac OSX when audio is renegotiated 2017-09-25 kthelgason@webrtc.org Remove precompiled header for AppRTCMobile. 2017-09-25 danilchap@webrtc.org Resolve cyclic dependency in remote bitrate estimator 2017-09-25 henrika@webrtc.org Adding time profiling support to AudioFrame 2017-09-25 buildbot@webrtc.org Roll chromium_revision 533744aa..29ce025c (504014:504034) 2017-09-25 philipel@webrtc.org Reland of Fix the video buffer size should take rtt into consideration (patchset #2 id:160001 of https://codereview.chromium.org/3002033002/ ) 2017-09-25 nisse@webrtc.org Reorganize config of RTP header extensions for video receive streams. 2017-09-25 kthelgason@webrtc.org Remove internal methods from global namespace. 2017-09-25 henrik.lundin@webrtc.org NetEq/Stats: Don't let concealed_samples decrease 2017-09-25 buildbot@webrtc.org Roll chromium_revision 300d540f..533744aa (503992:504014) 2017-09-25 oprypin@webrtc.org Revert "Remove remaining mentions of gflags" 2017-09-25 oprypin@webrtc.org Remove remaining mentions of gflags 2017-09-24 buildbot@webrtc.org Roll chromium_revision 7877db28..300d540f (503976:503992) 2017-09-24 buildbot@webrtc.org Roll chromium_revision c91bb424..7877db28 (503967:503976) 2017-09-24 buildbot@webrtc.org Roll chromium_revision 569732c0..c91bb424 (503964:503967) 2017-09-24 buildbot@webrtc.org Roll chromium_revision fe71bbc1..569732c0 (503807:503964) 2017-09-24 oprypin@webrtc.org Roll chromium_revision 008fb813..fe71bbc1 (503673:503807) + Android fix 2017-09-22 peah@webrtc.org Revert "Added logging inside AEC3 for render API buffer under/overruns" 2017-09-23 magjed@webrtc.org Remove unnecessary audio references in PeerConnectionFactory 2017-09-22 ehmaldonado@webrtc.org Fix autoroller script. 2017-09-22 solenberg@webrtc.org Remove voe::OutputMixer and AudioConferenceMixer. 2017-09-22 solenberg@webrtc.org Disable flaky AudioStats.NoLoss test. 2017-09-22 henrika@webrtc.org Avoids crash in AudioTrack when audio starts in background mode 2017-09-22 brandtr@webrtc.org Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ ) 2017-09-22 asapersson@webrtc.org VideoProcessorIntegrationTest: Group member variables into two structs containing target/actual rates. 2017-09-22 nisse@webrtc.org Delete unused Atomic32 overloads of binary +/- operators. 2017-09-22 brandtr@webrtc.org Add full stack tests for MediaCodec encoder. TBR=grunell@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: Ic58c012d1fb17bc7e2f941fbabc21861c06d0026 Reviewed-on: https://chromium-review.googlesource.com/689375Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#505012}
-
Anton Urusov authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If6e6df5bc0bc5c086ed2d41ec2ff31bd88cf82ac Reviewed-on: https://chromium-review.googlesource.com/672724 Commit-Queue: Anton Urusov <urusant@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505011}
-
Stephen Chenney authored
The list-based hit test result uses NodeForHitTest, but the node used for the point-based report in LayoutObject does not define this method, and uses custom logic for walking up from generated content to the parent before or after psuedo element. This patch moves NodeForHitTest from LayoutBox to LayoutObject and removes unnecessary overrides. LayoutObject::UpdateHitTestResult now uses NodeForHitTest and that includes the before/after content handling. R=pdr@chromium.org BUG=751405 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id64ae264fde3cb3525628d2dae4e4a1d1481c649 Reviewed-on: https://chromium-review.googlesource.com/668697Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#505010}
-
Nicolas Dossou-gbete authored
Bug: 664578 Change-Id: I29c93baa6177058f940d5a0032fef74faa4de598 Reviewed-on: https://chromium-review.googlesource.com/687894 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#505009}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=grunell@chromium.org Bug: 666525 Change-Id: Ie88bf81e57607e8cf85a9dd1ff4e2d48998d01a2 Reviewed-on: https://chromium-review.googlesource.com/689094Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505008}
-
Philip Jägenstedt authored
Follows https://github.com/whatwg/fullscreen/pull/104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
-
Olivier Robin authored
Test is consistently failing. TBR=edchin,kkhorimoto Bug: Change-Id: I402e9ae9bff5388441eb7a1a53e730f13ee5e106 Reviewed-on: https://chromium-review.googlesource.com/690078Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505006}
-
Darren Shen authored
This is a squashed commit of the following five CLs: https://chromium-review.googlesource.com/c/656637/ https://chromium-review.googlesource.com/c/642666/ https://chromium-review.googlesource.com/c/656657/ https://chromium-review.googlesource.com/c/663102/ https://chromium-review.googlesource.com/c/665778/ We did this to make it easier to revert if anything goes wrong. All five CLs have been LGTM'd. No significant performance regression is expected from the patch. Bug: 661854 Change-Id: I5f08b4bebcb687488fb43183a490b607512f3910 Reviewed-on: https://chromium-review.googlesource.com/676366 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#505005}
-
Juan Antonio Navarro Pérez authored
This reverts commit e996f894. Reason for revert: Story should be able to run now. Original change's description: > Revert "[tools/perf] Reenable multitab:misc:typical24 smoke test" > > This reverts commit 748a8867. > > Reason for revert: made telemetry_perf_unittests tip over some time limit > > Original change's description: > > [tools/perf] Reenable multitab:misc:typical24 smoke test > > > > The story may no longer be failing. > > > > TBR=nednguyen@google.com > > > > Bug: 698499 > > Change-Id: I9383bfee2e5882d75459e63a882b4e8fc10b2d3e > > Reviewed-on: https://chromium-review.googlesource.com/654868 > > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500567} > > TBR=perezju@chromium.org > > Change-Id: I7105c8fb94af1be724b1a13b82c7da81f9c9aecf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 698499,763379 > Reviewed-on: https://chromium-review.googlesource.com/657658 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500581} TBR=perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 698499, 763379 Change-Id: I201f175ac822d6b51ad881a8e220b6e4f30e0397 Reviewed-on: https://chromium-review.googlesource.com/690194Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#505004}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: I97cc90888f35ef0fcacc7e1a83deaa3439904337 Reviewed-on: https://chromium-review.googlesource.com/689018Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505003}
-
Han Leon authored
This CL introduces ServiceWorkerRegistrationObjectHost interface and eliminates 2 legacy IPCs: ServiceWorkerHostMsg_IncrementRegistrationRefCount ServiceWorkerHostMsg_DecrementRegistrationRefCount BUG=758151 Change-Id: Ia401b2fd77251686aefdcdd8fca6f69bb6ac2084 Reviewed-on: https://chromium-review.googlesource.com/665097 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505002}
-
Hiroki Nakagawa authored
This CL merges InProcessWorkerMessagingProxy into DedicatedWorkerMessagingProxy because DedicatedWorkerMessagingProxy is the only subclass of the InProcessWorkerMessagingProxy after CompositorWorkerMessagingProxy was removed[1]. Before this CL: - ThreadedMessagingProxyBase - InProcessWorkerMessagingProxy - DedicatedWorkerMessagingProxy - (CompositorWorkerMessagingProxy) <= Removed by the previous CL - ThreadedWorkletMessagingProxy - AnimationWorkletMessagingProxy - AudioWorkletMessagingProxy After this CL: - ThreadedMessagingProxyBase - DedicatedWorkerMessagingProxy - ThreadedWorkletMessagingProxy - AnimationWorkletMessagingProxy - AudioWorkletMessagingProxy [1] https://chromium-review.googlesource.com/c/chromium/src/+/673484 Bug: 769577 Change-Id: I011136db5f7951fe12cfb6f6d0c411b1027fb274 Reviewed-on: https://chromium-review.googlesource.com/688116 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505001}
-
Alex Clarke authored
This will let the devtools debugger pause virtual time. Bug: Change-Id: Ia1343c872122eeeae921077ece1d0e9f8751f0d1 Reviewed-on: https://chromium-review.googlesource.com/687135 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#505000}
-
Ramin Halavati authored
base::RemoveChars function is used instead of the locally implemented one, as the newly implemented base function does not have the previous performace issue on Windows. Bug: Change-Id: I36b44db2ddbf478f5982aeada509624cde169468 Reviewed-on: https://chromium-review.googlesource.com/690343Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#504999}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b90a4b6a. With Chromium commits locally applied on WPT: e1eb32d1 "Fix template content check in host-including inclusive ancestor algorithm" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2514 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I77db9d79636b05e8e8459d50915a741e5db1ea7b Reviewed-on: https://chromium-review.googlesource.com/690214 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504998}
-
Fan Yang authored
There are no flags to be updated. Store QUIC read/write QUIC version labels in network byte order. Protected by FLAGS_quic_reloadable_flag_quic_use_net_byte_order_version_label. Merge internal change: 169751038 https://chromium-review.googlesource.com/c/chromium/src/+/682143 Make toy client reads limited times in one epoll loop. Set the number of reads for quic to backend client to be 30 to avoid long epoll loop. Merge internal change: 169730319 https://chromium-review.googlesource.com/c/chromium/src/+/682142 In QuicDataReader::ReadBytesToUInt64, always initialize *result to zero before writing to its least significant bytes. Also remove explicit initializations from all call sites. Merge internal change: 169722194 https://chromium-review.googlesource.com/c/chromium/src/+/681846 Use provided arena for QuartcFactory-created alarms. Merge internal change: 169663097 https://chromium-review.googlesource.com/c/chromium/src/+/682178 Report TLS 1.3 ciphers in QUIC rather than TLS 1.2 ones. Protected by quic_reloadable_flag_quic_use_tls13_cipher_suites. Merge internal change: 169611358 https://chromium-review.googlesource.com/c/chromium/src/+/681845 Use a new type QuicVersionLabel to store the in-memory representation of a QUIC version instead of a QuicTag. Merge internal change: 169341841 https://chromium-review.googlesource.com/c/chromium/src/+/682138 Minor cleanups of QuicCryptoClientConfigTest. Merge internal change: 169317616 https://chromium-review.googlesource.com/c/chromium/src/+/682137 Relax criteria for accepting initial packet numbers, protected by FLAGS_quic_restart_flag_quic_enable_accept_random_ipn. Merge internal change: 169296520 https://chromium-review.googlesource.com/c/chromium/src/+/682175 Use kConnectionLevelId instead of magic number 0 when creating the connection level flow controller. No behavior change since kConnectionLevelId is 0. Merge internal change: 169286115 https://chromium-review.googlesource.com/c/chromium/src/+/682174 Deprecate FLAGS_quic_reloadable_flag_quic_handle_acks. Merge internal change: 169127336 https://chromium-review.googlesource.com/c/chromium/src/+/682136 Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes4. Merge internal change: 169102115 https://chromium-review.googlesource.com/c/chromium/src/+/681841 Bug: Change-Id: Ic0d55656d1af566d7d0e856c581a10efcdf02022 Reviewed-on: https://chromium-review.googlesource.com/686777Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#504997}
-
Xida Chen authored
TBR=melandory@chromium.org NOTRY=true Bug: 769323 Change-Id: I7c35b4d4a172fb8ea3e3c978442811c29c4d620b Reviewed-on: https://chromium-review.googlesource.com/690315Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504996}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 666525 Change-Id: I5486880df5bf031d373c731213df577e918fe3b7 Reviewed-on: https://chromium-review.googlesource.com/689121Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504995}
-
Fabio Tirelo authored
The race condition happens in the very rare case when the cleaner process successfully removes UwS from the system before we haven't started rendering the Settings page after the user accepted the prompt (we expect a cleanup to take a few minutes, specially because an elevation is required). Bug: 768816 Change-Id: Ib3a7a866e38a870d6d83d99b7d8e054ccb3b7d65 Reviewed-on: https://chromium-review.googlesource.com/688476Reviewed-by:
Ali Tofigh <alito@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#504994}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=aelias@chromium.org Bug: 666525 Change-Id: I0e469931918a07647477d581c317cc78f0c067f3 Reviewed-on: https://chromium-review.googlesource.com/688230Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504993}
-
tzik authored
RefPtr<>::Get() is being renamed to get() for a preparation of the unification of RefPtr and scoped_refptr. This CL updates calles of Get() in platform/graphics/ to use get(). Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib807e04102fd90fa45065872d2e7d1db6580d990 Reviewed-on: https://chromium-review.googlesource.com/688264Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#504992}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: Ifc24a9925347dcce1a023adaa5cf2a5abf455535 Reviewed-on: https://chromium-review.googlesource.com/689123Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504991}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 666525 Change-Id: I383bce4b63a6a18ade43315c541a13d748299875 Reviewed-on: https://chromium-review.googlesource.com/689103Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504990}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 666525 Change-Id: I0df13be0c92b4e478604274d97386ec57960c332 Reviewed-on: https://chromium-review.googlesource.com/689111Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504989}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 666525 Change-Id: I012b61ef5f6b76295e4d01067369d1029a57d473 Reviewed-on: https://chromium-review.googlesource.com/689142Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504988}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=shimazu@chromium.org Bug: 666525 Change-Id: Ic084545de7fb2f741b5f53cb385dc88aca9a3086 Reviewed-on: https://chromium-review.googlesource.com/688172Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504987}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=phajdan.jr@chromium.org Bug: 666525 Change-Id: I9bc7a358b61bf9aceb4b074475b96bae34855b65 Reviewed-on: https://chromium-review.googlesource.com/689096Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504986}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=altimin@chromium.org Bug: 666525 Change-Id: I7d77d006c93c5c3867f686d018d2b624fbbb0f66 Reviewed-on: https://chromium-review.googlesource.com/689095Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504985}
-