- 15 Dec, 2020 40 commits
-
-
rajendrant authored
This CL adds OriginRobotsRulesCache that maintains robots rules for multiple origins in browser process. This is an MRU cache of a fixed size. This CL also changes usage of SchemeHostPort in robots rules processing to url::Origin. This CL also changes updaterobotsrules API in renderer to take an optional robots rules. Change-Id: Ib71dbeb9a3101b9c1ceb19752a55aeb2f1b0ae84 TBR: robertogden@chromium.org tbansal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592335 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#836989}
-
Luciano Pacheco authored
Follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/2589234 Bug: 1133186 Change-Id: I7f8af20af3cfb03e792850e9fbc8cdda5dda84c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592291 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836988}
-
Hiroki Sato authored
There are some cases that one task exposes multiple accessibility windows in Android. After this change, non-root windows have a generic container role instead of an application role so that while moving focus between windows, ChromeVox won't announce entering or exiting the application. Also, we won't dispatch focus for non-focused windows. Each window has a focused node, but previously all focus events are handled equally. With this change, only the focused window is considered in the focus handling logic. AX-Relnotes: n/a. Bug: b:150827488 Test: current unit tests pass. Change-Id: Icd900ef1dcf84926240c6b55f000ba75a05e1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576227 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836987}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f124108e2325..f01e6c826731 2020-12-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 282fb4092b6c to cb8903b14336 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ib924f451fa87de3ed25b93aa3784a2efd79f0d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836986}
-
Trent Apted authored
Currently Piex wasm loads into a global window.Module object as a side- effect of importing the wasm JS glue. This approach may inhibit other wasm modules loading into the same JS context. To fix, configure emscripten to wrap the Piex module in a loader function that returns a promise, and capture it into a unique identifier on initialization. This approach lends itself to on-demand loading of the wasm, so now the wasm subsystem is only initialized when required, rather than whenever the image loader extension starts up. That is, on the first request to refresh the thumbnail for a RAW image, which should occur rarely. Re-ran the Makefile at emscripten 1.38.33 (same as r815044), and ensured that my local sdk created identical files before adding MODULARIZE flags. Ran the separate test.sh. Test coverage also provided in browser_tests. Bug: b/175505626 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I533a8d8028f6913efe0739c5e5cf80864addbe0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584634Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#836985}
-
Erik Chen authored
This CL adds plumbing for the TestController crosapi. This is only available on Linux (non-device). It's used to provide a synchronization primitive between crosapi and Wayland, and basic automation capabilities. This is to support more full-fledged crosapi tests. This CL moves the previous implementation of WaitForLacrosToBeAvailableInAsh back into screen_manager_lacros_browsertest.cc. This CL adds the new methods WaitForWindowToBeAvailableInAsh and SendAndWaitForMouseClick. Change-Id: Ia497c13f2b38af62eba3618cdca526b0206b32ec Bug: 1157946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587707 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#836984}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b2a57822dbb4..6b173323cd23 2020-12-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idc5b1c425f45b2176f468ab14c41d70306a0d310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592648Reviewed-by:
-
Luciano Pacheco authored
Tbr: oshima Bug: 1157649 Change-Id: Iefb37aeeafc9cd6a2cd06c69b751915e995893e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592532Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836982}
-
Hiroki Nakagawa authored
PrerenderBrowserTest::request_count_by_path_ is accessed from MonitorResourceRequest() and GetRequestCount(). These functions are called from different threads: the UI thread and EmbeddedTestServer::io_thread_. Therefore, the field should have been protected by a lock. Bug: 1158659 Change-Id: I491f7a60b24c4652c4278f46129976eccb81fecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592289Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#836981}
-
Stephan Hartmann authored
Operator << of std::stringstream returns a reference to std::ostream which has no member function str(). Missed while fixing https://chromium-review.googlesource.com/c/chromium/src/+/2576877 Bug: 819294 Change-Id: Iba035535eaba9bc01c36a74592b6d94956c45498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584774 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836980}
-
Hiroki Sato authored
This is a preparation of auto complete handling. This change adds a new interface AXTreeSourceArc::Hook, which hooks serialization process of AXTreeSourceArc and can modify the default output of the serialization for special Android widgets. See go/arc-autocomplete-a11y for details. AX-Relnotes: n/a. Bug: b:150827488 Test: unit tests Change-Id: Ifa9a6cf4801e97ebca58ebe9636be66910c3b3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569199 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I511209f98d503dc06b4e90c1237aa8029ca76f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592057Reviewed-by:
-
Yulun Wu authored
Bug: 1145383 Change-Id: Ia1daa2762e5a0da81ef7dee1a47ead199352fa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582833Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836977}
-
Clark DuVall authored
The 99th percentile of this histogram was topping out at the 10sec allowed by recordTimesHistogram(), so switch these to using recordMediumTimesHistogram(). Bug: 1150600 Change-Id: I1839f664f137c0347fdcd06875b4ab1eb843016e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588867Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836976}
-
Seokho Song authored
According to the issue, background-clip was not applied to pseudo-styles. Therefore, kBackgroundClip appended to target styles. Bug: 1076508 Change-Id: I93595a14e3c4429faa56b7d060e3b8b9242b0518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586293Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#836975}
-
Giovanni Ortuño Urquidi authored
Currently WebUI properties, e.g. CSPs, requesting schemes, host, mojo, etc. are stored in WebUIControllers themselves. The lifetime of a WebUIController is bound to the frame, which makes it hard to use for some use cases. A non-dynamically allocated class where clients could query a WebUIs properties would be easier to use and audit. Introduces a new WebUIConfig class that stores properties of WebUIs. For now the two properties are 1. the WebUI's host and 2. if the WebUI is enabled. In the future this class could include information like CSPs, if we should enable Mojo, if we should enable chrome.send(), if we should allow network requests, URLDataSource, etc. For now all WebUIConfigs are owned by ChromeUntrustedWebUIControllerFactory but that could be moved somewhere else so that anyone could retrieve a WebUIConfig and check its properties. ChromeUntrustedWebUIControllerFactory holds a map of hosts to WebUIConfigs and implements WebUIControllerFactory methods by querying the appropriate config for its properties. Bug: 1080384 Change-Id: Ieebb0ded877f57d00d6f47aa5b9304cd250b1bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315572 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#836974}
-
Findit authored
This reverts commit d49dcd89. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 836899 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDQ5ZGNkODk1ZGNkMjgwZjBlYWZlNTRkZTdiNWJkZGJkY2ZiZDFhNQw Sample Failed Build: https://ci.chromium.org/b/8860879057915778784 Sample Failed Step: content_browsertests Sample Flaky Test: All/DumpAccessibilityTreeTest.AccessibilityIframeAriaHidden/linux Original change's description: > Add tests to exercise hypertext on hidden iframes > > TBR=kbabbitt@microsoft.com > > Bug: None > Change-Id: I14d580e7e20409fdf2ecc4d8a9294076f11ec07d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584562 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836899} Change-Id: I79641c036c742b0d893e91dc2fb5f69d4e0278cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592395 Cr-Commit-Position: refs/heads/master@{#836973}
-
Christopher Lam authored
This CL adds protobuf generation for semantic colors for Longform for use in Google3. Generated values are provided in proto json format. Bug: 1018654 Change-Id: I4f6648e41ab7fb1b205101bdb31362fd99ffb557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558100 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
CL:2559262 changed GetAvailableTransports() to unconditionally include FidoTransportProtocol::kInternal in its result, which causes a platform authenticator discovery to be instantiated. Prior to that CL no discovery would be instantiated if IsUVPAA() returned false. This causes a platform authenticator to be instantiated mistakenly when the system/u2fd IsUVPAA() call is true, but Chrome's IsUVPAA() is false due to being in an Off-The-Record context. To work around this, explicitly check for OTR in GetAvailableTransports(). This is temporary, until the CrOS platform authenticator is enabled in Incognito (crbug.com/1157651). Bug: 1157967 Change-Id: I94113ed7e05948d8bd0c207ec5063b676bdebb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587572Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#836971}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a5f4f619054..b2a57822dbb4 2020-12-15 jec@google.com [Application] Add learn more link in Cache Storage pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157792 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3b27766d328cc49fc51cc3c60271642f7463be0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591754Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fd7733e97423..cb8903b14336 2020-12-15 lehoangq@gmail.com Metal: Ignore OS's internal shader cache when testing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I21b81c00947e5964d12841f6334bc1e5cf3f6bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592058Reviewed-by:
-
Ryo Hashimoto authored
In case of a chrome crash, there can be an old VM still running. BUG=b:142281129 TEST=Open chrome://inducebrowsercrashforrealz to cause a browser crash and launch Play Store. Change-Id: Ib011bf37694c0ae5e6641e2f43d827e215e70855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589493 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#836968}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a1714d05..8a79762d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab68f9f16c9b44a28cf5581e0c36b7c4d3e4a1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591813Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836967}
-
Thomas Guilbert authored
This CL converts FolderCreator::FileIDCallback to OnceCallback. Bug: 1152272 Change-Id: I03fd7a647e2b91e967a23f15b3fa4b4444c8c74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586671 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836966}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4a2a59a1. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iee82981aeb9449e2a39a502be8bf9d594a2ca298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592129Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836965}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607968714-699bf16f3c6ce2b1b6a355f7ee1c8b08436d6eb2.profdata to chrome-win64-master-1607979561-3262ee4f1e44fdb99e07e0075a7cfc8e82b97c75.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I630706fa44ae8ae2f6be0a44f4f6fdd4fd9f8d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591748Reviewed-by:
-
Hiroki Sato authored
AX-Relnotes: None Bug: None Test: unit_tests pass Change-Id: I363b7c291f171bca64c6a22e442ee4222a72e3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586500 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
-
Kent Tamura authored
Since r835809, list-items respect to counter-* properties, but we didn't invalidate list-items on updating the properties. LayoutCounter::LayoutObjectStyleChanged(), which is called whenever counter-* properties are changed, invalidates ListItemOrdinal too. * LayoutCounter::LayoutObjectStyleChanged() calls new function ListItemOrdinal::ItemCounterStyleUpdated() * ListItemOrdinal::ItemInsertedOrRemoved() is renamed to ItemUpdated(), and it adds support of inclusive invalidation. * ListItemOrdinal::ItemInsertedOrRemoved() and ItemCounterStyleUpdated() call ItemUpdated(). * counter-set-002.html - Fix the flakiness - Add list-items before/after the updated node Bug: 1157854 Change-Id: I669c2c70f87473d5d863f5f02208eb7fe1a41a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586455Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#836962}
-
Min Qin authored
BUG=1155641 Change-Id: Id480d3e10659afa4fd52e89f5ffb9557e4820dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575327Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836961}
-
Darwin Huang authored
Add early returns when returning to the main thread, to ensure the ExecutionContext or LocalFrame is always valid before use. Also, add some comments for consistency between subclasses. Change-Id: I6abe00c90405c44214a45c8b5d02e070db767956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551304 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836960}
-
Chih-Yang Hsia authored
Expose NumberOfInputStreamsWithPermission related APIs up to CrasAudioHandler. - Add CrasAudioHandler::ClientType enum class. - Add OnNumberOfInputStreamsWithPermissionChanged to CrasAudioHandler::Observer. - Add GetNumberOfInputStreamsWithPermission to CrasAudioHandler. BUG=b:174336267 TEST=chromeos_unittests TEST=Build and use input streams to trigger dbus from CRAS Change-Id: Ia040a310e8e4604076ecc89018700d1d210f29d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579931Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org> Cr-Commit-Position: refs/heads/master@{#836959}
-
David Staessens authored
This reverts commit 72c52cf1. Reason for revert: Reason for revert: This breaks lower resolution test cases in ARC++/ARCVM: b/175515392 Original change's description: > media/gpu/vaapiWrapper: Enforce supported resolutions in CreateContext() > > VaapiWrapper reports the supported min and max resolutions by > VaapiWrapper::GetSupportedDec/EncodeProfiles(). They might be > different from the min and max resolutions supported by a > hardware and driver for some reason. For instance, we set > the minimum encoder resolution to 321x241 and the webrtc encoder > enforces the resolution per kWebRtcUseMinMaxVEADimensions > (e.g. crbug.com/1008491). > Clients of VaapiWrapper were expected to respect the supported > resolutions, but could still request values outside of that > range, thus using hardware codecs unintentionally. This CL > enforces the supported range in VaapiWrapper::CreateContext(). > This also introduces a feature, > VaapiEnforceVideoMinMaxResolution, to disable this check for > testing. > > Bug: b:171041334 > Test: video.Play.vp9_hw on atlas and cyan > Test: video_decode_accelerator_tests on atlas and cyan > Test: video_encode_accelerator_tests on atlas and cyan > Test: appr.tc/?vsc=h264&vrc=h264&debug=loopback on atlas and cyan > Change-Id: Ide589ee4d1456553e400a271cb8b3383b472b4d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549161 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Auto-Submit: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832609} TBR=dalecurtis@chromium.org,mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:171041334,b:175509204,b:175515392 Change-Id: I18e172dac47aae5949329b183373b59ee862c1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589257Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#836958}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I446953da1ef2b10232c43585c64977e6ca47825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592193Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836957}
-
Min Qin authored
Currently if there are multiple QT flags set through chrome://flags, only one of them will work This CL fixes the issue BUG=1158567 Change-Id: If21f90bf51c6a471534a517cd372f2bea7629e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590590Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836956}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d2b075ce060..f124108e2325 2020-12-15 mtklein@google.com how to use SkArenaAlloc with no friends 2020-12-15 csmartdalton@google.com Get CanvasKit viewer compiling again 2020-12-15 jmbetancourt@google.com implement SkAudioPLayer for Android 2020-12-14 johnstiles@google.com Optimize Gaussian convolution fragment processor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ief714543132e1f33bd4f6aa18a45c7481c1b0846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592056Reviewed-by:
-
jchen10 authored
This is the initial implementation of WebGL_webcodecs_video_frame: https://www.khronos.org/registry/webgl/extensions/proposals/WEBGL_webcodecs_video_frame/ It's basically functional on Win, ChromeOS, Android and MacOS. Test: https://www.khronos.org/registry/webgl/sdk/tests/performance/webgl_webcodecs_video_frame/ Bug: 1142754 Change-Id: I41a860e7d1388824ab00863d5fa6d8972822145b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525285Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#836954}
-
Michael Hansen authored
Moves the logic for determining the ShareType into the *Attachment classes. This cleans up some static casts and also allows this logic to be reused when generating the preview for the receive dialog page, coming in a subsequent CL. To avoid a dependency cycle I've moved the ShareType mojo struct definition into its own build target, which required importing new mojo gen files in a number of places. Fixed: 1144942 Change-Id: I7fe151470c9067a918363152d2e0520a08dc0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582523 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836953}
-
Victor Costan authored
This CL updates IndexedDBBackingStore and its inner classes. * Each class is documented as not thread-safe. The obsolete thread safety comment on IndexedDBBackingstore is removed. * Each class' data members are either marked const or GUARDED_BY_CONTEXT with a SequenceChecker. * DISALLOW_COPY_AND_ASSIGN is replaced with deleted copy constructor and assignment. * An unused data member was removed. * Data members initialized with constants in constructors are instead initialized when declared. * Invariant-enforcing DCHECKs are consistently placed at the beginning of methods. This CL introduces no functional changes. Change-Id: I8a38d0f2225ff4b5334fd37891a8216b8bb72930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588292Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836952}
-
Alan Cutter authored
This CL enables the migration from default Chrome apps over to web apps on Chrome OS only. This migration is targeting M89 and will use Finch to control the rollout in stable, all other channels will start migrating immediately. Bug: 1058265 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I5aabdc0efa2057ee77480d2c78ec16df93878ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586167Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836951}
-
Jiewei Qian authored
Cleans up left over code in https://crrev.com/c/2265693. Also adds a test to verify full url is used when launching a web app from intent. Fixed: 1157281 Change-Id: I47597bc93903ab9b8aa80bf3ddfa484676640e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589258 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836950}
-
