GitLab

The IDL for proposed API has been reviewed: https://codereview.chromium.org/2174423002/

This is the actual implementation of the API. The dialog to request PIN is defined in request_pin_view.h

The CertificateProviderApi is receiving the requests from extensions and uses the service object to manage the view. CertificateProviderService object keeps the state of the view and forwards updates to it. And the RequestPinView is notifying the CertificateProviderApi about the user input through callback.

BUG=612886

Review-Url: https://codereview.chromium.org/2094333002
Cr-Commit-Position: refs/heads/master@{#435620}

BUG=542537
TBR=meade@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2541223003
Cr-Commit-Position: refs/heads/master@{#435619}

SchemeRegistry.cpp has bunch of distinct static URLSchemesSet's and they
are getting a bit out of control. This patch:

* Introduces URLSchemesRegisry that bundles all the URLSchemesSet's so
  that they can be initialized at once
* Provides mutable and non-mutable version of getters for the
  URLSchemesRegistry instance so that one can safely call non-mutable
  getters without worrying about thread-safety, while we have  the
  thread assertion in the mutable version of getter.

BUG=n/a

Review-Url: https://codereview.chromium.org/2545443002
Cr-Commit-Position: refs/heads/master@{#435618}

It crashes due to a WeakPtr SequenceChecker failure.

BUG=670307
TBR=ikilpatrick@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549533002
Cr-Commit-Position: refs/heads/master@{#435617}

This patch implements detection for the loading RAIL mode. This mode
starts when the top-level frame navigates and lasts until we see the
first meaningful paint for the top-level frame (which is currently not
guaranteed to happen on all pages).

We don't currently use this state for scheduling but only pass the
information to v8 which can use it to adjust garbage collection
policies.

As a safeguard against cases where FMP is not detected, we terminate the
load stage if we see user input. The assumption is that if the user is interacting
with the page, there is likely meaningful content on the screen at that point.

BUG=613520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2397753006
Cr-Commit-Position: refs/heads/master@{#435616}

This CL writes field trial parameters into its allocated spot in shared memory. The format of the pickle should now look like:

TrialName
GroupName
ParamKey1
ParamValue1
ParamKey2
ParamValue2
...

BUG=660041

Review-Url: https://codereview.chromium.org/2463223002
Cr-Commit-Position: refs/heads/master@{#435615}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/252d869b..403eccb0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2543453004
Cr-Commit-Position: refs/heads/master@{#435614}

The actual icon is taken from LOCATION_BAR_HTTP.

BUG=666340

Review-Url: https://codereview.chromium.org/2532313003
Cr-Commit-Position: refs/heads/master@{#435613}

Net.Socket.IdleSocketTimeSaving histogram isn't measuring what it is supposed
to measure, see https://codereview.chromium.org/2533063002 for more info.

This CL removes this histogram.

R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2537923002
Cr-Commit-Position: refs/heads/master@{#435612}

BUG=670295
TBR=yhirano@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549513002
Cr-Commit-Position: refs/heads/master@{#435611}

As confirmed with the UMA team, the field trial allows only 60-70% coverage of
users for one day (particularly, on Windows).

To address this shortcoming, this change hardcodes the explicit date of the
experiment (for December 14th as seen in PST, to be synchronized with field
trial server-seeding better). To be effective this must be cherry-picked to M55.

The experiment still has the ability to serve as a "kill switch" by setting the
group "ExperimentYes_expires_2016-12-14T07:00:00Z" (or any earlier date in the
string). As discussed above, this has limited effect in the day range.

Also this changes AGSA to opt out of the experiment. Currently AGSA only uses
ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR. The experiment will not take effect
on these origins. Other 1st party apps are not using this prerender::Origin, as
far as we know, and the use of it is restricted to 1st party, hence this change
should not affect the experiment for other Android apps.

BUG=640592

Review-Url: https://codereview.chromium.org/2538723003
Cr-Commit-Position: refs/heads/master@{#435610}

BUG=chromium:668907

Review-Url: https://codereview.chromium.org/2538943002
Cr-Commit-Position: refs/heads/master@{#435609}

BUG=609747

Review-Url: https://codereview.chromium.org/2539183004
Cr-Commit-Position: refs/heads/master@{#435608}

BUG=None

Review-Url: https://codereview.chromium.org/2548493002
Cr-Commit-Position: refs/heads/master@{#435607}

Revert of (Reland) Insert logcat as part of test result for android instrumentation tests. (patchset #3 id:40001 of https://codereview.chromium.org/2545653002/ )

Reason for revert:
Failing on large suites: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/5996/steps/chrome_public_test_apk/logs/stdio

Original issue's description:
> (Reland) Insert logcat as part of test result for android instrumentation tests.
>
> In this cl, we are trying to add the logcat of each instrumentation
> test into the corresponding test result object, so that when we are
> checking the result of each test case, we would be able to see the
> corresponding logcat for that test case at the same time.
>
> The reason of reland is to fix the issue where environmental variables are not set.
>
> BUG=631213
>
> Committed: https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9
> Cr-Commit-Position: refs/heads/master@{#435550}

TBR=hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631213

Review-Url: https://codereview.chromium.org/2548503002
Cr-Commit-Position: refs/heads/master@{#435606}

BUG=664868

Review-Url: https://codereview.chromium.org/2547473002
Cr-Commit-Position: refs/heads/master@{#435605}

For calls to url::ResolveRelative, if the input is not in fact relative,
we call RemoveURLWhitespace twice on the same buffer. This is not necessary.

On a test of loading 100 identical ~1mb data URL images, this patch speeds
up the renderer by ~8% on Linux.

BUG=657978

Review-Url: https://codereview.chromium.org/2540893004
Cr-Commit-Position: refs/heads/master@{#435604}

Start in two places:
-On press custom shortcut (Ctrl-Alt-Shift-A) for the enrollment
-On reading install attributes in case it's Active Directory managed
device.

BUG=638663
TEST=manual

Review-Url: https://codereview.chromium.org/2530833002
Cr-Commit-Position: refs/heads/master@{#435603}

This is a partial revert of https://codereview.chromium.org/2504963004
which broke Cronet data reduction proxy builder. The original CL
passed the CQ because the Cronet builder has been down for 4-5 days.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=669037
TBR=sclittle@chromium.org

Review-Url: https://codereview.chromium.org/2547513002
Cr-Commit-Position: refs/heads/master@{#435602}

It'll be useful to compare timings and byte sizes for the
different image types (content image, icon, badge, action icon).

BUG=669621,614456

Review-Url: https://codereview.chromium.org/2540763002
Cr-Commit-Position: refs/heads/master@{#435601}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb1b609e..252d869b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2541153003
Cr-Commit-Position: refs/heads/master@{#435600}

This removes the PaintLayer-factor and DSF from the "screen scale factor",
leaving only the transform to the <svg> root and the "content transform" (used
by <pattern>, <mask> and <clipPath>.)

BUG=664961

Review-Url: https://codereview.chromium.org/2492013004
Cr-Commit-Position: refs/heads/master@{#435599}

BUG=661279

Review-Url: https://codereview.chromium.org/2538543002
Cr-Commit-Position: refs/heads/master@{#435598}

This patch is a part of 'AudioContext.getOutputTimestamp' method implementation [1] and it continues the changes introduced at [2].

The AudioRendererSink::RenderCallback::Render method has same semantics as AudioSourceCallback::OnMoreData.
That caused other changes in the following interfaces:
- AudioSyncReader::UpdatePendingBytes(uint32_t bytes, uint32_t frames_skipped) -> AudioSyncReader::PrepareNextData(base::TimeDelta delay, base::TimeTicks delay_timestamp, uint32_t frames_skipped)
- AudioDeviceThread::Callback::Process(uint32_t pending_data) -> AudioDeviceThread::Callback::Process(int64_t pending_data, base::TimeTicks data_timestamp)
- AudioDeviceThread is receiving a "packet" of two int64_t values

BUG=619533

[1] https://codereview.chromium.org/2060833002/
[2] https://codereview.chromium.org/2101303004/

Initially committed at: https://crrev.com/06d9d80a203b9c329fc6d53fde44bae66645a389
Reverted at: https://crrev.com/2665e952502835c6c37d51153bfa180343635a41
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2517503003
Cr-Commit-Position: refs/heads/master@{#435597}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c43132b7..eb1b609e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2539423002
Cr-Commit-Position: refs/heads/master@{#435596}

BUG=666227

Review-Url: https://codereview.chromium.org/2544603003
Cr-Commit-Position: refs/heads/master@{#435595}

BUG=669055
TEST=manual test as noted in the bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538403003
Cr-Commit-Position: refs/heads/master@{#435594}

Various code was passing pointers to heap-allocated ScopedJavaGlobalRef
objects in order to pass Java objects between threads. Having
heap-allocated smart pointer types is very weird and not a desirable
pattern.

base::Bind handles rvalues correctly (they become owned by the callback)
and so the nicer alternative is to simply pass temporary
ScopedJavaGlobalRef parameters, which will automatically be deleted when
the callback is deleted. The receiving function can take a const
reference to JavaRef as its parameter type, which matches how direct
function calls typically take Java object parameters and makes this look
much more consistent.

ScopedJavaGlobalRef is movable, so using std::mode is also an option,
but all the cases in this CL simply construct temporaries.

BUG=519562

Review-Url: https://codereview.chromium.org/2538463002
Cr-Commit-Position: refs/heads/master@{#435593}

TextControlElement::{start,end}{Word,Sentence}() without VisiblePosition was
 introduced for Speedometor benchmark.(crrev.com/db6862d1)
Since, editing is now pipeline friendly and hoisting have not caused regression,
 we need not have such optimization functions.

This CL clean up code path. I will clean up the functions later.

BUG=639528

Review-Url: https://codereview.chromium.org/2533213003
Cr-Commit-Position: refs/heads/master@{#435592}

These were accidentally dropped during the port to the new harness a
while back.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2547463002
Cr-Commit-Position: refs/heads/master@{#435591}

Remove useless class and struct forward declarations, and add
missing ones in android_webview header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2540163002
Cr-Commit-Position: refs/heads/master@{#435590}

If line contains at least one breakpoint and more then one possible breakpoint location then text editor will show decorations for all breakpoints and possible breakpoint locations.

BUG=chromium:566801
R=lushnikov@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2526013002
Cr-Commit-Position: refs/heads/master@{#435589}

ExecutionContext has its own task suspension through MainThreadTaskRunner.
However, the suspension can be coarser, since it's used only when the page
is suspended. Also, the custom suspension / resumption makes it hard to
use finer grained TaskType.
This CL moves the task suspension from ExecutionContext to WebFrameScheduler.

Review-Url: https://codereview.chromium.org/2527143002
Cr-Commit-Position: refs/heads/master@{#435588}

This changes the name and signature of the
PaymentInstrument.getInstrumentMethodName method to:

    Set<String> getInstrumentMethodNames()

This is to match the "enabledMethods" field in the PaymentAppOption
dictionary in the Payment Apps specification, which is defined to be a
sequence of strings.

See: https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options

I also change the name of PaymentInstrument.getInstrumentDetails to
"invokePayment" in order to convey better that this is where the payment
method specific stuff happens. For a Web Based Payment App, this method
is an appropriate point to launch the payment request event into the
service worker.

BUG=669876

Review-Url: https://codereview.chromium.org/2530793002
Cr-Commit-Position: refs/heads/master@{#435587}

As of LLVM r287681 there are no issues when using integrated as.

BUG=None
TEST=Build Chromium Linux for MIPS with integrated as

Review-Url: https://codereview.chromium.org/2538493003
Cr-Commit-Position: refs/heads/master@{#435586}

BUG=None

Review-Url: https://codereview.chromium.org/2543933002
Cr-Commit-Position: refs/heads/master@{#435585}

Setting the testing build time ensures that the test passes even if the
system clock is incorrect when running the test.

BUG=666821,668539

Review-Url: https://codereview.chromium.org/2546433002
Cr-Commit-Position: refs/heads/master@{#435584}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e08f5483..c43132b7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2546693002
Cr-Commit-Position: refs/heads/master@{#435583}

tools/grit used to add it, but it should move to chrome_grit_defines
instead to avoid a ui dependency there. It's currently breaking WebRTC.

It's currently used by chrome/app/theme/theme_resources.grd.

(ui_resources.grd might need it later, but it doesn't right now).

BUG=657244
TBR=scottmg@chromium.org, sky@chromium.org

Review-Url: https://codereview.chromium.org/2535753007
Cr-Commit-Position: refs/heads/master@{#435582}

This CL has no behavior changes.

NOTRY=true

Review-Url: https://codereview.chromium.org/2546473004
Cr-Commit-Position: refs/heads/master@{#435581}