- 23 Mar, 2020 40 commits
-
-
Garrett Beaty authored
The recipes code has been updated so that we don't attempt to trigger these jobs, so they are no longer necessary. Bug: 819899 Change-Id: Ife039539bffb0c3fadacdb383c1be014f19ad6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115874Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#752644}
-
Caleb Rouleau authored
GitHub mirror is not being used anymore, so better to use the main source for the docs link. Bug: 1059913w Change-Id: Iab2d7e1eb180a6a79e4487e827e6e1f97edb1edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116785 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752643}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib39c23df559079bb38d410f56fb9afdbaf35ea15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752642}
-
Salvador Guerrero authored
This reverts commit 1231840e. Reason for revert: Causing build failures in android-internal-chromium-tot https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot Original change's description: > metrics: Remove CachedMetrics > > Bug: 1048429 > Change-Id: Ib5b5ee1d07492eb30b754320f6527acd5cda60f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079255 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752614} TBR=yfriedman@chromium.org,fgorski@chromium.org,pavely@chromium.org,bttk@chromium.org Change-Id: I3af9a0200e42e332c647ccb3d73f2cd756b0dc04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117153Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#752641}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/0be7fce4c6e4..84639a15fe70 $ git log 0be7fce4c..84639a15f --date=short --no-merges --format='%ad %ae %s' 2020-03-23 bnc Add QuicSpdySession::EnableServerPush(). Re-enable QuicSimpleServerSessionServerPushTests. 2020-03-21 fayang gfe-relnote: In QUIC, add a helper function to get N consecutive retransmission timeout delay. Only affecting client, no functional change expected, not protected. 2020-03-20 bnc gfe-relnote: Add and call Http3DebugVisitor methods. Not protected. 2020-03-20 danzh gfe-relnote: n/a(test only) Nice mock send algorithm to reduce GMOCK WARNING. 2020-03-20 wub Enable //gfe/gfe2/quic:quic_backend_connection_test in gfe_cb_feature_flags. 2020-03-20 wub Internal QUICHE change 2020-03-20 fayang gfe-relnote: In QUIC, send H3 SETTINGs once 1-RTT write key is available (instead of both keys are available). Protected by gfe2_restart_flag_quic_send_settings_on_write_key_available. 2020-03-20 renjietang Simplify QuicUtils::GetMaxStreamCount() because it's never used in gQUIC. 2020-03-19 fayang gfe-relnote: Stop using SetDefaultEncryptionLevel in TLS handshake. Instead, use OnOneRttKeysAvailable. Refactor only, no functional change expected, not protected. 2020-03-19 renjietang Update QuicFramer methods' names to match IETF draft specs. Also removed unused peer methods. 2020-03-19 quiche-dev Change QuartcPeerTest to use a MockSendAlgorithm. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I69d2d1301aeb2dd1c4c34bec5f758aa1a735d2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115781 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#752640}
-
Archana Simha authored
Collects the size of the leaked ExtensionFunctions as well as the name and count of the ExtensionFunction with the most instances at the time of the dump. Change-Id: Ic52f79e2b002be8577f46d7e611c223577eae2c4 Bug: 893656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985816Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#752639}
-
Haiyang Pan authored
Bug: 1054829 Change-Id: I9a9113dff3932e9cc0f54604a9ca207254111d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116835Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#752638}
-
Avi Drissman authored
Each SxS-capable Chrome channel can have a different brand code, so update the Keystone glue to know that. This can be tricky because the old, non-SxS-capable Chromes are still built from this code, so be sure to handle that case. Overview plan at https://docs.google.com/document/d/1MVANxDLPPeN1x-NsfgsLSjbX8twzQi69Wb1iPK-owaU/edit Bug: 1061486 Change-Id: I2cbc2d6ba698b085ee00536a1fbfffa3336ddecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102642 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752637}
-
Yue Zhang authored
http://crrev.com/c/2110684 makes TabSelectionEditor adapt to different layouts of tab switcher. However, for carousel tab switcher we might still want the selection editor to follow a grid style. This CL fixes this issue by adding one extra check. Bug: 1063746 Change-Id: I5c0a2379d985acec8794b9a2a93758bd33e664f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116771Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#752636}
-
Ted Choc authored
BUG=1027549,1062563 Change-Id: I1f950aa62f091776595be7234c7a92ac6b1b2c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116135 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752635}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3e74fb81116b..cd1f1eb24f50 git log 3e74fb81116b..cd1f1eb24f50 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 thestig@chromium.org Fix JPEG2000 decoding when there is no /ColorSpace. 2020-03-23 thestig@chromium.org Use GetDecoderArray() in CPDF_DIB. 2020-03-23 thestig@chromium.org Make CPDF_DIB::ValidateDictParam() more consistent. 2020-03-23 thestig@chromium.org Treat no filters as an empty array in GetDecoderArray(). 2020-03-23 thestig@chromium.org Fix more nits in GetDecoderArray(). 2020-03-23 thestig@chromium.org Add unit tests for GetDecoderArray(). 2020-03-23 tsepez@chromium.org Test extracting values from variables contexts. 2020-03-23 tsepez@chromium.org Cover special |xfa| propname in CFXJSE_Engine::NormalPropertyGetter() 2020-03-23 thestig@chromium.org Move FlateDecode/Encode tests to fpdf_parser_decode_unittest.cpp. 2020-03-23 thestig@chromium.org Fix nits with GetDecoderArray(). Created with: gclient setdep -r src/third_party/pdfium@cd1f1eb24f50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5e48a83c586a63762e7e87b1df9ffe589df893f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7eab0a820f9c..f1df04b094fe git log 7eab0a820f9c..f1df04b094fe --date=short --first-parent --format='%ad %ae %s' 2020-03-23 mbonadei@webrtc.org Fix -Wunreachable-code on Linux. 2020-03-23 sprang@webrtc.org Remove RtpPacketSendInfo.has_rtp_sequence_number Created with: gclient setdep -r src/third_party/webrtc@f1df04b094fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie17989ac9f6dc16d4e7a16eba2a22155b75cd32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752633}
-
Robert Liao authored
PrintableSkColor transforms the test error output from... original Which is: 4293454573 to original Which is: SkColorARGB(0xff, 0xe8, 0xea, 0xed) Because SkColor is type aliased to uint32_t, a simple overload of operator<< will not pick it up, requiring a type container to trigger the overload. BUG= Change-Id: I56217ca8e166441f7fca0a257b7f5591469729d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116894 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752632}
-
Ahmed authored
BUG=1064104 TEST=Manually. Change-Id: Ifbdd85d252a4cf5d13a43d6e3e566be8c0f3fa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116784Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#752631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cde8177699c..82dd375715f3 git log 4cde8177699c..82dd375715f3 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 primiano@google.com Fix Chromium roll Win+Fuchsia 2020-03-23 fmayer@google.com Merge "Ingest location for dex / apk / jar for classes." 2020-03-23 treehugger-gerrit@google.com Merge "subprocess: Fix unused result warning in unit test" 2020-03-23 treehugger-gerrit@google.com Merge "Add /proc/<pid>/smaps parser." 2020-03-23 taylori@google.com Merge "perfetto-ui: Always show CPU slice" 2020-03-23 taylori@google.com Merge "perfetto-ui: Fix record page scrolling" 2020-03-23 lalitm@google.com Merge "perfetto: add script to strip binary in Android tree" 2020-03-22 taylori@google.com Merge "perfetto-ui: Fix file bug link" 2020-03-20 lalitm@google.com tp: allow semi-colon to delimit queries in query files 2020-03-20 skyostil@google.com Merge "TrackEvent: Add more documentation for app instrumentation" 2020-03-19 primiano@google.com Fix Win+Nacl builds 2020-03-19 primiano@google.com Merge "test: fix GetCurExecutableDir() on Mac" 2020-03-18 taylori@google.com Merge "ui: Fix showing details for slices where ts = 0" 2020-03-18 primiano@google.com Merge changes Ibc7838ee,I3deb0245 2020-03-18 rsavitski@google.com Merge "traced_perf: metatrace: encode PID that is being unwound as a "counter"" 2020-03-18 rsavitski@google.com Merge "traced_perf: fix unnecessarily retained heap allocations" Created with: gclient setdep -r src/third_party/perfetto@82dd375715f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:151968761 Tbr: perfetto-bugs@google.com Change-Id: I4771efc6769de4caa1934a45b93f6025eb815bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752630}
-
David Tseng authored
- initial bindings ExpectSpeech, Call added to SpeechMonitor - convert a few tests; see how it goes on bots before converting more Test: browser_tests --gtest_filter=*Spoken*.* Change-Id: I17fa771d7a7f6bc32cd7d7d85bdf40ae77a72f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115877Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#752629}
-
Moe Ahmadi authored
This CL introduces a feature flag (enabled by default) that allows disabling the Doodle notifier spinner in order to study its performance drawback on an official build. This CL may be reverted at a later time once the performance analysis is done. Bug: 1046786 Change-Id: I078f265bc30a32ae5b5bae173955107d42676773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116558Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#752628}
-
Maria Villarreal authored
This follows the guidance given in the comments of the bug to eliminate the use of hardcoded SkColorSet* in ui/. Part 1 cleans colors in combobox, bubble_frame_view, canvas_paint_mac, touch_selection_menu_views, message_view, image_skia_operations, clipboard_win, tween, dialog_example. Bug: 1056950 Change-Id: Iceb8e431b0b6346136eaa6b57537e3f6000c0ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108573 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752627}
-
Tricia Crichton authored
Verify that a colon exists before attempting to substring based on the position of the colon. Bug: chromedriver:3234 Change-Id: Iafb4ed1bf928fcebf28e0a430bc0bc1f7ceb7185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111051Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752626}
-
Jesse Schettler authored
Initial user feedback is still being gathered for ARC printing. Extend the flag's expiry milestone to M84 to allow the feature to be toggled on and off in M83. Bug: b:152244509 Change-Id: I90c36a596220d47adae4e512dde32899f905160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116933Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#752625}
-
Ryan Hansberry authored
NetworkStateHandler has never been meant to honor calls to its RequestUpdateForNetwork() method for Tether networks (as per its documentation) but never explicitly enforced that. A recent CL, crrev.com/c/2078372, exposed this oversight by calling RequestUpdateForNetwork() on a Tether network, causing a crash. This CL corrects that oversight by early-returning within RequestUpdateForNetwork() if a Tether network is provided. Bug: 1061780 Change-Id: Iea2ab7d73c4417408ccb1b5e7622dd87a7dcd71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111352 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752624}
-
Wei-Yin Chen (陳威尹) authored
Make sure all TabToGTSAnimation annotations in StartSurfaceLayoutTest are correct. Bug: 964406 Change-Id: I437040b668b1e9a397c90863d9142dadc2c0eabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114209Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752623}
-
garzonou authored
Change-Id: I4cb1539a93be286bdaaef436d94da036d5aa86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011629 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752622}
-
Jared Saul authored
Also cleans up the fieldtrial_testing_config entry for the SyncButterWallet launch now that it's enabled ToT (and 100% launched). Per request, not going to clean up the code usage of the flag quite yet because Butter for Mobile may be coming in the near future. Bug: 983940 Change-Id: Icfb628cb509c77960d7686c3ad8c5a6161ca7547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092064 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#752621}
-
Lan Wei authored
To simplify the use of the scroll function, we can use the smoothScroll function in gesture-util.js instead of chrome.gpuBenchmarking.smoothScrollBy in all the layout tests. Bug: 1047176 Change-Id: I6764bd72e42d54a2623b453a808061f96d045687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115798Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#752620}
-
Salvador Guerrero authored
This reverts commit 352154b4. Reason for revert: Causing build failure in android-internal-chromium-tot https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/54793? Original change's description: > [Payments][Android] Move PayerData.java into components/payments/.. > > This cl moves PayerData.java class into components/payments so that > the WebPaymentIntentHelper.java class can use it without depending on > chrome/browser. It also introduces a new Address class and its > converter utility class so that PayerData.java does not depend on > mojom.PaymentAddress. > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > Bug: 1026667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752597} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: I07531956a23479f4f7118b89b7b33b50c0114c65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116584Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#752619}
-
Nico Weber authored
Bug: 1063529,346399 Change-Id: I313ebf4cc16885d1f9bdc5a2ed8db524467735f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116590 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#752618}
-
Travis Skare authored
Change-Id: I03ebd6b77c58f614191afa71c1ab477e9b4d180d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051771Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#752617}
-
Livvie Lin authored
Design doc: https://docs.google.com/document/d/1lltQ1R7JoWOexVj5jMSVM1z9YMgU56wJ1ubxGA-AbYU Screenshot: https://drive.google.com/file/d/1lALD-x5vO8dWLwlmQIJ4GPqnxidKK8-C/view?usp=sharing Bug: 1061576 Change-Id: I91f83f4f6e151894b740b7ff2378a8e16721997f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103510 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752616}
-
Wei Li authored
UpdateBlockThirdPartyCookies() is no longer defined or used. Remove its declaration. BUG=none Change-Id: I44f2dd12911124cc1e2528c1237853d3bb68eed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114337 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#752615}
-
bttk authored
Bug: 1048429 Change-Id: Ib5b5ee1d07492eb30b754320f6527acd5cda60f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079255 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#752614}
-
David Grogan authored
A stretched item's pre-flex layout was getting a fixed cross size equal to the container's cross size, ignoring the item's min/max cross size. Bug: 845235 Change-Id: I8ff2c160f6ede952297ac4f114e954d8dcc5538e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113809 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#752613}
-
Caleb Rouleau authored
- Update the dialog image. - Update the arguments to match the new UI. - Add information about story tags. (To see how the markdown file will look, click the perf_trybots.md file link and then click the "gitiles" link next to the patchset number.) Bug: 1023451, 1059913 Change-Id: Ie019338f64d3fc0649cc7fd63d7a84bd29b756e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112579Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#752612}
-
Jing Wang authored
VK and PK are abbreviations which are ambiguous to readers outside our team, so rename them with full words. Rename zhuyinSelectionKeys to zhuyinSelectKeys to match the code in google3. Rearrange the sequence of properties, move all non-language-specific options to top and sort them alphabetically. InputMethodSettings have not been used in production code, so it is safe to rename these properties. Bug: 1060906 Change-Id: Idcf8eedcb1f7c3ee7d97f894599753a35fcd9179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114515Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752611}
-
Ben Pastene authored
Reverts crrev.com/c/2108826 + properly configures all internal builders to build with official & is_chrome_branded. Now that crrev.com/c/2107709 has landed, it should be safe to convert everything to the new flow. Bug: 937821 Change-Id: I32c1eedd0748e75e1074ce2944245532c98c263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116390Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#752610}
-
Daniel Clark authored
This change assigns the proper ARIA roles and attributes to the time picker popup to ensure a good experience with screen readers. Prior to this change the hour/minute/AM-PM columns were read as monolithic chunks of numbers and the individual values were not selectable. Now the columns and cells have the proper ARIA roles, labels, and selection management so that the popup works smoothly with a screen reader. Bug: 1026544 Change-Id: Ifb16eceed8c4211537aee46cd4d09f771fea8635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088553Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#752609}
-
Lukasz Anforowicz authored
This CL tweaks tests that used RenderProcessHostWatcher to verify that a rendeer process gets terminated because of a bad mojo message. After this CL, such tests use RenderProcessHostBadMojoMessageWaiter that provides an additional verification of the exact error message. Bug: 797360 Change-Id: I2d99190b7c2d3192687cd2869c0a6443be775041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115700 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752608}
-
Tibor Goldschwendt authored
Supports showing the (preview) image of static and animated doodles as well as iframing interactive doodles on the WebUI NTP. Support for playing animated doodles, resizing interactive doodles, etc. will be added later. To support iframing the interactive doodle, this CL adds chrome-untrusted://new-tab-page/iframe?<src> which lets us iframe arbitrary pages into the WebUI NTP. The iframing works by embedding an iframe pointing to <src> into an chrome-untrusted page, which in turn is embedded into the WebUI NTP. This is necessary since we cannot directly embed external pages into the WebUI NTP. + Adds support for a fresh-doodle query parameter to wait for the fetched doodle instead of displaying the cached one. Useful for testing. + Fixes vertical arrangement of elements on the WebUI NTP. Bug: 1039910 Change-Id: I3791a20d392f3f8e8a6d36cec4c1e90f302fc04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109172 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752607}
-
Brian Norris authored
We're changing the behavior here, to also grab the metric at startup: http://crrev.com/c/2111743 This shouldn't substantially change the nature of the metric, except that it will have more coverage. Bug: b:150971082 Change-Id: I3b41b03fbebed0661db84ace9c886255b3889a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113702Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#752606}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01ed358917aa..10d9c49f23c8 git log 01ed358917aa..10d9c49f23c8 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@10d9c49f23c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia2e9c0885680160715da60d4cbfdebab0ebe3346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752605}
-