GitLab

Practical reason of this CL:
This is causing a breakage in the Mac Valgrind builder
after crrev.com/1616793003:
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/91232/steps/runhooks/logs/stdio

Longer explanation:
crrev.com/1616793003 made allocator target toolset: host, target
(which itself should be OK)

A very old condition was forcing use_allocator=tcmalloc on all OS
when build_for_tool=memcheck.
This causes problems now on the Mac valgrind bot when building the
chromium_builder_dbg_valgrind_mac target.
In the last change that touched this line, crrev.com/258433005, the
original condition was linux_use_tcmalloc=1. This was mistakenly
translated in a blanket allocator==tcmalloc.

Rationale for removing this line:
allocator=tcmalloc is the default on linux these days. I don't see a
reason why re-enforcing this condition, as use_allocator=tcmalloc by
default on the right (Linux/Android) platforms.

BUG=564618,580108
TEST=gyp_chromium -Dbuild_for_tool=memcheck && ninja chromium_builder_dbg_valgrind_mac

Review URL: https://codereview.chromium.org/1613183002

Cr-Commit-Position: refs/heads/master@{#370724}

|max_concurrent_streams == 0| means no more stream can be created.  It does not
mean there is no limit on the number of streams.

Also add regression test.  I locally verified that the test fails without the
fix.

Also remove SpdySession::max_concurrent_streams() accessor that was only used in
one place, in a test that is friends with SpdySession anyway so it can directly
access the member in question.

BUG=481009

Review URL: https://codereview.chromium.org/1611703003

Cr-Commit-Position: refs/heads/master@{#370723}

BUG=577779
TEST=KioskModeInfoManifestTest.RequiredPlatformVersion*

Review URL: https://codereview.chromium.org/1595483004

Cr-Commit-Position: refs/heads/master@{#370722}

https://chromium.googlesource.com/skia.git/+log/dba573440906..1a7eb266644d

$ git log dba573440..1a7eb2666 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 caryclark resolution dependent path measure
2016-01-21 caryclark fix skp fuzz
2016-01-21 senorblanco Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS (now unused).
2016-01-21 reed detect bad/corrupt flattenable factory indices
2016-01-21 bsalomon Make colorimagefilter GM not crash when resource path not specified GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619723002 BUG=skia:
2016-01-21 mtklein fuzz: list API fuzzing options if -t api and -n matches nothing.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1617073002

Cr-Commit-Position: refs/heads/master@{#370721}

BUG=none

Review URL: https://codereview.chromium.org/1607473010

Cr-Commit-Position: refs/heads/master@{#370720}

The equivalent bug for attached canvases was fixed in
http://crrev.com/370047, but unattached canvases were ignored
there.

BUG=561045

Review URL: https://codereview.chromium.org/1613193002

Cr-Commit-Position: refs/heads/master@{#370719}

WebRTC 11309:11337

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4cb6ce4..6f75714

Libjingle 11304:11332

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/e05d86d..16d7ba3

TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/1619743002

Cr-Commit-Position: refs/heads/master@{#370718}

This is no longer needed.

BUG=579249

Review URL: https://codereview.chromium.org/1609293003

Cr-Commit-Position: refs/heads/master@{#370717}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a8157d1..6adc8c02

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1611183003

Cr-Commit-Position: refs/heads/master@{#370716}

Changes analyze.py to use loading_trace methods. Moved old files to
deprecated/, I think we're all done with them but we may need them for
reference.

Updated loading_model graph drawing to account for new content-types;
what I've done seems sub-optimal & suggestions are welcome.

Fixed at least one minor bug (the request end units problem Benoit
found).

Review URL: https://codereview.chromium.org/1619713002

Cr-Commit-Position: refs/heads/master@{#370715}

Set "2" in buttons to indicate right button pressed in both
mousedown and contextmenu originiated from a long press action.

BUG=576281

Review URL: https://codereview.chromium.org/1602443006

Cr-Commit-Position: refs/heads/master@{#370714}

BUG=577765

Review URL: https://codereview.chromium.org/1590103004

Cr-Commit-Position: refs/heads/master@{#370713}

Firstly, change the type passed to the allocator to always be BaseElementType.
Otherwise, the buffer will be ascribed to whatever derived type was being
allocated when the buffer overflowed.

Secondly, confine the typeName parameter to only those places where the type
is passed from the ContiguousContainer template, through the base class, to
the allocator. (There are two entry points: initial capacity and new allocation.)

Review URL: https://codereview.chromium.org/1609423002

Cr-Commit-Position: refs/heads/master@{#370712}

BUG=580091

Review URL: https://codereview.chromium.org/1614993002

Cr-Commit-Position: refs/heads/master@{#370711}

We often need to touch this file for text & layout work. It has a big
overlap with work in Source/platform/fonts. I would like to avoid being
slowed down by waiting for wtf/ OWNERs for these changes. Thanks.

BUG=

Review URL: https://codereview.chromium.org/1618823002

Cr-Commit-Position: refs/heads/master@{#370710}

Needed for determining emoji presentation options.

BUG=549517

Review URL: https://codereview.chromium.org/1604323002

Cr-Commit-Position: refs/heads/master@{#370709}

BUG=549021

Review URL: https://codereview.chromium.org/1612943003

Cr-Commit-Position: refs/heads/master@{#370708}

TBR=alancutter@chromium.org
NOTRY=true
BUG=580101

Review URL: https://codereview.chromium.org/1618863002

Cr-Commit-Position: refs/heads/master@{#370707}

BUG=None

Review URL: https://codereview.chromium.org/1617053003

Cr-Commit-Position: refs/heads/master@{#370706}

BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1611713002

Cr-Commit-Position: refs/heads/master@{#370705}

This CL includes two fixes:
- Ensure the app was not running after trying to launch.
- Be more specific when matching process names for the app.

These were split off from:
https://codereview.chromium.org/1510833002/

BUG=

Review URL: https://codereview.chromium.org/1606243002

Cr-Commit-Position: refs/heads/master@{#370704}

This patch changes the system font fallback logic on Windows to take
lang attributes into account.

When a code point is missing in all specified fonts, Blink determines
fonts to use by using Unicode properties for the character.

The UI locale is also used for characters of Asian scripts where
multiple scripts share a large set of the code points.

This patch takes the specified lang attribute to take precedence over
the UI locale. When language tag does not help to determine the script
for the unified ideographs, subtags such as script or country are also
used.

All test rebaselines are where lang attributes are used, and new
results use the correct font for the specified lang.

BUG=579492

Review URL: https://codereview.chromium.org/1607943004

Cr-Commit-Position: refs/heads/master@{#370703}

These tests have been rebased multiple times now, only to start
failing again a (few) days later. The other tests, including pixel tests,
are much more stable.

Let's remove these tests to reduce the burden on sheriffs.

BUG=563448

Review URL: https://codereview.chromium.org/1487683005

Cr-Commit-Position: refs/heads/master@{#370702}

Revert of Uniquify profile shortcut name. (patchset #4 id:60001 of https://codereview.chromium.org/1540543002/ )

Reason for revert:
Reverting since it broke tests on official bots:

https://code.google.com/p/chromium/issues/detail?id=580073

Original issue's description:
> Uniquify profile shortcut name.
>
> Profile desktop shortcut can have a name that conflicts with existing
> shortcuts. This commit tries to fix it by uniquifying shortcut name: by
> appending "(2)", "(3)" ... suffix if there is a conflict.
> If there are two or more profiles with identical logical names they are all
> able to have desktop shortcuts at the same time now.
>
> R=erg@chromium.org
>
> BUG=572593
>
> Committed: https://crrev.com/915cc7306b0899ed017f7656dd82de8a4e4184ec
> Cr-Commit-Position: refs/heads/master@{#370625}

TBR=calamity@chromium.org,anthonyvd@chromium.org,gab@chromium.org,thakis@chromium.org,mkolom@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=572593

Review URL: https://codereview.chromium.org/1614943004

Cr-Commit-Position: refs/heads/master@{#370701}

A speculative patch to try and fix a UAF in ThrottlingHelper.

BUG=579679

Review URL: https://codereview.chromium.org/1616793004

Cr-Commit-Position: refs/heads/master@{#370700}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7753eb89..4a8157d1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1612043002

Cr-Commit-Position: refs/heads/master@{#370699}

https://chromium.googlesource.com/skia.git/+log/744fdb5d78ef..dba573440906

$ git log 744fdb5d7..dba573440 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 kjlubick Seperating our fuzzing binary from DM produces a 50x speed increase for decoding images and a 10x speed increase in decoding/rendering Skps.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1614843003

Cr-Commit-Position: refs/heads/master@{#370698}

The controller should only provide the data model and tell the view when to redraw.

This is functionality neutral, although quite a few tests are shuffled around.

For Mac, a delegate interface is introduced so that the Cocoa view can call into the view layout model.

BUG=575802
TEST=Existing

Review URL: https://codereview.chromium.org/1570783003

Cr-Commit-Position: refs/heads/master@{#370697}

TBR=thakis

Committed: https://crrev.com/1f69728f5099df74ada2bf45ae72a2d294aa3cdf
Cr-Commit-Position: refs/heads/master@{#368569}

Review URL: https://codereview.chromium.org/1566983004

Cr-Commit-Position: refs/heads/master@{#370696}

UX preferred this one.

BUG=571056

Review URL: https://codereview.chromium.org/1618713003

Cr-Commit-Position: refs/heads/master@{#370695}

Reason for reland:
Some targets (clearkeycdmadapter, osmesa) now fell in the state where
they depend indirectly on base (which causes the removal of the default
clib) but via a shared_library boundary (which does not propagate the
replacement allocator / shim layer code).
Fixing those targets by adding a direct base dependency.

This causes a breakage in the main waterfall:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/10231

Original CL description:
> A smaller, yet key, step to move
>
> From: a situation where mainly executables (but not really) depend on
> allocator, and base needs dependencies (to tcmalloc) to be injected
> from content (which violates the ODR in component buids).
>
> To: a situation where only base depends on allocator and the other
> targets get recursively the required linked flags.
>
> In essence this CL is a more gradual approach to the bigger
> unreviewable crrev.com/1528013002.
>
> How is the transition handled?
> ------------------------------
> After this CL, the situation will be as follows:
> From a build time perspective base will also depend on allocator.
> This will not change anything substantial in static builds and introduce
> yet another (temporary) ODR violation in Linux component builds.
> The big change introduced by this CL is the fact that all the executable
> targets that depend on base (virtualy all) will also get another
> indirect dependency to allocator.
>
> In other words, after this CL executable targets will depend on
> allocator for two reasons:
>  - Because they have an explicit dependency to it (the one I am going to
>    get rid of in the immediate future).
>  - Because this new transitive path I am introducing in base.
>
> Rationale of this approach
> --------------------------
> This allows to restrict the critical changes in a smaller CL easier to
> review, at the cost of the temporary double dependency on base.
> The good things are:
>  - If something will break, this CL will be very easy to revert.
>  - The next cleanups will be straightforward.
>  - We have now smoke tests (crrev.com/1577883002) that will help us
>    realize if something goes wrong.
>
> Next steps
> ----------
> In the next CLs I will:
>  - Remove the content -> base injection layer, and let base directly use
>    the tcmalloc functions it needs.
>  - Remove all the traces of USE_TCMALLOC outside of base.
>  - Start cleaning up the hundreds use_allocator conditionals in the gyp
>    files in a way which is easier to review and produce zero ninja diffs
>    (see crrev.com/1583973002 as an example)
>
> Ninja diffs caused by this change
> ---------------------------------
>  ### Win, static build, GN:   https://paste.ee/p/hvcRp
>  The missing targets (mostly tests) that previously were
>  not depending on allocator, now get that by virtue of the transitive
>  dependency.
>
>  ### Win, static build, GYP:  https://paste.ee/p/AGuKR
>  As above. Just GYP seems to emit the ninja files in a different,
>  inlined, format.
>
>  ### linux static build, GYP:  https://paste.ee/p/kmD7U
>  As above. Plus the new targets also get the -Wl,-u (keep symbol)
>  args as expected by allocator.gyp for the tcmalloc heap profiler.
>
>  ### linux shared build, GYP: https://paste.ee/p/FHHNR
>  Nothing relevant. Just I moved the dependency to allocator from
>  base_unittests to base, and that is the only thing that reflects in the
>  ninja files.
>
> BUG=564618

TBR=wfh@chromium.org,brettw@chromium.org,kbr@chromium.org
BUG=564618

Review URL: https://codereview.chromium.org/1616793003

Cr-Commit-Position: refs/heads/master@{#370694}

This CL replaces String/AtomicString objects for JavaScript source
strings with CompressibleString. CompressibleString introduced by
this CL is a mock and just records UMA. CompressibleString has
compress/decompress methods but does not actual
compression/decompression. We're trying to experiment with this CL
to judge if we can introduce actual compression algorithm.

The new UMA Memory.CompressibleStringCount records the frequency
with which JavaScirpt source strings are compressed and decompressed
in foreground and background tabs. If decompressing in background
doesn't occur often compared to compressing in background, we would
be able to say decompressing would be effective to reduce memory.

BUG=574317

Review URL: https://codereview.chromium.org/1583263002

Cr-Commit-Position: refs/heads/master@{#370693}

SkLerpXermode is going away. The same functionality can be
achieved with SkArithmeticMode.

Review URL: https://codereview.chromium.org/1610573004

Cr-Commit-Position: refs/heads/master@{#370692}

BUG=550922

Review URL: https://codereview.chromium.org/1610653002

Cr-Commit-Position: refs/heads/master@{#370691}

Removes dependencies on chrome/ and content/ and moves the file to
components/omnibox/browser.

BUG=579668
TEST=None

Review URL: https://codereview.chromium.org/1610283002

Cr-Commit-Position: refs/heads/master@{#370690}

This CL adds support for CountResidentBytes on windows.
The QueryWorkingSetEx gives the information about pages in range of
given address that are in the working set of the process. We use that
to count the resident bytes similar to how it's done in other
platforms.

BUG=570655

Review URL: https://codereview.chromium.org/1573313002

Cr-Commit-Position: refs/heads/master@{#370689}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ed58de7a..7753eb89

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1611933004

Cr-Commit-Position: refs/heads/master@{#370688}

Seems like throwing a RuntimeException is quite an overkill.
In particular, we still seem to get onResult() callback even if the GMS core connection is suspended.
Replaced the exception with a warning message in a cherrypickable way (the crash happens in M48).

BUG=579718

Review URL: https://codereview.chromium.org/1614833003

Cr-Commit-Position: refs/heads/master@{#370687}

This ensures that we get what is actually played out with what we feed to the echo canceler as far-end data back in sync as quickly as possible after a skip, which in turn reduces the risk of echo. We drop data in WebRtcAudioRenderer::Render.

The fifo is created (if it doesn't exist) if the number of skipped frames is not 10 ms of data.

This CL also removes creating a new fifo unecessarily if only the sink's frames per buffer changes but not the source's (when they differ).

BUG=560371

Review URL: https://codereview.chromium.org/1596523005

Cr-Commit-Position: refs/heads/master@{#370686}

https://chromium.googlesource.com/skia.git/+log/269a82f2883c..744fdb5d78ef

$ git log 269a82f28..744fdb5d7 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 reed remove dead code around SK_SUPPORT_LEGACY_TRANSLATEROUNDHACK

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1619643002

Cr-Commit-Position: refs/heads/master@{#370685}