GitLab

And that we do not re-enter RebuildLayoutTree.

Bug: 868810
Change-Id: Icb70557747c26ccd107775919034ec91b054d070
Reviewed-on: https://chromium-review.googlesource.com/1217743Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590224}

We will need it outside of node.cc for layout tree rebuild root.

Bug: 868810
Change-Id: If428d5c1f954686c70c35631718c5fa270c8971b
Reviewed-on: https://chromium-review.googlesource.com/1217422Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590223}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/727453b25672..56e273293a3c


git log 727453b25672..56e273293a3c --date=short --no-merges --format='%ad %ae %s'
2018-09-11 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@56e273293a3c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I10281a13235851fac2d0ed17962022eb17baae85
Reviewed-on: https://chromium-review.googlesource.com/1217817Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590222}

 - Mark cancel-invoked.html as Timeout.
 - Mark basic.html as Timeout on ASAN.
 - Remove SLOW expectations for both of them.

Bug: 882756, 867982
Change-Id: Ie5d332d02ca8543cb6a4342101b2897ea7af27f3
Tbr: rmcilroy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1218642Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590221}

Bug: 878390
Change-Id: Idbf6ea53989688e675718c76babe259caf51c9db
Reviewed-on: https://chromium-review.googlesource.com/1215946
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#590220}

This is a re-land of [1] after MSAN failures caused a rollback in [2].

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/966442
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/1213152

Bug: 787905
Change-Id: Ie4632a3a482c77202e7e4d3b5c360f021e628389
Reviewed-on: https://chromium-review.googlesource.com/1216684Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590219}

This reverts commit d2bade56.

Reason for revert: Speculative revert for test failure.
https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Original change's description:
> Scheduler: WebURLLoader should notify Blink with the initial priority.
>
> The loading stack only notifies Blink with any increase in the
> request priority. Add support to notify the scheduler with the
> initial priority as well.
>
> Bug: 870349
> Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b
> Reviewed-on: https://chromium-review.googlesource.com/1185593
> Commit-Queue: Farah Charab <farahcharab@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586752}

TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870349, 882200
Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051
Reviewed-on: https://chromium-review.googlesource.com/1218263
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590218}

ChromeOS specific preferences are removed from the persistent storage
list for incognito mode.
As these preferences are not written from inside an incognito window,
the CL is not expected to make any behavioral change and is just
cleanup.

Bug: 861722
Change-Id: I9b5c18427cf9875b20d44dd99b65cab2900a5998
Reviewed-on: https://chromium-review.googlesource.com/1185598Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590217}

We have to set insets to ARC++ notification mask so that visible rect
should have appropriate rounded corners during scroll.
Ideally this can be fixed by changing layer ordering of NativeViewHost,
but it's not going to happen soon.

TEST=manual
BUG=866777

Change-Id: Ic4a2dc3c7f56051937dd02ae34fa0ab3bb290c08
Reviewed-on: https://chromium-review.googlesource.com/1215507Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590216}

In case of failure, debug/report the folder name in the log.

Test: browser_tests --gtest_filter="CreateNewFolder/FilesApp*"
Bug: 876267
Change-Id: I1341c3f746506521a172829fdcf121cbe2030920
Reviewed-on: https://chromium-review.googlesource.com/1207787
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590215}

https://skia.googlesource.com/skia.git/+log/5518e65d90d7..82bf31003c66


git log 5518e65d90d7..82bf31003c66 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader cf47cfdd7c44..6dafcf32ec41 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@82bf31003c66

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Ia71a82159dfe05a8daa28cfccd4e266118b5af88
Reviewed-on: https://chromium-review.googlesource.com/1218543Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590214}

This is a reland of f17b2cd3

Original change's description:
> Update ResourceLoader to also fetch cached code for inline scripts
> 
> V8 also stores code caches for inline scripts in the html resources.
> This cl updates ResourceLoader to fetch cached code for inline scripts
> in MainResources.
> 
> Bug: chromium:880212, chromium:812168
> Change-Id: I822453b52897aac292444df20e50937d8198064d
> Reviewed-on: https://chromium-review.googlesource.com/1208391
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589137}

Bug: chromium:880212, chromium:812168
Change-Id: I5d0d38bf89de68d6fe88324a42742b2dfac3be96
Reviewed-on: https://chromium-review.googlesource.com/1215326Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590213}

When the holdback experiment is enabled, the NetInfo
network quality related Web APIs (https://wicg.github.io/netinfo/)
would report network quality corresponding to the experiment
params.

This CL only affects the NetInfo JavaScript APIs. A subsequent CL
will use the framework in this CL to also override the values
of network quality reported in network quality related client hints
headers.

Change-Id: Iab9d4ecfe7c14eb5d3cee26dbf209fd943156333
Bug: 880545
Reviewed-on: https://chromium-review.googlesource.com/1201343
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590212}

New JS class Crostini to manage crostini shared paths.
Record paths that are shared, and do not show 'Share with Linux'
option for paths that are already shared.

Update Crostini UI test:
 * Verify that 'Share with Linux' is not shown for files (only dirs).
 * Fixed drive_welcome.css path.

Bug: 878324
Change-Id: I6b8445d0a127043f9d24126384267284af5ed7ab
Reviewed-on: https://chromium-review.googlesource.com/1215154Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590211}

Using wpt-import in Chromium f68077fb.
With Chromium commits locally applied on WPT:
d7762551 "Consistently use single quotes in Background Fetch WPTs."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24520

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I08929dba303e26a5d927e92ff5c3077a27c19903
Reviewed-on: https://chromium-review.googlesource.com/1217521
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590210}

Originally landed: crrev.com/c/1163724
Reverted: crrev.com/c/1217069

The revert was due to the two new tests failing on Ubuntu 16.04,
which has a newer version of ATK and thus different expectations.
In order to run the same tests in both environments, prune states
which are not essential to what is being tested from the state set
of the expectations. This modification also eliminates the need to
hand-edit new expectations which are generated on more recent systems.

Original changes preserved in this re-land:
* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome.
* Check to see if focus should follow selection. If it should, also
  emit state-changed:focused events.
* Ensure that the correct states (focusable and selectable) wind up
  in the state set of elements where focus should follow selection.
* Forward events from Blink content to AXPlatformNodeAuraLinux.
* Create an event listener so that DumpAccessibilityEventsTest tests
  can be run. Add expectations for tests for which events are now
  emitted. At the present time, that is only focus and selected.

R=dmazzoni@google.com

Bug: 866340
Change-Id: I371ad0a1516aceb6c6924d0142a6f3268dfdd3ac
Reviewed-on: https://chromium-review.googlesource.com/1217744Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590209}

Use the proper names for both of these in docs meant for public consumption.

Change-Id: Ia5f56ac791e5a743a3b59c5ccef2dea6a868c2b7
Reviewed-on: https://chromium-review.googlesource.com/1217546Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590208}

This is a follow-up CL of crrev.com/c/1215426. Now the test
is passing and we don't need -expected.txt files. I forgot to
remove these files under flag-specific/.

Bug: 882477
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7e5a3bb7bb3393bfbbf0e9827daf5c8983cff41a
Reviewed-on: https://chromium-review.googlesource.com/1218044Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590207}

This CL decodes the still capture frame to YUV, rotates it according to
screen rotation and encodes it back. This is to fix takePhoto() result
having wrong orientation on HALv1 devices.

Bug: 878865
Test: Tested on reef with CCA 5.1.0 that the captured photos are correct
for both front and back cameras.

Change-Id: Ib3758e0736b0dbb9b145acd3716b58cf6e08ccd3
Reviewed-on: https://chromium-review.googlesource.com/1208392
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590206}

https://chromium.googlesource.com/angle/angle.git/+log/63aa0e5b7001..0d0fb43f34ee


git log 63aa0e5b7001..0d0fb43f34ee --date=short --no-merges --format='%ad %ae %s'
2018-09-11 jmadill@chromium.org Pass unpack buffer as explicit parameter to texSubImage.


Created with:
  gclient setdep -r src/third_party/angle@0d0fb43f34ee

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:880906
TBR=ynovikov@chromium.org

Change-Id: I83ce6ccf2c62c770845912f19ef043d6cd3c374e
Reviewed-on: https://chromium-review.googlesource.com/1217815Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590205}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/867aebe10898..1bfa8980a363


git log 867aebe10898..1bfa8980a363 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@1bfa8980a363

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie61820f65ea25741a4b3084ccc917bacae0409f6
Reviewed-on: https://chromium-review.googlesource.com/1218422Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590204}

This is a cleanup code-health change.

Bug: 774918
Change-Id: I9b73ad49874fa48210aba031d646173f1544678d
Reviewed-on: https://chromium-review.googlesource.com/1209133Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590203}

template_url_parser_fuzzer eventually calls down into code that
interacts with base::CommandLine.

BUG=882155

Change-Id: Id37803e2f3e67a6acc2e5686b136661d3bb0e1ea
Reviewed-on: https://chromium-review.googlesource.com/1218163Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590202}

Rather than requiring subclasses of blink::Frame to remember to call
blink::frame::Detach() at the end of their overridden implementation,
move the subclass logic into a separate method that is pure virtual on
blink::Frame. This allows lifecycle management to be consolidated into
blink::Frame::Detach(), rather than having asserts scattered throughout
and hoping the subclasses managed it correctly.

Bug: 838348
Change-Id: If2e26d7117af7dd890e2fa04052979438ec87cae
Reviewed-on: https://chromium-review.googlesource.com/1217510Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590201}

There is a bug in the caching code which triggers PLOG. Suppress it to
avoid log noise.

BUG=chromium:882738

Change-Id: Id7effca5c24268a9862b4cad2761051b02add5c6
Reviewed-on: https://chromium-review.googlesource.com/1218482Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590200}

This patch fix ComputeInlineBoxPosition for the position that
points after line break and no LayoutObject after that by
fallback to previous position.
The fallback examples:
- "<br>|" to "|<br>"
- "<pre>foo\n|</pre>" to "<pre>foo|\n</pre>"

This change aligns legacy LocalCaretRect to NG.

Bug: 789870, 812535
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Icb6cd9b8bc58b56a04d01eb22bdd58bd16ad5a01
Reviewed-on: https://chromium-review.googlesource.com/1215506
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590199}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2353705f52ff..656c1c9c270c


Created with:
  gclient setdep -r src-internal@656c1c9c270c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:882510
TBR=mmoss@chromium.org

Change-Id: I30b703b7204c1cf4b5cec2d9d5fdcc0194a42e68
Reviewed-on: https://chromium-review.googlesource.com/1217818Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590198}

Bug: 881816
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I695dac7e9aa0b2c6e08d5e661d56afda12d140b8
Reviewed-on: https://chromium-review.googlesource.com/1215042
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590197}

Due to either syncing or using multi-profile, we can get into a state
where synced pin state lists Crostini apps although we shouldn't be
displaying them. This results in weirdness like blank-space icons for
the Terminal, or penguin icons for apps with icons, when these pinned
items are supposed to be hidden. Clicking the shelf icons does nothing
due to https://crrev.com/c/1212373. This CL prevents these broken
pinned apps from appearing.

Bug: 869266
Change-Id: I13ca91b8055cf43003bf1d467ca28161eb289e29
Reviewed-on: https://chromium-review.googlesource.com/1215532Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590196}

IntersectionObserver WPTs expect that intersection observations are
delivered within two step_timeouts of requestAnimationFrame. This
expectation holds in Blink, but doesn't necessarily hold in other engines.
In WebKit, requestAnimationFrame and layout are separate tasks, so it's
possible for the first step_timeout to fire in between rAF and layout,
leading to test flakiness. This CL switches these WPTs to using
double-rAF rather than rAF-setTimeout-setTimeout when waiting for
observations to be delivered.

Change-Id: Iad80943db184bc4519ab323c3bd7cfac1256e175
Reviewed-on: https://chromium-review.googlesource.com/1214176
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590195}

r526281 added a workaround for when text-transform shorten
the string, but did so only for when inline_text_box_.Start()
is zero.

This patch extends the workaround for when inline_text_box_.
Start() is not zero.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib4536ae5aaf92352e41ef19e53c2046a4c86806c
Bug: 880176, 795498
Reviewed-on: https://chromium-review.googlesource.com/1218202
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590194}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/385a05c3d606..5604391f597d


git log 385a05c3d606..5604391f597d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 hinoka@chromium.org Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""


Created with:
  gclient setdep -r src/native_client@5604391f597d

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mseaborn@chromium.org

Change-Id: Ib32d0d3f7078ffd0d9c0286890c329cbfbac9b37
Reviewed-on: https://chromium-review.googlesource.com/1217812Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590193}

A previous refactoring (http://crrev.com/586985) changed the CreateRoute
call in CastConfigClientMediaRouter::CastToSink to supply a null
callback. This causes a crash because MediaRouter assumes the callback
is not null. This patch fixes it by supplying base::DoNothing() instead.
Also, added a CHECK for null callback in MediaRouterMojoImpl.

Bug: 882567
Change-Id: Idaaf1ca24149dff4d0bab7228f10176e804226d4
Reviewed-on: https://chromium-review.googlesource.com/1217902Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590192}

The Chrome app menu and its submenus have a max-width of 800px. Bookmarks
_subfolders_ have a max-width of 400px. But this doesn't apply to the
bookmarks menu itself.

Currently if a bookmark has a long title and appears in the bookmarks
bar top-level, it will push out the width of the `Bookmarks` submenu
when accessed via the Chrome app menu to a width that feels inconsistent.

Bug: 881936
Change-Id: I1535b2b27f183e4106e21799ba91a5ab40287489
Reviewed-on: https://chromium-review.googlesource.com/1215503Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590191}

R=kojii@chromium.org,eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6eb59b3683c54d703b311842fe333b2590d05882
Reviewed-on: https://chromium-review.googlesource.com/1217708Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590190}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4624f2fdcfda..867aebe10898


git log 4624f2fdcfda..867aebe10898 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 chingcodes@google.com signing: add errors and add/update signers


Created with:
  gclient setdep -r src/third_party/chromite@867aebe10898

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2df033eeaae2bde498496550e47b670d9854587b
Reviewed-on: https://chromium-review.googlesource.com/1217810Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590189}

This CL lets PpapiThread use CreateMainThreadAndInitialize() so the
Platform class can create the main thread on behalf.

Previously, the code does not create an WebThread instance for the main
thread(!), and PpapiBlinkPlatform::CurrentThread() actually returns
nullptr on the main thread(!). This is because BlinkPlatformImpl::
CurrentThread() only cares about non-main threads created with
CreateThread(). This CL fixes this issue.

Bug: 826203
Change-Id: Icc1319e70da2d7c2a3ccaee0adb140df80cd496d
Reviewed-on: https://chromium-review.googlesource.com/1186019Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590188}

This is a clean up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1201507
which renames BubbleDialogDelegateView::set_arrow() to SetArrow().
This matches our style guide as SetArrow() isn't a simple getter function.

Bug: 877032
Change-Id: I9d506604d74651deed45a3854356ec7b66e57bb9
Reviewed-on: https://chromium-review.googlesource.com/1203493Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590187}

The ChromeOS Gallery, video_player, and audio_player currently pick out
a collection of .js files from various places inside the folder structure
of the ChromeOS files App.

This CL documents where that occurs, with a view to move these, shared
files out to a shared "toolkit" folder higher up in the folder structure.
There is already a "common" folder, but it is within the Files app
subtree and hard to enforce via layering.

It uses GN's "visibility" on the closure targets to detect whether new
dependencies are added.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6b134ccad20c22ad46372871ab488200d3cbafa1
Reviewed-on: https://chromium-review.googlesource.com/1188735
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590186}

../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(58,32):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
      keyboard_layout_handles_.size(), keyboard_layout_handles_.data());
      ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(75,35):  warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
  return keyboard_layout_handles_.size();
  ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(32,44):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
        keyboard_layout_manager->GetLayout(i);
                                 ~~~~~~~~~ ^
../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(33,20):  warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    PopulateLayout(i, dom_keyboard_layout);
    ~~~~~~~~~~~~~~ ^

../../ui/events/test/event_generator.cc(673,51):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
      (ui::EventTimeForNow() - base::TimeTicks()).InMicroseconds();
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

../../ui/events/win/events_win_utils.cc(257,36):  warning: implicit conversion loses integer precision: 'const LPARAM' (aka 'const long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32]
    return gfx::Point(native_event.lParam);
           ~~~        ~~~~~~~~~~~~~^~~~~~

../../ui/events/event_utils.cc(112,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(116,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(120,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../ui/events/event_utils.cc(124,41):  warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32]
                                  delta.InMicroseconds(), 1, 1000000, 50);
                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros.h(189,15):  note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS'
        name, sample, min, max, bucket_count,                                  \
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(128,19):  note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG'
        name, Add(sample),                                                     \
              ~~~ ^~~~~~
../..\base/metrics/histogram_macros_internal.h(120,27):  note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK'
                          histogram_add_method_invocation,                     \
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/metrics/histogram_macros_internal.h(104,24):  note: expanded from macro 'HISTOGRAM_POINTER_USE'
    histogram_pointer->histogram_add_method_invocation;                        \
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.
[22971/48339] CXX obj/ui/events/events/keyboard_hook_win.obj
../../ui/events/win/keyboard_hook_win.cc(117,25):  warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32]
    MSG msg = {nullptr, w_param, ll_hooks->vkCode,
              ~         ^~~~~~~

../../ui/events/event.cc(1137,47):  warning: implicit conversion loses integer precision: 'const WPARAM' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    key_ = DomKey::FromCharacter(native_event.wParam);
           ~~~~~~                ~~~~~~~~~~~~~^~~~~~

BUG=879657

Change-Id: If41fb68b2e054ff4f429396e78048d48f71a3e38
Reviewed-on: https://chromium-review.googlesource.com/1214682Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590185}