- 20 Sep, 2018 40 commits
-
-
Nico Weber authored
This reverts commit f6a8902e. Reason for revert: relanding with lto for android disabled until things are sorted out. Original change's description: > Revert "Roll clang 340925:342523." > > This reverts commit 34893e97. > > Reason for revert: New failures on Android in computeKnownBits(), looks like an LTO problem. http://crbug.com/887272 > > Original change's description: > > Roll clang 340925:342523. > > > > Ran `tools/clang/scripts/upload_revision.py 342523`. > > > > Bug: 880827 > > Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 > > Reviewed-on: https://chromium-review.googlesource.com/1232590 > > Reviewed-by: Reid Kleckner <rnk@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592531} > > TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org > > Change-Id: Idee414178ab15058aa080f670585cee81e0f8ac5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 880827 > Reviewed-on: https://chromium-review.googlesource.com/1236003 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592765} TBR=pasko@chromium.org,thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: I26ea97e83cfebcec0670e79683fe0db7f993c1a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880827 Reviewed-on: https://chromium-review.googlesource.com/1236174 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592778}
-
Yuki Awano authored
- Touch events come in screen pixel. We need to use in screen pixel conversion here as the comment in the file says. that touch exploration works correctly on the touch controller. Bug: 887222 Test: Enable spoken feedback on touch controller of CfM unit. Confirm Change-Id: Ic7a83eb5d9c4690b41a184ab85d5421e0468934e Reviewed-on: https://chromium-review.googlesource.com/1235489 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592777}
-
Charles Zhao authored
Both tests fail because the proto serialization is not deterministic. Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5 Bug: 884140 Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5 Reviewed-on: https://chromium-review.googlesource.com/1233096 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592776}
-
Mikel Astiz authored
This is a mitigation to what are believed to be bugs in the bridges, which may forget to appropriately report local deletions to the processor, leading to orphan sync metadata. We have recently instrumented a UMA metric ("Sync.ModelTypeOrphanMetadata") to assess the severity of the issue, and the collected data suggests that the problem is not specific to a single datatype. While we investigate each bridge individually, a reasonable workaround is to let the processor remove the orphaned metadata and untrack the entity. Bugs in the bridges should still be surfaced by the aforementioned UMA metric, although absolute numbers should tend to be smaller after this patch, because issues will get fixed after emitting the metric once. Bug: 875671,871733 Change-Id: Ieb06692f46739d73ce6f04115c25e14198ade1dd Reviewed-on: https://chromium-review.googlesource.com/1233676 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#592775}
-
Mohamed Amir Yosef authored
This CL adds the functionality to store the ids of lazy subscriptions in SharedPeferences. Later CL will consume this information to decide whether the FCM message should be deferred until there are visible activities or not. Bug: 882887 Change-Id: Ic28dbfeb2b77020cd9b5e02b79f055e477d55aed Reviewed-on: https://chromium-review.googlesource.com/1221532Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#592774}
-
Matthew Cary authored
android_build_tools/art was recently added, and pulls in several binaries that should be ignored by git. TBR: agrieve@chromium.org Change-Id: I2fb97c175707225237acbee80f4c01cdb0cdad44 Reviewed-on: https://chromium-review.googlesource.com/1235726Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592773}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I7515c9fb448b9324b81dec958e0c212192741188 Reviewed-on: https://chromium-review.googlesource.com/1228059 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592772}
-
Jan Krcal authored
This CL makes a cleanup in autofill sync unit-test, reducing code duplication and getting rid of custom fakes that can be mocked in one line. It also renames another existing fake to achieve more consistency in naming (w.r.t. gmock). This CL precedes a change in the AutofillWebDataBackend interface, making it easier to implement. Bug: 853688 Change-Id: Iaf9ec6151caa77e9b81297f50c061835443cfadd Reviewed-on: https://chromium-review.googlesource.com/1235716Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592771}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b8671f08f41..ecfe498c1a1a Created with: gclient setdep -r src-internal@ecfe498c1a1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8bb96b3b8e967bfc07accec533508d1478486a7e Reviewed-on: https://chromium-review.googlesource.com/1235839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee002e61857b..207cfdfbd889 git log ee002e61857b..207cfdfbd889 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 artit@webrtc.org Added support of getting coverage on mac Created with: gclient setdep -r src/third_party/webrtc@207cfdfbd889 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:844647 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I392429d4014348877087de19a4812632cbad9f38 Reviewed-on: https://chromium-review.googlesource.com/1235837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592769}
-
Thomas Tangl authored
Apparently creating a new image out of a bitmap leads to crashes in |Image::ToImageSkia|. This CL removes the conversion between images inside PrepareAvatarImage() to speculatively fix the issue. See bug report for details. Bug: 882330 Change-Id: Ifd7df91f5933ce0159ce223bf61fd9dcfac9356d Reviewed-on: https://chromium-review.googlesource.com/1228194 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592768}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8495ffe55979..985f6fe58181 git log 8495ffe55979..985f6fe58181 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 anthonyalridge@google.com Handle inputs with zero range for plots. Created with: gclient setdep -r src/third_party/catapult@985f6fe58181 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I80ec2cd27533b784f212a413532c4a7ee39e820f Reviewed-on: https://chromium-review.googlesource.com/1235838Reviewed-by:
-
Stuart Langley authored
This will always append the "supportsTeamDrives=true" parameters to drive query strings, so lots of mechanical test related changes to update the expected query string. Change-Id: Ic98c558f74195dc27550af5a06aab78fdb413e57 Reviewed-on: https://chromium-review.googlesource.com/1235454Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#592766}
-
Egor Pasko authored
This reverts commit 34893e97. Reason for revert: New failures on Android in computeKnownBits(), looks like an LTO problem. http://crbug.com/887272 Original change's description: > Roll clang 340925:342523. > > Ran `tools/clang/scripts/upload_revision.py 342523`. > > Bug: 880827 > Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 > Reviewed-on: https://chromium-review.googlesource.com/1232590 > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592531} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: Idee414178ab15058aa080f670585cee81e0f8ac5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880827 Reviewed-on: https://chromium-review.googlesource.com/1236003Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592765}
-
Florian Mayer authored
Change-Id: I764fcf0f349d5c78f8029408530f783ae9301b76 Reviewed-on: https://chromium-review.googlesource.com/1235934 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#592764}
-
Balazs Engedy authored
Bug: 885165 Change-Id: I207457e481ef89ffcf0d91ee530cea2d3c33649a Reviewed-on: https://chromium-review.googlesource.com/1230675 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#592763}
-
Gauthier Ambard authored
This CL removes the TabHistory popup code as it was only used pre-UI Refresh. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I140bbed84ef69efb81c67130186ec72cca684961 Reviewed-on: https://chromium-review.googlesource.com/1233853 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592762}
-
Marc Treib authored
This moves a bunch of helper functions around secondary account support from single_client_secondary_account_sync_test.cc into their own files. This is in preparation for adding more integration tests that will make use of these. Bug: 885211 Change-Id: I1f30b2425951933f6f9251f35c4aafb7e1cdb663 Reviewed-on: https://chromium-review.googlesource.com/1233704Reviewed-by:
-
Jdragon authored
This change fix settings css to access expand and delete icons. As a Result, cookies with long names can be deleted. Bug: 871639 Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42 Reviewed-on: https://chromium-review.googlesource.com/1202362 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592760}
-
Xi Cheng authored
This makes NotificationTemplateBuilder own a WeakPtr rather than a raw pointer to NotificationImageRetainer, which helps with tracking potential memory issues. Bug: 884224 Change-Id: I229ffd187ccd9b424987ab1473b240f898c06023 Reviewed-on: https://chromium-review.googlesource.com/1227717Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#592759}
-
Xi Cheng authored
This CL also cleans up the headers. Bug: 886957 Change-Id: I0d63484a7b2e96be64bc9e83f9350ca4ad7ffe41 Reviewed-on: https://chromium-review.googlesource.com/1234266Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 886957 Change-Id: I734a8858b2538aaf6b146ce6c209ab4718ff278c Reviewed-on: https://chromium-review.googlesource.com/1235132Reviewed-by:
-
Yuki Shiino authored
This is a follow-up of https://crrev.com/c/1226893 and moves eventlistener-with-remote-context.html to WPT. The test content is conceptually the same. Bug: 883643, 886588 Change-Id: I7c941e162a076d9cbb7abc1d259ff98742a14517 Reviewed-on: https://chromium-review.googlesource.com/1235774Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#592756}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3c2848bbfe9..1b8671f08f41 Created with: gclient setdep -r src-internal@1b8671f08f41 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7081744ee44f57d8926933c3892d082b44e6d224 Reviewed-on: https://chromium-review.googlesource.com/1235835Reviewed-by:
-
Vaclav Brozek authored
https://crrev.com/c/1230064 added a comment pointing out the dependency between autofill::kDefaultPasswordLength and the autofill server code. However, the detail was mostly given in the CL commit message instead of the comment itself. This CL attempts to bring more of the information into the comment to spare going through "git blame" in the future. Bug: 846694 Change-Id: I0db135e31da59a5c6bacba7c2de602a7581166b5 Reviewed-on: https://chromium-review.googlesource.com/1235574Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592754}
-
Keishi Hattori authored
We want to remove the distinction between DISALLOW_NEW and DISALLOW_NEW_EXCEPT_PLACEMENT_NEW by merging them together. Implementation wise this will be identical to the old DISALLOW_NEW_EXCEPT_PLACEMENT_NEW but we will rename it to DISALLOW_NEW as it is shorter. The new DISALLOW_NEW classes can be allocated on stack, as part objects, and inline in collection backings (i.e. everywhere except on-heap). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ec0d39d9dd991bf7157bd459bc659c5e011e229 Reviewed-on: https://chromium-review.googlesource.com/1212214 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592753}
-
Matthew Cary authored
long_running:tools:gmail-foreground and long_running:tools:gmail-background fail consistently during orderfile profiling. Blacklisting them will let us run another benchmark instead. Bug: 758566 Change-Id: I504e522c5f7d809838bcefc8168eb3a284d4ed1a Reviewed-on: https://chromium-review.googlesource.com/1235713Reviewed-by:
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ibbfe8b365f3c57b89e189150e8d579a633622e16 Reviewed-on: https://chromium-review.googlesource.com/1234230Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592751}
-
Eric Seckler authored
This patch updates callsites of BrowserThread task posting methods to use the post_task.h API instead. Background: We're changing the way tasks are posted to a BrowserThread, see PSA [1] and design doc [2]. This unifies the way tasks are posted and paves the way for annotating tasks with task types and other attributes that can be used to prioritize tasks in the future browser UI thread scheduler (design doc [3]). This CL changes callsites of the following forms: (a) BrowserThread::Post*Task(BrowserThread::UI/IO, ..) to base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI/IO}, ..), (b) BrowserThread::GetTaskRunnerForThread(BrowserThread::UI/IO) to base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::UI/IO}). It also adds necessary includes. These mechanical changes were applied by a script. Tasks posted with the same BrowserThread::ID trait (via PostTaskWithTraits or TaskRunners obtained from Create*TaskRunnerWithTraits) will still execute in the order they were posted, see [4]. [1] https://groups.google.com/a/chromium.org/d/topic/chromium-dev/A3_snMVXv8A/discussion [2] https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing [3] https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit?usp=sharing [4] https://cs.chromium.org/chromium/src/base/task/post_task.h?l=66 TBR=achuith@chromium.org, afakhry@chromium.org, agl@chromium.org, avi@chromium.org, bbudge@chromium.org, bengr@chromium.org, benwells@chromium.org, bnc@chromium.org, calamity@chromium.org, ccameron@chromium.org, chiniforooshan@chromium.org, cjgrant@chromium.org, cmumford@chromium.org, csharrison@chromium.org, dalecurtis@chromium.org, delphick@chromium.org, dgozman@chromium.org, dmazzoni@chromium.org, droger@chromium.org, dschuff@chromium.org, dullweber@chromium.org, erikchen@chromium.org, felt@chromium.org, fgorski@chromium.org, gogerald@chromium.org, groby@chromium.org, horo@chromium.org, imcheng@chromium.org, jcivelli@chromium.org, jianli@chromium.org, jinho.bang@samsung.com, jkarlin@chromium.org, jochen@chromium.org, kinuko@chromium.org, lazyboy@chromium.org, lpy@chromium.org, markusheintz@chromium.org, mattcary@chromium.org, maxmorin@chromium.org, miu@chromium.org, mkwst@chromium.org, mmenke@chromium.org, mpearson@chromium.org, msramek@chromium.org, nick@chromium.org, nparker@chromium.org, nyquist@chromium.org, peter@chromium.org, pwnall@chromium.org, qinmin@chromium.org, rbpotter@chromium.org, rdevlin.cronin@chromium.org, rouslan@chromium.org, scottmg@chromium.org, servolk@chromium.org, skuhne@chromium.org, sky@chromium.org, tapted@chromium.org, tbansal@chromium.org, thestig@chromium.org, tommi@chromium.org, tommycli@chromium.org, torne@chromium.org, tschumann@chromium.org, vabr@chromium.org, vakh@chromium.org, waffles@chromium.org, yfriedman@chromium.org, zmo@chromium.org, bartfab@chromium.org Bug: 878356 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I37526c8e75630ee7bec29421276094a30e903894 Reviewed-on: https://chromium-review.googlesource.com/1186623Reviewed-by:Eric Seckler <eseckler@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#592750}
-
Tonko Sabolčec authored
This CL includes: - Report number of successfully removed corrupted passwords. - Report cleanup result - success (with or without passwords removed), item failure - Store date of when user is recovered (preference renamed SyncUsersPasswordRecovery => PasswordRecovery) - Update tests Bug: 791541 Change-Id: Ie981606268b90c5a471a3aa31df8a2585f31d610 Reviewed-on: https://chromium-review.googlesource.com/1228016 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/582a06eb7835..8495ffe55979 git log 582a06eb7835..8495ffe55979 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 wangge@google.com Add function to collect the results after all the jobs have started. 2018-09-20 cbruni@chromium.org Reland: Output DevTools error messages as warnings while running a story. 2018-09-20 wangge@google.com Add utility functions to add new target. Created with: gclient setdep -r src/third_party/catapult@8495ffe55979 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390,chromium:880432,chromium:863390 TBR=sullivan@chromium.org Change-Id: Id6330948993bd8ecc83097ad61ca9e8726f110f0 Reviewed-on: https://chromium-review.googlesource.com/1235834Reviewed-by:
-
Justin Cohen authored
On small form factor devices (iPhone SE, 5, 5s, iPods), an edge case is causing an NSInternalInconsistencyException exception and crash immediately on startup. The problem only seems to present on devices with VoiceOver enabled as UIKit functions slightly differently when laying out a UICollectionView. By merging the batch updates when adding suggestions, we can work around the exception. crbug.com/881647 has a longer discussion about the cause and resolution. Bug: 881647 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0503957ee73edb57a6d978df4338fc76e0370062 Reviewed-on: https://chromium-review.googlesource.com/1234216 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d574123c5035..ee002e61857b git log d574123c5035..ee002e61857b --date=short --no-merges --format='%ad %ae %s' 2018-09-19 chfremer@webrtc.org Fix WebRTC fuzzers tests in Chromium missing field trial implementation 2018-09-19 yvesg@webrtc.org Roll chromium_revision e4b02117..cc7b9c68 (592264:592452) 2018-09-19 yvesg@webrtc.org Auto roller: Fix GenerateCommitMessage signature. 2018-09-19 yvesg@webrtc.org Auto roller: fix list of WEBRTC_ONLY_DEPS. 2018-09-19 yvesg@webrtc.org Auto roller: don't complain about expected dependencies. 2018-09-19 yvesg@webrtc.org Auto roller: improved tracking of android dependencies. 2018-09-19 buildbot@webrtc.org Roll chromium_revision f305d23e..e4b02117 (592151:592264) 2018-09-18 mbonadei@webrtc.org Fix WebRTC fuzzers tests in Chromium. 2018-09-18 buildbot@webrtc.org Roll chromium_revision f37f3783..f305d23e (591975:592151) 2018-09-18 ssilkin@webrtc.org Restrict use of frame rate controller. 2018-09-18 nisse@webrtc.org Simplify includes in p2ptransportchannel.cc 2018-09-18 sprang@webrtc.org Prevent resolution limited max bitrate from going below min 2018-09-18 mbonadei@webrtc.org Reland "Add RTC_EXPORT macro to export WebRTC symbols." 2018-09-18 mbonadei@webrtc.org Do not compile frame_analyzer_host during Chromium builds. 2018-09-18 mbonadei@webrtc.org Add documentation about field_trial/metrics custom impl. 2018-09-18 jtteh@webrtc.org Revert "Add RTC_EXPORT macro to export WebRTC symbols." 2018-09-18 mbonadei@webrtc.org Reland "Compile frame analyzer for the host machine on perf tests." 2018-09-18 buildbot@webrtc.org Roll chromium_revision 0eb6b522..f37f3783 (591627:591975) 2018-09-18 danilchap@webrtc.org Refactor RtpPacketizerH264 tests 2018-09-18 danilchap@webrtc.org Cleanup modules_common_types 2018-09-17 mbonadei@webrtc.org Revert "Compile frame analyzer for the host machine on perf tests." 2018-09-17 mbonadei@webrtc.org Add RTC_EXPORT macro to export WebRTC symbols. 2018-09-17 mbonadei@webrtc.org Compile frame analyzer for the host machine on perf tests. 2018-09-17 buildbot@webrtc.org Roll chromium_revision 1d75f6fc..0eb6b522 (591373:591627) 2018-09-17 mbonadei@webrtc.org Rename RTC_EXPORT to RTC_OBJC_EXPORT. 2018-09-17 mbonadei@webrtc.org Introduce GN arg rtc_exclude_runtime_enabled_features_default. 2018-09-17 danilchap@webrtc.org Register video rtp header extensions in rtp_rtcp by uri 2018-09-17 sprang@webrtc.org Add ability to throttle VideoBitrateAllocation updates. 2018-09-17 mbonadei@webrtc.org Remove obsolete comments. 2018-09-17 saza@webrtc.org Reland "Remove APM internal usage of EchoCancellation" 2018-09-15 mbonadei@webrtc.org Merge field_trial and field_trial_default in a unique target. 2018-09-15 mbonadei@webrtc.org Merge system_wrappers:metrics and system_wrappers:metrics_default. Created with: gclient setdep -r src/third_party/webrtc@ee002e61857b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:855108,chromium:855108,chromium:855108,chromium:855108,chromium:None,chromium:None,chromium:884164,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If83dd14ed68cd0ebd408e229d672b44eedb9fb98 Reviewed-on: https://chromium-review.googlesource.com/1235418Reviewed-by:
-
Kamila authored
Removed the separator line in "chrome://settings/content/flash" that should not be there: https://imgur.com/a/yLP1ITi Bug: 868251 Change-Id: I14a745ddca7ae7294444c1ae3f51fab42c723524 Reviewed-on: https://chromium-review.googlesource.com/1221263 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592745}
-
Max Morin authored
In preparation for moving render frame stream factories, ForwardingAudioStreamFactory and audio stream brokers to IO thread. Bug: 866440,852880,866442 Change-Id: Ifbea4159ad55507666836bf82d049feb5000a5d8 Reviewed-on: https://chromium-review.googlesource.com/1219627 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592744}
-
Dominik Röttsches authored
The availability of IDWriteFontFactory2 (which has the TranslateColorGlyphRun method on it) is equivalent to the ability of the underlying DirectWrite implementation to render COLR/CPAL fonts. We are using this detection to find out whether we are running on a system that can render COLR/CPAL natively, otherwise pass the web font to a COLR/CPAL SkFontMgr based on FreeType. Tests updated to reliably test rendering results for COLR/CPAL including our Windows 7 bots. Mac detection to do the same fallback for OS versions below Mac OS 10.13 will follow in a subsequent CL. Bug: 882844 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5f5aa16cbb176d22d229dee05619419cbb8bb892 Reviewed-on: https://chromium-review.googlesource.com/1219887 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592743}
-
Jan Wilken Dörrie authored
This change fixes bugs in the macOS BLE stack where delegates outlived the object they were observing and caused use-after-frees. Bug: 884897 Change-Id: Ib38164851fb6ab57cc56f9684f8b43161d59e13a Reviewed-on: https://chromium-review.googlesource.com/1233737Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#592742}
-
Valeriya Sinevich authored
Change-Id: I3da1a8afa52f6ee08aff2537b39f585d78961c69 Reviewed-on: https://chromium-review.googlesource.com/1199505 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#592741}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/422774f688e4..c3c2848bbfe9 Created with: gclient setdep -r src-internal@c3c2848bbfe9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I71f0cf20448e25e5ed53d7304c0706e6932c5ef2 Reviewed-on: https://chromium-review.googlesource.com/1235833Reviewed-by:
-
JunHo Seo authored
Problem: 1. In AdvanceFocusDirectionallyInContainer(), we process navigable container when the container is either scrollable element or local frame. In addition, we insert an element into already_checked only if the element is local frame. So if the loop processes remote frame as best candidate, then we get stuck in infinite loop. 2. OOPIF.IsKeyboardFocusable() = true && OOPIF.IsNavigableContainer() = true Because OOPIF is focusable, spatial navigation can give focus to OOPIF. If we enter into OOPIF by giving focus it, we can't get out of it by spatial navigation. Solution: Until we support OOPIF correctly, don't navigate to remote frame. To do that, we exclude OOPIF from FocusCandidate. Change-Id: I1928e8c7c9d38951687731a691f0ec0abbcdce10 Reviewed-on: https://chromium-review.googlesource.com/1227853Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#592739}
-
