GitLab

If EnableAdbRoot fails, then we can't wipe the data because then we're
not able to restore the adb_keys and the device never reappears.

BUG=396120

Review URL: https://codereview.chromium.org/413523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285008 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r284650. There is one test that is flaky 34% of the time, but that is the exception and not the norm. We don't need 12 retries to make browser_tests or other test suites not flaky. If there are very flaky tests, we should disable them instead. I've disabled all the tests that flake more than 5% of the time.

BUG=395189
R=brettw@chromium.org, sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/413733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285006 0039d316-1c4b-4281-b951-d872f2087c98

The monsoon provides power for the device, so for devices with no
real battery, we need a chance to turn them on after the monsoon
enables voltage output to the device.

BUG=

Review URL: https://codereview.chromium.org/400863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/410173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285004 0039d316-1c4b-4281-b951-d872f2087c98

It breaks http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5252

> Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.
> 
> BUG=393149
> 
> Review URL: https://codereview.chromium.org/387923002

TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/416543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396729
R=stgao@chromium.org
TBR=tbarzic@chromium.org

Review URL: https://codereview.chromium.org/411043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285001 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for moving files which are on the same provided file
system. Note, that moving between file system instances will be done using
FileStreamWriter.

TEST=unit_tests, browser_tests: *FileSystemProvider*Move*
BUG=391362

Review URL: https://codereview.chromium.org/389973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285000 0039d316-1c4b-4281-b951-d872f2087c98

This was used as part of the PNaCl rollout but is no longer necessary. I came
across this while investigating what code in chrome needs to be updated once
the file for the trusted plugin library is gone.

Usage statistics say that this flag has been used 1850 times in the past 7
days by 197 users.

TBR=ncbray
BUG=354867

Review URL: https://codereview.chromium.org/392023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284997 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284996 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13507: (noelallen) Reapply patch which was reverted due to conflict.
r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit
r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names.
r13510: (dschuff) Disable flaky sandboxed translator tests on mac
r13511: (dschuff) Update revision for PNaCl r13466->r13509

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
(linux_rel_precise32,linux_arm_cross_compile omitted because they are currently broken)

R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/409113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284995 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove ash_unittests to see if it's affecting bot stability (https://codereview.chromium.org/411673002/)

Reason for revert:
Was not the cause of flakiness.

Original issue's description:
> Remove ash_unittests to see if it's affecting bot stability
> 
> Bot has been completely failing intermittently. ash_unittests
> is the Win8-specific part that runs here, so temporarily remove
> it to see if it's related to the back-and-forth to Metro
> switches.
> 
> BUG=340422
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284820

TBR=sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=340422

Review URL: https://codereview.chromium.org/414783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284993 0039d316-1c4b-4281-b951-d872f2087c98

We have lots of test APKs that don't need application icons. And I think
we'd notice if Chrome itself was missing an icon even without this
warning ;)

BUG=393235
NOTRY=true

Review URL: https://codereview.chromium.org/410683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385327
NOTRY=true

Review URL: https://codereview.chromium.org/413633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284991 0039d316-1c4b-4281-b951-d872f2087c98

With this patch, both Windows and Ozone implementations use PlatformWindow for
interacting with the native windowing system. Eventually, the X11 implementations
will also use this, and WindowTreeHost will have a single implementation on all
platforms.

BUG=none
R=ben@chromium.org

Previously landed in r284850, but reverted in r284905 because it broke a multi-
window ash unit-test on Windows. The test is now disabled (r284931).

Review URL: https://codereview.chromium.org/400413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284986 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue introduced by https://codereview.chromium.org/135723003/
where the navigation messages are no longer associated with the
RenderView and as a result the resource loader was not resetting state
for new navigations.

BUG=391741

Review URL: https://codereview.chromium.org/368953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395823
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/410743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284984 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds language and keyboard pickers to public session pods. The
CL focuses on the necessary changes to the login UI. Follow-up CLs will:
- wire up the pickers so that they actually influence the language and
  keyboard layout in the public session, and
- customize the contents of the language picker based on policy
  (languages recommended by policy go first; the top recommended language
  is pre-selected)

BUG=214904,241790
TEST=Manual, including RTL

Review URL: https://codereview.chromium.org/398543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284983 0039d316-1c4b-4281-b951-d872f2087c98

Fixes this warning:

In file included from ..\..\media/video/capture/win/pin_base_win.h:15:
..\..\base/memory/ref_counted.h(131,7) :  warning(clang): delete called on 'const media::TypeEnumerator' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
      delete static_cast<const T*>(this);
      ^
..\..\media\video\capture\win\pin_base_win.cc(40,39) :  note(clang): in instantiation of member function 'base::RefCounted<media::TypeEnumerator>::Release' requested here
    base::RefCounted<TypeEnumerator>::Release();
                                      ^
1 warning generated.

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/410833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284982 0039d316-1c4b-4281-b951-d872f2087c98

This adds the //ui/base/ime target to the GN build, which is used
everywhere except for ios. In the gyp build this isn't a real target,
it's a set of properties that are included into the ui_base target which
is the best you can do in GYP since you can't link a static library into
a component without dropping some symbols. In GN, we can define this as
a source_set with its own dependencies and settings.

This also fixes up some miscellaneous mac issues.

R=brettw@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/389083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284981 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284980 0039d316-1c4b-4281-b951-d872f2087c98

Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win.

BUG=386891,387124,396373,396384,396386,396387,396388,396390,396392,387124,396393,396395,396399,396402,396403,396404,396405,393149,396409,95557,396413,396414,375894
R=viettrungluu@chromium.org
TBR=brettw, rvargas, sky

Review URL: https://codereview.chromium.org/410843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284977 0039d316-1c4b-4281-b951-d872f2087c98

Previously in the case of auth frame loading timeout auth frame was not reloaded, since we expected that frame will send an error to SigninScreenHandler. Current implementation explicitly reloads web frame when timeout happens.

BUG=394970
TEST=manual
NOTRY=true

Review URL: https://codereview.chromium.org/416493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/411023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284975 0039d316-1c4b-4281-b951-d872f2087c98

Add some content_shell targets. content_shell itself doesn't link yet so it's commented out, but some assocaited libs now compile.

This fixes a variety of out-of-date sources lists to get some targets closer to linking in the GN build.

Add xdisplaycheckk target

Update GYP files for GN names

Rename events_ipc

R=hclam@chromium.org

Review URL: https://codereview.chromium.org/407243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386274
R=agl@chromium.org

Review URL: https://codereview.chromium.org/400473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396661
TBR=nednguyen@chromium.org

Review URL: https://codereview.chromium.org/416573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396534

Review URL: https://codereview.chromium.org/417473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284971 0039d316-1c4b-4281-b951-d872f2087c98

Data is from https://chromium-build-logs.appspot.com/flakiness_dashboard?master=tryserver.chromium

BUG=386891,378061,394032,327719,395152,396318,396320,394592,396326,395152,396328,314905,396334,396336,396342,396344,396347,391894,315299,396352,396353,313205,248437,389084,396360,396363,396364,396347,367665,327719,120484,167158,396371,396373
R=viettrungluu@chromium.org
TBR=kalman

Review URL: https://codereview.chromium.org/410043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284970 0039d316-1c4b-4281-b951-d872f2087c98

On Mac the profile directory may contain a socket "App Shim Socket", which we don't want to copy to the generated profile.
The original fix for this no longer works on the bots for an unknown reason, attempt an alternate fix.

BUG=396106

Review URL: https://codereview.chromium.org/404413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284965 0039d316-1c4b-4281-b951-d872f2087c98

This is applied to:
- open to the search result
- click on app icon

I am not sure this is the right approach. We may want to introduce
an ActivityObserver or something, and minimize the home card
by itself. However, activity may be created for various reason
but minimizing should work upon the user's action on the
home card, so this approach isn't bad.

BUG=None
R=oshima@chromium.org, sadrul@chromium.org
TBR=sky@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/408623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284962 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284684

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284961 0039d316-1c4b-4281-b951-d872f2087c98

This patch strips out usage of specific threads defined in content/.

- Replaces FILE thread in BackgroundDownloaderWin with a SingleThreadTaskRunner backed by the FILE thread.
- Replaces a bunch of DCHECK(UI thread) with use of base::ThreadChecker (which just checks that it's all on the constructor thread).
- Replaces Posts to the UI thread with a post to the current message loop used in the constructor.

BUG=371463

Review URL: https://codereview.chromium.org/385013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284960 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/399273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393149

Review URL: https://codereview.chromium.org/387923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/dynamorio/issues/detail?id=1443
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/417593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284956 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the following changes:

  - Add support for the new "Characteristics" and "Descriptors" properties
    exposed under org.bluez.GattService1 and org.bluez.GattCharacteristic1,
    respectively.

  - Add device::BluetoothGattService::Observer::GattDiscoveryCompleteForService
    event, which gets called after the first PropertiesChanged signal is
    received for the "Characteristics" property of a service.

  - Change BluetoothLowEnergyEventRouter, so that it sends the "onServiceAdded"
    event not in GattServiceAdded but in GattDiscoveryCompleteForService.

BUG=394537
TEST=browser_tests:BluetoothLowEnergyApiTest,
device_unittests:BluetoothGattChromeOSTest

Review URL: https://codereview.chromium.org/402303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284955 0039d316-1c4b-4281-b951-d872f2087c98

CWS search has turned on 100% since 2013/9 and CWS server side has no
problem handling the traffic. So get rid of the field trial.

BUG=262192

Review URL: https://codereview.chromium.org/412583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284954 0039d316-1c4b-4281-b951-d872f2087c98

Script crashes with "TypeError: int() argument must be a string or a number, not 'NoneType'" message.
The fix is to use 'raise ValueError' instead of returning None.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/408253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284953 0039d316-1c4b-4281-b951-d872f2087c98

This means if you have an existing ViewManager connection you can just use that to ask the WM to embed a new node for you.

Also fix the issue where only one call to EmbedRoot() could be made to the init service prior to the window tree host being ready.

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/405163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284952 0039d316-1c4b-4281-b951-d872f2087c98

This CL replaces gfx based geometry objects with ones from mojo::.

TEST=none
R=beng@chromium.org, viettrungluu@chromium.org
BUG=330467

Review URL: https://codereview.chromium.org/409263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284951 0039d316-1c4b-4281-b951-d872f2087c98