- 03 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bb911c3aa2c..b1274ec33195 2020-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I767cfb6ce766b026d07201ffabbea2191f07032a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833157}
-
Minoru Chikamune authored
[purpose] The HeapMojoWrapperMode::kWithoutContextObserver was a HeapMojoWrapper's "safe mofe" to keep the existing behavior during the COVID-19 code freeze. The mojo objects on DevToolsFrontendImpl must outlive the ExecutionContext of LocalFrame, so it should not be associated with the ExecutionContext of LocalFrame. Bug: 1049056 Change-Id: I9c0b469ca206005a00a921838d24569c80f598a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291911Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#833156}
-
Joel Riley authored
Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. Bug: 1143814 Change-Id: I1c4fce614404c6cabd0336eed2ab6fa7ac1d4c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568547 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833155}
-
Yury Khmel authored
This sends request to ARC Android to set dalvik memory params based on device's memory config. BUG=b:160760318 TEST=unit test added Locally on device, early tests show improvements in app loading and ARC boot time up to 5%. This feature is currently optional and is behind Chrome feature. Next data will be collected on real user using finch experiment and in-lab tests by adding separate testing variation for few reference boards that activates this feature. Change-Id: Iacb1a8c6ce874fe74152204a2e41a35bb2fa9da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570552Reviewed-by:Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#833154}
-
Chan Li authored
To stop using result_adapter since iOS runner should be able to report results directly. Bug: 1136998 Change-Id: I0686ff23a16d5a59ddae1b80cf5b21df4240bf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561462 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#833153}
-
Oriol Brufau authored
MostBackwardOrForwardCaretPosition was added in r832706, and this caused a -1.8% perf regression for line-layout-repeat-append-select.html The reason is that the function adjusts the obtained candidate position to avoid crossing shadow boundaries. This patch adds fast paths for the common cases when both the candidate and the original position are neither in a shadow tree nor are shadow hosts themselves. Bug: 1154646 Change-Id: I036e9044e2b8c921b466595be9661efbc852aa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569740 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833152}
-
Nnamdi Theodore Johnson-Kanu authored
- Adds a dialog which allows the user to rename an esim profile screenshot: https://screenshot.googleplex.com/A6TtGk554XoETAr.png Reference: https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.gac80715f79_2_7 Bug: 1093185 Change-Id: I60b6780c28c603db1a35fb65733919b03bf92dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555470 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833151}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/b3becb2f257a..685cb02ea8d9 2020-12-02 dsinclair@chromium.org Remove internal usage of Context. 2020-12-02 dsinclair@chromium.org [ast] Remove more set methods. 2020-12-02 bclayton@google.com Unrevert "[ast] Remove unused constructors and setters". 2020-12-02 bclayton@google.com Add ClassID::Unique template and TINT_INSTANTIATE_CLASS_ID 2020-12-02 enga@chromium.org spirv-reader: Fix bug with passing stack-allocated variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I85b4681a00284c75a1e5ede40ae0644abd09054c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570021Reviewed-by:
-
Ian Prest authored
Previously, to detect if VoiceOver was running on the Mac, we used an undocumented attribute (AXEnhancedUserInterface) that was set on the application. Unfortunately, this doesn't work with the new VoiceControl system. After discussions with Apple, they recommended that we turn on a11y whenever an AT accesses the 'accessibilityRole' property. This would work for VoiceControl, and should work with any new ATs in the future. Since this attribute is called frequently, we use 'dispatch_once' to ensure the expensive work is only done once. One disadvantage is that we can no longer turn *off* a11y when the 'AXEnhancedUserInterface' attribute is set to zero, because doing so breaks compatibility with VoiceControl. (A11y would be enabled, then quickly disabled again.) Bug: 1143047 Change-Id: I41ed07b31476cef4a04fd0f2d9c994acc9311654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538257Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6216d098d8ab..1520e40f5e2b 2020-12-03 dneto@google.com copyright check: Exclude .venv in source tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ief57990d01d5fa03b9a494d76b36da7f2d4ef1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570014Reviewed-by:
-
Kenichi Ishibashi authored
This CL is similar to crrev.com/c/25509621 but for StoreUserData(). Introduces a specialized InflightCall for StoreUserData() to clone a move-only parameter for each call. Bug: 1133143 Change-Id: Ibfd98f2dab312e0f828ecb5941a4aaedae1883f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560706 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833147}
-
Joey Arhar authored
Fixed: 645845 Change-Id: I3dfcf092b1b323da8b08ec4620e8051e8e7c09d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497422Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833146}
-
Joel Hockey authored
Test is failing and blocking LKGM Bug: 1154794 Change-Id: I9739e4d1439f0db7088e34b4a35eb72c6f489a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569328 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833145}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b8d12f1..9f448651 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib91524c8768481cdf9b9ef41c190f7a2924ca4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833144}
-
Eric Willigers authored
apps_util::CreateShareIntentFromFiles now omits title or text strings from the intent, if the supplied string are empty. Bug: 1127670 Change-Id: Ic62b1e80299ad2cfe067132e7e852fb34b8c6e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569324Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#833143}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6d059e64e738b9648ff3355fbe2045b0e80aae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570013Reviewed-by:
-
Alan Cutter authored
This CL updates the Webapp.Update.ManifestUpdateResult histogram to record the situation where a navigation occurs in scope of a web app but the manifest served by the site would result in a different app ID than what's already installed. Bug: 1058265 Change-Id: I8d3d2ffceea77c3033d173e787dae1e538efff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569310 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#833141}
-
Kenichi Ishibashi authored
This CL is similar to crrev.com/c/2550108 but for user data methods, except for StoreUserData(). StoreUserData() has a move-only parameter and needs to be specialized. This CL also updates some browser_tests to wait for all inflight tasks are executed before finishing tests. These changes are needed to satisfy the DCHECK() in generated mojo bindings. Bug: 1133143 Change-Id: Ia234eb4b84098f7a42450dfda1e70d9f34f9fe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561963 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
BUG=b:171408795 TEST=Launch Play Store Change-Id: I350bb9e05ecbd168a6452e76b59b601a27db8dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560534Reviewed-by:
-
Jeffrey Young authored
Move photo downloading and decoding to new class |AmbientPhotoCache|. Follow-up CL will also move disk access to make |AmbientPhotoController| tests more reliable. BUG=b:165481552 TEST=ash_unittests --gtest_filter="AmbientPhotoControllerTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I9f06b34aa661c86d2a960d8f3e279857da462bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550606 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833138}
-
Jeffrey Kardatzke authored
This doesn't align with the media::Decryptor documentation where it indicates it should return kSuccess and a null buffer if CancelDecrypt is called. BUG=None TEST=Builds Change-Id: Ib0654014262f61db7875274350d92a7510c065ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570127 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833137}
-
Norman Rosas authored
and //components/u…, also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I7ff2789f38c4181269a3b292464ba289ac1a9a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570339 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate key actions in input-events/input-events-get-target-ranges.html Added . We have to disable it because we do not support key actions in gpuBenchmarking when running the tests in our chromium bots. Bug: 1145677 Change-Id: I5176f374aaa79d771a78ef651f63098f039101da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533965 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#833135}
-
Daniel Hosseinian authored
This is a reland of 2d0cae27. The original change was reverted because a pre-existing bug in which some IPC messages between the plugin and the renderer were dropped due to garbage text rendering info attempted to be sent. That bug was fixed in crrev.com/833065, so this CL should be safe to reland. Original change's description: > Reload the PDF accessibility tree on layout changes > > Currently, any layout changes applied to the PDF document (i.e. page > rotation or two-up view) after the accessibility tree has loaded does > not update the page bounds. > > Because the accessiblity tree has read-only nodes, the only way to > resolve the issue is to reload all the nodes of the tree on each layout > change. > > Note: This CL only fixes page bounds and positions. The bounds of page > content such as text or annotations still do not rotate with the rest > of the document. Those issues will be fixed in a follow-up. > > Bug: 1150665 > Change-Id: I2fbf2cb26f38ee3fed076333c0b224a8ede7947e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553217 > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830918} Bug: 1150665 Change-Id: Icf7a1fb3868560dee2f3d6c75dae83c128c4c0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570391 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Caroline Tice authored
Bringing in all the DWARF v5 rnglist fixes. e3d485f Dwarf5ReadRangeList: remove duplicated declaration 78180df Use size_t to fix the build on mac. a9afca9 Support miscelaneous dwarf5 forms. 9ecccc5 Implement dwarf5 range lists. 5c7535a amd64: reject frames with invalid rsp/rip f6669d6 Revert "Refactor rangelist handling to prepare for dwarf5 .debug_rngslist" 2b936b0 Refactor rangelist handling to prepare for dwarf5 .debug_rngslist BUG=1154770 Change-Id: I0a1f9ff4b68c9ca521269c1358a5d2d5ce1f2407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569945 Auto-Submit: Caroline Tice <cmtice@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#833133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/397ec99b1aca..df5c49db593b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: dimich@google.com Change-Id: I4be8a5aab439978eb2fa783767a3ef819da8a876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833132}
-
Ye Kuang authored
Bug: 1149386 Change-Id: I7807d4d05dd3d2381d4554d4d8d6da2c8c461517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569313 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#833131}
-
Jérémie Boulic authored
Converted files: - ui/file_manager/file_manager/background/js/metadata_proxy.js - ui/file_manager/file_manager/background/js/metadata_proxy_unittest.js Bug: 1133186 Change-Id: I81eb9d34fff12835ef5974acfee3817fec864340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563105 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#833130}
-
Olivier Yiptong authored
This changes the behavior from concurrent font chooser requests all returning the same data from a single chooser invocation to failing a subsequent request. As implemented, the User Activation check will consume the activation, failing any other in-flight requests. Fixed: 1149621 Change-Id: If14e7e12ff52967e8dc49c383a66da94995c9134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568931 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833129}
-
Asami Doi authored
The test is flaky on Win7. Flaky dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Foverlay%2Foverlay-persistent-overlays-with-emulation.js&testType=blink_web_tests TBR=alexrudenko@chromium.org No-Try: true Bug: 1154940 Change-Id: Ib153f02efb76026ae8d78b7504aa2f5b424a25e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569479 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833128}
-
Bartek Nowierski authored
Currently pages are committed as soon as the slot span is allocated. There is already code that cleverly avoids writing in-slot free list entries on pages of the span that aren't used yet, to prevent them from being faulted in. This code can be easily repurposed to commit pages as needed. An adjustment had to be made to not provision a slot (and add it to the free list) if it doesn't fully fit in a committed page (previously it was enough for the slot's free list entry to fit within the page). Change-Id: Ic9585aa6001a1cf53233ae5edc4932be780a93ad Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563385 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833127}
-
Nina Satragno authored
Only skip PIN entry on GetAssertion flows if there are two or more devices connected. The regression test requires a version of VirtualFidoDeviceFactory that supports multiple devices, so this patch also adds that. Fixed: 1154483 Change-Id: I3ec7e1d82c9434de74d84fbd23d6e2c02f873c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570196 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#833126}
-
Carlos IL authored
Previously ssl_info_ did not get reset on OnRequestFailedInternal if the response had no ssl info. This causes a bug if a valid HTTPS site (e.g. https://example.com) redirects to an invalid HTTP one (e.g. http://not-exist.test), the resulting error page (with http://not-exist.test on the omnibox) shows This Page is Secure if page info is opened, and shows https://example.com's certificate in the certificate viewer. This CL fixes this by setting ssl_info_ to nullopt in OnRequestFailedInternal if the URLLoaderCompletionStatus does not have ssl state set. Bug: 1154754 Change-Id: I75b6539ff7e5695cda2f1b7f14fdb5054957b202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569899 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833125}
-
Joel Riley authored
STS floating panel is now focusable and translates certain keys to panel actions. Pressing Search+S without a text selection restores focus to panel. AX-Relnotes: N/A Bug: 1143814 Change-Id: I7a8759a6e209044d24aa503fdcbfe61afa2a6a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568532 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Harry Cutts authored
Bug: none Test: remove deep-link-focus-id from HTML elements and check tests fail Change-Id: Ie3d4bb5fc58a628c6bf34e21ca624fe0eb39d761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551462 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8797714c4a78..abe9657839a4 2020-12-02 syoussefi@chromium.org Vulkan: I/O blocks: Support unsized arrays 2020-12-02 jonahr@google.com Reland "Reinitialize GL_VENDOR string when GPU switches" 2020-12-02 syoussefi@chromium.org Vulkan: Clean up render pass query code 2020-12-02 syoussefi@chromium.org Create helper for identifying builtin names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1152212 Tbr: ianelliott@google.com Change-Id: Ib96a7c85e6558a1d789160d39ec055ca80a937ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570167Reviewed-by:
-
Yury Khmel authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/f6d74c196c6c..7fa43c97b606 $ git log f6d74c196..7fa43c97b --date=short --no-merges --format='%ad %ae %s' 2020-12-02 paulhsia system_api: Add NumberOfInputStreamsWithPermission related constants 2020-11-18 yichengli u2fd: Don't reset pending WebAuthn sessions twice 2020-12-02 garrick system_api: Add fields to ConnectNamespace 2020-10-29 ejcaruso shill: enable IPv6 per APN in mobile operator DB 2020-12-01 dlunev cryptohome: remove now unused UpdateEx call 2020-12-01 garrick system_api: Add network device change signal 2020-11-30 garrick patchpanel: Add support for getting all managed devices. 2020-11-30 garrick patchpanel: Add guest enum type for net device. 2020-11-11 hardikgoyal cryptohome: add AuthSession API in DBUS 2020-12-01 khmel system_api: Add API to pass ARC dalvik memory profile type. Created with: roll-dep src/third_party/cros_system_api BUG=b:160760318 TEST=N/A Change-Id: Ie88b840c598aa0dc85be4416f253b6a70b9b854e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570102 Auto-Submit: Yury Khmel <khmel@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1366dd01174e..ae504d46b4c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I257b807860c85f5f26eb76e10d35bdd381e38ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570046Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606931953-8f73b2aa50fd158baa3a07c3a6f9cf4c6333162b.profdata to chrome-linux-master-1606953494-bd74c7c56f61c746e2347181ab9ffd8bac2372a6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f2d13a5a39878853940daf2f2f4218a9b6d062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570407Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5334e8976d42..c7112edbe0f4 2020-12-03 bsalomon@google.com Fix swizzles in clear_swizzle GM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I7f9bce263c8090e216bc066b0f6585f418344be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570536Reviewed-by:
-
